You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "troizet (via GitHub)" <gi...@apache.org> on 2025/10/02 15:43:58 UTC
[PR] Fixed an issue where a trait used in an anonymous class was defined as being used in a wrapper class [netbeans]
troizet opened a new pull request, #8883:
URL: https://github.com/apache/netbeans/pull/8883
Fixed an issue where a trait used in an anonymous class was defined as being used in a wrapper class.
Example:
```php
<?php
trait MyTrait
{
abstract function doSomething();
public function doNothing()
{
}
}
class MysClass
{
public function getObject()
{
return new class() {
public function getMyTraitAwareObject()
{
return new class() {
use MyTrait;
public function doSomething()
{
}
};
}
};
}
}
```
- Fixed the `ImplementAbstractMethodsHintError` hint for the above case [GH-8527]
before:
<img width="604" height="574" alt="gh_8527_before" src="https://github.com/user-attachments/assets/97c0421c-e1a1-4776-8bbb-431ad25eea22" />
after:
<img width="591" height="589" alt="gh_8527_after" src="https://github.com/user-attachments/assets/517731ca-e460-42f6-969e-520835891b5a" />
- Fixed incorrect detection of the used trait in the navigator for the above case
before:
<img width="460" height="396" alt="navigator_before" src="https://github.com/user-attachments/assets/50b4a9e6-51a7-40bc-bedb-c5693c25567a" />
after:
<img width="450" height="326" alt="navigator_after" src="https://github.com/user-attachments/assets/42af3d47-75dd-4b44-a23b-4e66acf3af82" />
- Fixed tests `NavigatorTest`
- Added new tests in `NavigatorTest` and `ImplementAbstractMethodsHintErrorTest`
---
**^Add meaningful description above**
<details open>
<summary>Click to collapse/expand PR instructions</summary>
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
### PR approval and merge checklist:
1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run?
2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
3. [ ] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates?
3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?
If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP: Fixed an issue where a trait used in an anonymous class was defined as being used in a wrapper class [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #8883:
URL: https://github.com/apache/netbeans/pull/8883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists