You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Fred Clift <fr...@clift.org> on 2014/08/26 19:07:05 UTC
Review Request 25065: pre-add all RewriteRule entries to metadata
htaccess file for system vm routers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25065/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
pre-add all RewriteRule entries to metadata htaccess file for system vm routers- makes automated router maintanince easier... The set is static and doesn't ever change after the initial provision - it is identical for every router... While it is probably good to have code that can dynamically add new lines (opt/cloud/bin/vmdata.py currently does this, starting from the stub in git now) there is no reason not to have the full static set of rules in the initial file. We (betterservers.com) have some in-house router-fixing scripts that would like to re-unpack the tarball and not loose the full .htaccess file...
Diffs
-----
systemvm/patches/debian/config/var/www/html/latest/.htaccess 038a4c9
Diff: https://reviews.apache.org/r/25065/diff/
Testing
-------
installed cloudstack, set up networks and provisioned a vm - made sure the router got the same .htaccess file that it would normally get after the first vm is added to the network
Thanks,
Fred Clift
Re: Review Request 25065: pre-add all RewriteRule entries to metadata
htaccess file for system vm routers
Posted by Fred Clift <fr...@clift.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25065/#review51585
-----------------------------------------------------------
https://reviews.apache.org/r/25023/ and cloudstack bug 7405 https://issues.apache.org/jira/browse/CLOUDSTACK-7405 have updated this format
I should probably submit a new patch with the new regexs
- Fred Clift
On Aug. 26, 2014, 5:07 p.m., Fred Clift wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25065/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 5:07 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> pre-add all RewriteRule entries to metadata htaccess file for system vm routers- makes automated router maintanince easier... The set is static and doesn't ever change after the initial provision - it is identical for every router... While it is probably good to have code that can dynamically add new lines (opt/cloud/bin/vmdata.py currently does this, starting from the stub in git now) there is no reason not to have the full static set of rules in the initial file. We (betterservers.com) have some in-house router-fixing scripts that would like to re-unpack the tarball and not loose the full .htaccess file...
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/var/www/html/latest/.htaccess 038a4c9
>
> Diff: https://reviews.apache.org/r/25065/diff/
>
>
> Testing
> -------
>
> installed cloudstack, set up networks and provisioned a vm - made sure the router got the same .htaccess file that it would normally get after the first vm is added to the network
>
>
> Thanks,
>
> Fred Clift
>
>
Re: Review Request 25065: pre-add all RewriteRule entries to metadata
htaccess file for system vm routers
Posted by Fred Clift <fr...@clift.org>.
> On Aug. 27, 2014, 4:50 a.m., Sebastien Goasguen wrote:
> > Hi Fred, thanks for looking into this. I already applied Erik's review from https://reviews.apache.org/r/25023/
> > I am happy to apply yours if you think it makes sense.
> >
> > We just need to make sure it indeed fixes the problem and applies on 4.3, 4.4 and master.
I think my patch, as it stands, will mostly invalidate/break Eric's patch - I'll do a pull, and remake my patch. To be honest, I'm not sure why we dynamically generate /var/www/htdocs/latest/.htaccess dynamically anyway. It may be a holdover from some past refactoring. Anyway, I'll have somthing today.
- Fred
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25065/#review51648
-----------------------------------------------------------
On Aug. 26, 2014, 11:07 a.m., Fred Clift wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25065/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 11:07 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> pre-add all RewriteRule entries to metadata htaccess file for system vm routers- makes automated router maintanince easier... The set is static and doesn't ever change after the initial provision - it is identical for every router... While it is probably good to have code that can dynamically add new lines (opt/cloud/bin/vmdata.py currently does this, starting from the stub in git now) there is no reason not to have the full static set of rules in the initial file. We (betterservers.com) have some in-house router-fixing scripts that would like to re-unpack the tarball and not loose the full .htaccess file...
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/var/www/html/latest/.htaccess 038a4c9
>
> Diff: https://reviews.apache.org/r/25065/diff/
>
>
> Testing
> -------
>
> installed cloudstack, set up networks and provisioned a vm - made sure the router got the same .htaccess file that it would normally get after the first vm is added to the network
>
>
> Thanks,
>
> Fred Clift
>
>
Re: Review Request 25065: pre-add all RewriteRule entries to metadata
htaccess file for system vm routers
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25065/#review51648
-----------------------------------------------------------
Hi Fred, thanks for looking into this. I already applied Erik's review from https://reviews.apache.org/r/25023/
I am happy to apply yours if you think it makes sense.
We just need to make sure it indeed fixes the problem and applies on 4.3, 4.4 and master.
- Sebastien Goasguen
On Aug. 26, 2014, 5:07 p.m., Fred Clift wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25065/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 5:07 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> pre-add all RewriteRule entries to metadata htaccess file for system vm routers- makes automated router maintanince easier... The set is static and doesn't ever change after the initial provision - it is identical for every router... While it is probably good to have code that can dynamically add new lines (opt/cloud/bin/vmdata.py currently does this, starting from the stub in git now) there is no reason not to have the full static set of rules in the initial file. We (betterservers.com) have some in-house router-fixing scripts that would like to re-unpack the tarball and not loose the full .htaccess file...
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/var/www/html/latest/.htaccess 038a4c9
>
> Diff: https://reviews.apache.org/r/25065/diff/
>
>
> Testing
> -------
>
> installed cloudstack, set up networks and provisioned a vm - made sure the router got the same .htaccess file that it would normally get after the first vm is added to the network
>
>
> Thanks,
>
> Fred Clift
>
>
Re: Review Request 25065: pre-add all RewriteRule entries to metadata
htaccess file for system vm routers
Posted by Fred Clift <fr...@clift.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25065/
-----------------------------------------------------------
(Updated Aug. 28, 2014, 3:07 p.m.)
Review request for cloudstack.
Repository: cloudstack-git
Description (updated)
-------
pre-add all RewriteRule entries to metadata htaccess file for system vm routers- makes automated router maintanince easier... The set is static and doesn't ever change after the initial provision - it is identical for every router...
Fix htaccess file, vmdata.py that used to modify it, and added comments to producers of meta-data to note the new usage
We (betterservers.com) have some in-house router-fixing scripts that would like to re-unpack the tarball and not loose the full .htaccess file...
Diffs
-----
core/test/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResourceTest.java aab1e72
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java e133f7d
server/src/com/cloud/network/element/CloudZonesNetworkElement.java 55cd5fa
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 33d7cd7
systemvm/patches/debian/config/opt/cloud/bin/vmdata.py a44c134
systemvm/patches/debian/config/var/www/html/latest/.htaccess 038a4c9
Diff: https://reviews.apache.org/r/25065/diff/
Testing
-------
installed cloudstack, set up networks and provisioned a vm - made sure the router got the same .htaccess file that it would normally get after the first vm is added to the network
Thanks,
Fred Clift
Re: Review Request 25065: pre-add all RewriteRule entries to metadata
htaccess file for system vm routers
Posted by Fred Clift <fr...@clift.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25065/
-----------------------------------------------------------
(Updated Aug. 28, 2014, 3:06 p.m.)
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
pre-add all RewriteRule entries to metadata htaccess file for system vm routers- makes automated router maintanince easier... The set is static and doesn't ever change after the initial provision - it is identical for every router... While it is probably good to have code that can dynamically add new lines (opt/cloud/bin/vmdata.py currently does this, starting from the stub in git now) there is no reason not to have the full static set of rules in the initial file. We (betterservers.com) have some in-house router-fixing scripts that would like to re-unpack the tarball and not loose the full .htaccess file...
Diffs (updated)
-----
core/test/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResourceTest.java aab1e72
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java e133f7d
server/src/com/cloud/network/element/CloudZonesNetworkElement.java 55cd5fa
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 33d7cd7
systemvm/patches/debian/config/opt/cloud/bin/vmdata.py a44c134
systemvm/patches/debian/config/var/www/html/latest/.htaccess 038a4c9
Diff: https://reviews.apache.org/r/25065/diff/
Testing
-------
installed cloudstack, set up networks and provisioned a vm - made sure the router got the same .htaccess file that it would normally get after the first vm is added to the network
Thanks,
Fred Clift