You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tiles.apache.org by "Antonio Petrelli (JIRA)" <ji...@apache.org> on 2007/02/06 16:38:15 UTC
[jira] Created: (TILES-103) Refactor attribute management
Refactor attribute management
-----------------------------
Key: TILES-103
URL: https://issues.apache.org/struts/browse/TILES-103
Project: Tiles
Issue Type: Improvement
Components: tiles-core, tiles-jsp (jsp support)
Affects Versions: 2.0.0
Reporter: Antonio Petrelli
Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
- Rename the <put> element to <putAttribute>, just as the tag name.
- Rename the <add> element to <putAttribute>, and it adds attributes
and not values. Values are still stored by <item> and <bean>.
- Rename <tiles:putList> and <putList> to <tiles:putAttributeList> and
<putAttributeList>, for coherence.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-103) Refactor attribute management
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-103:
-----------------------------------
Description:
Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
- Rename the <put> element to <putAttribute>, just as the tag name.
- Rename the <add> element to <addAttribute>, and it adds attributes
and not values. Values are still stored by <item> and <bean>.
- Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
<putListAttribute>, for coherence.
was:
Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
- Rename the <put> element to <putAttribute>, just as the tag name.
- Rename the <add> element to <putAttribute>, and it adds attributes
and not values. Values are still stored by <item> and <bean>.
- Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
<putListAttribute>, for coherence.
Corrected renaming of "add" to "addAttribute"
> Refactor attribute management
> -----------------------------
>
> Key: TILES-103
> URL: https://issues.apache.org/struts/browse/TILES-103
> Project: Tiles
> Issue Type: Improvement
> Components: tiles-core, tiles-jsp (jsp support)
> Affects Versions: 2.0.0
> Reporter: Antonio Petrelli
> Assigned To: Antonio Petrelli
>
> Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
> - Rename the <put> element to <putAttribute>, just as the tag name.
> - Rename the <add> element to <addAttribute>, and it adds attributes
> and not values. Values are still stored by <item> and <bean>.
> - Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
> <putListAttribute>, for coherence.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TILES-103) Refactor attribute management
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli resolved TILES-103.
------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.1
All refactorings have been finished.
> Refactor attribute management
> -----------------------------
>
> Key: TILES-103
> URL: https://issues.apache.org/struts/browse/TILES-103
> Project: Tiles
> Issue Type: Improvement
> Components: tiles-core, tiles-jsp (jsp support)
> Affects Versions: 2.0.0
> Reporter: Antonio Petrelli
> Assigned To: Antonio Petrelli
> Fix For: 2.0.1
>
>
> Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
> - Rename the <put> element to <putAttribute>, just as the tag name.
> - Rename the <add> element to <addAttribute>, and it adds attributes
> and not values. Values are still stored by <item> and <bean>.
> - Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
> <putListAttribute>, for coherence.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TILES-103) Refactor attribute management
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli closed TILES-103.
----------------------------------
> Refactor attribute management
> -----------------------------
>
> Key: TILES-103
> URL: https://issues.apache.org/struts/browse/TILES-103
> Project: Tiles
> Issue Type: Improvement
> Components: tiles-core, tiles-jsp (jsp support)
> Affects Versions: 2.0.0
> Reporter: Antonio Petrelli
> Assigned To: Antonio Petrelli
> Fix For: 2.0.1
>
>
> Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
> - Rename the <put> element to <putAttribute>, just as the tag name.
> - Rename the <add> element to <addAttribute>, and it adds attributes
> and not values. Values are still stored by <item> and <bean>.
> - Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
> <putListAttribute>, for coherence.
> -- Second phase of refactoring:
> - Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>.
> - The <put-list-attribute> must have a child called <add-list-attribute> with no name.
> - The "name" of <tiles:putAttribute> tag should be mandatory.
> - Create a <tiles:addAttribute> tag and a <tiles:addListAttribute> to be child of <tiles:putListAttribute> and that have no name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (TILES-103) Refactor attribute management
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli reopened TILES-103:
------------------------------------
Assignee: (was: Antonio Petrelli)
Reopened because the refactoring is not finished:
- Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>. Apply the same renaming to JSP tags.
- The <put-list-attribute> must have a child called <add-list-attribute> with no name.
- The "name" of <tiles:put-attribute> tag should be mandatory.
- Create a <tiles:add-attribute> tag and a <tiles:add-list-attribute> to be child of <tiles:put-list-attribute> and that have no name.
> Refactor attribute management
> -----------------------------
>
> Key: TILES-103
> URL: https://issues.apache.org/struts/browse/TILES-103
> Project: Tiles
> Issue Type: Improvement
> Components: tiles-core, tiles-jsp (jsp support)
> Affects Versions: 2.0.0
> Reporter: Antonio Petrelli
> Fix For: 2.0.1
>
>
> Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
> - Rename the <put> element to <putAttribute>, just as the tag name.
> - Rename the <add> element to <addAttribute>, and it adds attributes
> and not values. Values are still stored by <item> and <bean>.
> - Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
> <putListAttribute>, for coherence.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-103) Refactor attribute management
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-103:
-----------------------------------
Description:
Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
- Rename the <put> element to <putAttribute>, just as the tag name.
- Rename the <add> element to <addAttribute>, and it adds attributes
and not values. Values are still stored by <item> and <bean>.
- Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
<putListAttribute>, for coherence.
-- Second phase of refactoring:
- Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>. Apply the same renaming to JSP tags.
- The <put-list-attribute> must have a child called <add-list-attribute> with no name.
- The "name" of <tiles:put-attribute> tag should be mandatory.
- Create a <tiles:add-attribute> tag and a <tiles:add-list-attribute> to be child of <tiles:put-list-attribute> and that have no name.
was:
Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
- Rename the <put> element to <putAttribute>, just as the tag name.
- Rename the <add> element to <addAttribute>, and it adds attributes
and not values. Values are still stored by <item> and <bean>.
- Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
<putListAttribute>, for coherence.
-- Second phase of refactoring:
- Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>. Apply the same renaming to JSP tags.
- The <put-list-attribute> must have a child called <add-list-attribute> with no name.
- The "name" of <tiles:put-attribute> tag should be mandatory.
- Create a <tiles:add-attribute> tag and a <tiles:add-list-attribute> to be child of <tiles:put-list-attribute> and that have no name.
[ Show » ]
- Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>
- Apply the same renaming to JSP tags. - The <put-list-attribute> must have a child called <add-list-attribute> with no name.
- The "name" of <tiles:put-attribute> tag should be mandatory.
- Create a <tiles:add-attribute> tag and a <tiles:add-list-attribute> to be child of <tiles:put-list-attribute> and that have no name.
Removed a part of the description that I added by mistake.
> Refactor attribute management
> -----------------------------
>
> Key: TILES-103
> URL: https://issues.apache.org/struts/browse/TILES-103
> Project: Tiles
> Issue Type: Improvement
> Components: tiles-core, tiles-jsp (jsp support)
> Affects Versions: 2.0.0
> Reporter: Antonio Petrelli
> Fix For: 2.0.1
>
>
> Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
> - Rename the <put> element to <putAttribute>, just as the tag name.
> - Rename the <add> element to <addAttribute>, and it adds attributes
> and not values. Values are still stored by <item> and <bean>.
> - Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
> <putListAttribute>, for coherence.
> -- Second phase of refactoring:
> - Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>. Apply the same renaming to JSP tags.
> - The <put-list-attribute> must have a child called <add-list-attribute> with no name.
> - The "name" of <tiles:put-attribute> tag should be mandatory.
> - Create a <tiles:add-attribute> tag and a <tiles:add-list-attribute> to be child of <tiles:put-list-attribute> and that have no name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-103) Refactor attribute management
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-103:
-----------------------------------
Description:
Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
- Rename the <put> element to <putAttribute>, just as the tag name.
- Rename the <add> element to <addAttribute>, and it adds attributes
and not values. Values are still stored by <item> and <bean>.
- Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
<putListAttribute>, for coherence.
-- Second phase of refactoring:
- Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>. Apply the same renaming to JSP tags.
- The <put-list-attribute> must have a child called <add-list-attribute> with no name.
- The "name" of <tiles:put-attribute> tag should be mandatory.
- Create a <tiles:add-attribute> tag and a <tiles:add-list-attribute> to be child of <tiles:put-list-attribute> and that have no name.
[ Show » ]
- Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>
- Apply the same renaming to JSP tags. - The <put-list-attribute> must have a child called <add-list-attribute> with no name.
- The "name" of <tiles:put-attribute> tag should be mandatory.
- Create a <tiles:add-attribute> tag and a <tiles:add-list-attribute> to be child of <tiles:put-list-attribute> and that have no name.
was:
Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
- Rename the <put> element to <putAttribute>, just as the tag name.
- Rename the <add> element to <addAttribute>, and it adds attributes
and not values. Values are still stored by <item> and <bean>.
- Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
<putListAttribute>, for coherence.
> Refactor attribute management
> -----------------------------
>
> Key: TILES-103
> URL: https://issues.apache.org/struts/browse/TILES-103
> Project: Tiles
> Issue Type: Improvement
> Components: tiles-core, tiles-jsp (jsp support)
> Affects Versions: 2.0.0
> Reporter: Antonio Petrelli
> Fix For: 2.0.1
>
>
> Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
> - Rename the <put> element to <putAttribute>, just as the tag name.
> - Rename the <add> element to <addAttribute>, and it adds attributes
> and not values. Values are still stored by <item> and <bean>.
> - Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
> <putListAttribute>, for coherence.
> -- Second phase of refactoring:
> - Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>. Apply the same renaming to JSP tags.
> - The <put-list-attribute> must have a child called <add-list-attribute> with no name.
> - The "name" of <tiles:put-attribute> tag should be mandatory.
> - Create a <tiles:add-attribute> tag and a <tiles:add-list-attribute> to be child of <tiles:put-list-attribute> and that have no name.
> [ Show » ]
> - Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>
> - Apply the same renaming to JSP tags. - The <put-list-attribute> must have a child called <add-list-attribute> with no name.
> - The "name" of <tiles:put-attribute> tag should be mandatory.
> - Create a <tiles:add-attribute> tag and a <tiles:add-list-attribute> to be child of <tiles:put-list-attribute> and that have no name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-103) Refactor attribute management
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-103:
-----------------------------------
Description:
Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
- Rename the <put> element to <putAttribute>, just as the tag name.
- Rename the <add> element to <addAttribute>, and it adds attributes
and not values. Values are still stored by <item> and <bean>.
- Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
<putListAttribute>, for coherence.
-- Second phase of refactoring:
- Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>.
- The <put-list-attribute> must have a child called <add-list-attribute> with no name.
- The "name" of <tiles:putAttribute> tag should be mandatory.
- Create a <tiles:addAttribute> tag and a <tiles:addListAttribute> to be child of <tiles:putListAttribute> and that have no name.
was:
Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
- Rename the <put> element to <putAttribute>, just as the tag name.
- Rename the <add> element to <addAttribute>, and it adds attributes
and not values. Values are still stored by <item> and <bean>.
- Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
<putListAttribute>, for coherence.
-- Second phase of refactoring:
- Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>. Apply the same renaming to JSP tags.
- The <put-list-attribute> must have a child called <add-list-attribute> with no name.
- The "name" of <tiles:put-attribute> tag should be mandatory.
- Create a <tiles:add-attribute> tag and a <tiles:add-list-attribute> to be child of <tiles:put-list-attribute> and that have no name.
Corrected the description to follow guidelines for JSP tags (their names must be in camel-case).
> Refactor attribute management
> -----------------------------
>
> Key: TILES-103
> URL: https://issues.apache.org/struts/browse/TILES-103
> Project: Tiles
> Issue Type: Improvement
> Components: tiles-core, tiles-jsp (jsp support)
> Affects Versions: 2.0.0
> Reporter: Antonio Petrelli
> Assigned To: Antonio Petrelli
> Fix For: 2.0.1
>
>
> Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
> - Rename the <put> element to <putAttribute>, just as the tag name.
> - Rename the <add> element to <addAttribute>, and it adds attributes
> and not values. Values are still stored by <item> and <bean>.
> - Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
> <putListAttribute>, for coherence.
> -- Second phase of refactoring:
> - Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>.
> - The <put-list-attribute> must have a child called <add-list-attribute> with no name.
> - The "name" of <tiles:putAttribute> tag should be mandatory.
> - Create a <tiles:addAttribute> tag and a <tiles:addListAttribute> to be child of <tiles:putListAttribute> and that have no name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TILES-103) Refactor attribute management
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli resolved TILES-103.
------------------------------------
Resolution: Fixed
All refactoring finished.
> Refactor attribute management
> -----------------------------
>
> Key: TILES-103
> URL: https://issues.apache.org/struts/browse/TILES-103
> Project: Tiles
> Issue Type: Improvement
> Components: tiles-core, tiles-jsp (jsp support)
> Affects Versions: 2.0.0
> Reporter: Antonio Petrelli
> Assigned To: Antonio Petrelli
> Fix For: 2.0.1
>
>
> Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
> - Rename the <put> element to <putAttribute>, just as the tag name.
> - Rename the <add> element to <addAttribute>, and it adds attributes
> and not values. Values are still stored by <item> and <bean>.
> - Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
> <putListAttribute>, for coherence.
> -- Second phase of refactoring:
> - Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>.
> - The <put-list-attribute> must have a child called <add-list-attribute> with no name.
> - The "name" of <tiles:putAttribute> tag should be mandatory.
> - Create a <tiles:addAttribute> tag and a <tiles:addListAttribute> to be child of <tiles:putListAttribute> and that have no name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TILES-103) Refactor attribute management
Posted by "Eric Bernstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40445 ]
Eric Bernstein commented on TILES-103:
--------------------------------------
It doesn't appear that the dtd (either the one hosted at struts or the new one http://tiles.apache.org/dtds/tiles-config_2_0.dtd) has been updated with these changes. Was a dtd change included in this change? Is that dtd hosted somewhere? Thanks
> Refactor attribute management
> -----------------------------
>
> Key: TILES-103
> URL: https://issues.apache.org/struts/browse/TILES-103
> Project: Tiles
> Issue Type: Improvement
> Components: tiles-core, tiles-jsp (jsp support)
> Affects Versions: 2.0.0
> Reporter: Antonio Petrelli
> Assigned To: Antonio Petrelli
> Fix For: 2.0.1
>
>
> Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
> - Rename the <put> element to <putAttribute>, just as the tag name.
> - Rename the <add> element to <addAttribute>, and it adds attributes
> and not values. Values are still stored by <item> and <bean>.
> - Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
> <putListAttribute>, for coherence.
> -- Second phase of refactoring:
> - Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>.
> - The <put-list-attribute> must have a child called <add-list-attribute> with no name.
> - The "name" of <tiles:putAttribute> tag should be mandatory.
> - Create a <tiles:addAttribute> tag and a <tiles:addListAttribute> to be child of <tiles:putListAttribute> and that have no name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-103) Refactor attribute management
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-103:
-----------------------------------
Description:
Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
- Rename the <put> element to <putAttribute>, just as the tag name.
- Rename the <add> element to <putAttribute>, and it adds attributes
and not values. Values are still stored by <item> and <bean>.
- Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
<putListAttribute>, for coherence.
was:
Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
- Rename the <put> element to <putAttribute>, just as the tag name.
- Rename the <add> element to <putAttribute>, and it adds attributes
and not values. Values are still stored by <item> and <bean>.
- Rename <tiles:putList> and <putList> to <tiles:putAttributeList> and
<putAttributeList>, for coherence.
Corrected some typos...
> Refactor attribute management
> -----------------------------
>
> Key: TILES-103
> URL: https://issues.apache.org/struts/browse/TILES-103
> Project: Tiles
> Issue Type: Improvement
> Components: tiles-core, tiles-jsp (jsp support)
> Affects Versions: 2.0.0
> Reporter: Antonio Petrelli
> Assigned To: Antonio Petrelli
>
> Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
> - Rename the <put> element to <putAttribute>, just as the tag name.
> - Rename the <add> element to <putAttribute>, and it adds attributes
> and not values. Values are still stored by <item> and <bean>.
> - Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
> <putListAttribute>, for coherence.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TILES-103) Refactor attribute management
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli reassigned TILES-103:
--------------------------------------
Assignee: Antonio Petrelli
> Refactor attribute management
> -----------------------------
>
> Key: TILES-103
> URL: https://issues.apache.org/struts/browse/TILES-103
> Project: Tiles
> Issue Type: Improvement
> Components: tiles-core, tiles-jsp (jsp support)
> Affects Versions: 2.0.0
> Reporter: Antonio Petrelli
> Assigned To: Antonio Petrelli
>
> Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
> - Rename the <put> element to <putAttribute>, just as the tag name.
> - Rename the <add> element to <putAttribute>, and it adds attributes
> and not values. Values are still stored by <item> and <bean>.
> - Rename <tiles:putList> and <putList> to <tiles:putAttributeList> and
> <putAttributeList>, for coherence.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TILES-103) Refactor attribute management
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli reassigned TILES-103:
--------------------------------------
Assignee: Antonio Petrelli
> Refactor attribute management
> -----------------------------
>
> Key: TILES-103
> URL: https://issues.apache.org/struts/browse/TILES-103
> Project: Tiles
> Issue Type: Improvement
> Components: tiles-core, tiles-jsp (jsp support)
> Affects Versions: 2.0.0
> Reporter: Antonio Petrelli
> Assigned To: Antonio Petrelli
> Fix For: 2.0.1
>
>
> Currently the attribute management code has some incoherences within names of the JSP tags and of the elements of Tiles configuration files, and they need to be renamed:
> - Rename the <put> element to <putAttribute>, just as the tag name.
> - Rename the <add> element to <addAttribute>, and it adds attributes
> and not values. Values are still stored by <item> and <bean>.
> - Rename <tiles:putList> and <putList> to <tiles:putListAttribute> and
> <putListAttribute>, for coherence.
> -- Second phase of refactoring:
> - Rename all elements with "camel case" names to "dash-separated" names, e.g. <putListAttribute> to <put-list-attribute>. Apply the same renaming to JSP tags.
> - The <put-list-attribute> must have a child called <add-list-attribute> with no name.
> - The "name" of <tiles:put-attribute> tag should be mandatory.
> - Create a <tiles:add-attribute> tag and a <tiles:add-list-attribute> to be child of <tiles:put-list-attribute> and that have no name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.