You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/08/24 09:57:41 UTC

[GitHub] [bookkeeper] zengguan opened a new pull request, #3153: Make netty acceptor threadPool size configurable

zengguan opened a new pull request, #3153:
URL: https://github.com/apache/bookkeeper/pull/3153

   Descriptions of the changes in this PR:
   default value of acceptor threadPool is 2*cpu core, it is unnecessary and not separate configuration。
   
   ### Motivation
   
   Make Netty acceptor threads  separate configurable
   
   ### Changes
   
   (Describe: what changes you have made)
   
   - [x] `no-need-doc` 
     
     (Please explain why)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] hangc0276 commented on pull request #3153: Make netty acceptor threadPool size configurable

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3153:
URL: https://github.com/apache/bookkeeper/pull/3153#issuecomment-1165707282

   @merlimat  @eolivelli @dlg99  Please help take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] zengguan closed pull request #3153: Make netty acceptor threadPool size configurable

Posted by GitBox <gi...@apache.org>.
zengguan closed pull request #3153: Make netty acceptor threadPool size configurable
URL: https://github.com/apache/bookkeeper/pull/3153


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] zengguan commented on a diff in pull request #3153: Make netty acceptor threadPool size configurable

Posted by GitBox <gi...@apache.org>.
zengguan commented on code in PR #3153:
URL: https://github.com/apache/bookkeeper/pull/3153#discussion_r950985192


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/EventLoopUtil.java:
##########
@@ -47,6 +47,10 @@ public static EventLoopGroup getServerEventLoopGroup(ServerConfiguration conf, T
         return getEventLoopGroup(threadFactory, conf.getServerNumIOThreads(), conf.isBusyWaitEnabled());
     }
 
+    public static EventLoopGroup getServerAcceptorGroup(ServerConfiguration conf, ThreadFactory threadFactory) {
+        return getEventLoopGroup(threadFactory, conf.getServerNumAcceptorThreads(), conf.isBusyWaitEnabled());

Review Comment:
   I changed it to false. Thanks~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3153: Make netty acceptor threadPool size configurable

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3153:
URL: https://github.com/apache/bookkeeper/pull/3153#issuecomment-1225343776

   fix old workflow,please see #3455 for detail


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] zengguan commented on pull request #3153: Make netty acceptor threadPool size configurable

Posted by GitBox <gi...@apache.org>.
zengguan commented on PR #3153:
URL: https://github.com/apache/bookkeeper/pull/3153#issuecomment-1225501345

   > First-time contributors need a maintainer to approve running workflows
   
   it is my first-time contributors .Need a maintainer to approve running workflows


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli merged pull request #3153: Make netty acceptor threadPool size configurable

Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #3153:
URL: https://github.com/apache/bookkeeper/pull/3153


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] zengguan commented on a diff in pull request #3153: Make netty acceptor threadPool size configurable

Posted by GitBox <gi...@apache.org>.
zengguan commented on code in PR #3153:
URL: https://github.com/apache/bookkeeper/pull/3153#discussion_r950985741


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java:
##########
@@ -118,10 +119,14 @@ class BookieNettyServer {
         this.authProviderFactory = AuthProviderFactoryFactory.newBookieAuthProviderFactory(conf);
 
         if (!conf.isDisableServerSocketBind()) {
-            this.eventLoopGroup = EventLoopUtil.getServerEventLoopGroup(conf, new DefaultThreadFactory("bookie-io"));
+            this.eventLoopGroup = EventLoopUtil.getServerEventLoopGroup(conf,
+                    new DefaultThreadFactory("bookie-io"));
+            this.acceptorGroup = EventLoopUtil.getServerAcceptorGroup(conf,

Review Comment:
   Yes. I added shutdown hook. Thanks~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] zengguan commented on pull request #3153: Make netty acceptor threadPool size configurable

Posted by GitBox <gi...@apache.org>.
zengguan commented on PR #3153:
URL: https://github.com/apache/bookkeeper/pull/3153#issuecomment-1225502143

   > fix old workflow,please see #3455 for detail
   
   This is my first-time contributors .Need a maintainer to approve running workflows


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3153: Make netty acceptor threadPool size configurable

Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #3153:
URL: https://github.com/apache/bookkeeper/pull/3153#discussion_r930967010


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/EventLoopUtil.java:
##########
@@ -47,6 +47,10 @@ public static EventLoopGroup getServerEventLoopGroup(ServerConfiguration conf, T
         return getEventLoopGroup(threadFactory, conf.getServerNumIOThreads(), conf.isBusyWaitEnabled());
     }
 
+    public static EventLoopGroup getServerAcceptorGroup(ServerConfiguration conf, ThreadFactory threadFactory) {
+        return getEventLoopGroup(threadFactory, conf.getServerNumAcceptorThreads(), conf.isBusyWaitEnabled());

Review Comment:
   does BusyWaitEnabled apply to the acceptor  group ?



##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java:
##########
@@ -118,10 +119,14 @@ class BookieNettyServer {
         this.authProviderFactory = AuthProviderFactoryFactory.newBookieAuthProviderFactory(conf);
 
         if (!conf.isDisableServerSocketBind()) {
-            this.eventLoopGroup = EventLoopUtil.getServerEventLoopGroup(conf, new DefaultThreadFactory("bookie-io"));
+            this.eventLoopGroup = EventLoopUtil.getServerEventLoopGroup(conf,
+                    new DefaultThreadFactory("bookie-io"));
+            this.acceptorGroup = EventLoopUtil.getServerAcceptorGroup(conf,

Review Comment:
   aren't we shutting down this group ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org