You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/29 03:30:31 UTC
[GitHub] [superset] xinjingqing opened a new pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
xinjingqing opened a new pull request #17278:
URL: https://github.com/apache/superset/pull/17278
the question exists in all version after v1.2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xinjingqing commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
xinjingqing commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r741561682
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xinjingqing commented on pull request #17278: fix: The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
xinjingqing commented on pull request #17278:
URL: https://github.com/apache/superset/pull/17278#issuecomment-979824222
@villebro if you set the parameter DASHBOARD_CROSS_FILTERS=true，in the file “superset/config.py”,the problem will arise...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xinjingqing commented on pull request #17278: fix: The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
xinjingqing commented on pull request #17278:
URL: https://github.com/apache/superset/pull/17278#issuecomment-1012118164
ok,i get it, thanks
Best Regards
On 01/13/2022 08:25，Joey ***@***.***> wrote：
@yeoji commented on this pull request.
In superset-frontend/src/dashboard/actions/dashboardInfo.ts:
> @@ -60,10 +64,12 @@ export const setChartConfiguration = (
});
try {
+ const filterCondition = JSON.parse(String(filterscopes));
Hey @xinjingqing, I've come across this issue too and found your fix.
Just wanted to note that this line breaks the saving of cross filter scoping since filterscopes is undefined (called from CrossFilterScopingModal.tsx), so it's probably necessary to check this parameter before attempting to JSON.parse it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r739566943
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
Do you need this change? these lines will set those features enabled for all users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r741417984
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
you can list the necessary feature flags in the description, like `Steps to reproduce this issue`. Other people, like QA or reviewers, read your description and reproduce your issue in their local development environment.
But you should not commit these feature flags in the PR. Once it is merged, it might impact all the users in the Superset community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r740379305
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
I mean these flags are not necessary for fixing filter mapping issue, and will cause other users to enable these features. So you should remove them from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17278:
URL: https://github.com/apache/superset/pull/17278#issuecomment-955096740
# [Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17278](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (066d504) into [1.3](https://codecov.io/gh/apache/superset/commit/286ba5d37d4e240d01bbefd2307a816829cf512d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (286ba5d) will **decrease** coverage by `0.24%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.3 #17278 +/- ##
==========================================
- Coverage 76.81% 76.56% -0.25%
==========================================
Files 998 998
Lines 53138 53139 +1
Branches 7261 7261
==========================================
- Hits 40816 40688 -128
- Misses 12091 12220 +129
Partials 231 231
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.71% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `81.74% <100.00%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
| python | `81.83% <100.00%> (-0.47%)` | :arrow_down: |
| sqlite | `81.38% <100.00%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `27.86% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/actions/dashboardInfo.ts](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEluZm8udHM=) | `47.05% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.33% <100.00%> (+0.02%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.80% <0.00%> (-16.87%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.47% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `93.13% <0.00%> (-3.44%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `88.88% <0.00%> (-1.86%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [286ba5d...066d504](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r741417984
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
you can list the necessary feature flags in the description, like `Steps to reproduce this issue`. Other people, like QA or reviewers, read your description and reproduce your issue in their local development environment.
But you should not commit these feature flags in the PR. Once it is merged, it might impact all the users in the Superset community.
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
you can list the necessary feature flags in the description, like `Steps to reproduce this issue`. Other people, like QA or reviewers, read your description and reproduce your issue in their local development environment.
But you should not commit these feature flags in the PR. Once it is merged, it might impact all the users in the Superset community.
You also need to fix the linting errors. You can run ```
npm run lint
```
in your own development environment, and see what is broken.
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
you can list the necessary feature flags in the description, like `Steps to reproduce this issue`. Other people, like QA or reviewers, read your description and reproduce your issue in their local development environment.
But you should not commit these feature flags in the PR. Once it is merged, it might impact all the users in the Superset community.
You also need to fix the linting errors. You can run
```
npm run lint
```
in your own development environment, and see what is broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xinjingqing commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
xinjingqing commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r741561682
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xinjingqing commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
xinjingqing commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r741561682
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xinjingqing commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
xinjingqing commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r739906905
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yeoji commented on a change in pull request #17278: fix: The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
yeoji commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r783540711
##########
File path: superset-frontend/src/dashboard/actions/dashboardInfo.ts
##########
@@ -60,10 +64,12 @@ export const setChartConfiguration = (
});
try {
+ const filterCondition = JSON.parse(String(filterscopes));
Review comment:
Hey @xinjingqing, I've come across this issue too and found your fix.
Just wanted to note that this line breaks the saving of cross filter scoping since `filterscopes` is `undefined` (called from `CrossFilterScopingModal.tsx`), so it's probably necessary to check this parameter before attempting to `JSON.parse` it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xinjingqing commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
xinjingqing commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r740743294
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
but...if you set the param to TRUE,the problem will present...if you close it,that's ok.....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r741417984
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
you can list the necessary feature flags in the description, like `Steps to reproduce this issue`. Other people, like QA or reviewers, read your description and reproduce your issue in their local development environment.
But you should not commit these feature flags in the PR. Once it is merged, it might impact all the users in the Superset community.
You also need to fix the linting errors. You can run ```
npm run lint
```
in your own development environment, and see what is broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #17278:
URL: https://github.com/apache/superset/pull/17278#issuecomment-979012729
@xinjingqing can you remove the feature flag changes as requested + address the linting issues? After that we can give this a new review + test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17278:
URL: https://github.com/apache/superset/pull/17278#issuecomment-955096740
# [Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17278](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (066d504) into [1.3](https://codecov.io/gh/apache/superset/commit/286ba5d37d4e240d01bbefd2307a816829cf512d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (286ba5d) will **decrease** coverage by `0.26%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.3 #17278 +/- ##
==========================================
- Coverage 76.81% 76.54% -0.27%
==========================================
Files 998 998
Lines 53138 53139 +1
Branches 7261 7261
==========================================
- Hits 40816 40676 -140
- Misses 12091 12232 +141
Partials 231 231
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `81.74% <100.00%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
| python | `81.78% <100.00%> (-0.52%)` | :arrow_down: |
| sqlite | `81.38% <100.00%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `27.86% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/actions/dashboardInfo.ts](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEluZm8udHM=) | `47.05% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.33% <100.00%> (+0.02%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.80% <0.00%> (-16.87%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.47% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `94.04% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `93.13% <0.00%> (-3.44%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `88.88% <0.00%> (-1.86%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [286ba5d...066d504](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r740379305
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
I mean these flags are not necessary for fixing filter mapping issue, and will cause other users to enable these features. So you should remove them from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r741417984
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
you can list the necessary feature flags in the description, like `Steps to reproduce this issue`. Other people, like QA or reviewers, read your description and reproduce your issue in their local development environment.
But you should not commit these feature flags in the PR. Once it is merged, it might impact all the users in the Superset community.
You also need to fix the linting errors. You can run
```
npm run lint
```
in your own development environment, and see what is broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17278:
URL: https://github.com/apache/superset/pull/17278#issuecomment-955096740
# [Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17278](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (066d504) into [1.3](https://codecov.io/gh/apache/superset/commit/286ba5d37d4e240d01bbefd2307a816829cf512d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (286ba5d) will **increase** coverage by `0.00%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.3 #17278 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 998 998
Lines 53138 53139 +1
Branches 7261 7261
=======================================
+ Hits 40816 40817 +1
Misses 12091 12091
Partials 231 231
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.50% <100.00%> (+0.04%)` | :arrow_up: |
| mysql | `81.71% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `81.74% <100.00%> (-0.04%)` | :arrow_down: |
| presto | `81.62% <100.00%> (+0.04%)` | :arrow_up: |
| python | `82.30% <100.00%> (+<0.01%)` | :arrow_up: |
| sqlite | `81.38% <100.00%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `27.86% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/actions/dashboardInfo.ts](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEluZm8udHM=) | `47.05% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.33% <100.00%> (+0.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [286ba5d...066d504](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xinjingqing commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
xinjingqing commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r739906905
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xinjingqing commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
xinjingqing commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r739907946
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
Another way to do it,set the value in DEFAULT_FEATURE_FLAGS. "DASHBOARD_CROSS_FILTERS": True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17278: fix: The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17278:
URL: https://github.com/apache/superset/pull/17278#issuecomment-955096740
# [Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17278](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (066d504) into [1.3](https://codecov.io/gh/apache/superset/commit/286ba5d37d4e240d01bbefd2307a816829cf512d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (286ba5d) will **increase** coverage by `0.00%`.
> The diff coverage is `66.66%`.
> :exclamation: Current head 066d504 differs from pull request most recent head 1a359e5. Consider uploading reports for the commit 1a359e5 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.3 #17278 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 998 998
Lines 53138 53139 +1
Branches 7261 7261
=======================================
+ Hits 40816 40817 +1
Misses 12091 12091
Partials 231 231
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.50% <100.00%> (+0.04%)` | :arrow_up: |
| mysql | `81.71% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `81.74% <100.00%> (-0.04%)` | :arrow_down: |
| presto | `81.62% <100.00%> (+0.04%)` | :arrow_up: |
| python | `82.30% <100.00%> (+<0.01%)` | :arrow_up: |
| sqlite | `81.38% <100.00%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `27.86% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/actions/dashboardInfo.ts](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEluZm8udHM=) | `47.05% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.33% <100.00%> (+0.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [286ba5d...1a359e5](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xinjingqing commented on pull request #17278: fix: The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
xinjingqing commented on pull request #17278:
URL: https://github.com/apache/superset/pull/17278#issuecomment-979742744
@villebro ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #17278: fix: The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #17278:
URL: https://github.com/apache/superset/pull/17278#issuecomment-979768495
Thanks @xinjingqing - I'll test and review now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xinjingqing commented on pull request #17278: fix: The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
xinjingqing commented on pull request #17278:
URL: https://github.com/apache/superset/pull/17278#issuecomment-979767585
@villebro I restored the pre-version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #17278: fix: The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #17278:
URL: https://github.com/apache/superset/pull/17278#issuecomment-979777437
@xinjingqing I am unable to reproduce this problem on master. Can you add detailed reproduction steps so that we can verify that this change is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17278:
URL: https://github.com/apache/superset/pull/17278#issuecomment-955096740
# [Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17278](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (066d504) into [1.3](https://codecov.io/gh/apache/superset/commit/286ba5d37d4e240d01bbefd2307a816829cf512d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (286ba5d) will **decrease** coverage by `0.07%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.3 #17278 +/- ##
==========================================
- Coverage 76.81% 76.73% -0.08%
==========================================
Files 998 998
Lines 53138 53139 +1
Branches 7261 7261
==========================================
- Hits 40816 40776 -40
- Misses 12091 12132 +41
Partials 231 231
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.50% <100.00%> (+0.04%)` | :arrow_up: |
| mysql | `81.71% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `81.74% <100.00%> (-0.04%)` | :arrow_down: |
| presto | `?` | |
| python | `82.15% <100.00%> (-0.15%)` | :arrow_down: |
| sqlite | `81.38% <100.00%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `27.86% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/actions/dashboardInfo.ts](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEluZm8udHM=) | `47.05% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.33% <100.00%> (+0.02%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `84.51% <0.00%> (-5.86%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.27% <0.00%> (-1.43%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/17278/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.69% <0.00%> (-0.26%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [286ba5d...066d504](https://codecov.io/gh/apache/superset/pull/17278?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xinjingqing commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
xinjingqing commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r739908257
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
Not necessary,you can set the value in DEFAULT_FEATURE_FLAGS. eg. "DASHBOARD_CROSS_FILTERS": True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xinjingqing commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
xinjingqing commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r740743294
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
but...if you set the param to TRUE,the problem will present...if you close it,that's ok.....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xinjingqing commented on a change in pull request #17278: Fix：The filter mapping configuration can not be saved in V1.2.0 +
Posted by GitBox <gi...@apache.org>.
xinjingqing commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r740743294
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
but...if you set the param to TRUE,the problem will present...if you close it,that's ok.....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org