You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2023/01/12 00:50:06 UTC

[GitHub] [pinot] navina commented on a diff in pull request #10104: fix java doc in AbstractMetrics

navina commented on code in PR #10104:
URL: https://github.com/apache/pinot/pull/10104#discussion_r1067599310


##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java:
##########
@@ -707,15 +708,16 @@ public void removeTableGauge(final String tableName, final G gauge) {
 
 
   /**
+   * @deprecated please use removeTableGauge(final String tableName, final String key, final G gauge) instead
+   *
    * Removes a table gauge given the table name and the gauge.
    * The add/remove is expected to work correctly in case of being invoked across multiple threads.
    * @param tableName table name
+   * @param partitionId The partition id
    * @param gauge the gauge to be removed
    */
   public void removePartitionGauge(final String tableName, final int partitionId, final G gauge) {

Review Comment:
   @zhtaoxiang what is your proposed solution for ensuring that partition level metric names have a unified pattern? That was the motivation behind my comment in @jugomezv 's PR and it is not specific to any use-case. 
   Does your PR here solve this problem or not? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org