You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by busykai <gi...@git.apache.org> on 2015/10/16 00:29:33 UTC
[GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand.
GitHub user busykai opened a pull request:
https://github.com/apache/cordova-lib/pull/322
Keep module-to-plugin mapping at hand.
This information is handy for various use-cases. E.g. for preview application to
provide only the plugins which are used by the application (instead of all of
them, since they are built-in in the preview app on the device). The other is
simulation (taco-simulation does need this info).
Instead of trying to (unreliably) recover this information from module list,
just keep track of it when it's known (at the prepare stage).
CC: @tony--
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/busykai/cordova-lib kai/module-plugin-meta
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #322
----
commit 84b486eb7e988653ae3aae63affd47b825ccb81a
Author: Arzhan Kinzhalin <ar...@intel.com>
Date: 2015-10-15T22:21:27Z
Keep module-to-plugin mapping at hand.
This information is handy for various use-cases. E.g. for preview application to
provide only the plugins which are used by the application (instead of all of
them, since they are built-in in the preview app on the device). The other is
simulation (taco-simulation does need this info).
Instead of trying to (unreliably) recover this information from module list,
just keep track of it when it's known (at the prepare stage).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9813 Keep module-to-plugin mapping at...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/322
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand.
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/322#discussion_r42191593
--- Diff: cordova-lib/src/platforms/PlatformApiPoly.js ---
@@ -566,7 +566,8 @@ PlatformApiPoly.prototype._addModulesInfo = function(plugin, targetDir) {
var moduleName = plugin.id + '.' + ( moduleToInstall.name || moduleToInstall.src.match(/([^\/]+)\.js/)[1] );
var obj = {
file: ['plugins', plugin.id, moduleToInstall.src].join('/'),
- id: moduleName
+ id: moduleName,
+ plugin: plugin.id
--- End diff --
`pluginId` perhaps?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand.
Posted by busykai <gi...@git.apache.org>.
Github user busykai commented on the pull request:
https://github.com/apache/cordova-lib/pull/322#issuecomment-148547532
Thanks, Tony! Updated the commit message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand.
Posted by busykai <gi...@git.apache.org>.
Github user busykai commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/322#discussion_r42191928
--- Diff: cordova-lib/src/platforms/PlatformApiPoly.js ---
@@ -566,7 +566,8 @@ PlatformApiPoly.prototype._addModulesInfo = function(plugin, targetDir) {
var moduleName = plugin.id + '.' + ( moduleToInstall.name || moduleToInstall.src.match(/([^\/]+)\.js/)[1] );
var obj = {
file: ['plugins', plugin.id, moduleToInstall.src].join('/'),
- id: moduleName
+ id: moduleName,
+ plugin: plugin.id
--- End diff --
yes, `pluginId` is more descriptive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand.
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/322#issuecomment-148547272
LGTM, @busykai.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand.
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/322#issuecomment-148547652
Thanks @tony-- - @busykai, could you update the PR title to include the JIRA issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Keep module-to-plugin mapping at hand.
Posted by tony-- <gi...@git.apache.org>.
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-lib/pull/322#issuecomment-148547339
[JIRA issue CB-9813](https://issues.apache.org/jira/browse/CB-9813)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org