You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/01/22 01:05:38 UTC
[GitHub] [incubator-mxnet] xinyual opened a new pull request #20837: Add graph pass and backward option
xinyual opened a new pull request #20837:
URL: https://github.com/apache/incubator-mxnet/pull/20837
## Description ##
This is the branch to add the zero sharding (especially partitioning gradient). The changes can be divided into three part:
1. in C++, I add an operation called reduce operation. It will do nothing in forward but reduce gradient on backward.
2. Then open an API called backward option to delete the output of certain graph.
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] xinyual removed a comment on pull request #20837: Add graph pass and backward option
Posted by GitBox <gi...@apache.org>.
xinyual removed a comment on pull request #20837:
URL: https://github.com/apache/incubator-mxnet/pull/20837#issuecomment-1023841822
> Thank you @xinyual! Could you please make sure the CI tests (ci/jenkins/mxnet-validation/sanity) pass, then we can merge this code into the zero_sharding feature branch for future devolpment
Ok. I'll work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] xinyual commented on pull request #20837: Add graph pass and backward option
Posted by GitBox <gi...@apache.org>.
xinyual commented on pull request #20837:
URL: https://github.com/apache/incubator-mxnet/pull/20837#issuecomment-1023841822
> Thank you @xinyual! Could you please make sure the CI tests (ci/jenkins/mxnet-validation/sanity) pass, then we can merge this code into the zero_sharding feature branch for future devolpment
Ok. I'll work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] xinyual commented on pull request #20837: Add graph pass and backward option
Posted by GitBox <gi...@apache.org>.
xinyual commented on pull request #20837:
URL: https://github.com/apache/incubator-mxnet/pull/20837#issuecomment-1024011931
> Thank you @xinyual! Could you please make sure the CI tests (ci/jenkins/mxnet-validation/sanity) pass, then we can merge this code into the zero_sharding feature branch for future devolpment
Hi leo, I don't know where is the problem since the error information only shows the wrong command. Is this related to third party ondnn? It seems I don't update it to latest version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #20837: Add graph pass and backward option
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #20837:
URL: https://github.com/apache/incubator-mxnet/pull/20837#issuecomment-1021495358
Thank you @xinyual! Could you please make sure the CI tests (ci/jenkins/mxnet-validation/sanity) pass, then we can merge this code into the zero_sharding feature branch for future devolpment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20837: Add graph pass and backward option
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20837:
URL: https://github.com/apache/incubator-mxnet/pull/20837#issuecomment-1019000557
Hey @xinyual , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, centos-cpu, website, unix-cpu, windows-gpu, windows-cpu, centos-gpu, miscellaneous, clang, sanity, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #20837: Add graph pass and backward option
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #20837:
URL: https://github.com/apache/incubator-mxnet/pull/20837#issuecomment-1030262399
Thank you @xinyual. Please rebase on top of the apache/incubator-mxnet master branch and force push to your xinyual/incubator-mxnet add_graph_pass_and_backward_option branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org