You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@struts.apache.org by "Alberto A. Flores" <aa...@gmail.com> on 2007/11/28 21:05:48 UTC
WW-167 not working
Has anyone been able to confirm that this issue is working? I don't seem
to get it to work yet JIRA says it is. This is about having a <button>
tag with an image and text inside the button.
Thanks,
Alberto
Re: WW-167 not working
Posted by "Alberto A. Flores" <aa...@gmail.com>.
I apologize for sending the wrong Jira Issue reference. The correct one is
as Martin stated (WW-1677, thanks Martin). And I agree with Martin, the body
of the <button> tag is not properly built (when the <s:submit type="button">
is used). I saw a new comment on Jira reflecting the "reopened" state of
this issue. I don't have the access to "reopen" an issue, but thought of
asking the group.
Thanks!
On Nov 28, 2007 11:36 PM, Eric Martin <er...@ericmmartin.com> wrote:
>
> Martin,
>
> Yes, there is a problem with the output. The SubmitTextName should be
> inside
> the button tag, but in your example and others posted, the value gets
> placed
> outside the button tag (seems to get displayed before the rendering of the
> button.
>
> I would expect the output to be:
>
> <button type="submit" id="example1_0"
> value="SubmitTextName">SubmitTextName</button>
>
> In HTML, what is used for the value attribute, is what will be sent to the
> server on submit. Whereas, the "value" that is nested in the button tag,
> is
> only the "label" of the button and is not sent on submit.
>
> So, as far as Struts is concerned, I would expect the following:
>
> - User nests a "value" inside the s:submit tag, but does not include a
> value
> attribute
>
> <s:submit type="button" theme="simple">
> <s:text name="SubmitTextName" />
> </s:submit>
>
> <button type="submit" id="example1_0">SubmitTextName</button>
>
> ======================================================
>
> - User does not nest a "value", but does include the value attribute
>
> <s:submit type="button" theme="simple" value="SubmitTextName"/>
>
> <button type="submit" id="example1_0"
> value="SubmitTextName">SubmitTextName</button>
>
> ======================================================
>
> - User does not nest or include a value with the s:submit tag. A default
> value will be used for both.
>
> <s:submit type="button" theme="simple" />
>
> <button type="submit" id="example1_0" value="Submit">Submit</button>
>
> ======================================================
>
> - User adds both a nested "value" and a value attribute:
>
> <s:submit type="button" theme="simple" value="SubmitTextName">
> <s:text name="SomeOtherSubmitTextName" />
> </s:submit>
>
> <button type="submit" id="example1_0"
> value="SubmitTextName">SomeOtherSubmitTextName</button>
>
> ======================================================
>
> Hopefully that makes sense ;) Thanks for looking into this...
>
> -Eric
>
>
>
>
> mgainty wrote:
> >
> > Eric-
> >
> > I just tossed this into a test.jsp page
> > <s:submit type="button" theme="simple">
> > <s:text name="SubmitTextName" />
> > </s:submit>
> >
> > ..and this was the rendered html output..
> >
> > SubmitTextName
> > <button type="submit" id="example1_0" value="Submit">Submit</button>
> >
> > anything wrong with the output???
> > Martin--
> > ----- Original Message -----
> > From: "Eric Martin" <er...@ericmmartin.com>
> > To: <us...@struts.apache.org>
> > Sent: Wednesday, November 28, 2007 8:27 PM
> > Subject: Re: WW-167 not working
> >
> >
> >>
> >> https://issues.apache.org/struts/browse/WW-1677
> >>
> >>
> >> mgainty wrote:
> >> >
> >> > Alberto-
> >> >
> >> > which button component are you speaking of?
> >> >
> >> > Martin--
> >> > ----- Original Message -----
> >> > From: "Alberto A. Flores" <aa...@gmail.com>
> >> > To: <us...@struts.apache.org>
> >> > Sent: Wednesday, November 28, 2007 3:05 PM
> >> > Subject: WW-167 not working
> >> >
> >> >
> >> >> Has anyone been able to confirm that this issue is working? I don't
> > seem
> >> >> to get it to work yet JIRA says it is. This is about having a
> <button>
> >> >> tag with an image and text inside the button.
> >> >>
> >> >> Thanks,
> >> >>
> >> >> Alberto
> >> >>
> >> >>
> >
>
> --
> View this message in context:
> http://www.nabble.com/WW-167-not-working-tf4892993.html#a14019260
> Sent from the Struts - User mailing list archive at Nabble.com.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
>
>
--
Alberto
http://www.linkedin.com/in/aflores
Re: WW-167 not working
Posted by Eric Martin <er...@ericmmartin.com>.
Martin,
Yes, there is a problem with the output. The SubmitTextName should be inside
the button tag, but in your example and others posted, the value gets placed
outside the button tag (seems to get displayed before the rendering of the
button.
I would expect the output to be:
<button type="submit" id="example1_0"
value="SubmitTextName">SubmitTextName</button>
In HTML, what is used for the value attribute, is what will be sent to the
server on submit. Whereas, the "value" that is nested in the button tag, is
only the "label" of the button and is not sent on submit.
So, as far as Struts is concerned, I would expect the following:
- User nests a "value" inside the s:submit tag, but does not include a value
attribute
<s:submit type="button" theme="simple">
<s:text name="SubmitTextName" />
</s:submit>
<button type="submit" id="example1_0">SubmitTextName</button>
======================================================
- User does not nest a "value", but does include the value attribute
<s:submit type="button" theme="simple" value="SubmitTextName"/>
<button type="submit" id="example1_0"
value="SubmitTextName">SubmitTextName</button>
======================================================
- User does not nest or include a value with the s:submit tag. A default
value will be used for both.
<s:submit type="button" theme="simple" />
<button type="submit" id="example1_0" value="Submit">Submit</button>
======================================================
- User adds both a nested "value" and a value attribute:
<s:submit type="button" theme="simple" value="SubmitTextName">
<s:text name="SomeOtherSubmitTextName" />
</s:submit>
<button type="submit" id="example1_0"
value="SubmitTextName">SomeOtherSubmitTextName</button>
======================================================
Hopefully that makes sense ;) Thanks for looking into this...
-Eric
mgainty wrote:
>
> Eric-
>
> I just tossed this into a test.jsp page
> <s:submit type="button" theme="simple">
> <s:text name="SubmitTextName" />
> </s:submit>
>
> ..and this was the rendered html output..
>
> SubmitTextName
> <button type="submit" id="example1_0" value="Submit">Submit</button>
>
> anything wrong with the output???
> Martin--
> ----- Original Message -----
> From: "Eric Martin" <er...@ericmmartin.com>
> To: <us...@struts.apache.org>
> Sent: Wednesday, November 28, 2007 8:27 PM
> Subject: Re: WW-167 not working
>
>
>>
>> https://issues.apache.org/struts/browse/WW-1677
>>
>>
>> mgainty wrote:
>> >
>> > Alberto-
>> >
>> > which button component are you speaking of?
>> >
>> > Martin--
>> > ----- Original Message -----
>> > From: "Alberto A. Flores" <aa...@gmail.com>
>> > To: <us...@struts.apache.org>
>> > Sent: Wednesday, November 28, 2007 3:05 PM
>> > Subject: WW-167 not working
>> >
>> >
>> >> Has anyone been able to confirm that this issue is working? I don't
> seem
>> >> to get it to work yet JIRA says it is. This is about having a <button>
>> >> tag with an image and text inside the button.
>> >>
>> >> Thanks,
>> >>
>> >> Alberto
>> >>
>> >>
>
--
View this message in context: http://www.nabble.com/WW-167-not-working-tf4892993.html#a14019260
Sent from the Struts - User mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: WW-167 not working
Posted by Martin Gainty <mg...@hotmail.com>.
Eric-
I just tossed this into a test.jsp page
<s:submit type="button" theme="simple">
<s:text name="SubmitTextName" />
</s:submit>
..and this was the rendered html output..
SubmitTextName
<button type="submit" id="example1_0" value="Submit">Submit</button>
anything wrong with the output???
Martin--
----- Original Message -----
From: "Eric Martin" <er...@ericmmartin.com>
To: <us...@struts.apache.org>
Sent: Wednesday, November 28, 2007 8:27 PM
Subject: Re: WW-167 not working
>
> https://issues.apache.org/struts/browse/WW-1677
>
>
> mgainty wrote:
> >
> > Alberto-
> >
> > which button component are you speaking of?
> >
> > Martin--
> > ----- Original Message -----
> > From: "Alberto A. Flores" <aa...@gmail.com>
> > To: <us...@struts.apache.org>
> > Sent: Wednesday, November 28, 2007 3:05 PM
> > Subject: WW-167 not working
> >
> >
> >> Has anyone been able to confirm that this issue is working? I don't
seem
> >> to get it to work yet JIRA says it is. This is about having a <button>
> >> tag with an image and text inside the button.
> >>
> >> Thanks,
> >>
> >> Alberto
> >>
> >>
> >
> >
>
> --------------------------------------------------------------------------
--
> > ----
> >
> >
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> >> For additional commands, e-mail: user-help@struts.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> > For additional commands, e-mail: user-help@struts.apache.org
> >
> >
> >
>
> --
> View this message in context:
http://www.nabble.com/WW-167-not-working-tf4892993.html#a14017529
> Sent from the Struts - User mailing list archive at Nabble.com.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: WW-167 not working
Posted by Eric Martin <er...@ericmmartin.com>.
https://issues.apache.org/struts/browse/WW-1677
mgainty wrote:
>
> Alberto-
>
> which button component are you speaking of?
>
> Martin--
> ----- Original Message -----
> From: "Alberto A. Flores" <aa...@gmail.com>
> To: <us...@struts.apache.org>
> Sent: Wednesday, November 28, 2007 3:05 PM
> Subject: WW-167 not working
>
>
>> Has anyone been able to confirm that this issue is working? I don't seem
>> to get it to work yet JIRA says it is. This is about having a <button>
>> tag with an image and text inside the button.
>>
>> Thanks,
>>
>> Alberto
>>
>>
>
>
> ----------------------------------------------------------------------------
> ----
>
>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>> For additional commands, e-mail: user-help@struts.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
>
>
>
--
View this message in context: http://www.nabble.com/WW-167-not-working-tf4892993.html#a14017529
Sent from the Struts - User mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: WW-167 not working
Posted by Martin Gainty <mg...@hotmail.com>.
Alberto-
which button component are you speaking of?
Martin--
----- Original Message -----
From: "Alberto A. Flores" <aa...@gmail.com>
To: <us...@struts.apache.org>
Sent: Wednesday, November 28, 2007 3:05 PM
Subject: WW-167 not working
> Has anyone been able to confirm that this issue is working? I don't seem
> to get it to work yet JIRA says it is. This is about having a <button>
> tag with an image and text inside the button.
>
> Thanks,
>
> Alberto
>
>
----------------------------------------------------------------------------
----
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org