You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/11/10 03:11:02 UTC
[GitHub] [echarts] pe-3 opened a new pull request, #17897: Feat funnel new style
pe-3 opened a new pull request, #17897:
URL: https://github.com/apache/echarts/pull/17897
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
<!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
- [x] Add a property to flatten the funnel exit based on the existing funnel style.
- [x] Add a dynamic height prop
### Fixed issues
<!--
- #xxxx: ...
-->
#14863
#16445
#17566
## Details
### Before: What was the problem?
The following is the current style of funnel diagram, and you can see that there is a lot of room to expand the function of funnel diagram such as flatten the top and so on.
### After: How does it behave after the fixing?
To preserve the original style, the new style needs to be set with new options.
1. If you want to flatten the top to represent none zero value, please set `exitWidth` as `100%`.
2. If you want data dynamic mapping on the height， please set `dynamicHeight` as `true`.
## Document Info
3. If you want the previous funnel to be a little bit thicker, please set `minSize` as a percentage string between 0% and 100% such as `'33%'`.
4. If you want to show the conversion rate between each of the data in Figure 1, please set `showRate` as true.
5. If you want make the previous funnel last piece a trapezoidal, plese set `exitWidth` as a percentage string between 0% and 100% such as `'33%'`.
### More: New attribute explanation
1. `exitWidth`, this property is to set the top width of the top funnel block, taking the bottom width of the piece as the base. Application scenarios: figure 1 and figure 5. Invalid when `dynamicArea` is valid;
2. `dynamicHeight`, this property will let each data take it's funnel piece height.
3. `thickDegree`, this property is control then thick degree of then dynamic height funnel, if you set this prop greater than 0% ,the funnel will thicker than default.
4. `showRate`, this property will show rate pieces between each data, invalid when dynamicHeight or dynamicArea is true.
- [ ] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [x] The document changes have been made in apache/echarts-doc#xxx
## related doc pr https://github.com/apache/echarts-doc/pull/281
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
Please refer to test/funnel.html
N.A.
## Others
### Merging options
- [x] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #17897: Feat funnel new style
Posted by GitBox <gi...@apache.org>.
pissang commented on PR #17897:
URL: https://github.com/apache/echarts/pull/17897#issuecomment-1309820136
About the `exitWidth`. Seems `neckHeight` and `neckWidth` are more commonly used options to configure the output shape of `funnel` chart. See
+ https://api.highcharts.com/highcharts/series.funnel.neckHeight
+ https://canvasjs.com/docs/charts/chart-options/data/neck-height/
+ https://playground.anychart.com/api/charts/_samples/anychart.charts.Funnel.neckHeight_set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17897: Feat funnel new style
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17897:
URL: https://github.com/apache/echarts/pull/17897#issuecomment-1309708875
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org