You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2013/08/14 17:17:49 UTC
[jira] [Commented] (SOLR-4764) When using NRT, just init the reader
from IndexWriter
[ https://issues.apache.org/jira/browse/SOLR-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13739759#comment-13739759 ]
Mark Miller commented on SOLR-4764:
-----------------------------------
+1 - I think this is a good way to solve this. It's minimally invasive given all the other current code and it allows you still lazy load the IW if you don't reopen readers.
I've closely reviewed the patch and run the units tests - it all looks okay to me.
> When using NRT, just init the reader from IndexWriter
> -----------------------------------------------------
>
> Key: SOLR-4764
> URL: https://issues.apache.org/jira/browse/SOLR-4764
> Project: Solr
> Issue Type: Improvement
> Reporter: Robert Muir
> Attachments: SOLR-4764.patch, SOLR-4764_test.patch
>
>
> Spinoff from SOLR-4761
> Solr first opens a DirectoryReader from the directory, then later will pass this to IW openIfChanged.
> I noticed this when i was confused that mergedsegmentwarmer doesn't appear to work at first until after you've reopened...
> I'm not totally sure what the current behavior causes (does IW's pool reuse segments from this passed-in "external" reader, or is this causing some horrible doubling-up/inefficient stuff etc?). To some extent i think we should change it even if its actually performant: I think its confusing.
> I think ideally we'd change IndexReaderFactory's method to take writer instead of directory so that custom DirectoryReaders can still work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org