You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2024/11/30 20:48:16 UTC
[PR] Remove AIP-44 from airflow/cli/commands/task_command.py [airflow]
jscheffl opened a new pull request, #44521:
URL: https://github.com/apache/airflow/pull/44521
related: https://github.com/apache/airflow/issues/44436
- [x] ./airflow/cli/commands/task_command.py: _get_ti_db_access
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIP-44 from airflow/cli/commands/task_command.py [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #44521:
URL: https://github.com/apache/airflow/pull/44521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove AIP-44 from airflow/cli/commands/task_command.py [airflow]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #44521:
URL: https://github.com/apache/airflow/pull/44521#discussion_r1864518751
##########
airflow/cli/commands/task_command.py:
##########
@@ -193,19 +192,20 @@ def _get_dag_run(
raise ValueError(f"unknown create_if_necessary value: {create_if_necessary!r}")
-@internal_api_call
@provide_session
-def _get_ti_db_access(
- dag: DAG,
+def _get_ti(
Review Comment:
The function `_get_ti` no longer returns the `dr_created` flag, which was part of the tuple returned by `_get_ti_db_access`. This might cause issues if other parts of the code rely on this flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org