[GitHub] [avro] zcsizmadia commented on a change in pull request #1536: AVRO-3388: Extra codecs in C#

[GitBox <gi...@apache.org>]

zcsizmadia commented on a change in pull request #1536:
URL: https://github.com/apache/avro/pull/1536#discussion_r807318209



##########
File path: lang/csharp/build.sh
##########
@@ -38,6 +38,10 @@ do
       # AVRO-2442: Explicitly set LANG to work around ICU bug in `dotnet test`
       LANG=en_US.UTF-8 dotnet test  --configuration Release --no-build \
           --filter "TestCategory!=Interop" Avro.sln
+
+       dotnet build --configuration Release src/apache/codec/Avro.Codec.sln
+       ANG=en_US.UTF-8 dotnet test --configuration Release --no-build \

Review comment:
       I really just added this to be able to test the  codecs by gitflow. At this stage I was not even sure that this Codec lib package should be part of this repo or a sepearet repo?
   
   Other idea I had was that Avro.main C# has  all the defines as well for all the codecs just like Java, however in the CreateCodec(...) it creates an codec from :Apache.Avro.Codec....." assembly.
   If the project was built with PackageReference Apache.Avro.Codec.Snappy, the snappy codec will be available, otherwise unknwo codec exception.
   
   So I had many questions here, at this stage it was jsut a proof of concept to have seperate nuget packages fopr all supported codecs, and how others like the idea. I like this way sure, since Avro.main does not have any new package dependencies. The application using the C# cllibrary will have to add the codecs  which it wants to use. All of them if it wants to support all.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org