You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "Dominik Psenner (JIRA)" <ji...@apache.org> on 2018/07/31 06:53:00 UTC

[jira] [Commented] (LOG4NET-608) File Appender Vulnerabilities

    [ https://issues.apache.org/jira/browse/LOG4NET-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563210#comment-16563210 ] 

Dominik Psenner commented on LOG4NET-608:
-----------------------------------------

If you're going to build and package this project, this happens under your responsibility. The only advice that I can give is that.

How can a class that's not serialized across application domains become a vulnerability, especially when the class is private and thus not part of the public api? Adding the serializable attribute would be an easy fix, but as far as I am concerned I am rather convinced that this is a false positive warning from "Fortify". By adding the serializable attribute, the exception that is today an implementation detail would suddenly be serialized across application domains. I do not know what the original author thought, but it appears to me that the current behavior is intentional.

public class FileAppender
{
  *private sealed* class LockingStream
  {
     public sealed class LockStateException
[...]
}

> File Appender Vulnerabilities
> -----------------------------
>
>                 Key: LOG4NET-608
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-608
>             Project: Log4net
>          Issue Type: Bug
>    Affects Versions: 2.0.8
>         Environment: Window 7 Pro
>            Reporter: V
>            Priority: Minor
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Hi, 
>      I am using Fortify to perform Vulnerability scans. Quite a number of Issues are recorded. 
> 1 of the Issue is related to FileAppender as listed below. How do I resolve it? Is there any way to just remove a number of files as I am just logging the files with vb script only for an application? Which files should I just package with the dll. Thank you for your advice. 
> Abstract: The class LockStateException implements the ISerializable interface but does not
> declare the [Serializable] attribute, so it will not be serialized.
> Sink: FileAppender.cs:141 Class: LockStateException()
> 139 private sealed class LockingStream : Stream, IDisposable
> 140 {
> 141 public sealed class LockStateException : LogException
> 142 {
> 143 public LockStateException(string message)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)