You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by akaltsikis <gi...@git.apache.org> on 2017/05/12 15:19:05 UTC

[GitHub] spark issue #16732: [SPARK-19368][MLlib] BlockMatrix.toIndexedRowMatrix() op...

Github user akaltsikis commented on the issue:

    https://github.com/apache/spark/pull/16732
  
    Hey guys i was implementing that as an external function in jar to work with spark 2.1.1. Even if @uzadude improved performance of the 2.x implementation by creating 2 seperate cases for sparse and dense matrices it seems that the Blockmatrix.toCoordinateMatrix().toIndexedRowMatrix() still works faster according to my recent benchmarks.I would suggest that we put that in case of numberNonZeroPerRow<0.1 till the function for sparse matrices has better performance that the double conversion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org