You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Sudheer Vinukonda (JIRA)" <ji...@apache.org> on 2014/04/24 01:22:15 UTC
[jira] [Comment Edited] (TS-2743) SPDY_ATS - Crash with SPDY on
production environment in SpdyNV::SpdyNV
[ https://issues.apache.org/jira/browse/TS-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979064#comment-13979064 ]
Sudheer Vinukonda edited comment on TS-2743 at 4/23/14 11:21 PM:
-----------------------------------------------------------------
It looks like the code may have an issue. There may be non string type http headers (e.g Expires), which will fail the assert.
SpdyNV::SpdyNV(TSFetchSM fetch_sm)
{
//....
//...
value = TSMimeHdrFieldValueStringGet(bufp, loc, field_loc, -1, &value_len);
TSReleaseAssert(value && value_len);
//....
To confirm, did a simple test by replacing the assert with an error log and noticed the below errors coming out a lot and the core dump looks to be fixed (although, a new core dump occured - will open a separate jira for that). Will be trying a patch to try TSMimeHdrFieldValueDateGet() if the TSMimeHdrFieldValueStringGet() fails.
20140423.23h05m42s Spdy Error in processing hdr Expires of field length 7
was (Author: sudheerv):
It looks like the code may have an issue. There may be non string type http headers (e.g Expires), which will fail the assert.
SpdyNV::SpdyNV(TSFetchSM fetch_sm)
{
//....
//...
value = TSMimeHdrFieldValueStringGet(bufp, loc, field_loc, -1, &value_len);
TSReleaseAssert(value && value_len);
//....
To confirm, did a simple test by replacing the assert with an error log and noticed the below errors coming out a lot and the core dump looks to be fixed (although, a new core dump occured - will open a separate jira for that). Will be trying a patch to try TSMimeHdrFieldValueIntGet() if the TSMimeHdrFieldValueStringGet() fails.
20140423.23h05m42s Spdy Error in processing hdr Expires of field length 7
> SPDY_ATS - Crash with SPDY on production environment in SpdyNV::SpdyNV
> ----------------------------------------------------------------------
>
> Key: TS-2743
> URL: https://issues.apache.org/jira/browse/TS-2743
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Reporter: Sudheer Vinukonda
>
> After patching a fix (by removing the apparent incorrect assert failure on non-ipv4 address in TsFetchCreate - jira ts-2742), noticed a new crash, this time in SpdyNV::SpdyNV with the below stack trace. Will update more upon investigation.
> FATAL: SpdyCommon.cc:133: failed assert `value && value_len`
> FATAL: SpdyCommon.cc:133: failed assert `value && value_len`
> /home/y/bin/traffic_server - STACK TRACE:
> /home/y/bin/traffic_server - STACK TRACE:
> /home/y/lib64/libtsutil.so.5(+0x1f5c8)[0x2b7371f6a5c8]
> /home/y/lib64/libtsutil.so.5(+0x1f5c8)[0x2b7371f6a5c8]
> /home/y/lib64/libtsutil.so.5(+0x1da8f)[0x2b7371f68a8f]
> /home/y/lib64/libtsutil.so.5(+0x1da8f)[0x2b7371f68a8f]
> /home/y/bin/traffic_server[0x4af739]
> /home/y/bin/traffic_server[0x5cf7ea]
> /home/y/bin/traffic_server[0x5d0a6a]
> /home/y/bin/traffic_server(_ZN7FetchSM15InvokePluginExtEi+0x33a)[0x4c7a5a]
> /home/y/bin/traffic_server[0x4af739]
> /home/y/bin/traffic_server(_ZN7FetchSM18process_fetch_readEi+0x187)[0x4c7f37]
> /home/y/bin/traffic_server[0x5cf7ea]
> /home/y/bin/traffic_server[0x5d0a6a]
> /home/y/bin/traffic_server(_ZN7FetchSM15InvokePluginExtEi+0x33a)[0x4c7a5a]
> /home/y/bin/traffic_server(_ZN7FetchSM18process_fetch_readEi+0x187)[0x4c7f37]
> /home/y/bin/traffic_server(_ZN7FetchSM13fetch_handlerEiPv+0x8b)[0x4c80eb]
> /home/y/bin/traffic_server(_ZN8PluginVC17process_read_sideEb+0x375)[0x4dd0d5]
> /home/y/bin/traffic_server(_ZN8PluginVC18process_write_sideEb+0x57a)[0x4dda2a]
> /home/y/bin/traffic_server(_ZN7FetchSM13fetch_handlerEiPv+0x8b)[0x4c80eb]
> /home/y/bin/traffic_server(_ZN8PluginVC12main_handlerEiPv+0x372)[0x4de272]
> /home/y/bin/traffic_server(_ZN8PluginVC17process_read_sideEb+0x375)[0x4dd0d5]
> /home/y/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0x8f)[0x712f7f]
> /home/y/bin/traffic_server(_ZN8PluginVC18process_write_sideEb+0x57a)[0x4dda2a]
> /home/y/bin/traffic_server(_ZN7EThread7executeEv+0x61b)[0x713aab]
> /home/y/bin/traffic_server(_ZN8PluginVC12main_handlerEiPv+0x372)[0x4de272]
> /home/y/bin/traffic_server[0x71232a]
> /home/y/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0x8f)[0x712f7f]
> /lib64/libpthread.so.0(+0x3297207851)[0x2b7372601851]
> /home/y/bin/traffic_server(_ZN7EThread7executeEv+0x61b)[0x713aab]
> /lib64/libc.so.6(clone+0x6d)[0x3296ee890d]
> /home/y/bin/traffic_server[0x71232a]
> /lib64/libpthread.so.0(+0x3297207851)[0x2b7372601851]
--
This message was sent by Atlassian JIRA
(v6.2#6252)