You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by av...@apache.org on 2020/09/16 09:21:45 UTC
[ignite] branch ignite-ducktape updated: Add check codestyle
(flake8) (#8248)
This is an automated email from the ASF dual-hosted git repository.
av pushed a commit to branch ignite-ducktape
in repository https://gitbox.apache.org/repos/asf/ignite.git
The following commit(s) were added to refs/heads/ignite-ducktape by this push:
new 4dfdbcc Add check codestyle (flake8) (#8248)
4dfdbcc is described below
commit 4dfdbcc46a9eeaf70bd319f2b2660e879d95f555
Author: Ivan Daschinskiy <iv...@gmail.com>
AuthorDate: Wed Sep 16 12:21:15 2020 +0300
Add check codestyle (flake8) (#8248)
---
.../tests/ignitetest/tests/cellular_affinity_test.py | 8 ++++----
modules/ducktests/tests/ignitetest/tests/discovery_test.py | 7 +++++--
modules/ducktests/tests/ignitetest/utils/__init__.py | 7 ++++++-
modules/ducktests/tests/tox.ini | 13 +++++++++++--
4 files changed, 26 insertions(+), 9 deletions(-)
diff --git a/modules/ducktests/tests/ignitetest/tests/cellular_affinity_test.py b/modules/ducktests/tests/ignitetest/tests/cellular_affinity_test.py
index 3c38b22..5d40f17 100644
--- a/modules/ducktests/tests/ignitetest/tests/cellular_affinity_test.py
+++ b/modules/ducktests/tests/ignitetest/tests/cellular_affinity_test.py
@@ -57,12 +57,12 @@ class CellularAffinity(IgniteTest):
</bean>
</property>
<property name="name" value="{{ cacheName }}"/>
- <property name="backups" value="{{ nodes }}"/>
+ <property name="backups" value="{{ nodes }}"/>
<property name="atomicityMode" value="TRANSACTIONAL"/>
</bean>
</list>
</property>
- """
+ """ # noqa: E501
@staticmethod
def properties():
@@ -185,8 +185,8 @@ class CellularAffinity(IgniteTest):
self.test_context,
IgniteConfiguration(version=IgniteVersion(version), properties=self.properties(),
discovery_spi=from_ignite_cluster(nodes)), # Server node.
- java_class_name=
- "org.apache.ignite.internal.ducktest.tests.cellular_affinity_test.CellularPreparedTxStreamer",
+ java_class_name="org.apache.ignite.internal.ducktest.tests.cellular_affinity_test."
+ "CellularPreparedTxStreamer",
params={"cacheName": CellularAffinity.CACHE_NAME,
"attr": CellularAffinity.ATTRIBUTE,
"cell": cell_id,
diff --git a/modules/ducktests/tests/ignitetest/tests/discovery_test.py b/modules/ducktests/tests/ignitetest/tests/discovery_test.py
index 8d806a4..2c8d6a1 100644
--- a/modules/ducktests/tests/ignitetest/tests/discovery_test.py
+++ b/modules/ducktests/tests/ignitetest/tests/discovery_test.py
@@ -122,8 +122,11 @@ class DiscoveryTest(IgniteTest):
version=test_config.version,
discovery_spi=discovery_spi,
failure_detection_timeout=self.FAILURE_DETECTION_TIMEOUT,
- caches=[CacheConfiguration(name='test-cache', backups=1, atomicity_mode='TRANSACTIONAL' if
- test_config.load_type == ClusterLoad.TRANSACTIONAL else 'ATOMIC')]
+ caches=[CacheConfiguration(
+ name='test-cache',
+ backups=1,
+ atomicity_mode='TRANSACTIONAL' if test_config.load_type == ClusterLoad.TRANSACTIONAL else 'ATOMIC'
+ )]
)
servers, start_servers_sec = start_servers(self.test_context, self.NUM_NODES - 1, ignite_config, modules)
diff --git a/modules/ducktests/tests/ignitetest/utils/__init__.py b/modules/ducktests/tests/ignitetest/utils/__init__.py
index 838c333..2f557ee 100644
--- a/modules/ducktests/tests/ignitetest/utils/__init__.py
+++ b/modules/ducktests/tests/ignitetest/utils/__init__.py
@@ -13,5 +13,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# pylint: disable=C0114
+"""
+This module contains convenient utils for test.
+"""
+
from ._mark import version_if, ignite_versions
+
+__all__ = ['version_if', 'ignite_versions']
diff --git a/modules/ducktests/tests/tox.ini b/modules/ducktests/tests/tox.ini
index 7955108..809d713 100644
--- a/modules/ducktests/tests/tox.ini
+++ b/modules/ducktests/tests/tox.ini
@@ -13,24 +13,30 @@
# See the License for the specific language governing permissions and
# limitations under the License.
[tox]
-envlist = linter
+envlist = codestyle,linter
skipsdist = True
[travis]
python =
- 3.8: linter
+ 3.8: codestyle, linter
[testenv]
envdir = {homedir}/.virtualenvs/ignite-ducktests-{envname}
deps =
-r ./docker/requirements.txt
pylint==2.6.0
+ flake8==3.8.3
[testenv:linter]
basepython = python3.8
commands =
pylint --rcfile=tox.ini ./ignitetest
+[testenv:codestyle]
+basepython = python3.8
+commands =
+ flake8 ./ignitetest
+
[BASIC]
min-public-methods=0
good-names=i,j,k,x,y,ex,pk,tx
@@ -40,3 +46,6 @@ ignore-imports=yes
[FORMAT]
max-line-length=120
+
+[flake8]
+max-line-length=120