You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2018/01/29 03:56:45 UTC
[GitHub] carbondata pull request #1874: [WIP] Refactor query process to improve reada...
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1874
[WIP] Refactor query process to improve readability
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata column_page_reader4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1874.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1874
----
commit 4069486c48da6dc2372535ad1413673405234cd7
Author: Jacky Li <ja...@...>
Date: 2018-01-28T14:57:31Z
wip
commit f1aaca334bd68466503129a1eeedb5fe1d279a3e
Author: Jacky Li <ja...@...>
Date: 2018-01-28T17:02:43Z
wip
commit 8bfb5029955c23fe0ec75cb2b7a2d9a4fef19fb0
Author: Jacky Li <ja...@...>
Date: 2018-01-28T18:11:52Z
wip
commit 3a614894c41b08884ec8c668d2f918de23c9dfb1
Author: Jacky Li <ja...@...>
Date: 2018-01-28T18:12:00Z
wip
commit 6a1a58a185034df14e70fd1a0e10750158009518
Author: Jacky Li <ja...@...>
Date: 2018-01-28T18:41:34Z
wip
commit c057459f864db4889b9f1f48fe522434513ef21e
Author: Jacky Li <ja...@...>
Date: 2018-01-28T18:51:50Z
wip
commit 89612c028ed26c118993a75784542217ea474bd5
Author: Jacky Li <ja...@...>
Date: 2018-01-28T18:52:18Z
wip
commit a016dcfca98dddebd241f66e328c7b96b11a6360
Author: Jacky Li <ja...@...>
Date: 2018-01-29T01:03:25Z
wip
commit 7daf9b66faf93a4b1280b5c6e9457229fc2e983c
Author: Jacky Li <ja...@...>
Date: 2018-01-29T01:03:31Z
wip
commit a20766354f5cfff0c05a07fced6d53cd8f7b60f9
Author: Jacky Li <ja...@...>
Date: 2018-01-29T01:14:01Z
wip
commit c21193b88fad2344ab94b7ff0acf6043d535d831
Author: Jacky Li <ja...@...>
Date: 2018-01-29T01:23:03Z
wip
commit b36c23712b4c71ab739bec2a339177514b2b0103
Author: Jacky Li <ja...@...>
Date: 2018-01-29T01:23:39Z
wip
commit d6421f0a7633b984adbee3d372c12f5775e26b90
Author: Jacky Li <ja...@...>
Date: 2018-01-29T02:40:14Z
wip
commit 7d12336f34a9ca0eac2b613a59d47fc3a9ec0f45
Author: Jacky Li <ja...@...>
Date: 2018-01-29T02:42:59Z
wip
commit 8438f737a2092889a619ff2a8f0d397a2b172415
Author: Jacky Li <ja...@...>
Date: 2018-01-29T03:24:49Z
wip
commit b003a3b41a23b45827cc99af9ca17b9de49108e4
Author: Jacky Li <ja...@...>
Date: 2018-01-29T03:30:11Z
wip
commit 312e2265ab6c6c5ab08804731532ccb9de838e94
Author: Jacky Li <ja...@...>
Date: 2018-01-29T03:49:27Z
wip
commit ac3eca1dc3041ec2b2effadb9ac54a0b75521222
Author: Jacky Li <ja...@...>
Date: 2018-01-29T03:55:08Z
wip
----
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3323/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query scan process to improve readabi...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1874
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3185/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2142/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query scan process to improve readabi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2023/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3377/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query process to improve readability
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1993/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query scan process to improve readabi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3231/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query process to improve readability
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3227/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query process to improve readability
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1874
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3168/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2140/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1874
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3229/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1874
retest sdv please
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3344/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3379/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1874
retest this please
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1874
Merged into carbonstore branch
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1874
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3263/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query process to improve readability
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1971/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2096/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/1874
LGTM
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1874
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3214/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2108/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query process to improve readability
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3204/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1874
retest this please
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2042/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query process to improve readability
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3228/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query scan process to improve readabi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1997/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2050/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2038/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query process to improve readability
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1984/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3311/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query process to improve readability
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1874
retest this please
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2087/
---
[GitHub] carbondata pull request #1874: [CARBONDATA-2099] Refactor query scan process...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1874#discussion_r164982595
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/model/QueryModel.java ---
@@ -117,43 +104,15 @@
*/
private boolean readPageByPage;
- public QueryModel() {
+ public QueryModel(CarbonTable carbonTable) {
--- End diff --
ok, fixed
---
[GitHub] carbondata issue #1874: [WIP] Refactor query process to improve readability
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3217/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3277/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2130/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query process to improve readability
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1992/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3274/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query scan process to improve readabi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3257/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query process to improve readability
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1994/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2074/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query process to improve readability
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3226/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1874
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3259/
---
[GitHub] carbondata issue #1874: [WIP] Refactor query scan process to improve readabi...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1874
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3179/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3290/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2083/
---
[GitHub] carbondata pull request #1874: [CARBONDATA-2099] Refactor query scan process...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk closed the pull request at:
https://github.com/apache/carbondata/pull/1874
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3332/
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3366/
---
[GitHub] carbondata pull request #1874: [CARBONDATA-2099] Refactor query scan process...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1874#discussion_r164977898
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/model/QueryModel.java ---
@@ -117,43 +104,15 @@
*/
private boolean readPageByPage;
- public QueryModel() {
+ public QueryModel(CarbonTable carbonTable) {
--- End diff --
use private modifier
---
[GitHub] carbondata issue #1874: [CARBONDATA-2099] Refactor query scan process to imp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1874
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3319/
---