You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/20 16:42:18 UTC
[GitHub] [apisix] Yiyiyimu opened a new pull request #3621: ci: auto release and check for rpm
Yiyiyimu opened a new pull request #3621:
URL: https://github.com/apache/apisix/pull/3621
Signed-off-by: yiyiyimu <wo...@gmail.com>
### What this PR does / why we need it:
Currently we have methods to make rpm package in https://github.com/api7/apisix-build-tools/pull/14. Create this PR to make it automized.
Ref: #3521
Todo:
- [ ] add test for also deb
- [ ] use master branch of apisix-build-tools when PR merged
- [ ] use the same kind of release branch check to create package
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#issuecomment-785001884
Cool it almost passed the CI 🎉 🎉
Just one last problem, since currently luarocks would not take `conf/debug.yaml` in, the test `t/debug/hook.t` would fail. Considering right now tarball would pack all `conf` directory in, we could do the same to luarocks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r586159933
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -2,11 +2,9 @@ name: CI Centos7
on:
push:
- branches:
- - master
+ branches: [master, 'release/**']
pull_request:
- branches:
- - master
+ branches: [master]
Review comment:
BTW, your change request still blocks the merging 🤣
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r586090871
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -2,11 +2,9 @@ name: CI Centos7
on:
push:
- branches:
- - master
+ branches: [master, 'release/**']
pull_request:
- branches:
- - master
+ branches: [master]
Review comment:
In fact, we will create PR to `release/**` right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r584550133
##########
File path: utils/centos7-ci.sh
##########
@@ -27,7 +27,7 @@ install_dependencies() {
# install openresty
yum install -y yum-utils && yum-config-manager --add-repo https://openresty.org/package/centos/openresty.repo
- yum install -y openresty-debug openresty-openssl111-debug-devel
+ yum install -y openresty openresty-debug openresty-openssl111-debug-devel
Review comment:
Rpm package requires [-d 'openresty >= 1.17.8.2'](https://github.com/api7/apisix-build-tools/blob/master/Makefile#L45). It seems only works for `openresty` but not `openresty-debug`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3621: ci: auto release and check for rpm
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r579842922
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -29,6 +29,15 @@ jobs:
with:
submodules: recursive
+ - name: Build rpm package
+ run: |
+ sudo gem install --no-document fpm
+ # WOULD CHANGE TO MASTER WHEN PR GETS MERGED
+ git clone https://github.com/idbeta/build-tools.git
Review comment:
Thanks, it's only for test for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r585634137
##########
File path: utils/centos7-ci.sh
##########
@@ -27,7 +27,7 @@ install_dependencies() {
# install openresty
yum install -y yum-utils && yum-config-manager --add-repo https://openresty.org/package/centos/openresty.repo
- yum install -y openresty-debug openresty-openssl111-debug-devel
+ yum install -y openresty openresty-debug openresty-openssl111-debug-devel
Review comment:
fixed. PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r585512377
##########
File path: utils/centos7-ci.sh
##########
@@ -27,7 +27,7 @@ install_dependencies() {
# install openresty
yum install -y yum-utils && yum-config-manager --add-repo https://openresty.org/package/centos/openresty.repo
- yum install -y openresty-debug openresty-openssl111-debug-devel
+ yum install -y openresty openresty-debug openresty-openssl111-debug-devel
Review comment:
Better to add a comment for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r584479878
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -29,6 +27,15 @@ jobs:
with:
submodules: recursive
+ - name: Build rpm package
+ if: ${{ startsWith(github.ref, 'refs/heads/release/') && !endsWith(matrix.os_name, 'luarocks') }}
Review comment:
Thanks! Removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r586158142
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -2,11 +2,9 @@ name: CI Centos7
on:
push:
- branches:
- - master
+ branches: [master, 'release/**']
pull_request:
- branches:
- - master
+ branches: [master]
Review comment:
Yes and relevant discussion is in #3726. Welcome have some discussion~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #3621: ci: auto release and check for rpm
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#issuecomment-782898694
> Binary packages can only be generated after the mailing list is voted pass
Binary packages are only generated here, not published. It needs maintainer to download it as "artifact".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r584451362
##########
File path: utils/centos7-ci.sh
##########
@@ -57,11 +57,11 @@ install_dependencies() {
# install dependencies
git clone https://github.com/iresty/test-nginx.git test-nginx
make deps
- make init
Review comment:
Why move this line?
##########
File path: utils/centos7-ci.sh
##########
@@ -27,7 +27,7 @@ install_dependencies() {
# install openresty
yum install -y yum-utils && yum-config-manager --add-repo https://openresty.org/package/centos/openresty.repo
- yum install -y openresty-debug openresty-openssl111-debug-devel
+ yum install -y openresty openresty-debug openresty-openssl111-debug-devel
Review comment:
Why install `openresty`?
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -29,6 +27,15 @@ jobs:
with:
submodules: recursive
+ - name: Build rpm package
+ if: ${{ startsWith(github.ref, 'refs/heads/release/') && !endsWith(matrix.os_name, 'luarocks') }}
Review comment:
The `os_name` can't be `luarocks`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r586034784
##########
File path: utils/centos7-ci.sh
##########
@@ -25,9 +25,9 @@ install_dependencies() {
yum install -y wget tar gcc automake autoconf libtool make unzip \
curl git which sudo
- # install openresty
+ # install openresty to make rpm work
Review comment:
Which rpm? It should be our rpm not OpenResty's.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#issuecomment-787594134
Test failed for centos, not sure if unstable
```
# Failed test 'ERROR: client socket timed out - TEST 12: consumer binds the limit-req plugin and `key` is `consumer_name`
# '
# at /apisix/test-nginx/lib/Test/Nginx/Socket.pm line 2094.
# Failed test 'TEST 12: consumer binds the limit-req plugin and `key` is `consumer_name` - status code ok'
# at /apisix/test-nginx/lib/Test/Nginx/Socket.pm line 948.
# got: ''
# expected: '200'
# Failed test 'TEST 12: consumer binds the limit-req plugin and `key` is `consumer_name` - response_body - response is expected (repeated req 0, req 0)'
# at /apisix/test-nginx/lib/Test/Nginx/Socket.pm line 1589.
# got: ''
# expected: 'passed
# '
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu edited a comment on pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu edited a comment on pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#issuecomment-788965187
[Centos CI passed](https://github.com/apache/apisix/runs/2012358706) in `release/test` branch. Ready to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#issuecomment-788965187
Centos CI passed in `release/test` branch. Ready to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r584480562
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -29,6 +27,16 @@ jobs:
with:
submodules: recursive
+ - name: Build rpm package
Review comment:
Yes it would only be triggered when we push to release branch. See the next line
```
if: ${{ startsWith(github.ref, 'refs/heads/release/') }}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r584480825
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -29,6 +27,16 @@ jobs:
with:
submodules: recursive
+ - name: Build rpm package
Review comment:
OK, good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #3621: ci: auto release and check for rpm
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#issuecomment-782868055
According to Apache rules, binary packages cannot be released automatically
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3621: ci: auto release and check for rpm
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r579681687
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -29,6 +29,15 @@ jobs:
with:
submodules: recursive
+ - name: Build rpm package
+ run: |
+ sudo gem install --no-document fpm
+ # WOULD CHANGE TO MASTER WHEN PR GOT MERGED
Review comment:
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r580748858
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -29,6 +29,15 @@ jobs:
with:
submodules: recursive
+ - name: Build rpm package
+ run: |
+ sudo gem install --no-document fpm
+ # WOULD CHANGE TO MASTER WHEN PR GETS MERGED
+ git clone https://github.com/idbeta/build-tools.git
+ cd build-tools
+ git checkout new-method-to-package
Review comment:
Thanks! Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jbampton commented on a change in pull request #3621: ci: auto release and check for rpm
Posted by GitBox <gi...@apache.org>.
jbampton commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r579679112
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -29,6 +29,15 @@ jobs:
with:
submodules: recursive
+ - name: Build rpm package
+ run: |
+ sudo gem install --no-document fpm
+ # WOULD CHANGE TO MASTER WHEN PR GOT MERGED
Review comment:
```suggestion
# WOULD CHANGE TO MASTER WHEN PR GETS MERGED
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #3621: ci: auto release and check for rpm
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#issuecomment-782951843
> > Binary packages can only be generated after the mailing list is voted pass
>
>
>
> Binary packages are only generated here, not published. It needs maintainer to download it as "artifact".
the title is “auto release”， which misled me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r586046151
##########
File path: utils/centos7-ci.sh
##########
@@ -25,9 +25,9 @@ install_dependencies() {
yum install -y wget tar gcc automake autoconf libtool make unzip \
curl git which sudo
- # install openresty
+ # install openresty to make rpm work
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #3621: ci: auto release and check for rpm
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r579813653
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -29,6 +29,15 @@ jobs:
with:
submodules: recursive
+ - name: Build rpm package
+ run: |
+ sudo gem install --no-document fpm
+ # WOULD CHANGE TO MASTER WHEN PR GETS MERGED
+ git clone https://github.com/idbeta/build-tools.git
Review comment:
IMO, we should wait for `https://github.com/api7/apisix-build-tools/pull/14` to be merged, and use `api7/apisix-build-tools`
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -29,6 +29,15 @@ jobs:
with:
submodules: recursive
+ - name: Build rpm package
+ run: |
+ sudo gem install --no-document fpm
+ # WOULD CHANGE TO MASTER WHEN PR GETS MERGED
+ git clone https://github.com/idbeta/build-tools.git
+ cd build-tools
+ git checkout new-method-to-package
Review comment:
We can use `-b` to specify the branch
Like
```
git clone -b new-method-to-package https://github.com/idbeta/build-tools.git
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r584481147
##########
File path: utils/centos7-ci.sh
##########
@@ -57,11 +57,11 @@ install_dependencies() {
# install dependencies
git clone https://github.com/iresty/test-nginx.git test-nginx
make deps
- make init
Review comment:
We need to install dependencies before we install apisix with rpm. So when we install dependencies, `make init` would fail since there is no `bin/apisix` yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#issuecomment-783003944
> the title is “auto release”， which misled me
Sorry my bad 😿 Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu edited a comment on pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
Yiyiyimu edited a comment on pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#issuecomment-785001884
Cool it almost passed the CI 🎉 🎉
Just one last problem, since currently luarocks would not take `conf/debug.yaml` in, the test `t/debug/hook.t` would fail. Considering right now tarball would pack all `conf` directory in, we could do the same to luarocks.
---
Raise issue in #3657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r584480035
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -29,6 +27,16 @@ jobs:
with:
submodules: recursive
+ - name: Build rpm package
Review comment:
Does we really need to build a RPM package each time the master branch or the pull request updating? What about just triggering it when tagging?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #3621: ci: auto release and check for rpm
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#issuecomment-782868334
Binary packages can only be generated after the mailing list is voted pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3621: ci: auto generate and check for rpm package
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #3621:
URL: https://github.com/apache/apisix/pull/3621
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org