You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/12/08 00:15:36 UTC
[kudu-CR] python: add back multiprocessing as a test dependency
Hello Jordan Birdsell,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5410
to review the following change.
Change subject: python: add back multiprocessing as a test dependency
......................................................................
python: add back multiprocessing as a test dependency
23cbc63387c066eff513a5a7c3a66a01ff491e79 had removed the dependency on
multiprocessing. However, it is required to work around a python 2.6 bug[1]
which caused the following output at the end of any test run:
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
File "/usr/lib64/python2.6/atexit.py", line 24, in _run_exitfuncs
func(*targs, **kargs)
File "/usr/lib64/python2.6/multiprocessing/util.py", line 258, in _exit_function
info('process shutting down')
TypeError: 'NoneType' object is not callable
Error in sys.exitfunc:
Traceback (most recent call last):
File "/usr/lib64/python2.6/atexit.py", line 24, in _run_exitfuncs
func(*targs, **kargs)
File "/usr/lib64/python2.6/multiprocessing/util.py", line 258, in _exit_function
info('process shutting down')
TypeError: 'NoneType' object is not callable
[1] http://bugs.python.org/issue15881
Change-Id: I72dd0b8cb91ef6e4099b57792d95cfddec31eae1
---
M python/setup.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/5410/1
--
To view, visit http://gerrit.cloudera.org:8080/5410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I72dd0b8cb91ef6e4099b57792d95cfddec31eae1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
[kudu-CR] python: add back multiprocessing as a test dependency
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: python: add back multiprocessing as a test dependency
......................................................................
Patch Set 1:
hrm, apparently this breaks py3. Jordan, any thoughts? I guess we could conditionally add it in setup.py?
--
To view, visit http://gerrit.cloudera.org:8080/5410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I72dd0b8cb91ef6e4099b57792d95cfddec31eae1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] python: add workaround for multiprocessing atexit hook on py2.6
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: python: add workaround for multiprocessing atexit hook on py2.6
......................................................................
python: add workaround for multiprocessing atexit hook on py2.6
23cbc63387c066eff513a5a7c3a66a01ff491e79 had removed the dependency on
multiprocessing. However, this exposed a python 2.6 bug[1] which caused the
following output at the end of any test run:
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
File "/usr/lib64/python2.6/atexit.py", line 24, in _run_exitfuncs
func(*targs, **kargs)
File "/usr/lib64/python2.6/multiprocessing/util.py", line 258, in _exit_function
info('process shutting down')
TypeError: 'NoneType' object is not callable
Error in sys.exitfunc:
Traceback (most recent call last):
File "/usr/lib64/python2.6/atexit.py", line 24, in _run_exitfuncs
func(*targs, **kargs)
File "/usr/lib64/python2.6/multiprocessing/util.py", line 258, in _exit_function
info('process shutting down')
TypeError: 'NoneType' object is not callable
This patch adds a workaround for the issue as suggested in the bug report.
[1] http://bugs.python.org/issue15881
Change-Id: I72dd0b8cb91ef6e4099b57792d95cfddec31eae1
Reviewed-on: http://gerrit.cloudera.org:8080/5410
Tested-by: Kudu Jenkins
Reviewed-by: Jordan Birdsell <jt...@apache.org>
---
M python/setup.py
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Jordan Birdsell: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72dd0b8cb91ef6e4099b57792d95cfddec31eae1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] python: add back multiprocessing as a test dependency
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: python: add back multiprocessing as a test dependency
......................................................................
Patch Set 1:
Yea, I'd do a conditional.
--
To view, visit http://gerrit.cloudera.org:8080/5410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I72dd0b8cb91ef6e4099b57792d95cfddec31eae1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] python: add workaround for multiprocessing atexit hook on py2.6
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: python: add workaround for multiprocessing atexit hook on py2.6
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I72dd0b8cb91ef6e4099b57792d95cfddec31eae1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] python: add workaround for multiprocessing atexit hook on py2.6
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Jordan Birdsell, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5410
to look at the new patch set (#2).
Change subject: python: add workaround for multiprocessing atexit hook on py2.6
......................................................................
python: add workaround for multiprocessing atexit hook on py2.6
23cbc63387c066eff513a5a7c3a66a01ff491e79 had removed the dependency on
multiprocessing. However, this exposed a python 2.6 bug[1] which caused the
following output at the end of any test run:
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
File "/usr/lib64/python2.6/atexit.py", line 24, in _run_exitfuncs
func(*targs, **kargs)
File "/usr/lib64/python2.6/multiprocessing/util.py", line 258, in _exit_function
info('process shutting down')
TypeError: 'NoneType' object is not callable
Error in sys.exitfunc:
Traceback (most recent call last):
File "/usr/lib64/python2.6/atexit.py", line 24, in _run_exitfuncs
func(*targs, **kargs)
File "/usr/lib64/python2.6/multiprocessing/util.py", line 258, in _exit_function
info('process shutting down')
TypeError: 'NoneType' object is not callable
This patch adds a workaround for the issue as suggested in the bug report.
[1] http://bugs.python.org/issue15881
Change-Id: I72dd0b8cb91ef6e4099b57792d95cfddec31eae1
---
M python/setup.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/5410/2
--
To view, visit http://gerrit.cloudera.org:8080/5410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I72dd0b8cb91ef6e4099b57792d95cfddec31eae1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>