You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2006/12/29 23:53:21 UTC

[jira] Created: (DIRSERVER-808) Modify the semantic of LdapDN.toString() method

Modify the semantic of LdapDN.toString() method
-----------------------------------------------

                 Key: DIRSERVER-808
                 URL: http://issues.apache.org/jira/browse/DIRSERVER-808
             Project: Directory ApacheDS
          Issue Type: Improvement
          Components: ldap
            Reporter: Emmanuel Lecharny
         Assigned To: Emmanuel Lecharny
             Fix For: 1.5.0


The semantic of LdapDN.toString() method is really bad : it returns a normalized form of the DN. By no means this should have been the case, so I suggest to switch it back to what it should have been from the beginning :

toString() returns the user provided DN
getUpName() return the user provided DN ( for completness)
getNormName() returns the normalized form of the DN

Of course, many test cases will be impacted, but this is not something that can't be fixed in less that a few hours.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] Created: (DIRSERVER-808) Modify the semantic of LdapDN.toString() method

Posted by Norval Hope <nr...@gmail.com>.
Gets my vote, for sure!

I have a lot of code trying to get around this problem, and it means
distinguishing between Sun JNDI Names and LdapDNs in methods taking a
javax.naming.Name argument which is not the best.

[jira] Updated: (DIRSERVER-808) Modify the semantic of LdapDN.toString() method

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny updated DIRSERVER-808:
----------------------------------------

    Fix Version/s:     (was: 1.5.0)
                   1.5.1

I have started to modify the semantic of this class, but much should be done. May be a complete review of the API and the internal of LdapDN should be done. Alex suggested that may be it could be a good idea to have two classes : LdapDN and NormalizedLdapDN, to express the different natures of a DN. It could also be good to reviex the code, which is very complicated...

> Modify the semantic of LdapDN.toString() method
> -----------------------------------------------
>
>                 Key: DIRSERVER-808
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-808
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>          Components: ldap
>            Reporter: Emmanuel Lecharny
>         Assigned To: Emmanuel Lecharny
>             Fix For: 1.5.1
>
>
> The semantic of LdapDN.toString() method is really bad : it returns a normalized form of the DN. By no means this should have been the case, so I suggest to switch it back to what it should have been from the beginning :
> toString() returns the user provided DN
> getUpName() return the user provided DN ( for completness)
> getNormName() returns the normalized form of the DN
> Of course, many test cases will be impacted, but this is not something that can't be fixed in less that a few hours.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRSERVER-808) Modify the semantic of LdapDN.toString() method

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490530 ] 

Emmanuel Lecharny commented on DIRSERVER-808:
---------------------------------------------

the toString() method has to be mapped to getUpName() for debug purposes. 

getUpName() and getNormName() methods have been created

> Modify the semantic of LdapDN.toString() method
> -----------------------------------------------
>
>                 Key: DIRSERVER-808
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-808
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>          Components: ldap
>            Reporter: Emmanuel Lecharny
>         Assigned To: Emmanuel Lecharny
>             Fix For: 1.5.1
>
>
> The semantic of LdapDN.toString() method is really bad : it returns a normalized form of the DN. By no means this should have been the case, so I suggest to switch it back to what it should have been from the beginning :
> toString() returns the user provided DN
> getUpName() return the user provided DN ( for completness)
> getNormName() returns the normalized form of the DN
> Of course, many test cases will be impacted, but this is not something that can't be fixed in less that a few hours.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DIRSERVER-808) Modify the semantic of LdapDN.toString() method

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny closed DIRSERVER-808.
---------------------------------------


done

> Modify the semantic of LdapDN.toString() method
> -----------------------------------------------
>
>                 Key: DIRSERVER-808
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-808
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>          Components: ldap
>            Reporter: Emmanuel Lecharny
>         Assigned To: Emmanuel Lecharny
>             Fix For: 1.5.1
>
>
> The semantic of LdapDN.toString() method is really bad : it returns a normalized form of the DN. By no means this should have been the case, so I suggest to switch it back to what it should have been from the beginning :
> toString() returns the user provided DN
> getUpName() return the user provided DN ( for completness)
> getNormName() returns the normalized form of the DN
> Of course, many test cases will be impacted, but this is not something that can't be fixed in less that a few hours.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DIRSERVER-808) Modify the semantic of LdapDN.toString() method

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny resolved DIRSERVER-808.
-----------------------------------------

    Resolution: Fixed

The semantic has been changed

> Modify the semantic of LdapDN.toString() method
> -----------------------------------------------
>
>                 Key: DIRSERVER-808
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-808
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>          Components: ldap
>            Reporter: Emmanuel Lecharny
>         Assigned To: Emmanuel Lecharny
>             Fix For: 1.5.1
>
>
> The semantic of LdapDN.toString() method is really bad : it returns a normalized form of the DN. By no means this should have been the case, so I suggest to switch it back to what it should have been from the beginning :
> toString() returns the user provided DN
> getUpName() return the user provided DN ( for completness)
> getNormName() returns the normalized form of the DN
> Of course, many test cases will be impacted, but this is not something that can't be fixed in less that a few hours.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.