[jira] [Commented] (FLINK-2769) Web dashboard port not configurable on client side

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909245#comment-14909245 ] 

ASF GitHub Bot commented on FLINK-2769:
---------------------------------------

GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/1185

    [FLINK-2769] [dashboard] Remove hard coded job server URL

    Removes the hard coded job server URL for the client scripts. This was preventing the web server port configuration to be picked up by the client.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink dashboard_port-2769

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1185
    
----
commit 118850ae95de9830705ad6b284967c964ea60674
Author: Ufuk Celebi <uc...@apache.org>
Date:   2015-09-26T12:12:20Z

    [FLINK-2769] [dashboard] Remove hard coded job server URL

----


> Web dashboard port not configurable on client side
> --------------------------------------------------
>
>                 Key: FLINK-2769
>                 URL: https://issues.apache.org/jira/browse/FLINK-2769
>             Project: Flink
>          Issue Type: Bug
>          Components: Webfrontend
>    Affects Versions: master
>            Reporter: Ufuk Celebi
>            Priority: Critical
>
> The new web dashboard port configuration only affects the server side, but not the client side.
> To reproduce set in {{flink-conf.yaml}}:
> {code}
> jobmanager.web.port: 9091
> jobmanager.new-web-frontend: true
> {code}
> Run
> {code}
> $ bin/start-cluster.sh
> {code}
> You can browse to {{http://localhost:9091}}, but you won't see any data from the job manager. Requests to http://localhost:9091/overview etc. work as expected, but the client side JavaScript is running requests against {{http://localhost:8081}}.
> The problem is that {{flink-runtime-web/web-dashboard/app/scripts/index.coffee}} hard codes:
> {code}
> .value 'flinkConfig', {
>   jobServer: 'http://localhost:8081'
> }
> {code} which is picked up by all generated scripts.
> This needs to be configurable for both standalone mode but especially for recovery mode. This was a major pain point for me today, because I was working on the dashboard and thought that my changes were wrong.
> In general, we need to add more tests to the new dashboard, which should soon replace the old one imo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)