You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "dabla (via GitHub)" <gi...@apache.org> on 2026/03/03 06:59:40 UTC

Re: [PR] Fix dynamic dag_id resolution in `TriggerDagRunOperator` links [airflow]

dabla commented on PR #56973:
URL: https://github.com/apache/airflow/pull/56973#issuecomment-3989090198

   > > Looking good to me apart from question if this change should also not be directly tested in test_serialized_objects instead of relying on indirect tests?
   > 
   > Good point. Currently tested indirectly through TriggerDagRunOperator tests. A direct unit test in test_serialized_objects.py for _deserialize_field_value() handling ARG_NOT_SET for date fields would be clearer. Should I add this test, or would you prefer to handle it in a follow-up?
   
   It think it would be better even though it's indirectly tested through TriggerDagRunOperator tests.  So yes would add case in test_serialized_objects.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org