You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Arnout Engelen (JIRA)" <ji...@apache.org> on 2008/02/28 23:33:51 UTC
[jira] Created: (WICKET-1380) (Simple)AttributeModifier abuse check
(Simple)AttributeModifier abuse check
-------------------------------------
Key: WICKET-1380
URL: https://issues.apache.org/jira/browse/WICKET-1380
Project: Wicket
Issue Type: Improvement
Components: wicket
Reporter: Arnout Engelen
Priority: Minor
I've seen people using an AttributeModifier to manipulate the ID of a component, causing puzzling problems e.g. with Ajax.
It would be nice to show a warning in the logging in this case, telling him/her to use http://wicketstuff.org/wicket13doc/org/apache/wicket/Component.html#setMarkupId(java.lang.String) instead if they must manually set the id.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1380) (Simple)AttributeModifier abuse
check
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576618#action_12576618 ]
Igor Vaynberg commented on WICKET-1380:
---------------------------------------
this should be done on a lower level so that if a user uses their own behavior, or overrides oncomponenttag and does it there the same warning should appear.
> (Simple)AttributeModifier abuse check
> -------------------------------------
>
> Key: WICKET-1380
> URL: https://issues.apache.org/jira/browse/WICKET-1380
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Arnout Engelen
> Priority: Minor
>
> I've seen people using an AttributeModifier to manipulate the ID of a component, causing puzzling problems e.g. with Ajax.
> It would be nice to show a warning in the logging in this case, telling him/her to use http://wicketstuff.org/wicket13doc/org/apache/wicket/Component.html#setMarkupId(java.lang.String) instead if they must manually set the id.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1380) (Simple)AttributeModifier abuse check
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1380:
----------------------------------
Fix Version/s: 1.5-M1
> (Simple)AttributeModifier abuse check
> -------------------------------------
>
> Key: WICKET-1380
> URL: https://issues.apache.org/jira/browse/WICKET-1380
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Arnout Engelen
> Priority: Minor
> Fix For: 1.5-M1
>
>
> I've seen people using an AttributeModifier to manipulate the ID of a component, causing puzzling problems e.g. with Ajax.
> It would be nice to show a warning in the logging in this case, telling him/her to use http://wicketstuff.org/wicket13doc/org/apache/wicket/Component.html#setMarkupId(java.lang.String) instead if they must manually set the id.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1380) (Simple)AttributeModifier abuse
check
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-1380.
----------------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.5-M1)
1.4-RC2
Assignee: Juergen Donnerstag
Introduced TagAttribute which extends ValueMap and which does the check. An internal put method is available for e.g. MarkupParser which genuinely needs to add the "id" attribute to the map.
> (Simple)AttributeModifier abuse check
> -------------------------------------
>
> Key: WICKET-1380
> URL: https://issues.apache.org/jira/browse/WICKET-1380
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Arnout Engelen
> Assignee: Juergen Donnerstag
> Priority: Minor
> Fix For: 1.4-RC2
>
>
> I've seen people using an AttributeModifier to manipulate the ID of a component, causing puzzling problems e.g. with Ajax.
> It would be nice to show a warning in the logging in this case, telling him/her to use http://wicketstuff.org/wicket13doc/org/apache/wicket/Component.html#setMarkupId(java.lang.String) instead if they must manually set the id.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.