You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by jhorcicka <gi...@git.apache.org> on 2016/08/05 06:58:45 UTC
[GitHub] metamodel pull request #121: FixedWidthReader diacritics bug fix
GitHub user jhorcicka opened a pull request:
https://github.com/apache/metamodel/pull/121
FixedWidthReader diacritics bug fix
Refactoring of FixedWidthReader in PR https://github.com/apache/metamodel/pull/103 introduced a bug related to charset (which was not used). So, input containing diacritic characters was not read correctly.
JUnit FixedWidthReaderTest was updated with charset tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jhorcicka/metamodel master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit 480f71af754f08d53891f40d9ff9c27822fec62b
Author: jhorcicka <ja...@humaninference.com>
Date: 2016-05-20T11:26:23Z
METAMODEL-250 FixedWidth EBCDIC support: headerPresent and eolPresent options; Reader was replaced by InputStream;
commit ca3ef6cf93f4cfd6f0dc7854aa23d0bd2f75868d
Author: jhorcicka <ja...@humaninference.com>
Date: 2016-05-20T12:39:04Z
METAMODEL-250 FixedWidthConfiguration: formatting.
commit 35d9b6d1b861a9d60b848614673c1fb98165bc1c
Author: jhorcicka <ja...@humaninference.com>
Date: 2016-05-23T07:00:24Z
METAMODEL-250 FixedWidthReader: refactoring of "throwInconsistentValueException".
commit f7b9ad7c036100b11607eae5e4185161a595b3c4
Author: jhorcicka <ja...@humaninference.com>
Date: 2016-05-23T07:08:58Z
METAMODEL-250 FixedWidthConfiguration overloaded constructor: default values for new properties => backwards compatibility.
commit 897117d8be90b6a5b4259b69c480d6c1e722dbc8
Author: jhorcicka <ja...@humaninference.com>
Date: 2016-08-01T11:27:41Z
METAMODEL-250 Ebcdic Configuration and Reader were separated (sub-classed) from FixedWidth parents so that EBCDIC-specific properties are handled in separated classes.
commit c0526d09829e43b4372d6a3d36d09dcdb1f983e1
Author: jhorcicka <ja...@humaninference.com>
Date: 2016-08-01T13:49:12Z
METAMODEL-250 Code cleanup.
commit d0672c76d56d2449778fa836104c2192723f19ce
Author: jhorcicka <ja...@humaninference.com>
Date: 2016-08-01T13:55:02Z
Merge branch 'upstream-master'
# Conflicts:
# fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java
commit 513fa907299885f50cd0ccbd6f01654869e9e0b4
Author: jhorcicka <ja...@humaninference.com>
Date: 2016-08-01T14:14:38Z
METAMODEL-250 test corrections.
commit 5d1d8e07de2de4f36ddaafd686552e02b373a83b
Author: jhorcicka <ja...@humaninference.com>
Date: 2016-08-01T14:26:39Z
METAMODEL-250 EbcdicReader: _headerPresent was renamed to _skipEbcdicHeader.
commit 257420a9a75f510f54a05a9871593274194793cb
Author: jhorcicka <ja...@humaninference.com>
Date: 2016-08-03T14:46:10Z
METAMODEL-250 FixedWidthReader: encoding problem was fixed.
commit e8ac28efa6fa4e994203fceacb7fbffcbea55246
Author: jhorcicka <ja...@humaninference.com>
Date: 2016-08-03T14:54:22Z
Merge branch 'upstream-master'
# Conflicts:
# fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java
commit a54b7588c995b333a2fa99cc000f6fdbbf7c28cd
Author: jhorcicka <ja...@humaninference.com>
Date: 2016-08-04T07:56:23Z
METAMODEL-250 FixedWidthReader: junit tests for diacritics were added.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request #121: FixedWidthReader diacritics bug fix
Posted by jhorcicka <gi...@git.apache.org>.
Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/121#discussion_r73649819
--- Diff: fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java ---
@@ -85,6 +92,15 @@ public FixedWidthReader(InputStream stream, String charsetName, int[] valueWidth
_expectedLineLength = expectedLineLength;
}
+ private void initReader() {
+ try {
+ InputStreamReader inputStreamReader = new InputStreamReader(_stream, _charsetName);
--- End diff --
This was the missing part in the previous version, _charsetName was not used anywhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request #121: FixedWidthReader diacritics bug fix
Posted by jhorcicka <gi...@git.apache.org>.
Github user jhorcicka closed the pull request at:
https://github.com/apache/metamodel/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #121: FixedWidthReader diacritics bug fix
Posted by jhorcicka <gi...@git.apache.org>.
Github user jhorcicka commented on the issue:
https://github.com/apache/metamodel/pull/121
I closed this PR because of a bad source, I will create a new one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #121: FixedWidthReader diacritics bug fix
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/121
This seems to be based on your old branch, instead of on mm:master.
It might be a good idea to make a new PR based directly on mm:master so there's no guesswork on which commits are new.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---