You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vineet Garg <vg...@hortonworks.com> on 2018/02/25 06:42:42 UTC

Review Request 65801: HIVE-18797 ExprConstNodeDesc's getExprString should put appropriate qualifier with literals

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65801/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-18797
    https://issues.apache.org/jira/browse/HIVE-18797


Repository: hive-git


Description
-------

See JIRA


Diffs
-----

  hbase-handler/src/test/results/positive/hbase_timestamp.q.out e719b087d4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java 73f449fc28 
  ql/src/test/results/clientpositive/annotate_stats_deep_filters.q.out ab8c22b9be 
  ql/src/test/results/clientpositive/annotate_stats_groupby.q.out 25efe1e1f4 
  ql/src/test/results/clientpositive/annotate_stats_groupby2.q.out 78c4808f5f 
  ql/src/test/results/clientpositive/annotate_stats_select.q.out 9aaa6f68a2 
  ql/src/test/results/clientpositive/cast_on_constant.q.out 7f920f41af 
  ql/src/test/results/clientpositive/constant_prop_3.q.out b754f8e7b4 
  ql/src/test/results/clientpositive/constantfolding.q.out c4fce25e41 
  ql/src/test/results/clientpositive/constprog_type.q.out 27ef1f482b 
  ql/src/test/results/clientpositive/druid_basic2.q.out 08b64d6d82 
  ql/src/test/results/clientpositive/druid_basic3.q.out ce6d0aafed 
  ql/src/test/results/clientpositive/druid_intervals.q.out c94cbe9bd4 
  ql/src/test/results/clientpositive/druid_timeseries.q.out 785cbd2114 
  ql/src/test/results/clientpositive/druid_topn.q.out 90eec3dd49 
  ql/src/test/results/clientpositive/except_all.q.out c3310f5154 
  ql/src/test/results/clientpositive/extrapolate_part_stats_date.q.out 8fea7fdf44 
  ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out 49e0d35d39 
  ql/src/test/results/clientpositive/groupby_cube1.q.out 37b8c62edd 
  ql/src/test/results/clientpositive/groupby_cube_multi_gby.q.out e6126ab2c6 
  ql/src/test/results/clientpositive/groupby_grouping_id3.q.out ac43413400 
  ql/src/test/results/clientpositive/groupby_grouping_sets1.q.out 62fc9fb550 
  ql/src/test/results/clientpositive/groupby_grouping_sets2.q.out 43e17ec6bc 
  ql/src/test/results/clientpositive/groupby_grouping_sets3.q.out 352d4beb9f 
  ql/src/test/results/clientpositive/groupby_grouping_sets4.q.out e368e1ee12 
  ql/src/test/results/clientpositive/groupby_grouping_sets5.q.out 1766fb9bbc 
  ql/src/test/results/clientpositive/groupby_grouping_sets6.q.out 563b110a11 
  ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out 1f2cd456c8 
  ql/src/test/results/clientpositive/groupby_grouping_sets_limit.q.out efa1802855 
  ql/src/test/results/clientpositive/groupby_grouping_window.q.out 0f58f5182a 
  ql/src/test/results/clientpositive/groupby_rollup1.q.out a849a8d368 
  ql/src/test/results/clientpositive/groupby_rollup_empty.q.out dd53fe2140 
  ql/src/test/results/clientpositive/having.q.out 8a630751bb 
  ql/src/test/results/clientpositive/having2.q.out 67f8af8328 
  ql/src/test/results/clientpositive/implicit_cast1.q.out 6e1706a8a3 
  ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out 72249383ee 
  ql/src/test/results/clientpositive/infer_const_type.q.out 647c910241 
  ql/src/test/results/clientpositive/interval_alt.q.out 53c1be8d05 
  ql/src/test/results/clientpositive/interval_arithmetic.q.out eba97face9 
  ql/src/test/results/clientpositive/limit_pushdown2.q.out f4cff2bcc0 
  ql/src/test/results/clientpositive/literal_ints.q.out 9a56ebd5eb 
  ql/src/test/results/clientpositive/llap/acid_vectorization_original.q.out 68801f0294 
  ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out 98ede4e995 
  ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_3.q.out aca6b21dba 
  ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out 15a97a78c1 
  ql/src/test/results/clientpositive/llap/dynpart_sort_optimization.q.out 78b9a443b8 
  ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out 7b1dd40a16 
  ql/src/test/results/clientpositive/llap/except_distinct.q.out 1e5937a22d 
  ql/src/test/results/clientpositive/llap/explainuser_1.q.out 43ca0d9ad7 
  ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.out 24be36ea36 
  ql/src/test/results/clientpositive/llap/having.q.out 75de96ab59 
  ql/src/test/results/clientpositive/llap/intersect_all.q.out 20a234e53b 
  ql/src/test/results/clientpositive/llap/intersect_distinct.q.out a5384eb196 
  ql/src/test/results/clientpositive/llap/intersect_merge.q.out 6f0e7f1f66 
  ql/src/test/results/clientpositive/llap/lineage2.q.out 4f59a4d59b 
  ql/src/test/results/clientpositive/llap/lineage3.q.out ca4405caf7 
  ql/src/test/results/clientpositive/llap/mrr.q.out bfa26e4ff8 
  ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out 66bf74f15a 
  ql/src/test/results/clientpositive/llap/orc_merge5.q.out 6eba365ff2 
  ql/src/test/results/clientpositive/llap/orc_merge6.q.out 1583007d7b 
  ql/src/test/results/clientpositive/llap/orc_merge_incompat1.q.out 0e9b34f8ec 
  ql/src/test/results/clientpositive/llap/orc_predicate_pushdown.q.out 9f20f77cb0 
  ql/src/test/results/clientpositive/llap/parquet_predicate_pushdown.q.out 6885346539 
  ql/src/test/results/clientpositive/llap/sqlmerge.q.out 2ff590ea0c 
  ql/src/test/results/clientpositive/llap/subquery_in.q.out b5f9641502 
  ql/src/test/results/clientpositive/llap/subquery_in_having.q.out cc0b6a597a 
  ql/src/test/results/clientpositive/llap/subquery_multi.q.out 67a22c812f 
  ql/src/test/results/clientpositive/llap/subquery_notin.q.out 50c18c8a68 
  ql/src/test/results/clientpositive/llap/subquery_null_agg.q.out cff9568406 
  ql/src/test/results/clientpositive/llap/subquery_scalar.q.out cec3daa085 
  ql/src/test/results/clientpositive/llap/subquery_select.q.out 89eab37d07 
  ql/src/test/results/clientpositive/llap/subquery_views.q.out 01a86d1300 
  ql/src/test/results/clientpositive/llap/tez_dynpart_hashjoin_2.q.out 642bda2736 
  ql/src/test/results/clientpositive/llap/tez_union_group_by.q.out 79321c1460 
  ql/src/test/results/clientpositive/llap/tez_vector_dynpart_hashjoin_2.q.out 1ce7a3a37c 
  ql/src/test/results/clientpositive/llap/vector_between_in.q.out f4f87ae0ee 
  ql/src/test/results/clientpositive/llap/vector_date_1.q.out bacd667498 
  ql/src/test/results/clientpositive/llap/vector_decimal_aggregate.q.out 5cb3e6678f 
  ql/src/test/results/clientpositive/llap/vector_elt.q.out 24a1a65022 
  ql/src/test/results/clientpositive/llap/vector_interval_2.q.out 7548686c50 
  ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out f2a4d3a855 
  ql/src/test/results/clientpositive/llap/vector_number_compare_projection.q.out cd2e1e4c42 
  ql/src/test/results/clientpositive/llap/vector_ptf_part_simple.q.out 16b59e612c 
  ql/src/test/results/clientpositive/llap/vector_reuse_scratchcols.q.out b9c1ba31e8 
  ql/src/test/results/clientpositive/llap/vector_struct_in.q.out 4af1015fe7 
  ql/src/test/results/clientpositive/llap/vector_udf_adaptor_1.q.out a752dfadd4 
  ql/src/test/results/clientpositive/llap/vector_windowing_navfn.q.out 8dc3fa7764 
  ql/src/test/results/clientpositive/llap/vector_windowing_rank.q.out aa47b1bf75 
  ql/src/test/results/clientpositive/llap/vector_windowing_streaming.q.out 2c54027bed 
  ql/src/test/results/clientpositive/llap/vectorization_14.q.out c7a32e3a7e 
  ql/src/test/results/clientpositive/llap/vectorization_17.q.out bdcb1ebfee 
  ql/src/test/results/clientpositive/llap/vectorization_4.q.out a2142b716d 
  ql/src/test/results/clientpositive/llap/vectorization_6.q.out 84b9260c18 
  ql/src/test/results/clientpositive/llap/vectorization_7.q.out 3c7522912d 
  ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out bd5e284523 
  ql/src/test/results/clientpositive/llap/vectorized_case.q.out ed17e5c5f1 
  ql/src/test/results/clientpositive/llap/vectorized_casts.q.out 84b4d9454d 
  ql/src/test/results/clientpositive/llap/vectorized_date_funcs.q.out db292508ac 
  ql/src/test/results/clientpositive/llap/vectorized_timestamp.q.out 9652d36b20 
  ql/src/test/results/clientpositive/llap/vectorized_timestamp_ints_casts.q.out c346ff2cf8 
  ql/src/test/results/clientpositive/num_op_type_conv.q.out 8e714f4ad7 
  ql/src/test/results/clientpositive/orc_merge5.q.out 970c4ddad9 
  ql/src/test/results/clientpositive/orc_merge6.q.out a08eb09cee 
  ql/src/test/results/clientpositive/orc_merge_incompat1.q.out e8d504a9cb 
  ql/src/test/results/clientpositive/parquet_vectorization_14.q.out f127434557 
  ql/src/test/results/clientpositive/parquet_vectorization_17.q.out 8f26d41a48 
  ql/src/test/results/clientpositive/parquet_vectorization_4.q.out 4c39858751 
  ql/src/test/results/clientpositive/parquet_vectorization_6.q.out 3d7d5e3c85 
  ql/src/test/results/clientpositive/parquet_vectorization_7.q.out 77caa03107 
  ql/src/test/results/clientpositive/parquet_vectorization_div0.q.out 4a5cca6d22 
  ql/src/test/results/clientpositive/perf/spark/query12.q.out d1796248f2 
  ql/src/test/results/clientpositive/perf/spark/query16.q.out 1b763e278e 
  ql/src/test/results/clientpositive/perf/spark/query18.q.out 33b2f62386 
  ql/src/test/results/clientpositive/perf/spark/query20.q.out ab1b24dbf9 
  ql/src/test/results/clientpositive/perf/spark/query21.q.out e73a627332 
  ql/src/test/results/clientpositive/perf/spark/query22.q.out 38e4119afc 
  ql/src/test/results/clientpositive/perf/spark/query23.q.out 8b5a83a58a 
  ql/src/test/results/clientpositive/perf/spark/query27.q.out a87ec45c11 
  ql/src/test/results/clientpositive/perf/spark/query32.q.out e7d356d257 
  ql/src/test/results/clientpositive/perf/spark/query36.q.out 1a1a991b96 
  ql/src/test/results/clientpositive/perf/spark/query37.q.out d8bff8173d 
  ql/src/test/results/clientpositive/perf/spark/query38.q.out b9af9642b5 
  ql/src/test/results/clientpositive/perf/spark/query40.q.out ab196dcb5d 
  ql/src/test/results/clientpositive/perf/spark/query45.q.out 07af4e2e4b 
  ql/src/test/results/clientpositive/perf/spark/query5.q.out 1ba37e050f 
  ql/src/test/results/clientpositive/perf/spark/query6.q.out 126cf9e11c 
  ql/src/test/results/clientpositive/perf/spark/query67.q.out b0fc41c7a2 
  ql/src/test/results/clientpositive/perf/spark/query70.q.out 7ebb776719 
  ql/src/test/results/clientpositive/perf/spark/query77.q.out 9a77a7b8b4 
  ql/src/test/results/clientpositive/perf/spark/query8.q.out 13cd0f4ab6 
  ql/src/test/results/clientpositive/perf/spark/query80.q.out ee769f9b95 
  ql/src/test/results/clientpositive/perf/spark/query82.q.out b45f8d0bfb 
  ql/src/test/results/clientpositive/perf/spark/query86.q.out 80a24d3dd7 
  ql/src/test/results/clientpositive/perf/spark/query87.q.out 5fe3e48dfc 
  ql/src/test/results/clientpositive/perf/spark/query9.q.out 4ec20070f7 
  ql/src/test/results/clientpositive/perf/spark/query92.q.out 677a85cea1 
  ql/src/test/results/clientpositive/perf/spark/query94.q.out 39c4476a5c 
  ql/src/test/results/clientpositive/perf/spark/query95.q.out 0d136b6da7 
  ql/src/test/results/clientpositive/perf/spark/query98.q.out 24d7de8b71 
  ql/src/test/results/clientpositive/perf/tez/query12.q.out 0506eca00d 
  ql/src/test/results/clientpositive/perf/tez/query14.q.out ef44cdbb6d 
  ql/src/test/results/clientpositive/perf/tez/query16.q.out 1c0539199e 
  ql/src/test/results/clientpositive/perf/tez/query18.q.out 1f0ec90b41 
  ql/src/test/results/clientpositive/perf/tez/query20.q.out c07141b368 
  ql/src/test/results/clientpositive/perf/tez/query21.q.out aed0990277 
  ql/src/test/results/clientpositive/perf/tez/query22.q.out d13169c25c 
  ql/src/test/results/clientpositive/perf/tez/query23.q.out c7a5041861 
  ql/src/test/results/clientpositive/perf/tez/query27.q.out c6a190553e 
  ql/src/test/results/clientpositive/perf/tez/query32.q.out 3ad9595910 
  ql/src/test/results/clientpositive/perf/tez/query36.q.out a30ac2e53c 
  ql/src/test/results/clientpositive/perf/tez/query37.q.out d5af964b0a 
  ql/src/test/results/clientpositive/perf/tez/query38.q.out 199bed7de5 
  ql/src/test/results/clientpositive/perf/tez/query40.q.out 604f741279 
  ql/src/test/results/clientpositive/perf/tez/query45.q.out 3efed2e0e1 
  ql/src/test/results/clientpositive/perf/tez/query5.q.out ff197d2871 
  ql/src/test/results/clientpositive/perf/tez/query6.q.out f1e47581b4 
  ql/src/test/results/clientpositive/perf/tez/query67.q.out 86c4d7ce14 
  ql/src/test/results/clientpositive/perf/tez/query70.q.out d5ad6e5fcc 
  ql/src/test/results/clientpositive/perf/tez/query77.q.out d10e2266b3 
  ql/src/test/results/clientpositive/perf/tez/query8.q.out 8660fc9c57 
  ql/src/test/results/clientpositive/perf/tez/query80.q.out a64cad7389 
  ql/src/test/results/clientpositive/perf/tez/query82.q.out 037c2ffc2c 
  ql/src/test/results/clientpositive/perf/tez/query86.q.out be7e858e22 
  ql/src/test/results/clientpositive/perf/tez/query87.q.out 8430e8ad60 
  ql/src/test/results/clientpositive/perf/tez/query92.q.out fbb4eb3a55 
  ql/src/test/results/clientpositive/perf/tez/query94.q.out e18d45b15f 
  ql/src/test/results/clientpositive/perf/tez/query95.q.out 15920d9751 
  ql/src/test/results/clientpositive/perf/tez/query98.q.out da534cdcd3 
  ql/src/test/results/clientpositive/ppd2.q.out 43119be016 
  ql/src/test/results/clientpositive/ppd_gby.q.out c21e5a3435 
  ql/src/test/results/clientpositive/ppd_gby2.q.out c65e5c9a4a 
  ql/src/test/results/clientpositive/ppd_vc.q.out 1569cf62b7 
  ql/src/test/results/clientpositive/results_cache_2.q.out ab1b0de9c0 
  ql/src/test/results/clientpositive/semijoin4.q.out 46d1d3f37b 
  ql/src/test/results/clientpositive/setop_subq.q.out ac20c4c422 
  ql/src/test/results/clientpositive/spark/groupby_cube1.q.out 71ccea5507 
  ql/src/test/results/clientpositive/spark/groupby_rollup1.q.out cf3721df04 
  ql/src/test/results/clientpositive/spark/having.q.out 2876e67f06 
  ql/src/test/results/clientpositive/spark/limit_pushdown2.q.out 3bd49b4c77 
  ql/src/test/results/clientpositive/spark/orc_merge5.q.out c6f06add8a 
  ql/src/test/results/clientpositive/spark/orc_merge6.q.out 5c3b25e035 
  ql/src/test/results/clientpositive/spark/orc_merge_incompat1.q.out d97ac66af3 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_14.q.out f5b2896102 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_17.q.out a5ef4ae3f8 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_4.q.out 1d0de537d9 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_6.q.out b74f56b9ef 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_7.q.out f01e80854e 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_div0.q.out 5ba7587b89 
  ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out ebd8d8692c 
  ql/src/test/results/clientpositive/spark/subquery_in.q.out 5e48a5cb7d 
  ql/src/test/results/clientpositive/spark/subquery_multi.q.out 3764d92b3b 
  ql/src/test/results/clientpositive/spark/subquery_multiinsert.q.out 5b4aa49900 
  ql/src/test/results/clientpositive/spark/subquery_notin.q.out e2f26a977f 
  ql/src/test/results/clientpositive/spark/subquery_null_agg.q.out 4cfce1033c 
  ql/src/test/results/clientpositive/spark/subquery_select.q.out e36c74a91c 
  ql/src/test/results/clientpositive/spark/subquery_views.q.out 14be0186dd 
  ql/src/test/results/clientpositive/spark/union_remove_10.q.out 9bdcaf656a 
  ql/src/test/results/clientpositive/spark/union_remove_12.q.out cf89dab3f8 
  ql/src/test/results/clientpositive/spark/union_remove_14.q.out cf89dab3f8 
  ql/src/test/results/clientpositive/spark/union_remove_2.q.out 5fa05a9a0c 
  ql/src/test/results/clientpositive/spark/union_remove_5.q.out 3d311eae36 
  ql/src/test/results/clientpositive/spark/union_remove_6_subq.q.out 3034bd1cde 
  ql/src/test/results/clientpositive/spark/union_remove_8.q.out 9d651ed9ea 
  ql/src/test/results/clientpositive/spark/vector_between_in.q.out 75397d7d7d 
  ql/src/test/results/clientpositive/spark/vector_decimal_aggregate.q.out bbe9431571 
  ql/src/test/results/clientpositive/spark/vector_elt.q.out b717fda722 
  ql/src/test/results/clientpositive/spark/vectorization_14.q.out 6fa51e53f7 
  ql/src/test/results/clientpositive/spark/vectorization_17.q.out 851c1806b5 
  ql/src/test/results/clientpositive/spark/vectorization_4.q.out 436fdd9efc 
  ql/src/test/results/clientpositive/spark/vectorization_6.q.out b16d7b0645 
  ql/src/test/results/clientpositive/spark/vectorization_div0.q.out 530bdf6069 
  ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out 9683efa1d4 
  ql/src/test/results/clientpositive/spark/vectorized_case.q.out 8fff1ed7ba 
  ql/src/test/results/clientpositive/subquery_multiinsert.q.out 381550a006 
  ql/src/test/results/clientpositive/subquery_notin_having.q.out 74239031f6 
  ql/src/test/results/clientpositive/subquery_unqual_corr_expr.q.out 2507d52c0f 
  ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out bfb5d2b0a6 
  ql/src/test/results/clientpositive/tez/acid_vectorization_original_tez.q.out 50c53d0972 
  ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out a1ea37a682 
  ql/src/test/results/clientpositive/tez/explainuser_3.q.out c6cf6803b5 
  ql/src/test/results/clientpositive/tez/multi_count_distinct.q.out 5f5a8523b8 
  ql/src/test/results/clientpositive/tez/vectorization_div0.q.out 4afe85c30c 
  ql/src/test/results/clientpositive/timestamp.q.out 9d0ceef50f 
  ql/src/test/results/clientpositive/timestamp_ints_casts.q.out bc5ceb3f30 
  ql/src/test/results/clientpositive/timestamp_literal.q.out 4e069695f4 
  ql/src/test/results/clientpositive/timestamptz.q.out 7cff9a5c23 
  ql/src/test/results/clientpositive/type_widening.q.out 30e556477e 
  ql/src/test/results/clientpositive/udf4.q.out 5d263ebf68 
  ql/src/test/results/clientpositive/udf5.q.out 3fa801a078 
  ql/src/test/results/clientpositive/udf6.q.out 4193d340e4 
  ql/src/test/results/clientpositive/udf9.q.out a9bd954bfc 
  ql/src/test/results/clientpositive/udf_abs.q.out 5a8c4d7cfd 
  ql/src/test/results/clientpositive/udf_crc32.q.out 5d2888ac0a 
  ql/src/test/results/clientpositive/udf_factorial.q.out d6757aa194 
  ql/src/test/results/clientpositive/udf_folder_constants.q.out 70a8c0197c 
  ql/src/test/results/clientpositive/udf_from_utc_timestamp.q.out f00e3a1108 
  ql/src/test/results/clientpositive/udf_if.q.out eac4fe3e2b 
  ql/src/test/results/clientpositive/udf_reflect2.q.out a1074f8a81 
  ql/src/test/results/clientpositive/udf_to_utc_timestamp.q.out 7bd9aaf6e1 
  ql/src/test/results/clientpositive/union_pos_alias.q.out 65e736f3ed 
  ql/src/test/results/clientpositive/union_remove_10.q.out f1f2dd692d 
  ql/src/test/results/clientpositive/union_remove_12.q.out 702aef8aaf 
  ql/src/test/results/clientpositive/union_remove_14.q.out 702aef8aaf 
  ql/src/test/results/clientpositive/union_remove_2.q.out 0b84fb0c18 
  ql/src/test/results/clientpositive/union_remove_5.q.out efe59a12d2 
  ql/src/test/results/clientpositive/union_remove_6_subq.q.out 742e5b19db 
  ql/src/test/results/clientpositive/union_remove_8.q.out 2093fe6a0a 
  ql/src/test/results/clientpositive/vector_date_1.q.out 93f9a7116d 
  ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2f7ce319ae 
  ql/src/test/results/clientpositive/vector_elt.q.out 0b51d83d7b 
  ql/src/test/results/clientpositive/vector_groupby_mapjoin.q.out 0815bdb5ff 
  ql/src/test/results/clientpositive/vector_grouping_sets.q.out fc8290e72e 
  ql/src/test/results/clientpositive/vector_interval_1.q.out 1c7df24651 
  ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out 3ab7467df8 
  ql/src/test/results/clientpositive/vector_struct_in.q.out 773908b6a6 
  ql/src/test/results/clientpositive/vectorization_14.q.out 0a0c5fba8b 
  ql/src/test/results/clientpositive/vectorization_17.q.out 7104ae50ee 
  ql/src/test/results/clientpositive/vectorization_4.q.out ee618691b5 
  ql/src/test/results/clientpositive/vectorization_6.q.out f2204fc636 
  ql/src/test/results/clientpositive/vectorization_7.q.out 51d2b45a20 
  ql/src/test/results/clientpositive/vectorization_numeric_overflows.q.out 344db2b897 
  ql/src/test/results/clientpositive/vectorized_case.q.out b89fa511df 
  ql/src/test/results/clientpositive/vectorized_casts.q.out f6f210533f 
  ql/src/test/results/clientpositive/vectorized_date_funcs.q.out 298d92bdcd 
  ql/src/test/results/clientpositive/vectorized_timestamp.q.out 6c49e038a3 
  ql/src/test/results/clientpositive/vectorized_timestamp_ints_casts.q.out a203507512 
  ql/src/test/results/clientpositive/view_cbo.q.out 2fafa4fe22 


Diff: https://reviews.apache.org/r/65801/diff/1/


Testing
-------


Thanks,

Vineet Garg


Re: Review Request 65801: HIVE-18797 ExprConstNodeDesc's getExprString should put appropriate qualifier with literals

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65801/#review198296
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java
Lines 126 (patched)
<https://reviews.apache.org/r/65801/#comment278410>

    Do you want to add support for decimal, interval, float. 
    For Char/varchar, boolean  I don't think parser can parse them as constant literal.


- Ashutosh Chauhan


On Feb. 26, 2018, 1:03 a.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65801/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2018, 1:03 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-18797
>     https://issues.apache.org/jira/browse/HIVE-18797
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   hbase-handler/src/test/results/positive/hbase_timestamp.q.out e719b087d4 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java 73f449fc28 
>   ql/src/test/results/clientpositive/annotate_stats_deep_filters.q.out ab8c22b9be 
>   ql/src/test/results/clientpositive/annotate_stats_groupby.q.out 25efe1e1f4 
>   ql/src/test/results/clientpositive/annotate_stats_groupby2.q.out 78c4808f5f 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out 9aaa6f68a2 
>   ql/src/test/results/clientpositive/cast_on_constant.q.out 7f920f41af 
>   ql/src/test/results/clientpositive/constant_prop_3.q.out b754f8e7b4 
>   ql/src/test/results/clientpositive/constantfolding.q.out c4fce25e41 
>   ql/src/test/results/clientpositive/constprog_type.q.out 27ef1f482b 
>   ql/src/test/results/clientpositive/druid_basic2.q.out 08b64d6d82 
>   ql/src/test/results/clientpositive/druid_basic3.q.out ce6d0aafed 
>   ql/src/test/results/clientpositive/druid_intervals.q.out c94cbe9bd4 
>   ql/src/test/results/clientpositive/druid_timeseries.q.out 785cbd2114 
>   ql/src/test/results/clientpositive/druid_topn.q.out 90eec3dd49 
>   ql/src/test/results/clientpositive/except_all.q.out c3310f5154 
>   ql/src/test/results/clientpositive/extrapolate_part_stats_date.q.out 8fea7fdf44 
>   ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out 49e0d35d39 
>   ql/src/test/results/clientpositive/groupby_cube1.q.out 37b8c62edd 
>   ql/src/test/results/clientpositive/groupby_cube_multi_gby.q.out e6126ab2c6 
>   ql/src/test/results/clientpositive/groupby_grouping_id3.q.out ac43413400 
>   ql/src/test/results/clientpositive/groupby_grouping_sets1.q.out 62fc9fb550 
>   ql/src/test/results/clientpositive/groupby_grouping_sets2.q.out 43e17ec6bc 
>   ql/src/test/results/clientpositive/groupby_grouping_sets3.q.out 352d4beb9f 
>   ql/src/test/results/clientpositive/groupby_grouping_sets4.q.out e368e1ee12 
>   ql/src/test/results/clientpositive/groupby_grouping_sets5.q.out 1766fb9bbc 
>   ql/src/test/results/clientpositive/groupby_grouping_sets6.q.out 563b110a11 
>   ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out 1f2cd456c8 
>   ql/src/test/results/clientpositive/groupby_grouping_sets_limit.q.out efa1802855 
>   ql/src/test/results/clientpositive/groupby_grouping_window.q.out 0f58f5182a 
>   ql/src/test/results/clientpositive/groupby_rollup1.q.out a849a8d368 
>   ql/src/test/results/clientpositive/groupby_rollup_empty.q.out dd53fe2140 
>   ql/src/test/results/clientpositive/having.q.out 8a630751bb 
>   ql/src/test/results/clientpositive/having2.q.out 67f8af8328 
>   ql/src/test/results/clientpositive/implicit_cast1.q.out 6e1706a8a3 
>   ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out 72249383ee 
>   ql/src/test/results/clientpositive/infer_const_type.q.out 647c910241 
>   ql/src/test/results/clientpositive/interval_alt.q.out 53c1be8d05 
>   ql/src/test/results/clientpositive/interval_arithmetic.q.out eba97face9 
>   ql/src/test/results/clientpositive/limit_pushdown2.q.out f4cff2bcc0 
>   ql/src/test/results/clientpositive/literal_ints.q.out 9a56ebd5eb 
>   ql/src/test/results/clientpositive/llap/acid_vectorization_original.q.out 68801f0294 
>   ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out 98ede4e995 
>   ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_3.q.out aca6b21dba 
>   ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out 15a97a78c1 
>   ql/src/test/results/clientpositive/llap/dynpart_sort_optimization.q.out 78b9a443b8 
>   ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out 7b1dd40a16 
>   ql/src/test/results/clientpositive/llap/except_distinct.q.out 1e5937a22d 
>   ql/src/test/results/clientpositive/llap/explainuser_1.q.out 43ca0d9ad7 
>   ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.out 24be36ea36 
>   ql/src/test/results/clientpositive/llap/having.q.out 75de96ab59 
>   ql/src/test/results/clientpositive/llap/intersect_all.q.out 20a234e53b 
>   ql/src/test/results/clientpositive/llap/intersect_distinct.q.out a5384eb196 
>   ql/src/test/results/clientpositive/llap/intersect_merge.q.out 6f0e7f1f66 
>   ql/src/test/results/clientpositive/llap/lineage2.q.out 4f59a4d59b 
>   ql/src/test/results/clientpositive/llap/lineage3.q.out ca4405caf7 
>   ql/src/test/results/clientpositive/llap/mrr.q.out bfa26e4ff8 
>   ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out 66bf74f15a 
>   ql/src/test/results/clientpositive/llap/orc_merge5.q.out 6eba365ff2 
>   ql/src/test/results/clientpositive/llap/orc_merge6.q.out 1583007d7b 
>   ql/src/test/results/clientpositive/llap/orc_merge_incompat1.q.out 0e9b34f8ec 
>   ql/src/test/results/clientpositive/llap/orc_predicate_pushdown.q.out 9f20f77cb0 
>   ql/src/test/results/clientpositive/llap/parquet_predicate_pushdown.q.out 6885346539 
>   ql/src/test/results/clientpositive/llap/sqlmerge.q.out 2ff590ea0c 
>   ql/src/test/results/clientpositive/llap/subquery_in.q.out b5f9641502 
>   ql/src/test/results/clientpositive/llap/subquery_in_having.q.out cc0b6a597a 
>   ql/src/test/results/clientpositive/llap/subquery_multi.q.out 67a22c812f 
>   ql/src/test/results/clientpositive/llap/subquery_notin.q.out 50c18c8a68 
>   ql/src/test/results/clientpositive/llap/subquery_null_agg.q.out cff9568406 
>   ql/src/test/results/clientpositive/llap/subquery_scalar.q.out cec3daa085 
>   ql/src/test/results/clientpositive/llap/subquery_select.q.out 89eab37d07 
>   ql/src/test/results/clientpositive/llap/subquery_views.q.out 01a86d1300 
>   ql/src/test/results/clientpositive/llap/tez_dynpart_hashjoin_2.q.out 642bda2736 
>   ql/src/test/results/clientpositive/llap/tez_union_group_by.q.out 79321c1460 
>   ql/src/test/results/clientpositive/llap/tez_vector_dynpart_hashjoin_2.q.out 1ce7a3a37c 
>   ql/src/test/results/clientpositive/llap/vector_between_in.q.out f4f87ae0ee 
>   ql/src/test/results/clientpositive/llap/vector_date_1.q.out bacd667498 
>   ql/src/test/results/clientpositive/llap/vector_decimal_aggregate.q.out 5cb3e6678f 
>   ql/src/test/results/clientpositive/llap/vector_elt.q.out 24a1a65022 
>   ql/src/test/results/clientpositive/llap/vector_groupby_cube1.q.out 04ac09b0a6 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id1.q.out fd9dacbb12 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id2.q.out 74f6289fb0 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id3.q.out da4ba84c46 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets1.q.out 137e06a5b5 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out d8da29ac36 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3.q.out 79116112da 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3_dec.q.out 8d2247d42e 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets4.q.out 55c18fa2f1 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets5.q.out 4e579888e6 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets6.q.out 83c7ad8f00 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_grouping.q.out 8dd5cf074c 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_limit.q.out f7f3014a7f 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_window.q.out 9374bcc27a 
>   ql/src/test/results/clientpositive/llap/vector_groupby_mapjoin.q.out 82b6ba0a09 
>   ql/src/test/results/clientpositive/llap/vector_groupby_rollup1.q.out 717c218da9 
>   ql/src/test/results/clientpositive/llap/vector_grouping_sets.q.out 172e003af6 
>   ql/src/test/results/clientpositive/llap/vector_interval_1.q.out 7d891db4ef 
>   ql/src/test/results/clientpositive/llap/vector_interval_2.q.out 7548686c50 
>   ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out f2a4d3a855 
>   ql/src/test/results/clientpositive/llap/vector_number_compare_projection.q.out cd2e1e4c42 
>   ql/src/test/results/clientpositive/llap/vector_ptf_part_simple.q.out 16b59e612c 
>   ql/src/test/results/clientpositive/llap/vector_reuse_scratchcols.q.out b9c1ba31e8 
>   ql/src/test/results/clientpositive/llap/vector_struct_in.q.out 4af1015fe7 
>   ql/src/test/results/clientpositive/llap/vector_udf_adaptor_1.q.out a752dfadd4 
>   ql/src/test/results/clientpositive/llap/vector_windowing_navfn.q.out 8dc3fa7764 
>   ql/src/test/results/clientpositive/llap/vector_windowing_rank.q.out aa47b1bf75 
>   ql/src/test/results/clientpositive/llap/vector_windowing_streaming.q.out 2c54027bed 
>   ql/src/test/results/clientpositive/llap/vectorization_14.q.out c7a32e3a7e 
>   ql/src/test/results/clientpositive/llap/vectorization_17.q.out bdcb1ebfee 
>   ql/src/test/results/clientpositive/llap/vectorization_4.q.out a2142b716d 
>   ql/src/test/results/clientpositive/llap/vectorization_6.q.out 84b9260c18 
>   ql/src/test/results/clientpositive/llap/vectorization_7.q.out 3c7522912d 
>   ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out bd5e284523 
>   ql/src/test/results/clientpositive/llap/vectorized_case.q.out ed17e5c5f1 
>   ql/src/test/results/clientpositive/llap/vectorized_casts.q.out 84b4d9454d 
>   ql/src/test/results/clientpositive/llap/vectorized_date_funcs.q.out db292508ac 
>   ql/src/test/results/clientpositive/llap/vectorized_timestamp.q.out 9652d36b20 
>   ql/src/test/results/clientpositive/llap/vectorized_timestamp_ints_casts.q.out c346ff2cf8 
>   ql/src/test/results/clientpositive/num_op_type_conv.q.out 8e714f4ad7 
>   ql/src/test/results/clientpositive/orc_merge5.q.out 970c4ddad9 
>   ql/src/test/results/clientpositive/orc_merge6.q.out a08eb09cee 
>   ql/src/test/results/clientpositive/orc_merge_incompat1.q.out e8d504a9cb 
>   ql/src/test/results/clientpositive/parquet_vectorization_14.q.out f127434557 
>   ql/src/test/results/clientpositive/parquet_vectorization_17.q.out 8f26d41a48 
>   ql/src/test/results/clientpositive/parquet_vectorization_4.q.out 4c39858751 
>   ql/src/test/results/clientpositive/parquet_vectorization_6.q.out 3d7d5e3c85 
>   ql/src/test/results/clientpositive/parquet_vectorization_7.q.out 77caa03107 
>   ql/src/test/results/clientpositive/parquet_vectorization_div0.q.out 4a5cca6d22 
>   ql/src/test/results/clientpositive/perf/spark/query12.q.out d1796248f2 
>   ql/src/test/results/clientpositive/perf/spark/query16.q.out 1b763e278e 
>   ql/src/test/results/clientpositive/perf/spark/query18.q.out 33b2f62386 
>   ql/src/test/results/clientpositive/perf/spark/query20.q.out ab1b24dbf9 
>   ql/src/test/results/clientpositive/perf/spark/query21.q.out e73a627332 
>   ql/src/test/results/clientpositive/perf/spark/query22.q.out 38e4119afc 
>   ql/src/test/results/clientpositive/perf/spark/query23.q.out 8b5a83a58a 
>   ql/src/test/results/clientpositive/perf/spark/query27.q.out a87ec45c11 
>   ql/src/test/results/clientpositive/perf/spark/query32.q.out e7d356d257 
>   ql/src/test/results/clientpositive/perf/spark/query36.q.out 1a1a991b96 
>   ql/src/test/results/clientpositive/perf/spark/query37.q.out d8bff8173d 
>   ql/src/test/results/clientpositive/perf/spark/query38.q.out b9af9642b5 
>   ql/src/test/results/clientpositive/perf/spark/query40.q.out ab196dcb5d 
>   ql/src/test/results/clientpositive/perf/spark/query45.q.out 07af4e2e4b 
>   ql/src/test/results/clientpositive/perf/spark/query5.q.out 1ba37e050f 
>   ql/src/test/results/clientpositive/perf/spark/query6.q.out 126cf9e11c 
>   ql/src/test/results/clientpositive/perf/spark/query67.q.out b0fc41c7a2 
>   ql/src/test/results/clientpositive/perf/spark/query70.q.out 7ebb776719 
>   ql/src/test/results/clientpositive/perf/spark/query77.q.out 9a77a7b8b4 
>   ql/src/test/results/clientpositive/perf/spark/query8.q.out 13cd0f4ab6 
>   ql/src/test/results/clientpositive/perf/spark/query80.q.out ee769f9b95 
>   ql/src/test/results/clientpositive/perf/spark/query82.q.out b45f8d0bfb 
>   ql/src/test/results/clientpositive/perf/spark/query86.q.out 80a24d3dd7 
>   ql/src/test/results/clientpositive/perf/spark/query87.q.out 5fe3e48dfc 
>   ql/src/test/results/clientpositive/perf/spark/query9.q.out 4ec20070f7 
>   ql/src/test/results/clientpositive/perf/spark/query92.q.out 677a85cea1 
>   ql/src/test/results/clientpositive/perf/spark/query94.q.out 39c4476a5c 
>   ql/src/test/results/clientpositive/perf/spark/query95.q.out 0d136b6da7 
>   ql/src/test/results/clientpositive/perf/spark/query98.q.out 24d7de8b71 
>   ql/src/test/results/clientpositive/perf/tez/query12.q.out 0506eca00d 
>   ql/src/test/results/clientpositive/perf/tez/query14.q.out ef44cdbb6d 
>   ql/src/test/results/clientpositive/perf/tez/query16.q.out 1c0539199e 
>   ql/src/test/results/clientpositive/perf/tez/query18.q.out 1f0ec90b41 
>   ql/src/test/results/clientpositive/perf/tez/query20.q.out c07141b368 
>   ql/src/test/results/clientpositive/perf/tez/query21.q.out aed0990277 
>   ql/src/test/results/clientpositive/perf/tez/query22.q.out d13169c25c 
>   ql/src/test/results/clientpositive/perf/tez/query23.q.out c7a5041861 
>   ql/src/test/results/clientpositive/perf/tez/query27.q.out c6a190553e 
>   ql/src/test/results/clientpositive/perf/tez/query32.q.out 3ad9595910 
>   ql/src/test/results/clientpositive/perf/tez/query36.q.out a30ac2e53c 
>   ql/src/test/results/clientpositive/perf/tez/query37.q.out d5af964b0a 
>   ql/src/test/results/clientpositive/perf/tez/query38.q.out 199bed7de5 
>   ql/src/test/results/clientpositive/perf/tez/query40.q.out 604f741279 
>   ql/src/test/results/clientpositive/perf/tez/query45.q.out 3efed2e0e1 
>   ql/src/test/results/clientpositive/perf/tez/query5.q.out ff197d2871 
>   ql/src/test/results/clientpositive/perf/tez/query6.q.out f1e47581b4 
>   ql/src/test/results/clientpositive/perf/tez/query67.q.out 86c4d7ce14 
>   ql/src/test/results/clientpositive/perf/tez/query70.q.out d5ad6e5fcc 
>   ql/src/test/results/clientpositive/perf/tez/query77.q.out d10e2266b3 
>   ql/src/test/results/clientpositive/perf/tez/query8.q.out 8660fc9c57 
>   ql/src/test/results/clientpositive/perf/tez/query80.q.out a64cad7389 
>   ql/src/test/results/clientpositive/perf/tez/query82.q.out 037c2ffc2c 
>   ql/src/test/results/clientpositive/perf/tez/query86.q.out be7e858e22 
>   ql/src/test/results/clientpositive/perf/tez/query87.q.out 8430e8ad60 
>   ql/src/test/results/clientpositive/perf/tez/query92.q.out fbb4eb3a55 
>   ql/src/test/results/clientpositive/perf/tez/query94.q.out e18d45b15f 
>   ql/src/test/results/clientpositive/perf/tez/query95.q.out 15920d9751 
>   ql/src/test/results/clientpositive/perf/tez/query98.q.out da534cdcd3 
>   ql/src/test/results/clientpositive/ppd2.q.out 43119be016 
>   ql/src/test/results/clientpositive/ppd_gby.q.out c21e5a3435 
>   ql/src/test/results/clientpositive/ppd_gby2.q.out c65e5c9a4a 
>   ql/src/test/results/clientpositive/ppd_vc.q.out 1569cf62b7 
>   ql/src/test/results/clientpositive/results_cache_2.q.out ab1b0de9c0 
>   ql/src/test/results/clientpositive/semijoin4.q.out 46d1d3f37b 
>   ql/src/test/results/clientpositive/setop_subq.q.out ac20c4c422 
>   ql/src/test/results/clientpositive/spark/groupby_cube1.q.out 71ccea5507 
>   ql/src/test/results/clientpositive/spark/groupby_rollup1.q.out cf3721df04 
>   ql/src/test/results/clientpositive/spark/having.q.out 2876e67f06 
>   ql/src/test/results/clientpositive/spark/limit_pushdown2.q.out 3bd49b4c77 
>   ql/src/test/results/clientpositive/spark/orc_merge5.q.out c6f06add8a 
>   ql/src/test/results/clientpositive/spark/orc_merge6.q.out 5c3b25e035 
>   ql/src/test/results/clientpositive/spark/orc_merge_incompat1.q.out d97ac66af3 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_14.q.out f5b2896102 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_17.q.out a5ef4ae3f8 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_4.q.out 1d0de537d9 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_6.q.out b74f56b9ef 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_7.q.out f01e80854e 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_div0.q.out 5ba7587b89 
>   ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out ebd8d8692c 
>   ql/src/test/results/clientpositive/spark/subquery_in.q.out 5e48a5cb7d 
>   ql/src/test/results/clientpositive/spark/subquery_multi.q.out 3764d92b3b 
>   ql/src/test/results/clientpositive/spark/subquery_multiinsert.q.out 5b4aa49900 
>   ql/src/test/results/clientpositive/spark/subquery_notin.q.out e2f26a977f 
>   ql/src/test/results/clientpositive/spark/subquery_null_agg.q.out 4cfce1033c 
>   ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 77359a0197 
>   ql/src/test/results/clientpositive/spark/subquery_select.q.out e36c74a91c 
>   ql/src/test/results/clientpositive/spark/subquery_views.q.out 14be0186dd 
>   ql/src/test/results/clientpositive/spark/union_remove_10.q.out 9bdcaf656a 
>   ql/src/test/results/clientpositive/spark/union_remove_12.q.out cf89dab3f8 
>   ql/src/test/results/clientpositive/spark/union_remove_14.q.out cf89dab3f8 
>   ql/src/test/results/clientpositive/spark/union_remove_2.q.out 5fa05a9a0c 
>   ql/src/test/results/clientpositive/spark/union_remove_5.q.out 3d311eae36 
>   ql/src/test/results/clientpositive/spark/union_remove_6_subq.q.out 3034bd1cde 
>   ql/src/test/results/clientpositive/spark/union_remove_8.q.out 9d651ed9ea 
>   ql/src/test/results/clientpositive/spark/vector_between_in.q.out 75397d7d7d 
>   ql/src/test/results/clientpositive/spark/vector_decimal_aggregate.q.out bbe9431571 
>   ql/src/test/results/clientpositive/spark/vector_elt.q.out b717fda722 
>   ql/src/test/results/clientpositive/spark/vectorization_14.q.out 6fa51e53f7 
>   ql/src/test/results/clientpositive/spark/vectorization_17.q.out 851c1806b5 
>   ql/src/test/results/clientpositive/spark/vectorization_4.q.out 436fdd9efc 
>   ql/src/test/results/clientpositive/spark/vectorization_6.q.out b16d7b0645 
>   ql/src/test/results/clientpositive/spark/vectorization_div0.q.out 530bdf6069 
>   ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out 9683efa1d4 
>   ql/src/test/results/clientpositive/spark/vectorized_case.q.out 8fff1ed7ba 
>   ql/src/test/results/clientpositive/subquery_multiinsert.q.out 381550a006 
>   ql/src/test/results/clientpositive/subquery_notin_having.q.out 74239031f6 
>   ql/src/test/results/clientpositive/subquery_unqual_corr_expr.q.out 2507d52c0f 
>   ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out bfb5d2b0a6 
>   ql/src/test/results/clientpositive/tez/acid_vectorization_original_tez.q.out 50c53d0972 
>   ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out a1ea37a682 
>   ql/src/test/results/clientpositive/tez/explainuser_3.q.out c6cf6803b5 
>   ql/src/test/results/clientpositive/tez/multi_count_distinct.q.out 5f5a8523b8 
>   ql/src/test/results/clientpositive/tez/vectorization_div0.q.out 4afe85c30c 
>   ql/src/test/results/clientpositive/timestamp.q.out 9d0ceef50f 
>   ql/src/test/results/clientpositive/timestamp_ints_casts.q.out bc5ceb3f30 
>   ql/src/test/results/clientpositive/timestamp_literal.q.out 4e069695f4 
>   ql/src/test/results/clientpositive/timestamptz.q.out 7cff9a5c23 
>   ql/src/test/results/clientpositive/type_widening.q.out 30e556477e 
>   ql/src/test/results/clientpositive/udf4.q.out 5d263ebf68 
>   ql/src/test/results/clientpositive/udf5.q.out 3fa801a078 
>   ql/src/test/results/clientpositive/udf6.q.out 4193d340e4 
>   ql/src/test/results/clientpositive/udf9.q.out a9bd954bfc 
>   ql/src/test/results/clientpositive/udf_abs.q.out 5a8c4d7cfd 
>   ql/src/test/results/clientpositive/udf_crc32.q.out 5d2888ac0a 
>   ql/src/test/results/clientpositive/udf_factorial.q.out d6757aa194 
>   ql/src/test/results/clientpositive/udf_folder_constants.q.out 70a8c0197c 
>   ql/src/test/results/clientpositive/udf_from_utc_timestamp.q.out f00e3a1108 
>   ql/src/test/results/clientpositive/udf_if.q.out eac4fe3e2b 
>   ql/src/test/results/clientpositive/udf_reflect2.q.out a1074f8a81 
>   ql/src/test/results/clientpositive/udf_to_utc_timestamp.q.out 7bd9aaf6e1 
>   ql/src/test/results/clientpositive/union_pos_alias.q.out 65e736f3ed 
>   ql/src/test/results/clientpositive/union_remove_10.q.out f1f2dd692d 
>   ql/src/test/results/clientpositive/union_remove_12.q.out 702aef8aaf 
>   ql/src/test/results/clientpositive/union_remove_14.q.out 702aef8aaf 
>   ql/src/test/results/clientpositive/union_remove_2.q.out 0b84fb0c18 
>   ql/src/test/results/clientpositive/union_remove_5.q.out efe59a12d2 
>   ql/src/test/results/clientpositive/union_remove_6_subq.q.out 742e5b19db 
>   ql/src/test/results/clientpositive/union_remove_8.q.out 2093fe6a0a 
>   ql/src/test/results/clientpositive/vector_date_1.q.out 93f9a7116d 
>   ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2f7ce319ae 
>   ql/src/test/results/clientpositive/vector_elt.q.out 0b51d83d7b 
>   ql/src/test/results/clientpositive/vector_groupby_mapjoin.q.out 0815bdb5ff 
>   ql/src/test/results/clientpositive/vector_grouping_sets.q.out fc8290e72e 
>   ql/src/test/results/clientpositive/vector_interval_1.q.out 1c7df24651 
>   ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out 3ab7467df8 
>   ql/src/test/results/clientpositive/vector_struct_in.q.out 773908b6a6 
>   ql/src/test/results/clientpositive/vectorization_14.q.out 0a0c5fba8b 
>   ql/src/test/results/clientpositive/vectorization_17.q.out 7104ae50ee 
>   ql/src/test/results/clientpositive/vectorization_4.q.out ee618691b5 
>   ql/src/test/results/clientpositive/vectorization_6.q.out f2204fc636 
>   ql/src/test/results/clientpositive/vectorization_7.q.out 51d2b45a20 
>   ql/src/test/results/clientpositive/vectorization_numeric_overflows.q.out 344db2b897 
>   ql/src/test/results/clientpositive/vectorized_case.q.out b89fa511df 
>   ql/src/test/results/clientpositive/vectorized_casts.q.out f6f210533f 
>   ql/src/test/results/clientpositive/vectorized_date_funcs.q.out 298d92bdcd 
>   ql/src/test/results/clientpositive/vectorized_timestamp.q.out 6c49e038a3 
>   ql/src/test/results/clientpositive/vectorized_timestamp_ints_casts.q.out a203507512 
>   ql/src/test/results/clientpositive/view_cbo.q.out 2fafa4fe22 
> 
> 
> Diff: https://reviews.apache.org/r/65801/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>


Re: Review Request 65801: HIVE-18797 ExprConstNodeDesc's getExprString should put appropriate qualifier with literals

Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65801/
-----------------------------------------------------------

(Updated Feb. 27, 2018, 12:38 a.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Support for DECIMAL, INTERVAL and DOUBLE.


Bugs: HIVE-18797
    https://issues.apache.org/jira/browse/HIVE-18797


Repository: hive-git


Description
-------

See JIRA


Diffs (updated)
-----

  hbase-handler/src/test/results/positive/hbase_timestamp.q.out e719b087d4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java 73f449fc28 
  ql/src/test/results/clientpositive/annotate_stats_deep_filters.q.out ab8c22b9be 
  ql/src/test/results/clientpositive/annotate_stats_groupby.q.out 25efe1e1f4 
  ql/src/test/results/clientpositive/annotate_stats_groupby2.q.out 78c4808f5f 
  ql/src/test/results/clientpositive/annotate_stats_select.q.out 9aaa6f68a2 
  ql/src/test/results/clientpositive/cast_on_constant.q.out 7f920f41af 
  ql/src/test/results/clientpositive/constant_prop_3.q.out b754f8e7b4 
  ql/src/test/results/clientpositive/constantfolding.q.out c4fce25e41 
  ql/src/test/results/clientpositive/constprog_type.q.out 27ef1f482b 
  ql/src/test/results/clientpositive/druid_basic2.q.out 08b64d6d82 
  ql/src/test/results/clientpositive/druid_basic3.q.out ce6d0aafed 
  ql/src/test/results/clientpositive/druid_intervals.q.out c94cbe9bd4 
  ql/src/test/results/clientpositive/druid_timeseries.q.out 785cbd2114 
  ql/src/test/results/clientpositive/druid_topn.q.out 90eec3dd49 
  ql/src/test/results/clientpositive/except_all.q.out c3310f5154 
  ql/src/test/results/clientpositive/extrapolate_part_stats_date.q.out 8fea7fdf44 
  ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out 49e0d35d39 
  ql/src/test/results/clientpositive/groupby_cube1.q.out 37b8c62edd 
  ql/src/test/results/clientpositive/groupby_cube_multi_gby.q.out e6126ab2c6 
  ql/src/test/results/clientpositive/groupby_grouping_id3.q.out ac43413400 
  ql/src/test/results/clientpositive/groupby_grouping_sets1.q.out 62fc9fb550 
  ql/src/test/results/clientpositive/groupby_grouping_sets2.q.out 43e17ec6bc 
  ql/src/test/results/clientpositive/groupby_grouping_sets3.q.out 352d4beb9f 
  ql/src/test/results/clientpositive/groupby_grouping_sets4.q.out e368e1ee12 
  ql/src/test/results/clientpositive/groupby_grouping_sets5.q.out 1766fb9bbc 
  ql/src/test/results/clientpositive/groupby_grouping_sets6.q.out 563b110a11 
  ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out 1f2cd456c8 
  ql/src/test/results/clientpositive/groupby_grouping_sets_limit.q.out efa1802855 
  ql/src/test/results/clientpositive/groupby_grouping_window.q.out 0f58f5182a 
  ql/src/test/results/clientpositive/groupby_rollup1.q.out a849a8d368 
  ql/src/test/results/clientpositive/groupby_rollup_empty.q.out dd53fe2140 
  ql/src/test/results/clientpositive/having.q.out 8a630751bb 
  ql/src/test/results/clientpositive/having2.q.out 67f8af8328 
  ql/src/test/results/clientpositive/implicit_cast1.q.out 6e1706a8a3 
  ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out 72249383ee 
  ql/src/test/results/clientpositive/infer_const_type.q.out 647c910241 
  ql/src/test/results/clientpositive/interval_alt.q.out 53c1be8d05 
  ql/src/test/results/clientpositive/interval_arithmetic.q.out eba97face9 
  ql/src/test/results/clientpositive/limit_pushdown2.q.out f4cff2bcc0 
  ql/src/test/results/clientpositive/literal_ints.q.out 9a56ebd5eb 
  ql/src/test/results/clientpositive/llap/acid_vectorization_original.q.out 68801f0294 
  ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out 98ede4e995 
  ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_3.q.out aca6b21dba 
  ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out 15a97a78c1 
  ql/src/test/results/clientpositive/llap/dynpart_sort_optimization.q.out 78b9a443b8 
  ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out 7b1dd40a16 
  ql/src/test/results/clientpositive/llap/except_distinct.q.out 1e5937a22d 
  ql/src/test/results/clientpositive/llap/explainuser_1.q.out 43ca0d9ad7 
  ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.out 24be36ea36 
  ql/src/test/results/clientpositive/llap/having.q.out 75de96ab59 
  ql/src/test/results/clientpositive/llap/intersect_all.q.out 20a234e53b 
  ql/src/test/results/clientpositive/llap/intersect_distinct.q.out a5384eb196 
  ql/src/test/results/clientpositive/llap/intersect_merge.q.out 6f0e7f1f66 
  ql/src/test/results/clientpositive/llap/lineage2.q.out 4f59a4d59b 
  ql/src/test/results/clientpositive/llap/lineage3.q.out ca4405caf7 
  ql/src/test/results/clientpositive/llap/mrr.q.out bfa26e4ff8 
  ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out 66bf74f15a 
  ql/src/test/results/clientpositive/llap/orc_merge5.q.out 6eba365ff2 
  ql/src/test/results/clientpositive/llap/orc_merge6.q.out 1583007d7b 
  ql/src/test/results/clientpositive/llap/orc_merge_incompat1.q.out 0e9b34f8ec 
  ql/src/test/results/clientpositive/llap/orc_predicate_pushdown.q.out 9f20f77cb0 
  ql/src/test/results/clientpositive/llap/parquet_predicate_pushdown.q.out 6885346539 
  ql/src/test/results/clientpositive/llap/sqlmerge.q.out 2ff590ea0c 
  ql/src/test/results/clientpositive/llap/subquery_in.q.out b5f9641502 
  ql/src/test/results/clientpositive/llap/subquery_in_having.q.out cc0b6a597a 
  ql/src/test/results/clientpositive/llap/subquery_multi.q.out 67a22c812f 
  ql/src/test/results/clientpositive/llap/subquery_notin.q.out 50c18c8a68 
  ql/src/test/results/clientpositive/llap/subquery_null_agg.q.out cff9568406 
  ql/src/test/results/clientpositive/llap/subquery_scalar.q.out cec3daa085 
  ql/src/test/results/clientpositive/llap/subquery_select.q.out 89eab37d07 
  ql/src/test/results/clientpositive/llap/subquery_views.q.out 01a86d1300 
  ql/src/test/results/clientpositive/llap/tez_dynpart_hashjoin_2.q.out 642bda2736 
  ql/src/test/results/clientpositive/llap/tez_union_group_by.q.out 79321c1460 
  ql/src/test/results/clientpositive/llap/tez_vector_dynpart_hashjoin_2.q.out 1ce7a3a37c 
  ql/src/test/results/clientpositive/llap/vector_between_in.q.out f4f87ae0ee 
  ql/src/test/results/clientpositive/llap/vector_date_1.q.out bacd667498 
  ql/src/test/results/clientpositive/llap/vector_decimal_aggregate.q.out 5cb3e6678f 
  ql/src/test/results/clientpositive/llap/vector_elt.q.out 24a1a65022 
  ql/src/test/results/clientpositive/llap/vector_groupby_cube1.q.out 04ac09b0a6 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id1.q.out fd9dacbb12 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id2.q.out 74f6289fb0 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id3.q.out da4ba84c46 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets1.q.out 137e06a5b5 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out d8da29ac36 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3.q.out 79116112da 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3_dec.q.out 8d2247d42e 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets4.q.out 55c18fa2f1 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets5.q.out 4e579888e6 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets6.q.out 83c7ad8f00 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_grouping.q.out 8dd5cf074c 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_limit.q.out f7f3014a7f 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_window.q.out 9374bcc27a 
  ql/src/test/results/clientpositive/llap/vector_groupby_mapjoin.q.out 82b6ba0a09 
  ql/src/test/results/clientpositive/llap/vector_groupby_rollup1.q.out 717c218da9 
  ql/src/test/results/clientpositive/llap/vector_grouping_sets.q.out 172e003af6 
  ql/src/test/results/clientpositive/llap/vector_interval_1.q.out 7d891db4ef 
  ql/src/test/results/clientpositive/llap/vector_interval_2.q.out 7548686c50 
  ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out f2a4d3a855 
  ql/src/test/results/clientpositive/llap/vector_number_compare_projection.q.out cd2e1e4c42 
  ql/src/test/results/clientpositive/llap/vector_ptf_part_simple.q.out 16b59e612c 
  ql/src/test/results/clientpositive/llap/vector_reuse_scratchcols.q.out b9c1ba31e8 
  ql/src/test/results/clientpositive/llap/vector_struct_in.q.out 4af1015fe7 
  ql/src/test/results/clientpositive/llap/vector_udf_adaptor_1.q.out a752dfadd4 
  ql/src/test/results/clientpositive/llap/vector_windowing_navfn.q.out 8dc3fa7764 
  ql/src/test/results/clientpositive/llap/vector_windowing_rank.q.out aa47b1bf75 
  ql/src/test/results/clientpositive/llap/vector_windowing_streaming.q.out 2c54027bed 
  ql/src/test/results/clientpositive/llap/vectorization_14.q.out c7a32e3a7e 
  ql/src/test/results/clientpositive/llap/vectorization_17.q.out bdcb1ebfee 
  ql/src/test/results/clientpositive/llap/vectorization_4.q.out a2142b716d 
  ql/src/test/results/clientpositive/llap/vectorization_6.q.out 84b9260c18 
  ql/src/test/results/clientpositive/llap/vectorization_7.q.out 3c7522912d 
  ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out bd5e284523 
  ql/src/test/results/clientpositive/llap/vectorized_case.q.out ed17e5c5f1 
  ql/src/test/results/clientpositive/llap/vectorized_casts.q.out 84b4d9454d 
  ql/src/test/results/clientpositive/llap/vectorized_date_funcs.q.out db292508ac 
  ql/src/test/results/clientpositive/llap/vectorized_timestamp.q.out 9652d36b20 
  ql/src/test/results/clientpositive/llap/vectorized_timestamp_ints_casts.q.out c346ff2cf8 
  ql/src/test/results/clientpositive/num_op_type_conv.q.out 8e714f4ad7 
  ql/src/test/results/clientpositive/orc_merge5.q.out 970c4ddad9 
  ql/src/test/results/clientpositive/orc_merge6.q.out a08eb09cee 
  ql/src/test/results/clientpositive/orc_merge_incompat1.q.out e8d504a9cb 
  ql/src/test/results/clientpositive/parquet_vectorization_14.q.out f127434557 
  ql/src/test/results/clientpositive/parquet_vectorization_17.q.out 8f26d41a48 
  ql/src/test/results/clientpositive/parquet_vectorization_4.q.out 4c39858751 
  ql/src/test/results/clientpositive/parquet_vectorization_6.q.out 3d7d5e3c85 
  ql/src/test/results/clientpositive/parquet_vectorization_7.q.out 77caa03107 
  ql/src/test/results/clientpositive/parquet_vectorization_div0.q.out 4a5cca6d22 
  ql/src/test/results/clientpositive/perf/spark/query12.q.out d1796248f2 
  ql/src/test/results/clientpositive/perf/spark/query16.q.out 1b763e278e 
  ql/src/test/results/clientpositive/perf/spark/query18.q.out 33b2f62386 
  ql/src/test/results/clientpositive/perf/spark/query20.q.out ab1b24dbf9 
  ql/src/test/results/clientpositive/perf/spark/query21.q.out e73a627332 
  ql/src/test/results/clientpositive/perf/spark/query22.q.out 38e4119afc 
  ql/src/test/results/clientpositive/perf/spark/query23.q.out 8b5a83a58a 
  ql/src/test/results/clientpositive/perf/spark/query27.q.out a87ec45c11 
  ql/src/test/results/clientpositive/perf/spark/query32.q.out e7d356d257 
  ql/src/test/results/clientpositive/perf/spark/query36.q.out 1a1a991b96 
  ql/src/test/results/clientpositive/perf/spark/query37.q.out d8bff8173d 
  ql/src/test/results/clientpositive/perf/spark/query38.q.out b9af9642b5 
  ql/src/test/results/clientpositive/perf/spark/query40.q.out ab196dcb5d 
  ql/src/test/results/clientpositive/perf/spark/query45.q.out 07af4e2e4b 
  ql/src/test/results/clientpositive/perf/spark/query5.q.out 1ba37e050f 
  ql/src/test/results/clientpositive/perf/spark/query6.q.out 126cf9e11c 
  ql/src/test/results/clientpositive/perf/spark/query67.q.out b0fc41c7a2 
  ql/src/test/results/clientpositive/perf/spark/query70.q.out 7ebb776719 
  ql/src/test/results/clientpositive/perf/spark/query77.q.out 9a77a7b8b4 
  ql/src/test/results/clientpositive/perf/spark/query8.q.out 13cd0f4ab6 
  ql/src/test/results/clientpositive/perf/spark/query80.q.out ee769f9b95 
  ql/src/test/results/clientpositive/perf/spark/query82.q.out b45f8d0bfb 
  ql/src/test/results/clientpositive/perf/spark/query86.q.out 80a24d3dd7 
  ql/src/test/results/clientpositive/perf/spark/query87.q.out 5fe3e48dfc 
  ql/src/test/results/clientpositive/perf/spark/query9.q.out 4ec20070f7 
  ql/src/test/results/clientpositive/perf/spark/query92.q.out 677a85cea1 
  ql/src/test/results/clientpositive/perf/spark/query94.q.out 39c4476a5c 
  ql/src/test/results/clientpositive/perf/spark/query95.q.out 0d136b6da7 
  ql/src/test/results/clientpositive/perf/spark/query98.q.out 24d7de8b71 
  ql/src/test/results/clientpositive/perf/tez/query12.q.out 0506eca00d 
  ql/src/test/results/clientpositive/perf/tez/query14.q.out ef44cdbb6d 
  ql/src/test/results/clientpositive/perf/tez/query16.q.out 1c0539199e 
  ql/src/test/results/clientpositive/perf/tez/query18.q.out 1f0ec90b41 
  ql/src/test/results/clientpositive/perf/tez/query20.q.out c07141b368 
  ql/src/test/results/clientpositive/perf/tez/query21.q.out aed0990277 
  ql/src/test/results/clientpositive/perf/tez/query22.q.out d13169c25c 
  ql/src/test/results/clientpositive/perf/tez/query23.q.out c7a5041861 
  ql/src/test/results/clientpositive/perf/tez/query27.q.out c6a190553e 
  ql/src/test/results/clientpositive/perf/tez/query32.q.out 3ad9595910 
  ql/src/test/results/clientpositive/perf/tez/query36.q.out a30ac2e53c 
  ql/src/test/results/clientpositive/perf/tez/query37.q.out d5af964b0a 
  ql/src/test/results/clientpositive/perf/tez/query38.q.out 199bed7de5 
  ql/src/test/results/clientpositive/perf/tez/query40.q.out 604f741279 
  ql/src/test/results/clientpositive/perf/tez/query45.q.out 3efed2e0e1 
  ql/src/test/results/clientpositive/perf/tez/query5.q.out ff197d2871 
  ql/src/test/results/clientpositive/perf/tez/query6.q.out f1e47581b4 
  ql/src/test/results/clientpositive/perf/tez/query67.q.out 86c4d7ce14 
  ql/src/test/results/clientpositive/perf/tez/query70.q.out d5ad6e5fcc 
  ql/src/test/results/clientpositive/perf/tez/query77.q.out d10e2266b3 
  ql/src/test/results/clientpositive/perf/tez/query8.q.out 8660fc9c57 
  ql/src/test/results/clientpositive/perf/tez/query80.q.out a64cad7389 
  ql/src/test/results/clientpositive/perf/tez/query82.q.out 037c2ffc2c 
  ql/src/test/results/clientpositive/perf/tez/query86.q.out be7e858e22 
  ql/src/test/results/clientpositive/perf/tez/query87.q.out 8430e8ad60 
  ql/src/test/results/clientpositive/perf/tez/query92.q.out fbb4eb3a55 
  ql/src/test/results/clientpositive/perf/tez/query94.q.out e18d45b15f 
  ql/src/test/results/clientpositive/perf/tez/query95.q.out 15920d9751 
  ql/src/test/results/clientpositive/perf/tez/query98.q.out da534cdcd3 
  ql/src/test/results/clientpositive/ppd2.q.out 43119be016 
  ql/src/test/results/clientpositive/ppd_gby.q.out c21e5a3435 
  ql/src/test/results/clientpositive/ppd_gby2.q.out c65e5c9a4a 
  ql/src/test/results/clientpositive/ppd_vc.q.out 1569cf62b7 
  ql/src/test/results/clientpositive/results_cache_2.q.out ab1b0de9c0 
  ql/src/test/results/clientpositive/semijoin4.q.out 46d1d3f37b 
  ql/src/test/results/clientpositive/setop_subq.q.out ac20c4c422 
  ql/src/test/results/clientpositive/spark/groupby_cube1.q.out 71ccea5507 
  ql/src/test/results/clientpositive/spark/groupby_rollup1.q.out cf3721df04 
  ql/src/test/results/clientpositive/spark/having.q.out 2876e67f06 
  ql/src/test/results/clientpositive/spark/limit_pushdown2.q.out 3bd49b4c77 
  ql/src/test/results/clientpositive/spark/orc_merge5.q.out c6f06add8a 
  ql/src/test/results/clientpositive/spark/orc_merge6.q.out 5c3b25e035 
  ql/src/test/results/clientpositive/spark/orc_merge_incompat1.q.out d97ac66af3 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_14.q.out f5b2896102 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_17.q.out a5ef4ae3f8 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_4.q.out 1d0de537d9 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_6.q.out b74f56b9ef 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_7.q.out f01e80854e 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_div0.q.out 5ba7587b89 
  ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out ebd8d8692c 
  ql/src/test/results/clientpositive/spark/subquery_in.q.out 5e48a5cb7d 
  ql/src/test/results/clientpositive/spark/subquery_multi.q.out 3764d92b3b 
  ql/src/test/results/clientpositive/spark/subquery_multiinsert.q.out 5b4aa49900 
  ql/src/test/results/clientpositive/spark/subquery_notin.q.out e2f26a977f 
  ql/src/test/results/clientpositive/spark/subquery_null_agg.q.out 4cfce1033c 
  ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 77359a0197 
  ql/src/test/results/clientpositive/spark/subquery_select.q.out e36c74a91c 
  ql/src/test/results/clientpositive/spark/subquery_views.q.out 14be0186dd 
  ql/src/test/results/clientpositive/spark/union_remove_10.q.out 9bdcaf656a 
  ql/src/test/results/clientpositive/spark/union_remove_12.q.out cf89dab3f8 
  ql/src/test/results/clientpositive/spark/union_remove_14.q.out cf89dab3f8 
  ql/src/test/results/clientpositive/spark/union_remove_2.q.out 5fa05a9a0c 
  ql/src/test/results/clientpositive/spark/union_remove_5.q.out 3d311eae36 
  ql/src/test/results/clientpositive/spark/union_remove_6_subq.q.out 3034bd1cde 
  ql/src/test/results/clientpositive/spark/union_remove_8.q.out 9d651ed9ea 
  ql/src/test/results/clientpositive/spark/vector_between_in.q.out 75397d7d7d 
  ql/src/test/results/clientpositive/spark/vector_decimal_aggregate.q.out bbe9431571 
  ql/src/test/results/clientpositive/spark/vector_elt.q.out b717fda722 
  ql/src/test/results/clientpositive/spark/vectorization_14.q.out 6fa51e53f7 
  ql/src/test/results/clientpositive/spark/vectorization_17.q.out 851c1806b5 
  ql/src/test/results/clientpositive/spark/vectorization_4.q.out 436fdd9efc 
  ql/src/test/results/clientpositive/spark/vectorization_6.q.out b16d7b0645 
  ql/src/test/results/clientpositive/spark/vectorization_div0.q.out 530bdf6069 
  ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out 9683efa1d4 
  ql/src/test/results/clientpositive/spark/vectorized_case.q.out 8fff1ed7ba 
  ql/src/test/results/clientpositive/subquery_multiinsert.q.out 381550a006 
  ql/src/test/results/clientpositive/subquery_notin_having.q.out 74239031f6 
  ql/src/test/results/clientpositive/subquery_unqual_corr_expr.q.out 2507d52c0f 
  ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out bfb5d2b0a6 
  ql/src/test/results/clientpositive/tez/acid_vectorization_original_tez.q.out 50c53d0972 
  ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out a1ea37a682 
  ql/src/test/results/clientpositive/tez/explainuser_3.q.out c6cf6803b5 
  ql/src/test/results/clientpositive/tez/multi_count_distinct.q.out 5f5a8523b8 
  ql/src/test/results/clientpositive/tez/vectorization_div0.q.out 4afe85c30c 
  ql/src/test/results/clientpositive/timestamp.q.out 9d0ceef50f 
  ql/src/test/results/clientpositive/timestamp_ints_casts.q.out bc5ceb3f30 
  ql/src/test/results/clientpositive/timestamp_literal.q.out 4e069695f4 
  ql/src/test/results/clientpositive/timestamptz.q.out 7cff9a5c23 
  ql/src/test/results/clientpositive/type_widening.q.out 30e556477e 
  ql/src/test/results/clientpositive/udf4.q.out 5d263ebf68 
  ql/src/test/results/clientpositive/udf5.q.out 3fa801a078 
  ql/src/test/results/clientpositive/udf6.q.out 4193d340e4 
  ql/src/test/results/clientpositive/udf9.q.out a9bd954bfc 
  ql/src/test/results/clientpositive/udf_abs.q.out 5a8c4d7cfd 
  ql/src/test/results/clientpositive/udf_crc32.q.out 5d2888ac0a 
  ql/src/test/results/clientpositive/udf_factorial.q.out d6757aa194 
  ql/src/test/results/clientpositive/udf_folder_constants.q.out 70a8c0197c 
  ql/src/test/results/clientpositive/udf_from_utc_timestamp.q.out f00e3a1108 
  ql/src/test/results/clientpositive/udf_if.q.out eac4fe3e2b 
  ql/src/test/results/clientpositive/udf_reflect2.q.out a1074f8a81 
  ql/src/test/results/clientpositive/udf_to_utc_timestamp.q.out 7bd9aaf6e1 
  ql/src/test/results/clientpositive/union_pos_alias.q.out 65e736f3ed 
  ql/src/test/results/clientpositive/union_remove_10.q.out f1f2dd692d 
  ql/src/test/results/clientpositive/union_remove_12.q.out 702aef8aaf 
  ql/src/test/results/clientpositive/union_remove_14.q.out 702aef8aaf 
  ql/src/test/results/clientpositive/union_remove_2.q.out 0b84fb0c18 
  ql/src/test/results/clientpositive/union_remove_5.q.out efe59a12d2 
  ql/src/test/results/clientpositive/union_remove_6_subq.q.out 742e5b19db 
  ql/src/test/results/clientpositive/union_remove_8.q.out 2093fe6a0a 
  ql/src/test/results/clientpositive/vector_date_1.q.out 93f9a7116d 
  ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2f7ce319ae 
  ql/src/test/results/clientpositive/vector_elt.q.out 0b51d83d7b 
  ql/src/test/results/clientpositive/vector_groupby_mapjoin.q.out 0815bdb5ff 
  ql/src/test/results/clientpositive/vector_grouping_sets.q.out fc8290e72e 
  ql/src/test/results/clientpositive/vector_interval_1.q.out 1c7df24651 
  ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out 3ab7467df8 
  ql/src/test/results/clientpositive/vector_struct_in.q.out 773908b6a6 
  ql/src/test/results/clientpositive/vectorization_14.q.out 0a0c5fba8b 
  ql/src/test/results/clientpositive/vectorization_17.q.out 7104ae50ee 
  ql/src/test/results/clientpositive/vectorization_4.q.out ee618691b5 
  ql/src/test/results/clientpositive/vectorization_6.q.out f2204fc636 
  ql/src/test/results/clientpositive/vectorization_7.q.out 51d2b45a20 
  ql/src/test/results/clientpositive/vectorization_numeric_overflows.q.out 344db2b897 
  ql/src/test/results/clientpositive/vectorized_case.q.out b89fa511df 
  ql/src/test/results/clientpositive/vectorized_casts.q.out f6f210533f 
  ql/src/test/results/clientpositive/vectorized_date_funcs.q.out 298d92bdcd 
  ql/src/test/results/clientpositive/vectorized_timestamp.q.out 6c49e038a3 
  ql/src/test/results/clientpositive/vectorized_timestamp_ints_casts.q.out a203507512 
  ql/src/test/results/clientpositive/view_cbo.q.out 2fafa4fe22 


Diff: https://reviews.apache.org/r/65801/diff/3/

Changes: https://reviews.apache.org/r/65801/diff/2-3/


Testing
-------


Thanks,

Vineet Garg


Re: Review Request 65801: HIVE-18797 ExprConstNodeDesc's getExprString should put appropriate qualifier with literals

Posted by Ashutosh Chauhan <ha...@apache.org>.

> On Feb. 26, 2018, 7:45 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java
> > Lines 120 (patched)
> > <https://reviews.apache.org/r/65801/diff/2/?file=1964682#file1964682line120>
> >
> >     you need a space between DATE and ', else it will not parse correctly.
> 
> Vineet Garg wrote:
>     Ashutosh I am able to parse this string correctly without any space. According to grammar rule:
>     dateLiteral
>         :
>         KW_DATE StringLiteral ->
>         {
>         
>     Parser doesn't expect any space.

I see. Cool.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65801/#review198291
-----------------------------------------------------------


On Feb. 26, 2018, 1:03 a.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65801/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2018, 1:03 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-18797
>     https://issues.apache.org/jira/browse/HIVE-18797
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   hbase-handler/src/test/results/positive/hbase_timestamp.q.out e719b087d4 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java 73f449fc28 
>   ql/src/test/results/clientpositive/annotate_stats_deep_filters.q.out ab8c22b9be 
>   ql/src/test/results/clientpositive/annotate_stats_groupby.q.out 25efe1e1f4 
>   ql/src/test/results/clientpositive/annotate_stats_groupby2.q.out 78c4808f5f 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out 9aaa6f68a2 
>   ql/src/test/results/clientpositive/cast_on_constant.q.out 7f920f41af 
>   ql/src/test/results/clientpositive/constant_prop_3.q.out b754f8e7b4 
>   ql/src/test/results/clientpositive/constantfolding.q.out c4fce25e41 
>   ql/src/test/results/clientpositive/constprog_type.q.out 27ef1f482b 
>   ql/src/test/results/clientpositive/druid_basic2.q.out 08b64d6d82 
>   ql/src/test/results/clientpositive/druid_basic3.q.out ce6d0aafed 
>   ql/src/test/results/clientpositive/druid_intervals.q.out c94cbe9bd4 
>   ql/src/test/results/clientpositive/druid_timeseries.q.out 785cbd2114 
>   ql/src/test/results/clientpositive/druid_topn.q.out 90eec3dd49 
>   ql/src/test/results/clientpositive/except_all.q.out c3310f5154 
>   ql/src/test/results/clientpositive/extrapolate_part_stats_date.q.out 8fea7fdf44 
>   ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out 49e0d35d39 
>   ql/src/test/results/clientpositive/groupby_cube1.q.out 37b8c62edd 
>   ql/src/test/results/clientpositive/groupby_cube_multi_gby.q.out e6126ab2c6 
>   ql/src/test/results/clientpositive/groupby_grouping_id3.q.out ac43413400 
>   ql/src/test/results/clientpositive/groupby_grouping_sets1.q.out 62fc9fb550 
>   ql/src/test/results/clientpositive/groupby_grouping_sets2.q.out 43e17ec6bc 
>   ql/src/test/results/clientpositive/groupby_grouping_sets3.q.out 352d4beb9f 
>   ql/src/test/results/clientpositive/groupby_grouping_sets4.q.out e368e1ee12 
>   ql/src/test/results/clientpositive/groupby_grouping_sets5.q.out 1766fb9bbc 
>   ql/src/test/results/clientpositive/groupby_grouping_sets6.q.out 563b110a11 
>   ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out 1f2cd456c8 
>   ql/src/test/results/clientpositive/groupby_grouping_sets_limit.q.out efa1802855 
>   ql/src/test/results/clientpositive/groupby_grouping_window.q.out 0f58f5182a 
>   ql/src/test/results/clientpositive/groupby_rollup1.q.out a849a8d368 
>   ql/src/test/results/clientpositive/groupby_rollup_empty.q.out dd53fe2140 
>   ql/src/test/results/clientpositive/having.q.out 8a630751bb 
>   ql/src/test/results/clientpositive/having2.q.out 67f8af8328 
>   ql/src/test/results/clientpositive/implicit_cast1.q.out 6e1706a8a3 
>   ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out 72249383ee 
>   ql/src/test/results/clientpositive/infer_const_type.q.out 647c910241 
>   ql/src/test/results/clientpositive/interval_alt.q.out 53c1be8d05 
>   ql/src/test/results/clientpositive/interval_arithmetic.q.out eba97face9 
>   ql/src/test/results/clientpositive/limit_pushdown2.q.out f4cff2bcc0 
>   ql/src/test/results/clientpositive/literal_ints.q.out 9a56ebd5eb 
>   ql/src/test/results/clientpositive/llap/acid_vectorization_original.q.out 68801f0294 
>   ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out 98ede4e995 
>   ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_3.q.out aca6b21dba 
>   ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out 15a97a78c1 
>   ql/src/test/results/clientpositive/llap/dynpart_sort_optimization.q.out 78b9a443b8 
>   ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out 7b1dd40a16 
>   ql/src/test/results/clientpositive/llap/except_distinct.q.out 1e5937a22d 
>   ql/src/test/results/clientpositive/llap/explainuser_1.q.out 43ca0d9ad7 
>   ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.out 24be36ea36 
>   ql/src/test/results/clientpositive/llap/having.q.out 75de96ab59 
>   ql/src/test/results/clientpositive/llap/intersect_all.q.out 20a234e53b 
>   ql/src/test/results/clientpositive/llap/intersect_distinct.q.out a5384eb196 
>   ql/src/test/results/clientpositive/llap/intersect_merge.q.out 6f0e7f1f66 
>   ql/src/test/results/clientpositive/llap/lineage2.q.out 4f59a4d59b 
>   ql/src/test/results/clientpositive/llap/lineage3.q.out ca4405caf7 
>   ql/src/test/results/clientpositive/llap/mrr.q.out bfa26e4ff8 
>   ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out 66bf74f15a 
>   ql/src/test/results/clientpositive/llap/orc_merge5.q.out 6eba365ff2 
>   ql/src/test/results/clientpositive/llap/orc_merge6.q.out 1583007d7b 
>   ql/src/test/results/clientpositive/llap/orc_merge_incompat1.q.out 0e9b34f8ec 
>   ql/src/test/results/clientpositive/llap/orc_predicate_pushdown.q.out 9f20f77cb0 
>   ql/src/test/results/clientpositive/llap/parquet_predicate_pushdown.q.out 6885346539 
>   ql/src/test/results/clientpositive/llap/sqlmerge.q.out 2ff590ea0c 
>   ql/src/test/results/clientpositive/llap/subquery_in.q.out b5f9641502 
>   ql/src/test/results/clientpositive/llap/subquery_in_having.q.out cc0b6a597a 
>   ql/src/test/results/clientpositive/llap/subquery_multi.q.out 67a22c812f 
>   ql/src/test/results/clientpositive/llap/subquery_notin.q.out 50c18c8a68 
>   ql/src/test/results/clientpositive/llap/subquery_null_agg.q.out cff9568406 
>   ql/src/test/results/clientpositive/llap/subquery_scalar.q.out cec3daa085 
>   ql/src/test/results/clientpositive/llap/subquery_select.q.out 89eab37d07 
>   ql/src/test/results/clientpositive/llap/subquery_views.q.out 01a86d1300 
>   ql/src/test/results/clientpositive/llap/tez_dynpart_hashjoin_2.q.out 642bda2736 
>   ql/src/test/results/clientpositive/llap/tez_union_group_by.q.out 79321c1460 
>   ql/src/test/results/clientpositive/llap/tez_vector_dynpart_hashjoin_2.q.out 1ce7a3a37c 
>   ql/src/test/results/clientpositive/llap/vector_between_in.q.out f4f87ae0ee 
>   ql/src/test/results/clientpositive/llap/vector_date_1.q.out bacd667498 
>   ql/src/test/results/clientpositive/llap/vector_decimal_aggregate.q.out 5cb3e6678f 
>   ql/src/test/results/clientpositive/llap/vector_elt.q.out 24a1a65022 
>   ql/src/test/results/clientpositive/llap/vector_groupby_cube1.q.out 04ac09b0a6 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id1.q.out fd9dacbb12 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id2.q.out 74f6289fb0 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id3.q.out da4ba84c46 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets1.q.out 137e06a5b5 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out d8da29ac36 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3.q.out 79116112da 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3_dec.q.out 8d2247d42e 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets4.q.out 55c18fa2f1 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets5.q.out 4e579888e6 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets6.q.out 83c7ad8f00 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_grouping.q.out 8dd5cf074c 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_limit.q.out f7f3014a7f 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_window.q.out 9374bcc27a 
>   ql/src/test/results/clientpositive/llap/vector_groupby_mapjoin.q.out 82b6ba0a09 
>   ql/src/test/results/clientpositive/llap/vector_groupby_rollup1.q.out 717c218da9 
>   ql/src/test/results/clientpositive/llap/vector_grouping_sets.q.out 172e003af6 
>   ql/src/test/results/clientpositive/llap/vector_interval_1.q.out 7d891db4ef 
>   ql/src/test/results/clientpositive/llap/vector_interval_2.q.out 7548686c50 
>   ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out f2a4d3a855 
>   ql/src/test/results/clientpositive/llap/vector_number_compare_projection.q.out cd2e1e4c42 
>   ql/src/test/results/clientpositive/llap/vector_ptf_part_simple.q.out 16b59e612c 
>   ql/src/test/results/clientpositive/llap/vector_reuse_scratchcols.q.out b9c1ba31e8 
>   ql/src/test/results/clientpositive/llap/vector_struct_in.q.out 4af1015fe7 
>   ql/src/test/results/clientpositive/llap/vector_udf_adaptor_1.q.out a752dfadd4 
>   ql/src/test/results/clientpositive/llap/vector_windowing_navfn.q.out 8dc3fa7764 
>   ql/src/test/results/clientpositive/llap/vector_windowing_rank.q.out aa47b1bf75 
>   ql/src/test/results/clientpositive/llap/vector_windowing_streaming.q.out 2c54027bed 
>   ql/src/test/results/clientpositive/llap/vectorization_14.q.out c7a32e3a7e 
>   ql/src/test/results/clientpositive/llap/vectorization_17.q.out bdcb1ebfee 
>   ql/src/test/results/clientpositive/llap/vectorization_4.q.out a2142b716d 
>   ql/src/test/results/clientpositive/llap/vectorization_6.q.out 84b9260c18 
>   ql/src/test/results/clientpositive/llap/vectorization_7.q.out 3c7522912d 
>   ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out bd5e284523 
>   ql/src/test/results/clientpositive/llap/vectorized_case.q.out ed17e5c5f1 
>   ql/src/test/results/clientpositive/llap/vectorized_casts.q.out 84b4d9454d 
>   ql/src/test/results/clientpositive/llap/vectorized_date_funcs.q.out db292508ac 
>   ql/src/test/results/clientpositive/llap/vectorized_timestamp.q.out 9652d36b20 
>   ql/src/test/results/clientpositive/llap/vectorized_timestamp_ints_casts.q.out c346ff2cf8 
>   ql/src/test/results/clientpositive/num_op_type_conv.q.out 8e714f4ad7 
>   ql/src/test/results/clientpositive/orc_merge5.q.out 970c4ddad9 
>   ql/src/test/results/clientpositive/orc_merge6.q.out a08eb09cee 
>   ql/src/test/results/clientpositive/orc_merge_incompat1.q.out e8d504a9cb 
>   ql/src/test/results/clientpositive/parquet_vectorization_14.q.out f127434557 
>   ql/src/test/results/clientpositive/parquet_vectorization_17.q.out 8f26d41a48 
>   ql/src/test/results/clientpositive/parquet_vectorization_4.q.out 4c39858751 
>   ql/src/test/results/clientpositive/parquet_vectorization_6.q.out 3d7d5e3c85 
>   ql/src/test/results/clientpositive/parquet_vectorization_7.q.out 77caa03107 
>   ql/src/test/results/clientpositive/parquet_vectorization_div0.q.out 4a5cca6d22 
>   ql/src/test/results/clientpositive/perf/spark/query12.q.out d1796248f2 
>   ql/src/test/results/clientpositive/perf/spark/query16.q.out 1b763e278e 
>   ql/src/test/results/clientpositive/perf/spark/query18.q.out 33b2f62386 
>   ql/src/test/results/clientpositive/perf/spark/query20.q.out ab1b24dbf9 
>   ql/src/test/results/clientpositive/perf/spark/query21.q.out e73a627332 
>   ql/src/test/results/clientpositive/perf/spark/query22.q.out 38e4119afc 
>   ql/src/test/results/clientpositive/perf/spark/query23.q.out 8b5a83a58a 
>   ql/src/test/results/clientpositive/perf/spark/query27.q.out a87ec45c11 
>   ql/src/test/results/clientpositive/perf/spark/query32.q.out e7d356d257 
>   ql/src/test/results/clientpositive/perf/spark/query36.q.out 1a1a991b96 
>   ql/src/test/results/clientpositive/perf/spark/query37.q.out d8bff8173d 
>   ql/src/test/results/clientpositive/perf/spark/query38.q.out b9af9642b5 
>   ql/src/test/results/clientpositive/perf/spark/query40.q.out ab196dcb5d 
>   ql/src/test/results/clientpositive/perf/spark/query45.q.out 07af4e2e4b 
>   ql/src/test/results/clientpositive/perf/spark/query5.q.out 1ba37e050f 
>   ql/src/test/results/clientpositive/perf/spark/query6.q.out 126cf9e11c 
>   ql/src/test/results/clientpositive/perf/spark/query67.q.out b0fc41c7a2 
>   ql/src/test/results/clientpositive/perf/spark/query70.q.out 7ebb776719 
>   ql/src/test/results/clientpositive/perf/spark/query77.q.out 9a77a7b8b4 
>   ql/src/test/results/clientpositive/perf/spark/query8.q.out 13cd0f4ab6 
>   ql/src/test/results/clientpositive/perf/spark/query80.q.out ee769f9b95 
>   ql/src/test/results/clientpositive/perf/spark/query82.q.out b45f8d0bfb 
>   ql/src/test/results/clientpositive/perf/spark/query86.q.out 80a24d3dd7 
>   ql/src/test/results/clientpositive/perf/spark/query87.q.out 5fe3e48dfc 
>   ql/src/test/results/clientpositive/perf/spark/query9.q.out 4ec20070f7 
>   ql/src/test/results/clientpositive/perf/spark/query92.q.out 677a85cea1 
>   ql/src/test/results/clientpositive/perf/spark/query94.q.out 39c4476a5c 
>   ql/src/test/results/clientpositive/perf/spark/query95.q.out 0d136b6da7 
>   ql/src/test/results/clientpositive/perf/spark/query98.q.out 24d7de8b71 
>   ql/src/test/results/clientpositive/perf/tez/query12.q.out 0506eca00d 
>   ql/src/test/results/clientpositive/perf/tez/query14.q.out ef44cdbb6d 
>   ql/src/test/results/clientpositive/perf/tez/query16.q.out 1c0539199e 
>   ql/src/test/results/clientpositive/perf/tez/query18.q.out 1f0ec90b41 
>   ql/src/test/results/clientpositive/perf/tez/query20.q.out c07141b368 
>   ql/src/test/results/clientpositive/perf/tez/query21.q.out aed0990277 
>   ql/src/test/results/clientpositive/perf/tez/query22.q.out d13169c25c 
>   ql/src/test/results/clientpositive/perf/tez/query23.q.out c7a5041861 
>   ql/src/test/results/clientpositive/perf/tez/query27.q.out c6a190553e 
>   ql/src/test/results/clientpositive/perf/tez/query32.q.out 3ad9595910 
>   ql/src/test/results/clientpositive/perf/tez/query36.q.out a30ac2e53c 
>   ql/src/test/results/clientpositive/perf/tez/query37.q.out d5af964b0a 
>   ql/src/test/results/clientpositive/perf/tez/query38.q.out 199bed7de5 
>   ql/src/test/results/clientpositive/perf/tez/query40.q.out 604f741279 
>   ql/src/test/results/clientpositive/perf/tez/query45.q.out 3efed2e0e1 
>   ql/src/test/results/clientpositive/perf/tez/query5.q.out ff197d2871 
>   ql/src/test/results/clientpositive/perf/tez/query6.q.out f1e47581b4 
>   ql/src/test/results/clientpositive/perf/tez/query67.q.out 86c4d7ce14 
>   ql/src/test/results/clientpositive/perf/tez/query70.q.out d5ad6e5fcc 
>   ql/src/test/results/clientpositive/perf/tez/query77.q.out d10e2266b3 
>   ql/src/test/results/clientpositive/perf/tez/query8.q.out 8660fc9c57 
>   ql/src/test/results/clientpositive/perf/tez/query80.q.out a64cad7389 
>   ql/src/test/results/clientpositive/perf/tez/query82.q.out 037c2ffc2c 
>   ql/src/test/results/clientpositive/perf/tez/query86.q.out be7e858e22 
>   ql/src/test/results/clientpositive/perf/tez/query87.q.out 8430e8ad60 
>   ql/src/test/results/clientpositive/perf/tez/query92.q.out fbb4eb3a55 
>   ql/src/test/results/clientpositive/perf/tez/query94.q.out e18d45b15f 
>   ql/src/test/results/clientpositive/perf/tez/query95.q.out 15920d9751 
>   ql/src/test/results/clientpositive/perf/tez/query98.q.out da534cdcd3 
>   ql/src/test/results/clientpositive/ppd2.q.out 43119be016 
>   ql/src/test/results/clientpositive/ppd_gby.q.out c21e5a3435 
>   ql/src/test/results/clientpositive/ppd_gby2.q.out c65e5c9a4a 
>   ql/src/test/results/clientpositive/ppd_vc.q.out 1569cf62b7 
>   ql/src/test/results/clientpositive/results_cache_2.q.out ab1b0de9c0 
>   ql/src/test/results/clientpositive/semijoin4.q.out 46d1d3f37b 
>   ql/src/test/results/clientpositive/setop_subq.q.out ac20c4c422 
>   ql/src/test/results/clientpositive/spark/groupby_cube1.q.out 71ccea5507 
>   ql/src/test/results/clientpositive/spark/groupby_rollup1.q.out cf3721df04 
>   ql/src/test/results/clientpositive/spark/having.q.out 2876e67f06 
>   ql/src/test/results/clientpositive/spark/limit_pushdown2.q.out 3bd49b4c77 
>   ql/src/test/results/clientpositive/spark/orc_merge5.q.out c6f06add8a 
>   ql/src/test/results/clientpositive/spark/orc_merge6.q.out 5c3b25e035 
>   ql/src/test/results/clientpositive/spark/orc_merge_incompat1.q.out d97ac66af3 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_14.q.out f5b2896102 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_17.q.out a5ef4ae3f8 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_4.q.out 1d0de537d9 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_6.q.out b74f56b9ef 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_7.q.out f01e80854e 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_div0.q.out 5ba7587b89 
>   ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out ebd8d8692c 
>   ql/src/test/results/clientpositive/spark/subquery_in.q.out 5e48a5cb7d 
>   ql/src/test/results/clientpositive/spark/subquery_multi.q.out 3764d92b3b 
>   ql/src/test/results/clientpositive/spark/subquery_multiinsert.q.out 5b4aa49900 
>   ql/src/test/results/clientpositive/spark/subquery_notin.q.out e2f26a977f 
>   ql/src/test/results/clientpositive/spark/subquery_null_agg.q.out 4cfce1033c 
>   ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 77359a0197 
>   ql/src/test/results/clientpositive/spark/subquery_select.q.out e36c74a91c 
>   ql/src/test/results/clientpositive/spark/subquery_views.q.out 14be0186dd 
>   ql/src/test/results/clientpositive/spark/union_remove_10.q.out 9bdcaf656a 
>   ql/src/test/results/clientpositive/spark/union_remove_12.q.out cf89dab3f8 
>   ql/src/test/results/clientpositive/spark/union_remove_14.q.out cf89dab3f8 
>   ql/src/test/results/clientpositive/spark/union_remove_2.q.out 5fa05a9a0c 
>   ql/src/test/results/clientpositive/spark/union_remove_5.q.out 3d311eae36 
>   ql/src/test/results/clientpositive/spark/union_remove_6_subq.q.out 3034bd1cde 
>   ql/src/test/results/clientpositive/spark/union_remove_8.q.out 9d651ed9ea 
>   ql/src/test/results/clientpositive/spark/vector_between_in.q.out 75397d7d7d 
>   ql/src/test/results/clientpositive/spark/vector_decimal_aggregate.q.out bbe9431571 
>   ql/src/test/results/clientpositive/spark/vector_elt.q.out b717fda722 
>   ql/src/test/results/clientpositive/spark/vectorization_14.q.out 6fa51e53f7 
>   ql/src/test/results/clientpositive/spark/vectorization_17.q.out 851c1806b5 
>   ql/src/test/results/clientpositive/spark/vectorization_4.q.out 436fdd9efc 
>   ql/src/test/results/clientpositive/spark/vectorization_6.q.out b16d7b0645 
>   ql/src/test/results/clientpositive/spark/vectorization_div0.q.out 530bdf6069 
>   ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out 9683efa1d4 
>   ql/src/test/results/clientpositive/spark/vectorized_case.q.out 8fff1ed7ba 
>   ql/src/test/results/clientpositive/subquery_multiinsert.q.out 381550a006 
>   ql/src/test/results/clientpositive/subquery_notin_having.q.out 74239031f6 
>   ql/src/test/results/clientpositive/subquery_unqual_corr_expr.q.out 2507d52c0f 
>   ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out bfb5d2b0a6 
>   ql/src/test/results/clientpositive/tez/acid_vectorization_original_tez.q.out 50c53d0972 
>   ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out a1ea37a682 
>   ql/src/test/results/clientpositive/tez/explainuser_3.q.out c6cf6803b5 
>   ql/src/test/results/clientpositive/tez/multi_count_distinct.q.out 5f5a8523b8 
>   ql/src/test/results/clientpositive/tez/vectorization_div0.q.out 4afe85c30c 
>   ql/src/test/results/clientpositive/timestamp.q.out 9d0ceef50f 
>   ql/src/test/results/clientpositive/timestamp_ints_casts.q.out bc5ceb3f30 
>   ql/src/test/results/clientpositive/timestamp_literal.q.out 4e069695f4 
>   ql/src/test/results/clientpositive/timestamptz.q.out 7cff9a5c23 
>   ql/src/test/results/clientpositive/type_widening.q.out 30e556477e 
>   ql/src/test/results/clientpositive/udf4.q.out 5d263ebf68 
>   ql/src/test/results/clientpositive/udf5.q.out 3fa801a078 
>   ql/src/test/results/clientpositive/udf6.q.out 4193d340e4 
>   ql/src/test/results/clientpositive/udf9.q.out a9bd954bfc 
>   ql/src/test/results/clientpositive/udf_abs.q.out 5a8c4d7cfd 
>   ql/src/test/results/clientpositive/udf_crc32.q.out 5d2888ac0a 
>   ql/src/test/results/clientpositive/udf_factorial.q.out d6757aa194 
>   ql/src/test/results/clientpositive/udf_folder_constants.q.out 70a8c0197c 
>   ql/src/test/results/clientpositive/udf_from_utc_timestamp.q.out f00e3a1108 
>   ql/src/test/results/clientpositive/udf_if.q.out eac4fe3e2b 
>   ql/src/test/results/clientpositive/udf_reflect2.q.out a1074f8a81 
>   ql/src/test/results/clientpositive/udf_to_utc_timestamp.q.out 7bd9aaf6e1 
>   ql/src/test/results/clientpositive/union_pos_alias.q.out 65e736f3ed 
>   ql/src/test/results/clientpositive/union_remove_10.q.out f1f2dd692d 
>   ql/src/test/results/clientpositive/union_remove_12.q.out 702aef8aaf 
>   ql/src/test/results/clientpositive/union_remove_14.q.out 702aef8aaf 
>   ql/src/test/results/clientpositive/union_remove_2.q.out 0b84fb0c18 
>   ql/src/test/results/clientpositive/union_remove_5.q.out efe59a12d2 
>   ql/src/test/results/clientpositive/union_remove_6_subq.q.out 742e5b19db 
>   ql/src/test/results/clientpositive/union_remove_8.q.out 2093fe6a0a 
>   ql/src/test/results/clientpositive/vector_date_1.q.out 93f9a7116d 
>   ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2f7ce319ae 
>   ql/src/test/results/clientpositive/vector_elt.q.out 0b51d83d7b 
>   ql/src/test/results/clientpositive/vector_groupby_mapjoin.q.out 0815bdb5ff 
>   ql/src/test/results/clientpositive/vector_grouping_sets.q.out fc8290e72e 
>   ql/src/test/results/clientpositive/vector_interval_1.q.out 1c7df24651 
>   ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out 3ab7467df8 
>   ql/src/test/results/clientpositive/vector_struct_in.q.out 773908b6a6 
>   ql/src/test/results/clientpositive/vectorization_14.q.out 0a0c5fba8b 
>   ql/src/test/results/clientpositive/vectorization_17.q.out 7104ae50ee 
>   ql/src/test/results/clientpositive/vectorization_4.q.out ee618691b5 
>   ql/src/test/results/clientpositive/vectorization_6.q.out f2204fc636 
>   ql/src/test/results/clientpositive/vectorization_7.q.out 51d2b45a20 
>   ql/src/test/results/clientpositive/vectorization_numeric_overflows.q.out 344db2b897 
>   ql/src/test/results/clientpositive/vectorized_case.q.out b89fa511df 
>   ql/src/test/results/clientpositive/vectorized_casts.q.out f6f210533f 
>   ql/src/test/results/clientpositive/vectorized_date_funcs.q.out 298d92bdcd 
>   ql/src/test/results/clientpositive/vectorized_timestamp.q.out 6c49e038a3 
>   ql/src/test/results/clientpositive/vectorized_timestamp_ints_casts.q.out a203507512 
>   ql/src/test/results/clientpositive/view_cbo.q.out 2fafa4fe22 
> 
> 
> Diff: https://reviews.apache.org/r/65801/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>


Re: Review Request 65801: HIVE-18797 ExprConstNodeDesc's getExprString should put appropriate qualifier with literals

Posted by Vineet Garg <vg...@hortonworks.com>.

> On Feb. 26, 2018, 7:45 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java
> > Lines 120 (patched)
> > <https://reviews.apache.org/r/65801/diff/2/?file=1964682#file1964682line120>
> >
> >     you need a space between DATE and ', else it will not parse correctly.

Ashutosh I am able to parse this string correctly without any space. According to grammar rule:
dateLiteral
    :
    KW_DATE StringLiteral ->
    {
    
Parser doesn't expect any space.


- Vineet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65801/#review198291
-----------------------------------------------------------


On Feb. 26, 2018, 1:03 a.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65801/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2018, 1:03 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-18797
>     https://issues.apache.org/jira/browse/HIVE-18797
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   hbase-handler/src/test/results/positive/hbase_timestamp.q.out e719b087d4 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java 73f449fc28 
>   ql/src/test/results/clientpositive/annotate_stats_deep_filters.q.out ab8c22b9be 
>   ql/src/test/results/clientpositive/annotate_stats_groupby.q.out 25efe1e1f4 
>   ql/src/test/results/clientpositive/annotate_stats_groupby2.q.out 78c4808f5f 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out 9aaa6f68a2 
>   ql/src/test/results/clientpositive/cast_on_constant.q.out 7f920f41af 
>   ql/src/test/results/clientpositive/constant_prop_3.q.out b754f8e7b4 
>   ql/src/test/results/clientpositive/constantfolding.q.out c4fce25e41 
>   ql/src/test/results/clientpositive/constprog_type.q.out 27ef1f482b 
>   ql/src/test/results/clientpositive/druid_basic2.q.out 08b64d6d82 
>   ql/src/test/results/clientpositive/druid_basic3.q.out ce6d0aafed 
>   ql/src/test/results/clientpositive/druid_intervals.q.out c94cbe9bd4 
>   ql/src/test/results/clientpositive/druid_timeseries.q.out 785cbd2114 
>   ql/src/test/results/clientpositive/druid_topn.q.out 90eec3dd49 
>   ql/src/test/results/clientpositive/except_all.q.out c3310f5154 
>   ql/src/test/results/clientpositive/extrapolate_part_stats_date.q.out 8fea7fdf44 
>   ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out 49e0d35d39 
>   ql/src/test/results/clientpositive/groupby_cube1.q.out 37b8c62edd 
>   ql/src/test/results/clientpositive/groupby_cube_multi_gby.q.out e6126ab2c6 
>   ql/src/test/results/clientpositive/groupby_grouping_id3.q.out ac43413400 
>   ql/src/test/results/clientpositive/groupby_grouping_sets1.q.out 62fc9fb550 
>   ql/src/test/results/clientpositive/groupby_grouping_sets2.q.out 43e17ec6bc 
>   ql/src/test/results/clientpositive/groupby_grouping_sets3.q.out 352d4beb9f 
>   ql/src/test/results/clientpositive/groupby_grouping_sets4.q.out e368e1ee12 
>   ql/src/test/results/clientpositive/groupby_grouping_sets5.q.out 1766fb9bbc 
>   ql/src/test/results/clientpositive/groupby_grouping_sets6.q.out 563b110a11 
>   ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out 1f2cd456c8 
>   ql/src/test/results/clientpositive/groupby_grouping_sets_limit.q.out efa1802855 
>   ql/src/test/results/clientpositive/groupby_grouping_window.q.out 0f58f5182a 
>   ql/src/test/results/clientpositive/groupby_rollup1.q.out a849a8d368 
>   ql/src/test/results/clientpositive/groupby_rollup_empty.q.out dd53fe2140 
>   ql/src/test/results/clientpositive/having.q.out 8a630751bb 
>   ql/src/test/results/clientpositive/having2.q.out 67f8af8328 
>   ql/src/test/results/clientpositive/implicit_cast1.q.out 6e1706a8a3 
>   ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out 72249383ee 
>   ql/src/test/results/clientpositive/infer_const_type.q.out 647c910241 
>   ql/src/test/results/clientpositive/interval_alt.q.out 53c1be8d05 
>   ql/src/test/results/clientpositive/interval_arithmetic.q.out eba97face9 
>   ql/src/test/results/clientpositive/limit_pushdown2.q.out f4cff2bcc0 
>   ql/src/test/results/clientpositive/literal_ints.q.out 9a56ebd5eb 
>   ql/src/test/results/clientpositive/llap/acid_vectorization_original.q.out 68801f0294 
>   ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out 98ede4e995 
>   ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_3.q.out aca6b21dba 
>   ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out 15a97a78c1 
>   ql/src/test/results/clientpositive/llap/dynpart_sort_optimization.q.out 78b9a443b8 
>   ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out 7b1dd40a16 
>   ql/src/test/results/clientpositive/llap/except_distinct.q.out 1e5937a22d 
>   ql/src/test/results/clientpositive/llap/explainuser_1.q.out 43ca0d9ad7 
>   ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.out 24be36ea36 
>   ql/src/test/results/clientpositive/llap/having.q.out 75de96ab59 
>   ql/src/test/results/clientpositive/llap/intersect_all.q.out 20a234e53b 
>   ql/src/test/results/clientpositive/llap/intersect_distinct.q.out a5384eb196 
>   ql/src/test/results/clientpositive/llap/intersect_merge.q.out 6f0e7f1f66 
>   ql/src/test/results/clientpositive/llap/lineage2.q.out 4f59a4d59b 
>   ql/src/test/results/clientpositive/llap/lineage3.q.out ca4405caf7 
>   ql/src/test/results/clientpositive/llap/mrr.q.out bfa26e4ff8 
>   ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out 66bf74f15a 
>   ql/src/test/results/clientpositive/llap/orc_merge5.q.out 6eba365ff2 
>   ql/src/test/results/clientpositive/llap/orc_merge6.q.out 1583007d7b 
>   ql/src/test/results/clientpositive/llap/orc_merge_incompat1.q.out 0e9b34f8ec 
>   ql/src/test/results/clientpositive/llap/orc_predicate_pushdown.q.out 9f20f77cb0 
>   ql/src/test/results/clientpositive/llap/parquet_predicate_pushdown.q.out 6885346539 
>   ql/src/test/results/clientpositive/llap/sqlmerge.q.out 2ff590ea0c 
>   ql/src/test/results/clientpositive/llap/subquery_in.q.out b5f9641502 
>   ql/src/test/results/clientpositive/llap/subquery_in_having.q.out cc0b6a597a 
>   ql/src/test/results/clientpositive/llap/subquery_multi.q.out 67a22c812f 
>   ql/src/test/results/clientpositive/llap/subquery_notin.q.out 50c18c8a68 
>   ql/src/test/results/clientpositive/llap/subquery_null_agg.q.out cff9568406 
>   ql/src/test/results/clientpositive/llap/subquery_scalar.q.out cec3daa085 
>   ql/src/test/results/clientpositive/llap/subquery_select.q.out 89eab37d07 
>   ql/src/test/results/clientpositive/llap/subquery_views.q.out 01a86d1300 
>   ql/src/test/results/clientpositive/llap/tez_dynpart_hashjoin_2.q.out 642bda2736 
>   ql/src/test/results/clientpositive/llap/tez_union_group_by.q.out 79321c1460 
>   ql/src/test/results/clientpositive/llap/tez_vector_dynpart_hashjoin_2.q.out 1ce7a3a37c 
>   ql/src/test/results/clientpositive/llap/vector_between_in.q.out f4f87ae0ee 
>   ql/src/test/results/clientpositive/llap/vector_date_1.q.out bacd667498 
>   ql/src/test/results/clientpositive/llap/vector_decimal_aggregate.q.out 5cb3e6678f 
>   ql/src/test/results/clientpositive/llap/vector_elt.q.out 24a1a65022 
>   ql/src/test/results/clientpositive/llap/vector_groupby_cube1.q.out 04ac09b0a6 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id1.q.out fd9dacbb12 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id2.q.out 74f6289fb0 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id3.q.out da4ba84c46 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets1.q.out 137e06a5b5 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out d8da29ac36 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3.q.out 79116112da 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3_dec.q.out 8d2247d42e 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets4.q.out 55c18fa2f1 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets5.q.out 4e579888e6 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets6.q.out 83c7ad8f00 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_grouping.q.out 8dd5cf074c 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_limit.q.out f7f3014a7f 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_window.q.out 9374bcc27a 
>   ql/src/test/results/clientpositive/llap/vector_groupby_mapjoin.q.out 82b6ba0a09 
>   ql/src/test/results/clientpositive/llap/vector_groupby_rollup1.q.out 717c218da9 
>   ql/src/test/results/clientpositive/llap/vector_grouping_sets.q.out 172e003af6 
>   ql/src/test/results/clientpositive/llap/vector_interval_1.q.out 7d891db4ef 
>   ql/src/test/results/clientpositive/llap/vector_interval_2.q.out 7548686c50 
>   ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out f2a4d3a855 
>   ql/src/test/results/clientpositive/llap/vector_number_compare_projection.q.out cd2e1e4c42 
>   ql/src/test/results/clientpositive/llap/vector_ptf_part_simple.q.out 16b59e612c 
>   ql/src/test/results/clientpositive/llap/vector_reuse_scratchcols.q.out b9c1ba31e8 
>   ql/src/test/results/clientpositive/llap/vector_struct_in.q.out 4af1015fe7 
>   ql/src/test/results/clientpositive/llap/vector_udf_adaptor_1.q.out a752dfadd4 
>   ql/src/test/results/clientpositive/llap/vector_windowing_navfn.q.out 8dc3fa7764 
>   ql/src/test/results/clientpositive/llap/vector_windowing_rank.q.out aa47b1bf75 
>   ql/src/test/results/clientpositive/llap/vector_windowing_streaming.q.out 2c54027bed 
>   ql/src/test/results/clientpositive/llap/vectorization_14.q.out c7a32e3a7e 
>   ql/src/test/results/clientpositive/llap/vectorization_17.q.out bdcb1ebfee 
>   ql/src/test/results/clientpositive/llap/vectorization_4.q.out a2142b716d 
>   ql/src/test/results/clientpositive/llap/vectorization_6.q.out 84b9260c18 
>   ql/src/test/results/clientpositive/llap/vectorization_7.q.out 3c7522912d 
>   ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out bd5e284523 
>   ql/src/test/results/clientpositive/llap/vectorized_case.q.out ed17e5c5f1 
>   ql/src/test/results/clientpositive/llap/vectorized_casts.q.out 84b4d9454d 
>   ql/src/test/results/clientpositive/llap/vectorized_date_funcs.q.out db292508ac 
>   ql/src/test/results/clientpositive/llap/vectorized_timestamp.q.out 9652d36b20 
>   ql/src/test/results/clientpositive/llap/vectorized_timestamp_ints_casts.q.out c346ff2cf8 
>   ql/src/test/results/clientpositive/num_op_type_conv.q.out 8e714f4ad7 
>   ql/src/test/results/clientpositive/orc_merge5.q.out 970c4ddad9 
>   ql/src/test/results/clientpositive/orc_merge6.q.out a08eb09cee 
>   ql/src/test/results/clientpositive/orc_merge_incompat1.q.out e8d504a9cb 
>   ql/src/test/results/clientpositive/parquet_vectorization_14.q.out f127434557 
>   ql/src/test/results/clientpositive/parquet_vectorization_17.q.out 8f26d41a48 
>   ql/src/test/results/clientpositive/parquet_vectorization_4.q.out 4c39858751 
>   ql/src/test/results/clientpositive/parquet_vectorization_6.q.out 3d7d5e3c85 
>   ql/src/test/results/clientpositive/parquet_vectorization_7.q.out 77caa03107 
>   ql/src/test/results/clientpositive/parquet_vectorization_div0.q.out 4a5cca6d22 
>   ql/src/test/results/clientpositive/perf/spark/query12.q.out d1796248f2 
>   ql/src/test/results/clientpositive/perf/spark/query16.q.out 1b763e278e 
>   ql/src/test/results/clientpositive/perf/spark/query18.q.out 33b2f62386 
>   ql/src/test/results/clientpositive/perf/spark/query20.q.out ab1b24dbf9 
>   ql/src/test/results/clientpositive/perf/spark/query21.q.out e73a627332 
>   ql/src/test/results/clientpositive/perf/spark/query22.q.out 38e4119afc 
>   ql/src/test/results/clientpositive/perf/spark/query23.q.out 8b5a83a58a 
>   ql/src/test/results/clientpositive/perf/spark/query27.q.out a87ec45c11 
>   ql/src/test/results/clientpositive/perf/spark/query32.q.out e7d356d257 
>   ql/src/test/results/clientpositive/perf/spark/query36.q.out 1a1a991b96 
>   ql/src/test/results/clientpositive/perf/spark/query37.q.out d8bff8173d 
>   ql/src/test/results/clientpositive/perf/spark/query38.q.out b9af9642b5 
>   ql/src/test/results/clientpositive/perf/spark/query40.q.out ab196dcb5d 
>   ql/src/test/results/clientpositive/perf/spark/query45.q.out 07af4e2e4b 
>   ql/src/test/results/clientpositive/perf/spark/query5.q.out 1ba37e050f 
>   ql/src/test/results/clientpositive/perf/spark/query6.q.out 126cf9e11c 
>   ql/src/test/results/clientpositive/perf/spark/query67.q.out b0fc41c7a2 
>   ql/src/test/results/clientpositive/perf/spark/query70.q.out 7ebb776719 
>   ql/src/test/results/clientpositive/perf/spark/query77.q.out 9a77a7b8b4 
>   ql/src/test/results/clientpositive/perf/spark/query8.q.out 13cd0f4ab6 
>   ql/src/test/results/clientpositive/perf/spark/query80.q.out ee769f9b95 
>   ql/src/test/results/clientpositive/perf/spark/query82.q.out b45f8d0bfb 
>   ql/src/test/results/clientpositive/perf/spark/query86.q.out 80a24d3dd7 
>   ql/src/test/results/clientpositive/perf/spark/query87.q.out 5fe3e48dfc 
>   ql/src/test/results/clientpositive/perf/spark/query9.q.out 4ec20070f7 
>   ql/src/test/results/clientpositive/perf/spark/query92.q.out 677a85cea1 
>   ql/src/test/results/clientpositive/perf/spark/query94.q.out 39c4476a5c 
>   ql/src/test/results/clientpositive/perf/spark/query95.q.out 0d136b6da7 
>   ql/src/test/results/clientpositive/perf/spark/query98.q.out 24d7de8b71 
>   ql/src/test/results/clientpositive/perf/tez/query12.q.out 0506eca00d 
>   ql/src/test/results/clientpositive/perf/tez/query14.q.out ef44cdbb6d 
>   ql/src/test/results/clientpositive/perf/tez/query16.q.out 1c0539199e 
>   ql/src/test/results/clientpositive/perf/tez/query18.q.out 1f0ec90b41 
>   ql/src/test/results/clientpositive/perf/tez/query20.q.out c07141b368 
>   ql/src/test/results/clientpositive/perf/tez/query21.q.out aed0990277 
>   ql/src/test/results/clientpositive/perf/tez/query22.q.out d13169c25c 
>   ql/src/test/results/clientpositive/perf/tez/query23.q.out c7a5041861 
>   ql/src/test/results/clientpositive/perf/tez/query27.q.out c6a190553e 
>   ql/src/test/results/clientpositive/perf/tez/query32.q.out 3ad9595910 
>   ql/src/test/results/clientpositive/perf/tez/query36.q.out a30ac2e53c 
>   ql/src/test/results/clientpositive/perf/tez/query37.q.out d5af964b0a 
>   ql/src/test/results/clientpositive/perf/tez/query38.q.out 199bed7de5 
>   ql/src/test/results/clientpositive/perf/tez/query40.q.out 604f741279 
>   ql/src/test/results/clientpositive/perf/tez/query45.q.out 3efed2e0e1 
>   ql/src/test/results/clientpositive/perf/tez/query5.q.out ff197d2871 
>   ql/src/test/results/clientpositive/perf/tez/query6.q.out f1e47581b4 
>   ql/src/test/results/clientpositive/perf/tez/query67.q.out 86c4d7ce14 
>   ql/src/test/results/clientpositive/perf/tez/query70.q.out d5ad6e5fcc 
>   ql/src/test/results/clientpositive/perf/tez/query77.q.out d10e2266b3 
>   ql/src/test/results/clientpositive/perf/tez/query8.q.out 8660fc9c57 
>   ql/src/test/results/clientpositive/perf/tez/query80.q.out a64cad7389 
>   ql/src/test/results/clientpositive/perf/tez/query82.q.out 037c2ffc2c 
>   ql/src/test/results/clientpositive/perf/tez/query86.q.out be7e858e22 
>   ql/src/test/results/clientpositive/perf/tez/query87.q.out 8430e8ad60 
>   ql/src/test/results/clientpositive/perf/tez/query92.q.out fbb4eb3a55 
>   ql/src/test/results/clientpositive/perf/tez/query94.q.out e18d45b15f 
>   ql/src/test/results/clientpositive/perf/tez/query95.q.out 15920d9751 
>   ql/src/test/results/clientpositive/perf/tez/query98.q.out da534cdcd3 
>   ql/src/test/results/clientpositive/ppd2.q.out 43119be016 
>   ql/src/test/results/clientpositive/ppd_gby.q.out c21e5a3435 
>   ql/src/test/results/clientpositive/ppd_gby2.q.out c65e5c9a4a 
>   ql/src/test/results/clientpositive/ppd_vc.q.out 1569cf62b7 
>   ql/src/test/results/clientpositive/results_cache_2.q.out ab1b0de9c0 
>   ql/src/test/results/clientpositive/semijoin4.q.out 46d1d3f37b 
>   ql/src/test/results/clientpositive/setop_subq.q.out ac20c4c422 
>   ql/src/test/results/clientpositive/spark/groupby_cube1.q.out 71ccea5507 
>   ql/src/test/results/clientpositive/spark/groupby_rollup1.q.out cf3721df04 
>   ql/src/test/results/clientpositive/spark/having.q.out 2876e67f06 
>   ql/src/test/results/clientpositive/spark/limit_pushdown2.q.out 3bd49b4c77 
>   ql/src/test/results/clientpositive/spark/orc_merge5.q.out c6f06add8a 
>   ql/src/test/results/clientpositive/spark/orc_merge6.q.out 5c3b25e035 
>   ql/src/test/results/clientpositive/spark/orc_merge_incompat1.q.out d97ac66af3 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_14.q.out f5b2896102 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_17.q.out a5ef4ae3f8 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_4.q.out 1d0de537d9 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_6.q.out b74f56b9ef 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_7.q.out f01e80854e 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_div0.q.out 5ba7587b89 
>   ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out ebd8d8692c 
>   ql/src/test/results/clientpositive/spark/subquery_in.q.out 5e48a5cb7d 
>   ql/src/test/results/clientpositive/spark/subquery_multi.q.out 3764d92b3b 
>   ql/src/test/results/clientpositive/spark/subquery_multiinsert.q.out 5b4aa49900 
>   ql/src/test/results/clientpositive/spark/subquery_notin.q.out e2f26a977f 
>   ql/src/test/results/clientpositive/spark/subquery_null_agg.q.out 4cfce1033c 
>   ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 77359a0197 
>   ql/src/test/results/clientpositive/spark/subquery_select.q.out e36c74a91c 
>   ql/src/test/results/clientpositive/spark/subquery_views.q.out 14be0186dd 
>   ql/src/test/results/clientpositive/spark/union_remove_10.q.out 9bdcaf656a 
>   ql/src/test/results/clientpositive/spark/union_remove_12.q.out cf89dab3f8 
>   ql/src/test/results/clientpositive/spark/union_remove_14.q.out cf89dab3f8 
>   ql/src/test/results/clientpositive/spark/union_remove_2.q.out 5fa05a9a0c 
>   ql/src/test/results/clientpositive/spark/union_remove_5.q.out 3d311eae36 
>   ql/src/test/results/clientpositive/spark/union_remove_6_subq.q.out 3034bd1cde 
>   ql/src/test/results/clientpositive/spark/union_remove_8.q.out 9d651ed9ea 
>   ql/src/test/results/clientpositive/spark/vector_between_in.q.out 75397d7d7d 
>   ql/src/test/results/clientpositive/spark/vector_decimal_aggregate.q.out bbe9431571 
>   ql/src/test/results/clientpositive/spark/vector_elt.q.out b717fda722 
>   ql/src/test/results/clientpositive/spark/vectorization_14.q.out 6fa51e53f7 
>   ql/src/test/results/clientpositive/spark/vectorization_17.q.out 851c1806b5 
>   ql/src/test/results/clientpositive/spark/vectorization_4.q.out 436fdd9efc 
>   ql/src/test/results/clientpositive/spark/vectorization_6.q.out b16d7b0645 
>   ql/src/test/results/clientpositive/spark/vectorization_div0.q.out 530bdf6069 
>   ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out 9683efa1d4 
>   ql/src/test/results/clientpositive/spark/vectorized_case.q.out 8fff1ed7ba 
>   ql/src/test/results/clientpositive/subquery_multiinsert.q.out 381550a006 
>   ql/src/test/results/clientpositive/subquery_notin_having.q.out 74239031f6 
>   ql/src/test/results/clientpositive/subquery_unqual_corr_expr.q.out 2507d52c0f 
>   ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out bfb5d2b0a6 
>   ql/src/test/results/clientpositive/tez/acid_vectorization_original_tez.q.out 50c53d0972 
>   ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out a1ea37a682 
>   ql/src/test/results/clientpositive/tez/explainuser_3.q.out c6cf6803b5 
>   ql/src/test/results/clientpositive/tez/multi_count_distinct.q.out 5f5a8523b8 
>   ql/src/test/results/clientpositive/tez/vectorization_div0.q.out 4afe85c30c 
>   ql/src/test/results/clientpositive/timestamp.q.out 9d0ceef50f 
>   ql/src/test/results/clientpositive/timestamp_ints_casts.q.out bc5ceb3f30 
>   ql/src/test/results/clientpositive/timestamp_literal.q.out 4e069695f4 
>   ql/src/test/results/clientpositive/timestamptz.q.out 7cff9a5c23 
>   ql/src/test/results/clientpositive/type_widening.q.out 30e556477e 
>   ql/src/test/results/clientpositive/udf4.q.out 5d263ebf68 
>   ql/src/test/results/clientpositive/udf5.q.out 3fa801a078 
>   ql/src/test/results/clientpositive/udf6.q.out 4193d340e4 
>   ql/src/test/results/clientpositive/udf9.q.out a9bd954bfc 
>   ql/src/test/results/clientpositive/udf_abs.q.out 5a8c4d7cfd 
>   ql/src/test/results/clientpositive/udf_crc32.q.out 5d2888ac0a 
>   ql/src/test/results/clientpositive/udf_factorial.q.out d6757aa194 
>   ql/src/test/results/clientpositive/udf_folder_constants.q.out 70a8c0197c 
>   ql/src/test/results/clientpositive/udf_from_utc_timestamp.q.out f00e3a1108 
>   ql/src/test/results/clientpositive/udf_if.q.out eac4fe3e2b 
>   ql/src/test/results/clientpositive/udf_reflect2.q.out a1074f8a81 
>   ql/src/test/results/clientpositive/udf_to_utc_timestamp.q.out 7bd9aaf6e1 
>   ql/src/test/results/clientpositive/union_pos_alias.q.out 65e736f3ed 
>   ql/src/test/results/clientpositive/union_remove_10.q.out f1f2dd692d 
>   ql/src/test/results/clientpositive/union_remove_12.q.out 702aef8aaf 
>   ql/src/test/results/clientpositive/union_remove_14.q.out 702aef8aaf 
>   ql/src/test/results/clientpositive/union_remove_2.q.out 0b84fb0c18 
>   ql/src/test/results/clientpositive/union_remove_5.q.out efe59a12d2 
>   ql/src/test/results/clientpositive/union_remove_6_subq.q.out 742e5b19db 
>   ql/src/test/results/clientpositive/union_remove_8.q.out 2093fe6a0a 
>   ql/src/test/results/clientpositive/vector_date_1.q.out 93f9a7116d 
>   ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2f7ce319ae 
>   ql/src/test/results/clientpositive/vector_elt.q.out 0b51d83d7b 
>   ql/src/test/results/clientpositive/vector_groupby_mapjoin.q.out 0815bdb5ff 
>   ql/src/test/results/clientpositive/vector_grouping_sets.q.out fc8290e72e 
>   ql/src/test/results/clientpositive/vector_interval_1.q.out 1c7df24651 
>   ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out 3ab7467df8 
>   ql/src/test/results/clientpositive/vector_struct_in.q.out 773908b6a6 
>   ql/src/test/results/clientpositive/vectorization_14.q.out 0a0c5fba8b 
>   ql/src/test/results/clientpositive/vectorization_17.q.out 7104ae50ee 
>   ql/src/test/results/clientpositive/vectorization_4.q.out ee618691b5 
>   ql/src/test/results/clientpositive/vectorization_6.q.out f2204fc636 
>   ql/src/test/results/clientpositive/vectorization_7.q.out 51d2b45a20 
>   ql/src/test/results/clientpositive/vectorization_numeric_overflows.q.out 344db2b897 
>   ql/src/test/results/clientpositive/vectorized_case.q.out b89fa511df 
>   ql/src/test/results/clientpositive/vectorized_casts.q.out f6f210533f 
>   ql/src/test/results/clientpositive/vectorized_date_funcs.q.out 298d92bdcd 
>   ql/src/test/results/clientpositive/vectorized_timestamp.q.out 6c49e038a3 
>   ql/src/test/results/clientpositive/vectorized_timestamp_ints_casts.q.out a203507512 
>   ql/src/test/results/clientpositive/view_cbo.q.out 2fafa4fe22 
> 
> 
> Diff: https://reviews.apache.org/r/65801/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>


Re: Review Request 65801: HIVE-18797 ExprConstNodeDesc's getExprString should put appropriate qualifier with literals

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65801/#review198291
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java
Lines 120 (patched)
<https://reviews.apache.org/r/65801/#comment278400>

    you need a space between DATE and ', else it will not parse correctly.



ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java
Lines 122 (patched)
<https://reviews.apache.org/r/65801/#comment278401>

    you need a space between DATE and ', else it will not parse correctly. Hard to tell if its there or not.
    Similarly for TS and TSTZ.


- Ashutosh Chauhan


On Feb. 26, 2018, 1:03 a.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65801/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2018, 1:03 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-18797
>     https://issues.apache.org/jira/browse/HIVE-18797
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   hbase-handler/src/test/results/positive/hbase_timestamp.q.out e719b087d4 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java 73f449fc28 
>   ql/src/test/results/clientpositive/annotate_stats_deep_filters.q.out ab8c22b9be 
>   ql/src/test/results/clientpositive/annotate_stats_groupby.q.out 25efe1e1f4 
>   ql/src/test/results/clientpositive/annotate_stats_groupby2.q.out 78c4808f5f 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out 9aaa6f68a2 
>   ql/src/test/results/clientpositive/cast_on_constant.q.out 7f920f41af 
>   ql/src/test/results/clientpositive/constant_prop_3.q.out b754f8e7b4 
>   ql/src/test/results/clientpositive/constantfolding.q.out c4fce25e41 
>   ql/src/test/results/clientpositive/constprog_type.q.out 27ef1f482b 
>   ql/src/test/results/clientpositive/druid_basic2.q.out 08b64d6d82 
>   ql/src/test/results/clientpositive/druid_basic3.q.out ce6d0aafed 
>   ql/src/test/results/clientpositive/druid_intervals.q.out c94cbe9bd4 
>   ql/src/test/results/clientpositive/druid_timeseries.q.out 785cbd2114 
>   ql/src/test/results/clientpositive/druid_topn.q.out 90eec3dd49 
>   ql/src/test/results/clientpositive/except_all.q.out c3310f5154 
>   ql/src/test/results/clientpositive/extrapolate_part_stats_date.q.out 8fea7fdf44 
>   ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out 49e0d35d39 
>   ql/src/test/results/clientpositive/groupby_cube1.q.out 37b8c62edd 
>   ql/src/test/results/clientpositive/groupby_cube_multi_gby.q.out e6126ab2c6 
>   ql/src/test/results/clientpositive/groupby_grouping_id3.q.out ac43413400 
>   ql/src/test/results/clientpositive/groupby_grouping_sets1.q.out 62fc9fb550 
>   ql/src/test/results/clientpositive/groupby_grouping_sets2.q.out 43e17ec6bc 
>   ql/src/test/results/clientpositive/groupby_grouping_sets3.q.out 352d4beb9f 
>   ql/src/test/results/clientpositive/groupby_grouping_sets4.q.out e368e1ee12 
>   ql/src/test/results/clientpositive/groupby_grouping_sets5.q.out 1766fb9bbc 
>   ql/src/test/results/clientpositive/groupby_grouping_sets6.q.out 563b110a11 
>   ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out 1f2cd456c8 
>   ql/src/test/results/clientpositive/groupby_grouping_sets_limit.q.out efa1802855 
>   ql/src/test/results/clientpositive/groupby_grouping_window.q.out 0f58f5182a 
>   ql/src/test/results/clientpositive/groupby_rollup1.q.out a849a8d368 
>   ql/src/test/results/clientpositive/groupby_rollup_empty.q.out dd53fe2140 
>   ql/src/test/results/clientpositive/having.q.out 8a630751bb 
>   ql/src/test/results/clientpositive/having2.q.out 67f8af8328 
>   ql/src/test/results/clientpositive/implicit_cast1.q.out 6e1706a8a3 
>   ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out 72249383ee 
>   ql/src/test/results/clientpositive/infer_const_type.q.out 647c910241 
>   ql/src/test/results/clientpositive/interval_alt.q.out 53c1be8d05 
>   ql/src/test/results/clientpositive/interval_arithmetic.q.out eba97face9 
>   ql/src/test/results/clientpositive/limit_pushdown2.q.out f4cff2bcc0 
>   ql/src/test/results/clientpositive/literal_ints.q.out 9a56ebd5eb 
>   ql/src/test/results/clientpositive/llap/acid_vectorization_original.q.out 68801f0294 
>   ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out 98ede4e995 
>   ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_3.q.out aca6b21dba 
>   ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out 15a97a78c1 
>   ql/src/test/results/clientpositive/llap/dynpart_sort_optimization.q.out 78b9a443b8 
>   ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out 7b1dd40a16 
>   ql/src/test/results/clientpositive/llap/except_distinct.q.out 1e5937a22d 
>   ql/src/test/results/clientpositive/llap/explainuser_1.q.out 43ca0d9ad7 
>   ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.out 24be36ea36 
>   ql/src/test/results/clientpositive/llap/having.q.out 75de96ab59 
>   ql/src/test/results/clientpositive/llap/intersect_all.q.out 20a234e53b 
>   ql/src/test/results/clientpositive/llap/intersect_distinct.q.out a5384eb196 
>   ql/src/test/results/clientpositive/llap/intersect_merge.q.out 6f0e7f1f66 
>   ql/src/test/results/clientpositive/llap/lineage2.q.out 4f59a4d59b 
>   ql/src/test/results/clientpositive/llap/lineage3.q.out ca4405caf7 
>   ql/src/test/results/clientpositive/llap/mrr.q.out bfa26e4ff8 
>   ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out 66bf74f15a 
>   ql/src/test/results/clientpositive/llap/orc_merge5.q.out 6eba365ff2 
>   ql/src/test/results/clientpositive/llap/orc_merge6.q.out 1583007d7b 
>   ql/src/test/results/clientpositive/llap/orc_merge_incompat1.q.out 0e9b34f8ec 
>   ql/src/test/results/clientpositive/llap/orc_predicate_pushdown.q.out 9f20f77cb0 
>   ql/src/test/results/clientpositive/llap/parquet_predicate_pushdown.q.out 6885346539 
>   ql/src/test/results/clientpositive/llap/sqlmerge.q.out 2ff590ea0c 
>   ql/src/test/results/clientpositive/llap/subquery_in.q.out b5f9641502 
>   ql/src/test/results/clientpositive/llap/subquery_in_having.q.out cc0b6a597a 
>   ql/src/test/results/clientpositive/llap/subquery_multi.q.out 67a22c812f 
>   ql/src/test/results/clientpositive/llap/subquery_notin.q.out 50c18c8a68 
>   ql/src/test/results/clientpositive/llap/subquery_null_agg.q.out cff9568406 
>   ql/src/test/results/clientpositive/llap/subquery_scalar.q.out cec3daa085 
>   ql/src/test/results/clientpositive/llap/subquery_select.q.out 89eab37d07 
>   ql/src/test/results/clientpositive/llap/subquery_views.q.out 01a86d1300 
>   ql/src/test/results/clientpositive/llap/tez_dynpart_hashjoin_2.q.out 642bda2736 
>   ql/src/test/results/clientpositive/llap/tez_union_group_by.q.out 79321c1460 
>   ql/src/test/results/clientpositive/llap/tez_vector_dynpart_hashjoin_2.q.out 1ce7a3a37c 
>   ql/src/test/results/clientpositive/llap/vector_between_in.q.out f4f87ae0ee 
>   ql/src/test/results/clientpositive/llap/vector_date_1.q.out bacd667498 
>   ql/src/test/results/clientpositive/llap/vector_decimal_aggregate.q.out 5cb3e6678f 
>   ql/src/test/results/clientpositive/llap/vector_elt.q.out 24a1a65022 
>   ql/src/test/results/clientpositive/llap/vector_groupby_cube1.q.out 04ac09b0a6 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id1.q.out fd9dacbb12 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id2.q.out 74f6289fb0 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id3.q.out da4ba84c46 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets1.q.out 137e06a5b5 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out d8da29ac36 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3.q.out 79116112da 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3_dec.q.out 8d2247d42e 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets4.q.out 55c18fa2f1 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets5.q.out 4e579888e6 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets6.q.out 83c7ad8f00 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_grouping.q.out 8dd5cf074c 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_limit.q.out f7f3014a7f 
>   ql/src/test/results/clientpositive/llap/vector_groupby_grouping_window.q.out 9374bcc27a 
>   ql/src/test/results/clientpositive/llap/vector_groupby_mapjoin.q.out 82b6ba0a09 
>   ql/src/test/results/clientpositive/llap/vector_groupby_rollup1.q.out 717c218da9 
>   ql/src/test/results/clientpositive/llap/vector_grouping_sets.q.out 172e003af6 
>   ql/src/test/results/clientpositive/llap/vector_interval_1.q.out 7d891db4ef 
>   ql/src/test/results/clientpositive/llap/vector_interval_2.q.out 7548686c50 
>   ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out f2a4d3a855 
>   ql/src/test/results/clientpositive/llap/vector_number_compare_projection.q.out cd2e1e4c42 
>   ql/src/test/results/clientpositive/llap/vector_ptf_part_simple.q.out 16b59e612c 
>   ql/src/test/results/clientpositive/llap/vector_reuse_scratchcols.q.out b9c1ba31e8 
>   ql/src/test/results/clientpositive/llap/vector_struct_in.q.out 4af1015fe7 
>   ql/src/test/results/clientpositive/llap/vector_udf_adaptor_1.q.out a752dfadd4 
>   ql/src/test/results/clientpositive/llap/vector_windowing_navfn.q.out 8dc3fa7764 
>   ql/src/test/results/clientpositive/llap/vector_windowing_rank.q.out aa47b1bf75 
>   ql/src/test/results/clientpositive/llap/vector_windowing_streaming.q.out 2c54027bed 
>   ql/src/test/results/clientpositive/llap/vectorization_14.q.out c7a32e3a7e 
>   ql/src/test/results/clientpositive/llap/vectorization_17.q.out bdcb1ebfee 
>   ql/src/test/results/clientpositive/llap/vectorization_4.q.out a2142b716d 
>   ql/src/test/results/clientpositive/llap/vectorization_6.q.out 84b9260c18 
>   ql/src/test/results/clientpositive/llap/vectorization_7.q.out 3c7522912d 
>   ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out bd5e284523 
>   ql/src/test/results/clientpositive/llap/vectorized_case.q.out ed17e5c5f1 
>   ql/src/test/results/clientpositive/llap/vectorized_casts.q.out 84b4d9454d 
>   ql/src/test/results/clientpositive/llap/vectorized_date_funcs.q.out db292508ac 
>   ql/src/test/results/clientpositive/llap/vectorized_timestamp.q.out 9652d36b20 
>   ql/src/test/results/clientpositive/llap/vectorized_timestamp_ints_casts.q.out c346ff2cf8 
>   ql/src/test/results/clientpositive/num_op_type_conv.q.out 8e714f4ad7 
>   ql/src/test/results/clientpositive/orc_merge5.q.out 970c4ddad9 
>   ql/src/test/results/clientpositive/orc_merge6.q.out a08eb09cee 
>   ql/src/test/results/clientpositive/orc_merge_incompat1.q.out e8d504a9cb 
>   ql/src/test/results/clientpositive/parquet_vectorization_14.q.out f127434557 
>   ql/src/test/results/clientpositive/parquet_vectorization_17.q.out 8f26d41a48 
>   ql/src/test/results/clientpositive/parquet_vectorization_4.q.out 4c39858751 
>   ql/src/test/results/clientpositive/parquet_vectorization_6.q.out 3d7d5e3c85 
>   ql/src/test/results/clientpositive/parquet_vectorization_7.q.out 77caa03107 
>   ql/src/test/results/clientpositive/parquet_vectorization_div0.q.out 4a5cca6d22 
>   ql/src/test/results/clientpositive/perf/spark/query12.q.out d1796248f2 
>   ql/src/test/results/clientpositive/perf/spark/query16.q.out 1b763e278e 
>   ql/src/test/results/clientpositive/perf/spark/query18.q.out 33b2f62386 
>   ql/src/test/results/clientpositive/perf/spark/query20.q.out ab1b24dbf9 
>   ql/src/test/results/clientpositive/perf/spark/query21.q.out e73a627332 
>   ql/src/test/results/clientpositive/perf/spark/query22.q.out 38e4119afc 
>   ql/src/test/results/clientpositive/perf/spark/query23.q.out 8b5a83a58a 
>   ql/src/test/results/clientpositive/perf/spark/query27.q.out a87ec45c11 
>   ql/src/test/results/clientpositive/perf/spark/query32.q.out e7d356d257 
>   ql/src/test/results/clientpositive/perf/spark/query36.q.out 1a1a991b96 
>   ql/src/test/results/clientpositive/perf/spark/query37.q.out d8bff8173d 
>   ql/src/test/results/clientpositive/perf/spark/query38.q.out b9af9642b5 
>   ql/src/test/results/clientpositive/perf/spark/query40.q.out ab196dcb5d 
>   ql/src/test/results/clientpositive/perf/spark/query45.q.out 07af4e2e4b 
>   ql/src/test/results/clientpositive/perf/spark/query5.q.out 1ba37e050f 
>   ql/src/test/results/clientpositive/perf/spark/query6.q.out 126cf9e11c 
>   ql/src/test/results/clientpositive/perf/spark/query67.q.out b0fc41c7a2 
>   ql/src/test/results/clientpositive/perf/spark/query70.q.out 7ebb776719 
>   ql/src/test/results/clientpositive/perf/spark/query77.q.out 9a77a7b8b4 
>   ql/src/test/results/clientpositive/perf/spark/query8.q.out 13cd0f4ab6 
>   ql/src/test/results/clientpositive/perf/spark/query80.q.out ee769f9b95 
>   ql/src/test/results/clientpositive/perf/spark/query82.q.out b45f8d0bfb 
>   ql/src/test/results/clientpositive/perf/spark/query86.q.out 80a24d3dd7 
>   ql/src/test/results/clientpositive/perf/spark/query87.q.out 5fe3e48dfc 
>   ql/src/test/results/clientpositive/perf/spark/query9.q.out 4ec20070f7 
>   ql/src/test/results/clientpositive/perf/spark/query92.q.out 677a85cea1 
>   ql/src/test/results/clientpositive/perf/spark/query94.q.out 39c4476a5c 
>   ql/src/test/results/clientpositive/perf/spark/query95.q.out 0d136b6da7 
>   ql/src/test/results/clientpositive/perf/spark/query98.q.out 24d7de8b71 
>   ql/src/test/results/clientpositive/perf/tez/query12.q.out 0506eca00d 
>   ql/src/test/results/clientpositive/perf/tez/query14.q.out ef44cdbb6d 
>   ql/src/test/results/clientpositive/perf/tez/query16.q.out 1c0539199e 
>   ql/src/test/results/clientpositive/perf/tez/query18.q.out 1f0ec90b41 
>   ql/src/test/results/clientpositive/perf/tez/query20.q.out c07141b368 
>   ql/src/test/results/clientpositive/perf/tez/query21.q.out aed0990277 
>   ql/src/test/results/clientpositive/perf/tez/query22.q.out d13169c25c 
>   ql/src/test/results/clientpositive/perf/tez/query23.q.out c7a5041861 
>   ql/src/test/results/clientpositive/perf/tez/query27.q.out c6a190553e 
>   ql/src/test/results/clientpositive/perf/tez/query32.q.out 3ad9595910 
>   ql/src/test/results/clientpositive/perf/tez/query36.q.out a30ac2e53c 
>   ql/src/test/results/clientpositive/perf/tez/query37.q.out d5af964b0a 
>   ql/src/test/results/clientpositive/perf/tez/query38.q.out 199bed7de5 
>   ql/src/test/results/clientpositive/perf/tez/query40.q.out 604f741279 
>   ql/src/test/results/clientpositive/perf/tez/query45.q.out 3efed2e0e1 
>   ql/src/test/results/clientpositive/perf/tez/query5.q.out ff197d2871 
>   ql/src/test/results/clientpositive/perf/tez/query6.q.out f1e47581b4 
>   ql/src/test/results/clientpositive/perf/tez/query67.q.out 86c4d7ce14 
>   ql/src/test/results/clientpositive/perf/tez/query70.q.out d5ad6e5fcc 
>   ql/src/test/results/clientpositive/perf/tez/query77.q.out d10e2266b3 
>   ql/src/test/results/clientpositive/perf/tez/query8.q.out 8660fc9c57 
>   ql/src/test/results/clientpositive/perf/tez/query80.q.out a64cad7389 
>   ql/src/test/results/clientpositive/perf/tez/query82.q.out 037c2ffc2c 
>   ql/src/test/results/clientpositive/perf/tez/query86.q.out be7e858e22 
>   ql/src/test/results/clientpositive/perf/tez/query87.q.out 8430e8ad60 
>   ql/src/test/results/clientpositive/perf/tez/query92.q.out fbb4eb3a55 
>   ql/src/test/results/clientpositive/perf/tez/query94.q.out e18d45b15f 
>   ql/src/test/results/clientpositive/perf/tez/query95.q.out 15920d9751 
>   ql/src/test/results/clientpositive/perf/tez/query98.q.out da534cdcd3 
>   ql/src/test/results/clientpositive/ppd2.q.out 43119be016 
>   ql/src/test/results/clientpositive/ppd_gby.q.out c21e5a3435 
>   ql/src/test/results/clientpositive/ppd_gby2.q.out c65e5c9a4a 
>   ql/src/test/results/clientpositive/ppd_vc.q.out 1569cf62b7 
>   ql/src/test/results/clientpositive/results_cache_2.q.out ab1b0de9c0 
>   ql/src/test/results/clientpositive/semijoin4.q.out 46d1d3f37b 
>   ql/src/test/results/clientpositive/setop_subq.q.out ac20c4c422 
>   ql/src/test/results/clientpositive/spark/groupby_cube1.q.out 71ccea5507 
>   ql/src/test/results/clientpositive/spark/groupby_rollup1.q.out cf3721df04 
>   ql/src/test/results/clientpositive/spark/having.q.out 2876e67f06 
>   ql/src/test/results/clientpositive/spark/limit_pushdown2.q.out 3bd49b4c77 
>   ql/src/test/results/clientpositive/spark/orc_merge5.q.out c6f06add8a 
>   ql/src/test/results/clientpositive/spark/orc_merge6.q.out 5c3b25e035 
>   ql/src/test/results/clientpositive/spark/orc_merge_incompat1.q.out d97ac66af3 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_14.q.out f5b2896102 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_17.q.out a5ef4ae3f8 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_4.q.out 1d0de537d9 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_6.q.out b74f56b9ef 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_7.q.out f01e80854e 
>   ql/src/test/results/clientpositive/spark/parquet_vectorization_div0.q.out 5ba7587b89 
>   ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out ebd8d8692c 
>   ql/src/test/results/clientpositive/spark/subquery_in.q.out 5e48a5cb7d 
>   ql/src/test/results/clientpositive/spark/subquery_multi.q.out 3764d92b3b 
>   ql/src/test/results/clientpositive/spark/subquery_multiinsert.q.out 5b4aa49900 
>   ql/src/test/results/clientpositive/spark/subquery_notin.q.out e2f26a977f 
>   ql/src/test/results/clientpositive/spark/subquery_null_agg.q.out 4cfce1033c 
>   ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 77359a0197 
>   ql/src/test/results/clientpositive/spark/subquery_select.q.out e36c74a91c 
>   ql/src/test/results/clientpositive/spark/subquery_views.q.out 14be0186dd 
>   ql/src/test/results/clientpositive/spark/union_remove_10.q.out 9bdcaf656a 
>   ql/src/test/results/clientpositive/spark/union_remove_12.q.out cf89dab3f8 
>   ql/src/test/results/clientpositive/spark/union_remove_14.q.out cf89dab3f8 
>   ql/src/test/results/clientpositive/spark/union_remove_2.q.out 5fa05a9a0c 
>   ql/src/test/results/clientpositive/spark/union_remove_5.q.out 3d311eae36 
>   ql/src/test/results/clientpositive/spark/union_remove_6_subq.q.out 3034bd1cde 
>   ql/src/test/results/clientpositive/spark/union_remove_8.q.out 9d651ed9ea 
>   ql/src/test/results/clientpositive/spark/vector_between_in.q.out 75397d7d7d 
>   ql/src/test/results/clientpositive/spark/vector_decimal_aggregate.q.out bbe9431571 
>   ql/src/test/results/clientpositive/spark/vector_elt.q.out b717fda722 
>   ql/src/test/results/clientpositive/spark/vectorization_14.q.out 6fa51e53f7 
>   ql/src/test/results/clientpositive/spark/vectorization_17.q.out 851c1806b5 
>   ql/src/test/results/clientpositive/spark/vectorization_4.q.out 436fdd9efc 
>   ql/src/test/results/clientpositive/spark/vectorization_6.q.out b16d7b0645 
>   ql/src/test/results/clientpositive/spark/vectorization_div0.q.out 530bdf6069 
>   ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out 9683efa1d4 
>   ql/src/test/results/clientpositive/spark/vectorized_case.q.out 8fff1ed7ba 
>   ql/src/test/results/clientpositive/subquery_multiinsert.q.out 381550a006 
>   ql/src/test/results/clientpositive/subquery_notin_having.q.out 74239031f6 
>   ql/src/test/results/clientpositive/subquery_unqual_corr_expr.q.out 2507d52c0f 
>   ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out bfb5d2b0a6 
>   ql/src/test/results/clientpositive/tez/acid_vectorization_original_tez.q.out 50c53d0972 
>   ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out a1ea37a682 
>   ql/src/test/results/clientpositive/tez/explainuser_3.q.out c6cf6803b5 
>   ql/src/test/results/clientpositive/tez/multi_count_distinct.q.out 5f5a8523b8 
>   ql/src/test/results/clientpositive/tez/vectorization_div0.q.out 4afe85c30c 
>   ql/src/test/results/clientpositive/timestamp.q.out 9d0ceef50f 
>   ql/src/test/results/clientpositive/timestamp_ints_casts.q.out bc5ceb3f30 
>   ql/src/test/results/clientpositive/timestamp_literal.q.out 4e069695f4 
>   ql/src/test/results/clientpositive/timestamptz.q.out 7cff9a5c23 
>   ql/src/test/results/clientpositive/type_widening.q.out 30e556477e 
>   ql/src/test/results/clientpositive/udf4.q.out 5d263ebf68 
>   ql/src/test/results/clientpositive/udf5.q.out 3fa801a078 
>   ql/src/test/results/clientpositive/udf6.q.out 4193d340e4 
>   ql/src/test/results/clientpositive/udf9.q.out a9bd954bfc 
>   ql/src/test/results/clientpositive/udf_abs.q.out 5a8c4d7cfd 
>   ql/src/test/results/clientpositive/udf_crc32.q.out 5d2888ac0a 
>   ql/src/test/results/clientpositive/udf_factorial.q.out d6757aa194 
>   ql/src/test/results/clientpositive/udf_folder_constants.q.out 70a8c0197c 
>   ql/src/test/results/clientpositive/udf_from_utc_timestamp.q.out f00e3a1108 
>   ql/src/test/results/clientpositive/udf_if.q.out eac4fe3e2b 
>   ql/src/test/results/clientpositive/udf_reflect2.q.out a1074f8a81 
>   ql/src/test/results/clientpositive/udf_to_utc_timestamp.q.out 7bd9aaf6e1 
>   ql/src/test/results/clientpositive/union_pos_alias.q.out 65e736f3ed 
>   ql/src/test/results/clientpositive/union_remove_10.q.out f1f2dd692d 
>   ql/src/test/results/clientpositive/union_remove_12.q.out 702aef8aaf 
>   ql/src/test/results/clientpositive/union_remove_14.q.out 702aef8aaf 
>   ql/src/test/results/clientpositive/union_remove_2.q.out 0b84fb0c18 
>   ql/src/test/results/clientpositive/union_remove_5.q.out efe59a12d2 
>   ql/src/test/results/clientpositive/union_remove_6_subq.q.out 742e5b19db 
>   ql/src/test/results/clientpositive/union_remove_8.q.out 2093fe6a0a 
>   ql/src/test/results/clientpositive/vector_date_1.q.out 93f9a7116d 
>   ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2f7ce319ae 
>   ql/src/test/results/clientpositive/vector_elt.q.out 0b51d83d7b 
>   ql/src/test/results/clientpositive/vector_groupby_mapjoin.q.out 0815bdb5ff 
>   ql/src/test/results/clientpositive/vector_grouping_sets.q.out fc8290e72e 
>   ql/src/test/results/clientpositive/vector_interval_1.q.out 1c7df24651 
>   ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out 3ab7467df8 
>   ql/src/test/results/clientpositive/vector_struct_in.q.out 773908b6a6 
>   ql/src/test/results/clientpositive/vectorization_14.q.out 0a0c5fba8b 
>   ql/src/test/results/clientpositive/vectorization_17.q.out 7104ae50ee 
>   ql/src/test/results/clientpositive/vectorization_4.q.out ee618691b5 
>   ql/src/test/results/clientpositive/vectorization_6.q.out f2204fc636 
>   ql/src/test/results/clientpositive/vectorization_7.q.out 51d2b45a20 
>   ql/src/test/results/clientpositive/vectorization_numeric_overflows.q.out 344db2b897 
>   ql/src/test/results/clientpositive/vectorized_case.q.out b89fa511df 
>   ql/src/test/results/clientpositive/vectorized_casts.q.out f6f210533f 
>   ql/src/test/results/clientpositive/vectorized_date_funcs.q.out 298d92bdcd 
>   ql/src/test/results/clientpositive/vectorized_timestamp.q.out 6c49e038a3 
>   ql/src/test/results/clientpositive/vectorized_timestamp_ints_casts.q.out a203507512 
>   ql/src/test/results/clientpositive/view_cbo.q.out 2fafa4fe22 
> 
> 
> Diff: https://reviews.apache.org/r/65801/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>


Re: Review Request 65801: HIVE-18797 ExprConstNodeDesc's getExprString should put appropriate qualifier with literals

Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65801/
-----------------------------------------------------------

(Updated Feb. 26, 2018, 1:03 a.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-18797
    https://issues.apache.org/jira/browse/HIVE-18797


Repository: hive-git


Description
-------

See JIRA


Diffs (updated)
-----

  hbase-handler/src/test/results/positive/hbase_timestamp.q.out e719b087d4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java 73f449fc28 
  ql/src/test/results/clientpositive/annotate_stats_deep_filters.q.out ab8c22b9be 
  ql/src/test/results/clientpositive/annotate_stats_groupby.q.out 25efe1e1f4 
  ql/src/test/results/clientpositive/annotate_stats_groupby2.q.out 78c4808f5f 
  ql/src/test/results/clientpositive/annotate_stats_select.q.out 9aaa6f68a2 
  ql/src/test/results/clientpositive/cast_on_constant.q.out 7f920f41af 
  ql/src/test/results/clientpositive/constant_prop_3.q.out b754f8e7b4 
  ql/src/test/results/clientpositive/constantfolding.q.out c4fce25e41 
  ql/src/test/results/clientpositive/constprog_type.q.out 27ef1f482b 
  ql/src/test/results/clientpositive/druid_basic2.q.out 08b64d6d82 
  ql/src/test/results/clientpositive/druid_basic3.q.out ce6d0aafed 
  ql/src/test/results/clientpositive/druid_intervals.q.out c94cbe9bd4 
  ql/src/test/results/clientpositive/druid_timeseries.q.out 785cbd2114 
  ql/src/test/results/clientpositive/druid_topn.q.out 90eec3dd49 
  ql/src/test/results/clientpositive/except_all.q.out c3310f5154 
  ql/src/test/results/clientpositive/extrapolate_part_stats_date.q.out 8fea7fdf44 
  ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out 49e0d35d39 
  ql/src/test/results/clientpositive/groupby_cube1.q.out 37b8c62edd 
  ql/src/test/results/clientpositive/groupby_cube_multi_gby.q.out e6126ab2c6 
  ql/src/test/results/clientpositive/groupby_grouping_id3.q.out ac43413400 
  ql/src/test/results/clientpositive/groupby_grouping_sets1.q.out 62fc9fb550 
  ql/src/test/results/clientpositive/groupby_grouping_sets2.q.out 43e17ec6bc 
  ql/src/test/results/clientpositive/groupby_grouping_sets3.q.out 352d4beb9f 
  ql/src/test/results/clientpositive/groupby_grouping_sets4.q.out e368e1ee12 
  ql/src/test/results/clientpositive/groupby_grouping_sets5.q.out 1766fb9bbc 
  ql/src/test/results/clientpositive/groupby_grouping_sets6.q.out 563b110a11 
  ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out 1f2cd456c8 
  ql/src/test/results/clientpositive/groupby_grouping_sets_limit.q.out efa1802855 
  ql/src/test/results/clientpositive/groupby_grouping_window.q.out 0f58f5182a 
  ql/src/test/results/clientpositive/groupby_rollup1.q.out a849a8d368 
  ql/src/test/results/clientpositive/groupby_rollup_empty.q.out dd53fe2140 
  ql/src/test/results/clientpositive/having.q.out 8a630751bb 
  ql/src/test/results/clientpositive/having2.q.out 67f8af8328 
  ql/src/test/results/clientpositive/implicit_cast1.q.out 6e1706a8a3 
  ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out 72249383ee 
  ql/src/test/results/clientpositive/infer_const_type.q.out 647c910241 
  ql/src/test/results/clientpositive/interval_alt.q.out 53c1be8d05 
  ql/src/test/results/clientpositive/interval_arithmetic.q.out eba97face9 
  ql/src/test/results/clientpositive/limit_pushdown2.q.out f4cff2bcc0 
  ql/src/test/results/clientpositive/literal_ints.q.out 9a56ebd5eb 
  ql/src/test/results/clientpositive/llap/acid_vectorization_original.q.out 68801f0294 
  ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out 98ede4e995 
  ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_3.q.out aca6b21dba 
  ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out 15a97a78c1 
  ql/src/test/results/clientpositive/llap/dynpart_sort_optimization.q.out 78b9a443b8 
  ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out 7b1dd40a16 
  ql/src/test/results/clientpositive/llap/except_distinct.q.out 1e5937a22d 
  ql/src/test/results/clientpositive/llap/explainuser_1.q.out 43ca0d9ad7 
  ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.out 24be36ea36 
  ql/src/test/results/clientpositive/llap/having.q.out 75de96ab59 
  ql/src/test/results/clientpositive/llap/intersect_all.q.out 20a234e53b 
  ql/src/test/results/clientpositive/llap/intersect_distinct.q.out a5384eb196 
  ql/src/test/results/clientpositive/llap/intersect_merge.q.out 6f0e7f1f66 
  ql/src/test/results/clientpositive/llap/lineage2.q.out 4f59a4d59b 
  ql/src/test/results/clientpositive/llap/lineage3.q.out ca4405caf7 
  ql/src/test/results/clientpositive/llap/mrr.q.out bfa26e4ff8 
  ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out 66bf74f15a 
  ql/src/test/results/clientpositive/llap/orc_merge5.q.out 6eba365ff2 
  ql/src/test/results/clientpositive/llap/orc_merge6.q.out 1583007d7b 
  ql/src/test/results/clientpositive/llap/orc_merge_incompat1.q.out 0e9b34f8ec 
  ql/src/test/results/clientpositive/llap/orc_predicate_pushdown.q.out 9f20f77cb0 
  ql/src/test/results/clientpositive/llap/parquet_predicate_pushdown.q.out 6885346539 
  ql/src/test/results/clientpositive/llap/sqlmerge.q.out 2ff590ea0c 
  ql/src/test/results/clientpositive/llap/subquery_in.q.out b5f9641502 
  ql/src/test/results/clientpositive/llap/subquery_in_having.q.out cc0b6a597a 
  ql/src/test/results/clientpositive/llap/subquery_multi.q.out 67a22c812f 
  ql/src/test/results/clientpositive/llap/subquery_notin.q.out 50c18c8a68 
  ql/src/test/results/clientpositive/llap/subquery_null_agg.q.out cff9568406 
  ql/src/test/results/clientpositive/llap/subquery_scalar.q.out cec3daa085 
  ql/src/test/results/clientpositive/llap/subquery_select.q.out 89eab37d07 
  ql/src/test/results/clientpositive/llap/subquery_views.q.out 01a86d1300 
  ql/src/test/results/clientpositive/llap/tez_dynpart_hashjoin_2.q.out 642bda2736 
  ql/src/test/results/clientpositive/llap/tez_union_group_by.q.out 79321c1460 
  ql/src/test/results/clientpositive/llap/tez_vector_dynpart_hashjoin_2.q.out 1ce7a3a37c 
  ql/src/test/results/clientpositive/llap/vector_between_in.q.out f4f87ae0ee 
  ql/src/test/results/clientpositive/llap/vector_date_1.q.out bacd667498 
  ql/src/test/results/clientpositive/llap/vector_decimal_aggregate.q.out 5cb3e6678f 
  ql/src/test/results/clientpositive/llap/vector_elt.q.out 24a1a65022 
  ql/src/test/results/clientpositive/llap/vector_groupby_cube1.q.out 04ac09b0a6 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id1.q.out fd9dacbb12 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id2.q.out 74f6289fb0 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id3.q.out da4ba84c46 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets1.q.out 137e06a5b5 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out d8da29ac36 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3.q.out 79116112da 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3_dec.q.out 8d2247d42e 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets4.q.out 55c18fa2f1 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets5.q.out 4e579888e6 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets6.q.out 83c7ad8f00 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_grouping.q.out 8dd5cf074c 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_limit.q.out f7f3014a7f 
  ql/src/test/results/clientpositive/llap/vector_groupby_grouping_window.q.out 9374bcc27a 
  ql/src/test/results/clientpositive/llap/vector_groupby_mapjoin.q.out 82b6ba0a09 
  ql/src/test/results/clientpositive/llap/vector_groupby_rollup1.q.out 717c218da9 
  ql/src/test/results/clientpositive/llap/vector_grouping_sets.q.out 172e003af6 
  ql/src/test/results/clientpositive/llap/vector_interval_1.q.out 7d891db4ef 
  ql/src/test/results/clientpositive/llap/vector_interval_2.q.out 7548686c50 
  ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out f2a4d3a855 
  ql/src/test/results/clientpositive/llap/vector_number_compare_projection.q.out cd2e1e4c42 
  ql/src/test/results/clientpositive/llap/vector_ptf_part_simple.q.out 16b59e612c 
  ql/src/test/results/clientpositive/llap/vector_reuse_scratchcols.q.out b9c1ba31e8 
  ql/src/test/results/clientpositive/llap/vector_struct_in.q.out 4af1015fe7 
  ql/src/test/results/clientpositive/llap/vector_udf_adaptor_1.q.out a752dfadd4 
  ql/src/test/results/clientpositive/llap/vector_windowing_navfn.q.out 8dc3fa7764 
  ql/src/test/results/clientpositive/llap/vector_windowing_rank.q.out aa47b1bf75 
  ql/src/test/results/clientpositive/llap/vector_windowing_streaming.q.out 2c54027bed 
  ql/src/test/results/clientpositive/llap/vectorization_14.q.out c7a32e3a7e 
  ql/src/test/results/clientpositive/llap/vectorization_17.q.out bdcb1ebfee 
  ql/src/test/results/clientpositive/llap/vectorization_4.q.out a2142b716d 
  ql/src/test/results/clientpositive/llap/vectorization_6.q.out 84b9260c18 
  ql/src/test/results/clientpositive/llap/vectorization_7.q.out 3c7522912d 
  ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out bd5e284523 
  ql/src/test/results/clientpositive/llap/vectorized_case.q.out ed17e5c5f1 
  ql/src/test/results/clientpositive/llap/vectorized_casts.q.out 84b4d9454d 
  ql/src/test/results/clientpositive/llap/vectorized_date_funcs.q.out db292508ac 
  ql/src/test/results/clientpositive/llap/vectorized_timestamp.q.out 9652d36b20 
  ql/src/test/results/clientpositive/llap/vectorized_timestamp_ints_casts.q.out c346ff2cf8 
  ql/src/test/results/clientpositive/num_op_type_conv.q.out 8e714f4ad7 
  ql/src/test/results/clientpositive/orc_merge5.q.out 970c4ddad9 
  ql/src/test/results/clientpositive/orc_merge6.q.out a08eb09cee 
  ql/src/test/results/clientpositive/orc_merge_incompat1.q.out e8d504a9cb 
  ql/src/test/results/clientpositive/parquet_vectorization_14.q.out f127434557 
  ql/src/test/results/clientpositive/parquet_vectorization_17.q.out 8f26d41a48 
  ql/src/test/results/clientpositive/parquet_vectorization_4.q.out 4c39858751 
  ql/src/test/results/clientpositive/parquet_vectorization_6.q.out 3d7d5e3c85 
  ql/src/test/results/clientpositive/parquet_vectorization_7.q.out 77caa03107 
  ql/src/test/results/clientpositive/parquet_vectorization_div0.q.out 4a5cca6d22 
  ql/src/test/results/clientpositive/perf/spark/query12.q.out d1796248f2 
  ql/src/test/results/clientpositive/perf/spark/query16.q.out 1b763e278e 
  ql/src/test/results/clientpositive/perf/spark/query18.q.out 33b2f62386 
  ql/src/test/results/clientpositive/perf/spark/query20.q.out ab1b24dbf9 
  ql/src/test/results/clientpositive/perf/spark/query21.q.out e73a627332 
  ql/src/test/results/clientpositive/perf/spark/query22.q.out 38e4119afc 
  ql/src/test/results/clientpositive/perf/spark/query23.q.out 8b5a83a58a 
  ql/src/test/results/clientpositive/perf/spark/query27.q.out a87ec45c11 
  ql/src/test/results/clientpositive/perf/spark/query32.q.out e7d356d257 
  ql/src/test/results/clientpositive/perf/spark/query36.q.out 1a1a991b96 
  ql/src/test/results/clientpositive/perf/spark/query37.q.out d8bff8173d 
  ql/src/test/results/clientpositive/perf/spark/query38.q.out b9af9642b5 
  ql/src/test/results/clientpositive/perf/spark/query40.q.out ab196dcb5d 
  ql/src/test/results/clientpositive/perf/spark/query45.q.out 07af4e2e4b 
  ql/src/test/results/clientpositive/perf/spark/query5.q.out 1ba37e050f 
  ql/src/test/results/clientpositive/perf/spark/query6.q.out 126cf9e11c 
  ql/src/test/results/clientpositive/perf/spark/query67.q.out b0fc41c7a2 
  ql/src/test/results/clientpositive/perf/spark/query70.q.out 7ebb776719 
  ql/src/test/results/clientpositive/perf/spark/query77.q.out 9a77a7b8b4 
  ql/src/test/results/clientpositive/perf/spark/query8.q.out 13cd0f4ab6 
  ql/src/test/results/clientpositive/perf/spark/query80.q.out ee769f9b95 
  ql/src/test/results/clientpositive/perf/spark/query82.q.out b45f8d0bfb 
  ql/src/test/results/clientpositive/perf/spark/query86.q.out 80a24d3dd7 
  ql/src/test/results/clientpositive/perf/spark/query87.q.out 5fe3e48dfc 
  ql/src/test/results/clientpositive/perf/spark/query9.q.out 4ec20070f7 
  ql/src/test/results/clientpositive/perf/spark/query92.q.out 677a85cea1 
  ql/src/test/results/clientpositive/perf/spark/query94.q.out 39c4476a5c 
  ql/src/test/results/clientpositive/perf/spark/query95.q.out 0d136b6da7 
  ql/src/test/results/clientpositive/perf/spark/query98.q.out 24d7de8b71 
  ql/src/test/results/clientpositive/perf/tez/query12.q.out 0506eca00d 
  ql/src/test/results/clientpositive/perf/tez/query14.q.out ef44cdbb6d 
  ql/src/test/results/clientpositive/perf/tez/query16.q.out 1c0539199e 
  ql/src/test/results/clientpositive/perf/tez/query18.q.out 1f0ec90b41 
  ql/src/test/results/clientpositive/perf/tez/query20.q.out c07141b368 
  ql/src/test/results/clientpositive/perf/tez/query21.q.out aed0990277 
  ql/src/test/results/clientpositive/perf/tez/query22.q.out d13169c25c 
  ql/src/test/results/clientpositive/perf/tez/query23.q.out c7a5041861 
  ql/src/test/results/clientpositive/perf/tez/query27.q.out c6a190553e 
  ql/src/test/results/clientpositive/perf/tez/query32.q.out 3ad9595910 
  ql/src/test/results/clientpositive/perf/tez/query36.q.out a30ac2e53c 
  ql/src/test/results/clientpositive/perf/tez/query37.q.out d5af964b0a 
  ql/src/test/results/clientpositive/perf/tez/query38.q.out 199bed7de5 
  ql/src/test/results/clientpositive/perf/tez/query40.q.out 604f741279 
  ql/src/test/results/clientpositive/perf/tez/query45.q.out 3efed2e0e1 
  ql/src/test/results/clientpositive/perf/tez/query5.q.out ff197d2871 
  ql/src/test/results/clientpositive/perf/tez/query6.q.out f1e47581b4 
  ql/src/test/results/clientpositive/perf/tez/query67.q.out 86c4d7ce14 
  ql/src/test/results/clientpositive/perf/tez/query70.q.out d5ad6e5fcc 
  ql/src/test/results/clientpositive/perf/tez/query77.q.out d10e2266b3 
  ql/src/test/results/clientpositive/perf/tez/query8.q.out 8660fc9c57 
  ql/src/test/results/clientpositive/perf/tez/query80.q.out a64cad7389 
  ql/src/test/results/clientpositive/perf/tez/query82.q.out 037c2ffc2c 
  ql/src/test/results/clientpositive/perf/tez/query86.q.out be7e858e22 
  ql/src/test/results/clientpositive/perf/tez/query87.q.out 8430e8ad60 
  ql/src/test/results/clientpositive/perf/tez/query92.q.out fbb4eb3a55 
  ql/src/test/results/clientpositive/perf/tez/query94.q.out e18d45b15f 
  ql/src/test/results/clientpositive/perf/tez/query95.q.out 15920d9751 
  ql/src/test/results/clientpositive/perf/tez/query98.q.out da534cdcd3 
  ql/src/test/results/clientpositive/ppd2.q.out 43119be016 
  ql/src/test/results/clientpositive/ppd_gby.q.out c21e5a3435 
  ql/src/test/results/clientpositive/ppd_gby2.q.out c65e5c9a4a 
  ql/src/test/results/clientpositive/ppd_vc.q.out 1569cf62b7 
  ql/src/test/results/clientpositive/results_cache_2.q.out ab1b0de9c0 
  ql/src/test/results/clientpositive/semijoin4.q.out 46d1d3f37b 
  ql/src/test/results/clientpositive/setop_subq.q.out ac20c4c422 
  ql/src/test/results/clientpositive/spark/groupby_cube1.q.out 71ccea5507 
  ql/src/test/results/clientpositive/spark/groupby_rollup1.q.out cf3721df04 
  ql/src/test/results/clientpositive/spark/having.q.out 2876e67f06 
  ql/src/test/results/clientpositive/spark/limit_pushdown2.q.out 3bd49b4c77 
  ql/src/test/results/clientpositive/spark/orc_merge5.q.out c6f06add8a 
  ql/src/test/results/clientpositive/spark/orc_merge6.q.out 5c3b25e035 
  ql/src/test/results/clientpositive/spark/orc_merge_incompat1.q.out d97ac66af3 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_14.q.out f5b2896102 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_17.q.out a5ef4ae3f8 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_4.q.out 1d0de537d9 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_6.q.out b74f56b9ef 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_7.q.out f01e80854e 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_div0.q.out 5ba7587b89 
  ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out ebd8d8692c 
  ql/src/test/results/clientpositive/spark/subquery_in.q.out 5e48a5cb7d 
  ql/src/test/results/clientpositive/spark/subquery_multi.q.out 3764d92b3b 
  ql/src/test/results/clientpositive/spark/subquery_multiinsert.q.out 5b4aa49900 
  ql/src/test/results/clientpositive/spark/subquery_notin.q.out e2f26a977f 
  ql/src/test/results/clientpositive/spark/subquery_null_agg.q.out 4cfce1033c 
  ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 77359a0197 
  ql/src/test/results/clientpositive/spark/subquery_select.q.out e36c74a91c 
  ql/src/test/results/clientpositive/spark/subquery_views.q.out 14be0186dd 
  ql/src/test/results/clientpositive/spark/union_remove_10.q.out 9bdcaf656a 
  ql/src/test/results/clientpositive/spark/union_remove_12.q.out cf89dab3f8 
  ql/src/test/results/clientpositive/spark/union_remove_14.q.out cf89dab3f8 
  ql/src/test/results/clientpositive/spark/union_remove_2.q.out 5fa05a9a0c 
  ql/src/test/results/clientpositive/spark/union_remove_5.q.out 3d311eae36 
  ql/src/test/results/clientpositive/spark/union_remove_6_subq.q.out 3034bd1cde 
  ql/src/test/results/clientpositive/spark/union_remove_8.q.out 9d651ed9ea 
  ql/src/test/results/clientpositive/spark/vector_between_in.q.out 75397d7d7d 
  ql/src/test/results/clientpositive/spark/vector_decimal_aggregate.q.out bbe9431571 
  ql/src/test/results/clientpositive/spark/vector_elt.q.out b717fda722 
  ql/src/test/results/clientpositive/spark/vectorization_14.q.out 6fa51e53f7 
  ql/src/test/results/clientpositive/spark/vectorization_17.q.out 851c1806b5 
  ql/src/test/results/clientpositive/spark/vectorization_4.q.out 436fdd9efc 
  ql/src/test/results/clientpositive/spark/vectorization_6.q.out b16d7b0645 
  ql/src/test/results/clientpositive/spark/vectorization_div0.q.out 530bdf6069 
  ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out 9683efa1d4 
  ql/src/test/results/clientpositive/spark/vectorized_case.q.out 8fff1ed7ba 
  ql/src/test/results/clientpositive/subquery_multiinsert.q.out 381550a006 
  ql/src/test/results/clientpositive/subquery_notin_having.q.out 74239031f6 
  ql/src/test/results/clientpositive/subquery_unqual_corr_expr.q.out 2507d52c0f 
  ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out bfb5d2b0a6 
  ql/src/test/results/clientpositive/tez/acid_vectorization_original_tez.q.out 50c53d0972 
  ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out a1ea37a682 
  ql/src/test/results/clientpositive/tez/explainuser_3.q.out c6cf6803b5 
  ql/src/test/results/clientpositive/tez/multi_count_distinct.q.out 5f5a8523b8 
  ql/src/test/results/clientpositive/tez/vectorization_div0.q.out 4afe85c30c 
  ql/src/test/results/clientpositive/timestamp.q.out 9d0ceef50f 
  ql/src/test/results/clientpositive/timestamp_ints_casts.q.out bc5ceb3f30 
  ql/src/test/results/clientpositive/timestamp_literal.q.out 4e069695f4 
  ql/src/test/results/clientpositive/timestamptz.q.out 7cff9a5c23 
  ql/src/test/results/clientpositive/type_widening.q.out 30e556477e 
  ql/src/test/results/clientpositive/udf4.q.out 5d263ebf68 
  ql/src/test/results/clientpositive/udf5.q.out 3fa801a078 
  ql/src/test/results/clientpositive/udf6.q.out 4193d340e4 
  ql/src/test/results/clientpositive/udf9.q.out a9bd954bfc 
  ql/src/test/results/clientpositive/udf_abs.q.out 5a8c4d7cfd 
  ql/src/test/results/clientpositive/udf_crc32.q.out 5d2888ac0a 
  ql/src/test/results/clientpositive/udf_factorial.q.out d6757aa194 
  ql/src/test/results/clientpositive/udf_folder_constants.q.out 70a8c0197c 
  ql/src/test/results/clientpositive/udf_from_utc_timestamp.q.out f00e3a1108 
  ql/src/test/results/clientpositive/udf_if.q.out eac4fe3e2b 
  ql/src/test/results/clientpositive/udf_reflect2.q.out a1074f8a81 
  ql/src/test/results/clientpositive/udf_to_utc_timestamp.q.out 7bd9aaf6e1 
  ql/src/test/results/clientpositive/union_pos_alias.q.out 65e736f3ed 
  ql/src/test/results/clientpositive/union_remove_10.q.out f1f2dd692d 
  ql/src/test/results/clientpositive/union_remove_12.q.out 702aef8aaf 
  ql/src/test/results/clientpositive/union_remove_14.q.out 702aef8aaf 
  ql/src/test/results/clientpositive/union_remove_2.q.out 0b84fb0c18 
  ql/src/test/results/clientpositive/union_remove_5.q.out efe59a12d2 
  ql/src/test/results/clientpositive/union_remove_6_subq.q.out 742e5b19db 
  ql/src/test/results/clientpositive/union_remove_8.q.out 2093fe6a0a 
  ql/src/test/results/clientpositive/vector_date_1.q.out 93f9a7116d 
  ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2f7ce319ae 
  ql/src/test/results/clientpositive/vector_elt.q.out 0b51d83d7b 
  ql/src/test/results/clientpositive/vector_groupby_mapjoin.q.out 0815bdb5ff 
  ql/src/test/results/clientpositive/vector_grouping_sets.q.out fc8290e72e 
  ql/src/test/results/clientpositive/vector_interval_1.q.out 1c7df24651 
  ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out 3ab7467df8 
  ql/src/test/results/clientpositive/vector_struct_in.q.out 773908b6a6 
  ql/src/test/results/clientpositive/vectorization_14.q.out 0a0c5fba8b 
  ql/src/test/results/clientpositive/vectorization_17.q.out 7104ae50ee 
  ql/src/test/results/clientpositive/vectorization_4.q.out ee618691b5 
  ql/src/test/results/clientpositive/vectorization_6.q.out f2204fc636 
  ql/src/test/results/clientpositive/vectorization_7.q.out 51d2b45a20 
  ql/src/test/results/clientpositive/vectorization_numeric_overflows.q.out 344db2b897 
  ql/src/test/results/clientpositive/vectorized_case.q.out b89fa511df 
  ql/src/test/results/clientpositive/vectorized_casts.q.out f6f210533f 
  ql/src/test/results/clientpositive/vectorized_date_funcs.q.out 298d92bdcd 
  ql/src/test/results/clientpositive/vectorized_timestamp.q.out 6c49e038a3 
  ql/src/test/results/clientpositive/vectorized_timestamp_ints_casts.q.out a203507512 
  ql/src/test/results/clientpositive/view_cbo.q.out 2fafa4fe22 


Diff: https://reviews.apache.org/r/65801/diff/2/

Changes: https://reviews.apache.org/r/65801/diff/1-2/


Testing
-------


Thanks,

Vineet Garg