You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by qingwen220 <gi...@git.apache.org> on 2016/03/03 09:45:47 UTC

[GitHub] incubator-eagle pull request: EAGLE-177 Replace Legacy "dataSource...

GitHub user qingwen220 opened a pull request:

    https://github.com/apache/incubator-eagle/pull/108

    EAGLE-177 Replace Legacy "dataSource" field with "application" in all metadata

    https://issues.apache.org/jira/browse/EAGLE-177

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/qingwen220/incubator-eagle EAGLE-177

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #108
    
----
commit 4a545c8d1dd99e7cd2301fa95afa070090fae5ce
Author: Zhao, Qingwen <qi...@ebay.com>
Date:   2016-03-03T03:34:32Z

    replace dataSource with application

commit c8f695d451363d19d7a68c633a469ecfce658c27
Author: Zhao, Qingwen <qi...@ebay.com>
Date:   2016-03-01T09:47:52Z

    change tag dataSource to application

commit 3e8c5cfdf32dc8cf992b891b0f46d13f309ced73
Author: jiljiang <ji...@ebay.com>
Date:   2016-03-03T03:38:11Z

    rename dataSrc to application

commit 33dec8f9e92995e205a51f2247a94a95d2105748
Author: jiljiang <ji...@ebay.com>
Date:   2016-03-03T03:38:11Z

    rename dataSrc to application

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-177 Replace Legacy "dataSource...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-eagle/pull/108


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-177 Replace Legacy "dataSource...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the pull request:

    https://github.com/apache/incubator-eagle/pull/108#issuecomment-191866196
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-177 Replace Legacy "dataSource...

Posted by RalphSu <gi...@git.apache.org>.
Github user RalphSu commented on the pull request:

    https://github.com/apache/incubator-eagle/pull/108#issuecomment-191681816
  
    +1 
    Unit runs ok for me. 
    Be careful this would be incompatible for existing deployment if one already deployed. The one who already load the format of old version, will need
    a. Drop the old metadata that have the concept of datasource
    b. Recreate the metadata (for hadoop cases, re-run the sh files to create them)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---