You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/23 15:13:07 UTC

[GitHub] [skywalking] dmsolr commented on a change in pull request #5352: [plugin/test] Plugin test with jdk14

dmsolr commented on a change in pull request #5352:
URL: https://github.com/apache/skywalking/pull/5352#discussion_r475230982



##########
File path: test/plugin/containers/jvm-container/src/main/docker/run.sh
##########
@@ -16,7 +16,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-[[ -n $DEBUG_MODE ]] && set -ex
+[[ -n $DEBUG_MODE ]] && export

Review comment:
       In fact, it still should be needed. But process will exit directly [this](https://github.com/apache/skywalking/blob/763caf337037a1a4c0d2ccb76832e10edca17b1c/test/plugin/containers/jvm-container/src/main/docker/run.sh#L88) when `set -ex` is enabled.
   
   The process will exit why the result os the command executed is non-zero.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org