You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Reiss (JIRA)" <ji...@apache.org> on 2009/01/10 02:07:59 UTC
[jira] Commented: (THRIFT-252) Python libraries unable to build
with MSVC on Windows
[ https://issues.apache.org/jira/browse/THRIFT-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662590#action_12662590 ]
David Reiss commented on THRIFT-252:
------------------------------------
Including the Windows stuff inline is fine with me since it is isolated.
What is the purpose of this change?
{noformat}
+ PyObject* ret = NULL;
if (!parse_struct_args(&parsedargs, typeargs)) {
return NULL;
}
- PyObject* ret = PyObject_CallObject(parsedargs.klass, NULL);
+ (PyObject*) ret = PyObject_CallObject(parsedargs.klass, NULL);
{noformat}
{noformat}
- DecodeBuffer input = {};
+ DecodeBuffer input;
{noformat}
When I commit this, I'll split out the stuff that is not related to windows support as separate commits, since they really are not related to this issue.
> Python libraries unable to build with MSVC on Windows
> -----------------------------------------------------
>
> Key: THRIFT-252
> URL: https://issues.apache.org/jira/browse/THRIFT-252
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Python)
> Environment: Windows XP or Vista, Visual C++ 2008 (and likely others)
> Reporter: Michael Greene
> Assignee: Michael Greene
> Attachments: thrift-252-python-msvc-1.diff
>
>
> This patch adds support for Visual C++ on Windows to the Python libraries. stdbool and stdint are not available on MSVC, so alternates were defined. netinet is replaced with winsock2.
> Additionally, setup.py is updated to support this platform and with the latest project information.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.