You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/27 15:04:10 UTC

[GitHub] HeartSaVioR edited a comment on issue #23811: [SPARK-26902][SQL] Support java.time.Instant as an external type of TimestampType

HeartSaVioR edited a comment on issue #23811: [SPARK-26902][SQL] Support java.time.Instant as an external type of TimestampType
URL: https://github.com/apache/spark/pull/23811#issuecomment-467895365
 
 
   @MaxGekk 
   Just curious, is there specific reason for Instant serializer to be added only for `ScalaReflection`? I haven't find same for JavaTypeInference so just would like to see whether it is just missing spot or intended to exclude it.
   
   FYI: I'm proposing the same refactoring for `serializerFor` as well (#23908) and just aware of this PR while rebasing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org