You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Petr Kozelka (JIRA)" <ji...@codehaus.org> on 2011/11/20 20:05:39 UTC

[jira] Created: (SCM-646) git parser should fill changeset revision

git parser should fill changeset revision
-----------------------------------------

                 Key: SCM-646
                 URL: https://jira.codehaus.org/browse/SCM-646
             Project: Maven SCM
          Issue Type: Bug
          Components: maven-scm-provider-git
    Affects Versions: 1.5
            Reporter: Petr Kozelka
         Attachments: SCM-git-changeset-revision.patch

Current implementation of GitChangeLogConsumer fills revision on each ChangeFile but not on its containing ChangeSet - where it IMHO naturally belongs.

I fixed this on GitHub and submitted a pull request here:
https://github.com/apache/maven-scm/pull/1

I guess that Apache does not process Github pull-requests yet so I am attaching the patch also here.
In this patch, also unittest is extended to cover checking changeset revision as well.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (SCM-646) git parser should fill changeset revision

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/SCM-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy closed SCM-646.
----------------------------

       Resolution: Fixed
    Fix Version/s: 1.6
         Assignee: Olivier Lamy

fixed r1204846
Thanks!

> git parser should fill changeset revision
> -----------------------------------------
>
>                 Key: SCM-646
>                 URL: https://jira.codehaus.org/browse/SCM-646
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-git
>    Affects Versions: 1.5
>            Reporter: Petr Kozelka
>            Assignee: Olivier Lamy
>             Fix For: 1.6
>
>         Attachments: SCM-git-changeset-revision.patch
>
>
> Current implementation of GitChangeLogConsumer fills revision on each ChangeFile but not on its containing ChangeSet - where it IMHO naturally belongs.
> I fixed this on GitHub and submitted a pull request here:
> https://github.com/apache/maven-scm/pull/1
> I guess that Apache does not process Github pull-requests yet so I am attaching the patch also here.
> In this patch, also unittest is extended to cover checking changeset revision as well.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira