You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/03/13 21:47:52 UTC
[kudu-CR] [util] fix flakiness in threadpool-test
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22622
Change subject: [util] fix flakiness in threadpool-test
......................................................................
[util] fix flakiness in threadpool-test
There were reports about a few test scenarios failing intermittently
with errors like below on a very busy machine:
[ RUN ] ThreadPoolTest.TestThreadPoolWithNoMinimum
/root/Projects/kudu/src/kudu/util/threadpool-test.cc:317: Failure
Expected equality of these values:
0
pool_->num_threads()
Which is: 1
[ RUN ] ThreadPoolTest.TestVariableSizeThreadPool
/root/Projects/kudu/src/kudu/util/threadpool-test.cc:459: Failure
Expected equality of these values:
1
pool_->num_threads()
Which is: 2
This patch fixes the issue, removing implicit assumptions on timings
of events that might not be true in the presence of scheduled anomalies.
This is a follow-up to fc8615c37eb4e28f3cc6bea0fcd5a8732451e883.
Change-Id: I8caed555b2207d25a93105037d77bd579d160550
---
M src/kudu/util/threadpool-test.cc
1 file changed, 11 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/22622/1
--
To view, visit http://gerrit.cloudera.org:8080/22622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8caed555b2207d25a93105037d77bd579d160550
Gerrit-Change-Number: 22622
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [util] fix flakiness in threadpool-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [util] fix flakiness in threadpool-test
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I8caed555b2207d25a93105037d77bd579d160550
Gerrit-Change-Number: 22622
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [util] fix flakiness in threadpool-test
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22622 )
Change subject: [util] fix flakiness in threadpool-test
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1171/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8caed555b2207d25a93105037d77bd579d160550
Gerrit-Change-Number: 22622
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 13 Mar 2025 23:08:00 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fix flakiness in threadpool-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22622 )
Change subject: [util] fix flakiness in threadpool-test
......................................................................
Patch Set 1: Verified+1
unrelated failures of flaky java tests:
* TSAN: org.apache.kudu.client.TestKuduClient
--
To view, visit http://gerrit.cloudera.org:8080/22622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8caed555b2207d25a93105037d77bd579d160550
Gerrit-Change-Number: 22622
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 13 Mar 2025 23:09:40 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fix flakiness in threadpool-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22622 )
Change subject: [util] fix flakiness in threadpool-test
......................................................................
[util] fix flakiness in threadpool-test
There were reports about a few test scenarios failing intermittently
with errors like below on a very busy machine:
[ RUN ] ThreadPoolTest.TestThreadPoolWithNoMinimum
/root/Projects/kudu/src/kudu/util/threadpool-test.cc:317: Failure
Expected equality of these values:
0
pool_->num_threads()
Which is: 1
[ RUN ] ThreadPoolTest.TestVariableSizeThreadPool
/root/Projects/kudu/src/kudu/util/threadpool-test.cc:459: Failure
Expected equality of these values:
1
pool_->num_threads()
Which is: 2
This patch fixes the issue, removing implicit assumptions on timings
of events that might not be true in the presence of scheduled anomalies.
This is a follow-up to fc8615c37eb4e28f3cc6bea0fcd5a8732451e883.
Change-Id: I8caed555b2207d25a93105037d77bd579d160550
Reviewed-on: http://gerrit.cloudera.org:8080/22622
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/util/threadpool-test.cc
1 file changed, 11 insertions(+), 12 deletions(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8caed555b2207d25a93105037d77bd579d160550
Gerrit-Change-Number: 22622
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [util] fix flakiness in threadpool-test
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22622 )
Change subject: [util] fix flakiness in threadpool-test
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1171/
--
To view, visit http://gerrit.cloudera.org:8080/22622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8caed555b2207d25a93105037d77bd579d160550
Gerrit-Change-Number: 22622
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 13 Mar 2025 21:47:58 +0000
Gerrit-HasComments: No
[kudu-CR] [util] fix flakiness in threadpool-test
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22622 )
Change subject: [util] fix flakiness in threadpool-test
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8caed555b2207d25a93105037d77bd579d160550
Gerrit-Change-Number: 22622
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 05:02:26 +0000
Gerrit-HasComments: No