You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by shinrich <gi...@git.apache.org> on 2015/07/07 03:16:43 UTC
[GitHub] trafficserver pull request: TS-3742: ATS incorrectly advertises TL...
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/241
TS-3742: ATS incorrectly advertises TLS ticket extension.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-3742
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #241
----
commit 1e4c0a22a125c4e52947315dfa0d98f9e169adab
Author: shinrich <sh...@yahoo-inc.com>
Date: 2015-07-07T01:15:16Z
TS-3742: ATS incorrectly advertises TLS ticket extension.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3742: ATS incorrectly advertises TL...
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/241#discussion_r34001015
--- Diff: iocore/net/SSLUtils.cc ---
@@ -308,8 +308,10 @@ set_context_cert(SSL *ssl)
if (ctx != NULL) {
SSL_set_SSL_CTX(ssl, ctx);
#if HAVE_OPENSSL_SESSION_TICKETS
- // Reset the ticket callback if needed
- SSL_CTX_set_tlsext_ticket_key_cb(ctx, ssl_callback_session_ticket);
+ if (SSL_CTX_get_options(ctx) & SSL_OP_NO_TICKET) {
--- End diff --
I'm not sure this is correct:
SSL_OP_NO_TICKET
Normally clients and servers will, where possible, transparently make use of RFC4507bis tickets for stateless session resumption.
If this option is set this functionality is disabled and tickets will not be used by clients or servers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3742: ATS incorrectly advertises TL...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/241#discussion_r34028929
--- Diff: iocore/net/SSLUtils.cc ---
@@ -308,8 +308,10 @@ set_context_cert(SSL *ssl)
if (ctx != NULL) {
SSL_set_SSL_CTX(ssl, ctx);
#if HAVE_OPENSSL_SESSION_TICKETS
- // Reset the ticket callback if needed
- SSL_CTX_set_tlsext_ticket_key_cb(ctx, ssl_callback_session_ticket);
+ if (SSL_CTX_get_options(ctx) & SSL_OP_NO_TICKET) {
--- End diff --
That does seem backwards, doesn't it. Will track it down.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3742: ATS incorrectly advertises TL...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/241
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3742: ATS incorrectly advertises TL...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/241#issuecomment-119198776
Turns out no code change is needed. See comments on issue for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---