You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/22 22:13:47 UTC

[GitHub] [airflow] jedcunningham opened a new pull request, #28544: Add back join to zombie query that was dropped in #28198

jedcunningham opened a new pull request, #28544:
URL: https://github.com/apache/airflow/pull/28544

   #28198 accidentally dropped a join in a query, leading to this:
   
       airflow/jobs/scheduler_job.py:1547 SAWarning: SELECT statement has a
       cartesian product between FROM eleme
       nt(s) "dag_run_1", "task_instance", "job" and FROM element "dag".
       Apply join condition(s) between each element to resolve.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #28544: Add back join to zombie query that was dropped in #28198

Posted by GitBox <gi...@apache.org>.

kaxil commented on PR #28544:
URL: https://github.com/apache/airflow/pull/28544#issuecomment-1364391504

   Whoops


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] BobDu commented on pull request #28544: Add back join to zombie query that was dropped in #28198

Posted by GitBox <gi...@apache.org>.

BobDu commented on PR #28544:
URL: https://github.com/apache/airflow/pull/28544#issuecomment-1363851417

   I am sorry lost join in query.
   
   It is recommended to config SAWarning as an error in pytest.
   https://github.com/apache/airflow/blob/7eb805466993bc563275451c915d74f870b54231/pytest.ini#L31-L40
   add `ignore::sqlalchemy.exc.SAWarning` in the filterwarnings.
   
   @jedcunningham 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #28544: Add back join to zombie query that was dropped in #28198

Posted by GitBox <gi...@apache.org>.

potiuk commented on PR #28544:
URL: https://github.com/apache/airflow/pull/28544#issuecomment-1363397103

   Saw it today in main .. Was about to take a look :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham merged pull request #28544: Add back join to zombie query that was dropped in #28198

Posted by GitBox <gi...@apache.org>.

jedcunningham merged PR #28544:
URL: https://github.com/apache/airflow/pull/28544


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] BobDu commented on pull request #28544: Add back join to zombie query that was dropped in #28198

Posted by GitBox <gi...@apache.org>.

BobDu commented on PR #28544:
URL: https://github.com/apache/airflow/pull/28544#issuecomment-1365040999

   > Good idea, but I just tried to get that working without success. If you get it though, PR definitely welcome!
   
   no problem #28590


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on pull request #28544: Add back join to zombie query that was dropped in #28198

Posted by GitBox <gi...@apache.org>.

jedcunningham commented on PR #28544:
URL: https://github.com/apache/airflow/pull/28544#issuecomment-1364108207

   > I am sorry lost join in query.
   
   All good, it happens!
   
   > It is recommended to config SAWarning as an error in pytest.
   
   Good idea, but I just tried to get that working without success. If you get it though, PR definitely welcome!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org