You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "wyr8899 (via GitHub)" <gi...@apache.org> on 2024/01/12 08:17:09 UTC
[PR] rptun: Strip rpmsg and rptun. Extract common rpmsg api in rptun.c to rpmsg.c, rpmsg provide rpmsg_ops to each backend for specific implementation. [nuttx]
wyr8899 opened a new pull request, #11536:
URL: https://github.com/apache/nuttx/pull/11536
## Summary
nuttx/driver/rpmsg: new folder, extract common rpmsg api in rptun.c to rpmsg.c.
rpmsg provide rpmsg_ops to each backend for specific implementation.
## Impact
Clarify the functions of rptun and rpmsg so that rpmsg can adapt to other types of transport layers.
## Testing
Tested in sim vela, 86panel, n62. Verification function is normal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rptun: Strip rpmsg and rptun. Extract common rpmsg api in rptun.c to rpmsg.c, rpmsg provide rpmsg_ops to each backend for specific implementation. [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl merged PR #11536:
URL: https://github.com/apache/nuttx/pull/11536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rptun: Strip rpmsg and rptun. Extract common rpmsg api in rptun.c to rpmsg.c, rpmsg provide rpmsg_ops to each backend for specific implementation. [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on code in PR #11536:
URL: https://github.com/apache/nuttx/pull/11536#discussion_r1451390688
##########
include/nuttx/rptun/rptun.h:
##########
@@ -30,7 +30,9 @@
#ifdef CONFIG_RPTUN
#include <nuttx/fs/ioctl.h>
-#include <openamp/open_amp.h>
+#include <nuttx/rptun/rptun_ping.h>
Review Comment:
there is no such file in upstream
##########
include/nuttx/rpmsg/rpmsg.h:
##########
@@ -0,0 +1,116 @@
+/****************************************************************************
+ * include/nuttx/rpmsg/rpmsg.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __INCLUDE_NUTTX_RPMSG_RPMSG_H
+#define __INCLUDE_NUTTX_RPMSG_RPMSG_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#ifdef CONFIG_RPMSG
+
+#include <openamp/rpmsg.h>
+
+/****************************************************************************
+ * Public Types
+ ****************************************************************************/
+
+struct rpmsg_s
+{
+ struct metal_list bind;
+ rmutex_t lock;
+ struct metal_list node;
+ FAR const struct rpmsg_ops_s *ops;
+ struct rpmsg_device rdev[0];
+};
+
+typedef CODE int (*rpmsg_foreach_t)(FAR struct rpmsg_s *rpmsg,
+ FAR void *arg);
+
+/**
+ * struct rpmsg_ops_s - Rpmsg device operations
+ * @get_cpuname: get cpu name.
Review Comment:
please remove `@` from comments. See https://github.com/apache/nuttx/pull/11363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rptun: Strip rpmsg and rptun. Extract common rpmsg api in rptun.c to rpmsg.c, rpmsg provide rpmsg_ops to each backend for specific implementation. [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on code in PR #11536:
URL: https://github.com/apache/nuttx/pull/11536#discussion_r1451395414
##########
include/nuttx/rptun/rptun.h:
##########
@@ -30,7 +30,9 @@
#ifdef CONFIG_RPTUN
#include <nuttx/fs/ioctl.h>
-#include <openamp/open_amp.h>
+#include <nuttx/rptun/rptun_ping.h>
Review Comment:
I see that this file is added in https://github.com/apache/nuttx/pull/11537 but this line should not be in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rptun: Strip rpmsg and rptun. Extract common rpmsg api in rptun.c to rpmsg.c, rpmsg provide rpmsg_ops to each backend for specific implementation. [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #11536:
URL: https://github.com/apache/nuttx/pull/11536#issuecomment-1893160245
please rebase to the last master the ci break is fixed, @wyr8899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rptun: Strip rpmsg and rptun. Extract common rpmsg api in rptun.c to rpmsg.c, rpmsg provide rpmsg_ops to each backend for specific implementation. [nuttx]
Posted by "wyr8899 (via GitHub)" <gi...@apache.org>.
wyr8899 commented on code in PR #11536:
URL: https://github.com/apache/nuttx/pull/11536#discussion_r1452043581
##########
include/nuttx/rptun/rptun.h:
##########
@@ -30,7 +30,9 @@
#ifdef CONFIG_RPTUN
#include <nuttx/fs/ioctl.h>
-#include <openamp/open_amp.h>
+#include <nuttx/rptun/rptun_ping.h>
Review Comment:
Yes, this PR should be submited after #11537.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rptun: Strip rpmsg and rptun. Extract common rpmsg api in rptun.c to rpmsg.c, rpmsg provide rpmsg_ops to each backend for specific implementation. [nuttx]
Posted by "CV-Bowen (via GitHub)" <gi...@apache.org>.
CV-Bowen commented on PR #11536:
URL: https://github.com/apache/nuttx/pull/11536#issuecomment-1891668012
@wyr8899 Let's fix the CI problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org