You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Aaron Gooch <eo...@gmail.com> on 2012/07/09 21:23:40 UTC
Review Request: RAVE-624 dynamic debug preference
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5844/
-----------------------------------------------------------
Review request for rave.
Description
-------
Allow dynamic debug mode switching. Preferences will now allow toggle between debug on and off for container.js. An Event listening interface was created to fire the change and the DefaultScriptManager implements the interface listening for an event to happen.
This addresses bug RAVE-624.
https://issues.apache.org/jira/browse/RAVE-624
Diffs
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeEventListener.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeSaveEvent.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEvent.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventListener.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventManager.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/PortalPreferenceService.java 1359151
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceService.java 1359151
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/PortalPreferenceKeys.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/ScriptManager.java 1359151
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/impl/DefaultScriptManager.java 1359151
trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1359151
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceServiceTest.java 1359151
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/web/renderer/ScriptManagerTest.java 1359151
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1359151
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/UserController.java 1359151
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/WidgetController.java 1359151
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/PortalPreferenceForm.java 1359151
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java 1359151
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/ScriptTag.java 1359151
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java 1359151
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1359151
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/PortalPreferenceControllerTest.java 1359151
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/WidgetControllerTest.java 1359151
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/PortalPreferenceFormTest.java 1359151
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/tag/RegionWidgetTagTest.java 1359151
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/validator/PortalPreferenceFormValidatorTest.java 1359151
trunk/rave-portal-resources/src/main/resources/log4j.xml 1359151
trunk/rave-portal-resources/src/main/webapp/script/rave.js 1340978
trunk/rave-portal/pom.xml 1359151
trunk/rave-portal/src/test/java/renderer/RenderServiceIntegrationTest.java 1359151
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/config/OpenSocialEnvironment.java 1359151
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRenderer.java 1359151
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/test/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRendererTest.java 1359151
trunk/rave-providers/rave-w3c-provider/src/main/java/org/apache/rave/provider/w3c/web/renderer/W3cWidgetRenderer.java 1359151
Diff: https://reviews.apache.org/r/5844/diff/
Testing
-------
Thanks,
Aaron Gooch
Re: Review Request: RAVE-624 dynamic debug preference
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5844/#review9071
-----------------------------------------------------------
Aaron there appears to be a problem with this patch file, specifically the PortalPreferenceKeys.java file. Can you please re-create and upload?
- Anthony Carlucci
On July 9, 2012, 7:48 p.m., Aaron Gooch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5844/
> -----------------------------------------------------------
>
> (Updated July 9, 2012, 7:48 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Allow dynamic debug mode switching. Preferences will now allow toggle between debug on and off for container.js. An Event listening interface was created to fire the change and the DefaultScriptManager implements the interface listening for an event to happen.
>
>
> This addresses bug RAVE-624.
> https://issues.apache.org/jira/browse/RAVE-624
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeEventListener.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeSaveEvent.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEvent.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventListener.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventManager.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/PortalPreferenceService.java 1359337
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceService.java 1359337
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/PortalPreferenceKeys.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/ScriptManager.java 1359337
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/impl/DefaultScriptManager.java 1359337
> trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1359337
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceServiceTest.java 1359337
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/web/renderer/ScriptManagerTest.java 1359337
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1359337
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/UserController.java 1359337
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/WidgetController.java 1359337
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/PortalPreferenceForm.java 1359337
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java 1359337
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/ScriptTag.java 1359337
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java 1359337
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1359337
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/PortalPreferenceControllerTest.java 1359337
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/WidgetControllerTest.java 1359337
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/PortalPreferenceFormTest.java 1359337
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/tag/RegionWidgetTagTest.java 1359337
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/validator/PortalPreferenceFormValidatorTest.java 1359337
> trunk/rave-portal-resources/src/main/resources/log4j.xml 1359337
> trunk/rave-portal-resources/src/main/webapp/script/rave.js 1340978
> trunk/rave-portal/src/test/java/renderer/RenderServiceIntegrationTest.java 1359337
> trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/config/OpenSocialEnvironment.java 1359337
> trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRenderer.java 1359337
> trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/test/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRendererTest.java 1359337
> trunk/rave-providers/rave-w3c-provider/src/main/java/org/apache/rave/provider/w3c/web/renderer/W3cWidgetRenderer.java 1359337
>
> Diff: https://reviews.apache.org/r/5844/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aaron Gooch
>
>
Re: Review Request: RAVE-624 dynamic debug preference
Posted by Matt Franklin <mf...@apache.org>.
> On July 18, 2012, 4:29 p.m., Anthony Carlucci wrote:
> > Overall looks good, will make a few minor tweaks with commit:
> > 1) add apache header to PortalPreferenceKeys
> > 2) ignore pom.xml changes (looks like local changes you shouldn't have included)
> > 3) OpenSocialEnvironment - created a constant string for the value of the "debug on" instead of inlining it
Please close if this has been applied
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5844/#review9242
-----------------------------------------------------------
On July 16, 2012, 6:12 p.m., Aaron Gooch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5844/
> -----------------------------------------------------------
>
> (Updated July 16, 2012, 6:12 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Allow dynamic debug mode switching. Preferences will now allow toggle between debug on and off for container.js. An Event listening interface was created to fire the change and the DefaultScriptManager implements the interface listening for an event to happen.
>
>
> This addresses bug RAVE-624.
> https://issues.apache.org/jira/browse/RAVE-624
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-commons/src/main/java/org/apache/rave/persistence/jpa/impl/H2OpenJpaDialect.java 1362126
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeEventListener.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeSaveEvent.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEvent.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventListener.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventManager.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/PortalPreferenceService.java 1362126
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceService.java 1362126
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/ScriptManager.java 1362126
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/impl/DefaultScriptManager.java 1362126
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1362126
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceServiceTest.java 1362126
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/web/renderer/ScriptManagerTest.java 1362126
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1362126
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/WidgetController.java 1362126
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java 1362126
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/ScriptTag.java 1362126
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java 1362126
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/PortalPreferenceControllerTest.java 1362126
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/WidgetControllerTest.java 1362126
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/tag/RegionWidgetTagTest.java 1362126
> trunk/rave-portal-resources/src/main/resources/log4j.xml 1362126
> trunk/rave-portal-resources/src/main/webapp/script/rave.js 1345097
> trunk/rave-portal/pom.xml 1362126
> trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/config/OpenSocialEnvironment.java 1362126
> trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRenderer.java 1362126
> trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/test/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRendererTest.java 1362126
> trunk/rave-providers/rave-w3c-provider/src/main/java/org/apache/rave/provider/w3c/web/renderer/W3cWidgetRenderer.java 1362126
>
> Diff: https://reviews.apache.org/r/5844/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aaron Gooch
>
>
Re: Review Request: RAVE-624 dynamic debug preference
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5844/#review9242
-----------------------------------------------------------
Ship it!
Overall looks good, will make a few minor tweaks with commit:
1) add apache header to PortalPreferenceKeys
2) ignore pom.xml changes (looks like local changes you shouldn't have included)
3) OpenSocialEnvironment - created a constant string for the value of the "debug on" instead of inlining it
- Anthony Carlucci
On July 16, 2012, 6:12 p.m., Aaron Gooch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5844/
> -----------------------------------------------------------
>
> (Updated July 16, 2012, 6:12 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Allow dynamic debug mode switching. Preferences will now allow toggle between debug on and off for container.js. An Event listening interface was created to fire the change and the DefaultScriptManager implements the interface listening for an event to happen.
>
>
> This addresses bug RAVE-624.
> https://issues.apache.org/jira/browse/RAVE-624
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-commons/src/main/java/org/apache/rave/persistence/jpa/impl/H2OpenJpaDialect.java 1362126
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeEventListener.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeSaveEvent.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEvent.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventListener.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventManager.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/PortalPreferenceService.java 1362126
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceService.java 1362126
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/ScriptManager.java 1362126
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/impl/DefaultScriptManager.java 1362126
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1362126
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceServiceTest.java 1362126
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/web/renderer/ScriptManagerTest.java 1362126
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1362126
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/WidgetController.java 1362126
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java 1362126
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/ScriptTag.java 1362126
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java 1362126
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/PortalPreferenceControllerTest.java 1362126
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/WidgetControllerTest.java 1362126
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/tag/RegionWidgetTagTest.java 1362126
> trunk/rave-portal-resources/src/main/resources/log4j.xml 1362126
> trunk/rave-portal-resources/src/main/webapp/script/rave.js 1345097
> trunk/rave-portal/pom.xml 1362126
> trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/config/OpenSocialEnvironment.java 1362126
> trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRenderer.java 1362126
> trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/test/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRendererTest.java 1362126
> trunk/rave-providers/rave-w3c-provider/src/main/java/org/apache/rave/provider/w3c/web/renderer/W3cWidgetRenderer.java 1362126
>
> Diff: https://reviews.apache.org/r/5844/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aaron Gooch
>
>
Re: Review Request: RAVE-624 dynamic debug preference
Posted by Aaron Gooch <eo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5844/
-----------------------------------------------------------
(Updated July 16, 2012, 6:12 p.m.)
Review request for rave.
Changes
-------
Fixed patch file.
Description
-------
Allow dynamic debug mode switching. Preferences will now allow toggle between debug on and off for container.js. An Event listening interface was created to fire the change and the DefaultScriptManager implements the interface listening for an event to happen.
This addresses bug RAVE-624.
https://issues.apache.org/jira/browse/RAVE-624
Diffs (updated)
-----
trunk/rave-components/rave-commons/src/main/java/org/apache/rave/persistence/jpa/impl/H2OpenJpaDialect.java 1362126
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeEventListener.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeSaveEvent.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEvent.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventListener.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventManager.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/PortalPreferenceService.java 1362126
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceService.java 1362126
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/ScriptManager.java 1362126
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/impl/DefaultScriptManager.java 1362126
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java PRE-CREATION
trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1362126
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceServiceTest.java 1362126
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/web/renderer/ScriptManagerTest.java 1362126
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1362126
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/WidgetController.java 1362126
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java 1362126
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/ScriptTag.java 1362126
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java 1362126
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/PortalPreferenceControllerTest.java 1362126
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/WidgetControllerTest.java 1362126
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/tag/RegionWidgetTagTest.java 1362126
trunk/rave-portal-resources/src/main/resources/log4j.xml 1362126
trunk/rave-portal-resources/src/main/webapp/script/rave.js 1345097
trunk/rave-portal/pom.xml 1362126
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/config/OpenSocialEnvironment.java 1362126
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRenderer.java 1362126
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/test/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRendererTest.java 1362126
trunk/rave-providers/rave-w3c-provider/src/main/java/org/apache/rave/provider/w3c/web/renderer/W3cWidgetRenderer.java 1362126
Diff: https://reviews.apache.org/r/5844/diff/
Testing
-------
Thanks,
Aaron Gooch
Re: Review Request: RAVE-624 dynamic debug preference
Posted by Aaron Gooch <eo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5844/
-----------------------------------------------------------
(Updated July 9, 2012, 7:48 p.m.)
Review request for rave.
Changes
-------
Changed synchronized Map to a final and implemented it as a hashtable.
Description
-------
Allow dynamic debug mode switching. Preferences will now allow toggle between debug on and off for container.js. An Event listening interface was created to fire the change and the DefaultScriptManager implements the interface listening for an event to happen.
This addresses bug RAVE-624.
https://issues.apache.org/jira/browse/RAVE-624
Diffs (updated)
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeEventListener.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeSaveEvent.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEvent.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventListener.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventManager.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/PortalPreferenceService.java 1359337
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceService.java 1359337
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/PortalPreferenceKeys.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/ScriptManager.java 1359337
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/impl/DefaultScriptManager.java 1359337
trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1359337
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceServiceTest.java 1359337
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/web/renderer/ScriptManagerTest.java 1359337
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1359337
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/UserController.java 1359337
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/WidgetController.java 1359337
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/PortalPreferenceForm.java 1359337
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java 1359337
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/ScriptTag.java 1359337
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java 1359337
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1359337
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/PortalPreferenceControllerTest.java 1359337
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/WidgetControllerTest.java 1359337
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/PortalPreferenceFormTest.java 1359337
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/tag/RegionWidgetTagTest.java 1359337
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/validator/PortalPreferenceFormValidatorTest.java 1359337
trunk/rave-portal-resources/src/main/resources/log4j.xml 1359337
trunk/rave-portal-resources/src/main/webapp/script/rave.js 1340978
trunk/rave-portal/src/test/java/renderer/RenderServiceIntegrationTest.java 1359337
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/config/OpenSocialEnvironment.java 1359337
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRenderer.java 1359337
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/test/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRendererTest.java 1359337
trunk/rave-providers/rave-w3c-provider/src/main/java/org/apache/rave/provider/w3c/web/renderer/W3cWidgetRenderer.java 1359337
Diff: https://reviews.apache.org/r/5844/diff/
Testing
-------
Thanks,
Aaron Gooch
Re: Review Request: RAVE-624 dynamic debug preference
Posted by Aaron Gooch <eo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5844/
-----------------------------------------------------------
(Updated July 9, 2012, 7:30 p.m.)
Review request for rave.
Changes
-------
Removed pom.xml and added apache headers to new files.
Description
-------
Allow dynamic debug mode switching. Preferences will now allow toggle between debug on and off for container.js. An Event listening interface was created to fire the change and the DefaultScriptManager implements the interface listening for an event to happen.
This addresses bug RAVE-624.
https://issues.apache.org/jira/browse/RAVE-624
Diffs (updated)
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeEventListener.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeSaveEvent.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEvent.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventListener.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventManager.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/PortalPreferenceService.java 1359337
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceService.java 1359337
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/PortalPreferenceKeys.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/ScriptManager.java 1359337
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/impl/DefaultScriptManager.java 1359337
trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1359337
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceServiceTest.java 1359337
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/web/renderer/ScriptManagerTest.java 1359337
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1359337
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/UserController.java 1359337
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/WidgetController.java 1359337
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/PortalPreferenceForm.java 1359337
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java 1359337
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/ScriptTag.java 1359337
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java 1359337
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1359337
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/PortalPreferenceControllerTest.java 1359337
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/WidgetControllerTest.java 1359337
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/PortalPreferenceFormTest.java 1359337
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/tag/RegionWidgetTagTest.java 1359337
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/validator/PortalPreferenceFormValidatorTest.java 1359337
trunk/rave-portal-resources/src/main/resources/log4j.xml 1359337
trunk/rave-portal-resources/src/main/webapp/script/rave.js 1340978
trunk/rave-portal/src/test/java/renderer/RenderServiceIntegrationTest.java 1359337
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/config/OpenSocialEnvironment.java 1359337
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRenderer.java 1359337
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/test/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRendererTest.java 1359337
trunk/rave-providers/rave-w3c-provider/src/main/java/org/apache/rave/provider/w3c/web/renderer/W3cWidgetRenderer.java 1359337
Diff: https://reviews.apache.org/r/5844/diff/
Testing
-------
Thanks,
Aaron Gooch
Re: Review Request: RAVE-624 dynamic debug preference
Posted by Aaron Gooch <eo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5844/
-----------------------------------------------------------
(Updated July 9, 2012, 7:23 p.m.)
Review request for rave.
Description
-------
Allow dynamic debug mode switching. Preferences will now allow toggle between debug on and off for container.js. An Event listening interface was created to fire the change and the DefaultScriptManager implements the interface listening for an event to happen.
This addresses bug RAVE-624.
https://issues.apache.org/jira/browse/RAVE-624
Diffs
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeEventListener.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeSaveEvent.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEvent.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventListener.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventManager.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/PortalPreferenceService.java 1359151
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceService.java 1359151
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/PortalPreferenceKeys.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/ScriptManager.java 1359151
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/impl/DefaultScriptManager.java 1359151
trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1359151
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceServiceTest.java 1359151
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/web/renderer/ScriptManagerTest.java 1359151
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1359151
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/UserController.java 1359151
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/WidgetController.java 1359151
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/PortalPreferenceForm.java 1359151
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java 1359151
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/ScriptTag.java 1359151
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java 1359151
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1359151
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/PortalPreferenceControllerTest.java 1359151
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/WidgetControllerTest.java 1359151
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/PortalPreferenceFormTest.java 1359151
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/tag/RegionWidgetTagTest.java 1359151
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/validator/PortalPreferenceFormValidatorTest.java 1359151
trunk/rave-portal-resources/src/main/resources/log4j.xml 1359151
trunk/rave-portal-resources/src/main/webapp/script/rave.js 1340978
trunk/rave-portal/pom.xml 1359151
trunk/rave-portal/src/test/java/renderer/RenderServiceIntegrationTest.java 1359151
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/config/OpenSocialEnvironment.java 1359151
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRenderer.java 1359151
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/test/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRendererTest.java 1359151
trunk/rave-providers/rave-w3c-provider/src/main/java/org/apache/rave/provider/w3c/web/renderer/W3cWidgetRenderer.java 1359151
Diff: https://reviews.apache.org/r/5844/diff/
Testing
-------
Thanks,
Aaron Gooch