You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/25 08:03:12 UTC
[GitHub] [incubator-kyuubi] fsk119 opened a new issue, #2166: [Bug] Throw the exception to notify FlinkEngine config `table.dml-sync` is not equal to the parameter runAsync
fsk119 opened a new issue, #2166:
URL: https://github.com/apache/incubator-kyuubi/issues/2166
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.
### Describe the bug
Flink table uses `table.dml-sync`[1] to control whether wait the execution finish. However, Kyuubi use its own parameter to control the behaviour. I think it's neccesary to keep the behaviour unified and throw the exception to notify the users.
[1] https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/config/#table-dml-sync
### Affects Version(s)
master
### Kyuubi Server Log Output
_No response_
### Kyuubi Engine Log Output
_No response_
### Kyuubi Server Configurations
_No response_
### Kyuubi Engine Configurations
_No response_
### Additional context
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] fsk119 closed issue #2166: [Bug] Throw the exception to notify FlinkEngine config `table.dml-sync` is not equal to the parameter runAsync
Posted by GitBox <gi...@apache.org>.
fsk119 closed issue #2166: [Bug] Throw the exception to notify FlinkEngine config `table.dml-sync` is not equal to the parameter runAsync
URL: https://github.com/apache/incubator-kyuubi/issues/2166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] fsk119 commented on issue #2166: [Bug] Throw the exception to notify FlinkEngine config `table.dml-sync` is not equal to the parameter runAsync
Posted by GitBox <gi...@apache.org>.
fsk119 commented on issue #2166:
URL: https://github.com/apache/incubator-kyuubi/issues/2166#issuecomment-1108217103
Close the issue by mistake...reopen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] fsk119 commented on issue #2166: [Bug] Throw the exception to notify FlinkEngine config `table.dml-sync` is not equal to the parameter runAsync
Posted by GitBox <gi...@apache.org>.
fsk119 commented on issue #2166:
URL: https://github.com/apache/incubator-kyuubi/issues/2166#issuecomment-1108215020
Hi, all. Sorry for the late response. I think it's not a bug after reconsider the issue. The option `table.dml-sync` means the Flink `TableEnvironment` will wait for the execution finish, which means the lifecycle of the `Operation` contains the job execution. But the sync mode in the gateway means the Gateway should return the signal to the client until the `Operation` finishes, which doesn't means the gateway should influence the lifecycle of the `Operation`. Therefore, I think the two options don't need be the same. WDYT?
But the Operation lifecycle in the Hive always contains the execution of the job[1], right? Maybe we should set the option true forcely?
[1]https://github.com/apache/hive/blob/23b0d30051af3ade5b03496ab9cf22929168dc84/service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java#L233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] SteNicholas commented on issue #2166: [Bug] Throw the exception to notify FlinkEngine config `table.dml-sync` is not equal to the parameter runAsync
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #2166:
URL: https://github.com/apache/incubator-kyuubi/issues/2166#issuecomment-1104158004
@fsk119, any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on issue #2166: [Bug] Throw the exception to notify FlinkEngine config `table.dml-sync` is not equal to the parameter runAsync
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on issue #2166:
URL: https://github.com/apache/kyuubi/issues/2166#issuecomment-1420185716
> Maybe we should set the option true forcely?
make sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org