[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4882: Failure to recover after segment reload failure does not release segment lock

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4882:  Failure to recover after segment reload failure does not release segment lock
URL: https://github.com/apache/incubator-pinot/pull/4882#discussion_r353465137
 
 

 ##########
 File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java
 ##########
 @@ -237,8 +237,13 @@ private void reloadSegment(@Nonnull String tableNameWithType, @Nonnull SegmentMe
       // Delete segment temporary directory
       FileUtils.deleteDirectory(segmentTempDir);
     } finally {
-      LoaderUtils.reloadFailureRecovery(indexDir);
-      segmentLock.unlock();
+      try {
+        LoaderUtils.reloadFailureRecovery(indexDir);
+      } catch (Exception e) {
 
 Review comment:
   Please  remove this exception block, and let it throw exception. Try/finally should be fine.
   thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org