You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/07 21:43:09 UTC

[GitHub] [spark] planga82 edited a comment on pull request #32057: [SPARK-34961][SQL] Migrate First function from DeclarativeAggregate to TypedImperativeAggregate to improve performance

planga82 edited a comment on pull request #32057:
URL: https://github.com/apache/spark/pull/32057#issuecomment-814406977


   
   First, thanks for sharing the benchmark, I was concerned about something like that could happen,it does not seem very reasonable to lose performance in this case. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org