You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "rothardo (via GitHub)" <gi...@apache.org> on 2023/12/06 08:31:20 UTC

[PR] Renamed Hudson to Jenkins in UI [netbeans]

rothardo opened a new pull request, #6797:
URL: https://github.com/apache/netbeans/pull/6797

   **Description**
   In the UI, Hudson was seamlessly renamed as Jenkins without altering any directory, cluster, package, or method names.
   
   **Why was it required?**
   [Hudson is no more](https://en.wikipedia.org/wiki/Hudson_(software)) but NetBeans is still using it in the UI:
   
   **FIxes the Issue** 
   Rename Hudson to Jenkins #6628
   
   **Modifications made to**
   ```
   ide/hudson
   ide/hudson.git
   ide/hudson.mercurial
   ide/hudson.subversion
   ide/hudson.tasklist
   ide/hudson.ui
   php/hudson.php
   ```
   
   **After Changes in the UI it looks like this:**
   ![Screenshot 2023-12-06 133704](https://github.com/apache/netbeans/assets/83207402/62a566c0-ea78-429f-87ca-b3aa26a6f1af)
   
   ![Screenshot 2023-12-06 133644](https://github.com/apache/netbeans/assets/83207402/0bc9f73e-fdfa-4e43-85ba-d90c064e69b8)
   
   **And as stated above Hudson renamed as Jenkins without altering any hudson directory, cluster, package, or method names:**
   ![Screenshot 2023-12-06 133734](https://github.com/apache/netbeans/assets/83207402/55f2867f-276d-4fca-aa11-bcccc3f4f929)
   
   
   By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
   
    - are all your own work, and you have the right to contribute them.
    Yes
    - are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
    Yes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "rothardo (via GitHub)" <gi...@apache.org>.
rothardo commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1881301042

   
   > I've left comments about the URLs. Other than that, it looks good to me. Thank you for your work!
   
   @mbien should I change the URLs too as per @junichi11 's comment?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "rothardo (via GitHub)" <gi...@apache.org>.
rothardo commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1444062535


##########
ide/hudson/src/org/netbeans/modules/hudson/Bundle.properties:
##########
@@ -17,7 +17,7 @@
 
 OpenIDE-Module-Display-Category=Base IDE
 OpenIDE-Module-Long-Description=\
-    Helps browse and manage installations of the Hudson continuous integration server (http://hudson-ci.org/). \
+    Helps browse and manage installations of the Jenkins continuous integration server (http://hudson-ci.org/). \
     http://wiki.netbeans.org/HudsonInNetBeans has more information.
 OpenIDE-Module-Name=Hudson

Review Comment:
   > @mbien Indeed, that would make sense.
   > 
   > @rothardo sorry, I just noticed, that you pushed an update. FYI github does not inform when updates are force-pushed, so if you push an update like this it would be good to leave a comment. Could you have a look if the suggestion from @mbien also makes sense to you and update this also?
   
   surely @matthiasblaesing I will keep in mind to leave a comment if I force push from next time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1854858344

   @rothardo we have to figure out how to handle property file keys, since this PR here does currently rename a few but not all which makes it inconsistent. But I leave this to other reviewers to decide, esp those who wanted to make this change only in UI instead of a full rename.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1418100156


##########
php/hudson.php/src/org/netbeans/modules/hudson/php/options/HudsonOptions.java:
##########
@@ -36,7 +36,7 @@ public final class HudsonOptions {
 
     // Do not change arbitrary - consult with layer's folder OptionsExport
     // Path to Preferences node for storing these preferences
-    private static final String PREFERENCES_PATH = "hudson"; // NOI18N
+    private static final String PREFERENCES_PATH = "jenkins"; // NOI18N

Review Comment:
   Agreed. This does not worth the change. Changing this would mean that users invested in customizing their settings would lose those, unless handled in the updater logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1848875074

   > @rothardo you don't have to push merge commits right away, its ok if the branch is a little bit out of date.
   
   Well, let's keep the number of commits minimal for a PR. Unless there is no conflict, or a dependency, you do not need to merge anything back from the master branch. In those rare cases when needed, it's better to do a rebase instead of adding a merge commit.
   
   Since you are working on your own branch, it is Ok to amend a previous commit. This way most PR-s would be only 1 commit. That way you simply skip the squashing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1444086465


##########
ide/hudson/src/org/netbeans/modules/hudson/Bundle.properties:
##########
@@ -17,7 +17,7 @@
 
 OpenIDE-Module-Display-Category=Base IDE
 OpenIDE-Module-Long-Description=\
-    Helps browse and manage installations of the Hudson continuous integration server (http://hudson-ci.org/). \
+    Helps browse and manage installations of the Jenkins continuous integration server (http://hudson-ci.org/). \
     http://wiki.netbeans.org/HudsonInNetBeans has more information.

Review Comment:
   Should we remove this line because http://wiki.netbeans.org/HudsonInNetBeans is no longer available?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1884271667

   @rothardo Congrats!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #6797:
URL: https://github.com/apache/netbeans/pull/6797


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1443313435


##########
ide/hudson/src/org/netbeans/modules/hudson/Bundle.properties:
##########
@@ -17,7 +17,7 @@
 
 OpenIDE-Module-Display-Category=Base IDE
 OpenIDE-Module-Long-Description=\
-    Helps browse and manage installations of the Hudson continuous integration server (http://hudson-ci.org/). \
+    Helps browse and manage installations of the Jenkins continuous integration server (http://hudson-ci.org/). \
     http://wiki.netbeans.org/HudsonInNetBeans has more information.
 OpenIDE-Module-Name=Hudson

Review Comment:
   @matthiasblaesing @lkishalmi I think we should also update `OpenIDE-Module-Name` in all involved modules so that users don't have to search for "hudson" to find it in the plugin manager, what do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1444955879


##########
ide/hudson/src/org/netbeans/modules/hudson/Bundle.properties:
##########
@@ -17,7 +17,7 @@
 
 OpenIDE-Module-Display-Category=Base IDE
 OpenIDE-Module-Long-Description=\
-    Helps browse and manage installations of the Hudson continuous integration server (http://hudson-ci.org/). \
+    Helps browse and manage installations of the Jenkins continuous integration server (http://hudson-ci.org/). \

Review Comment:
   I thinks this would be nice 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1421577475


##########
ide/hudson.ui/src/org/netbeans/modules/hudson/ui/resources/instance.png:
##########


Review Comment:
   the libs/license verification job caught this - which is interesting.
   https://github.com/apache/netbeans/actions/runs/7153405473/job/19480067040
   
   so if the icons are changed this would have to need an update too:
   https://github.com/apache/netbeans/blob/master/ide/hudson.ui/licenseinfo.xml
   
   and more:
   https://github.com/search?q=repo%3Aapache%2Fnetbeans%20hudson%2Fui%2Fresources%2Finstance.png&type=code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1417815677


##########
ide/hudson.ui/src/org/netbeans/modules/hudson/ui/wizard/InstanceDialog.java:
##########
@@ -67,15 +67,15 @@ public void actionPerformed(ActionEvent e) {
     public HudsonInstance show() {
         dialog = DialogDisplayer.getDefault().createDialog(this);
         dialog.setVisible(true);
-        LOG.log(Level.FINE, "Added Hudson instance: {0}", created);
+        LOG.log(Level.FINE, "Added Jenkins instance: {0}", created);
         return created;
     }
 
     @NbBundle.Messages({
         "# UI logging of adding new server",
-        "UI_HUDSON_SERVER_REGISTERED=Hudson server registered",
+        "UI_JENKINS_SERVER_REGISTERED=Jenkins server registered",

Review Comment:
   we going to have to check if we should change the keys and the values, or just the values
   
   I think changing both should be fine, but lets see what others say.



##########
php/hudson.php/src/org/netbeans/modules/hudson/php/ui/options/HudsonOptionsPanelController.java:
##########
@@ -37,13 +37,13 @@
 @OptionsPanelController.SubRegistration(
     location=UiUtils.OPTIONS_PATH,
     id=HudsonOptionsPanelController.OPTIONS_SUBPATH,
-    displayName="#LBL_HudsonPHPOptionsName",
+    displayName="#LBL_JenkinsPHPOptionsName",
 //    toolTip="#LBL_OptionsTooltip"
     position=160
 )
 public class HudsonOptionsPanelController extends OptionsPanelController implements ChangeListener {
 
-    public static final String OPTIONS_SUBPATH = "Hudson"; // NOI18N
+    public static final String OPTIONS_SUBPATH = "Jenkins"; // NOI18N

Review Comment:
   same here



##########
php/hudson.php/src/org/netbeans/modules/hudson/php/options/HudsonOptions.java:
##########
@@ -36,7 +36,7 @@ public final class HudsonOptions {
 
     // Do not change arbitrary - consult with layer's folder OptionsExport
     // Path to Preferences node for storing these preferences
-    private static final String PREFERENCES_PATH = "hudson"; // NOI18N
+    private static final String PREFERENCES_PATH = "jenkins"; // NOI18N

Review Comment:
   this is something we will have to test.
   
   config migration and config import/export should still work after this change.
   
   IMO: migration of hudson -> jenkins is probably not worth to implement, what I mean by that is to check if the first-launch settings import from NB 21 to NB 22 still works if this path changes.
   
   It might be better to not change this property and move that task for later - I am not sure. (thats why I advocated to rename everything - since this does make things easier)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1443338603


##########
ide/hudson/src/org/netbeans/modules/hudson/Bundle.properties:
##########
@@ -17,7 +17,7 @@
 
 OpenIDE-Module-Display-Category=Base IDE
 OpenIDE-Module-Long-Description=\
-    Helps browse and manage installations of the Hudson continuous integration server (http://hudson-ci.org/). \
+    Helps browse and manage installations of the Jenkins continuous integration server (http://hudson-ci.org/). \
     http://wiki.netbeans.org/HudsonInNetBeans has more information.
 OpenIDE-Module-Name=Hudson

Review Comment:
   @mbien Indeed, that would make sense. 
   
   @rothardo sorry, I just noticed, that you pushed an update. FYI github does not inform when updates are force-pushed, so if you push an update like this it would be good to leave a comment. Could you have a look if the suggestion from @mbien also makes sense to you and update this also?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "rothardo (via GitHub)" <gi...@apache.org>.
rothardo commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1848418317

   Hi @mbien,
   
   I hope this message finds you well. I've recently gone through the [contributing guidelines](https://github.com/apache/netbeans/blob/120f2129a8dbc25b7a52542c359fe5a7a2569c60/.github/CONTRIBUTING.md) for the NetBeans project and I'm seeking some clarification on the squashing process. I attempted to squash my commits interactively in Vim, but encountered conflicts during the process.
   
   Specifically, I'm puzzled by an unexpected commit in the pull request [6797](https://github.com/apache/netbeans/pull/6797). In commit [8916655](https://github.com/apache/netbeans/pull/6797/commits/891665543a70e466b4fd862f32b495a3e7b4252c), I reconfigured the author's name. Subsequently, when I executed `git pull`, I noticed an automatic commit [Merge branch 'apache:master' into hudsontojenkins](https://github.com/apache/netbeans/pull/6797/commits/32a8216b3179e76031b2767e354d877d055a5bb1).
   
   Could you please provide further guidance on the squashing process and help me understand why the mentioned merge commit was automatically generated? I want to ensure that I follow the correct procedures and address any issues promptly.
   
   Your expertise in clarifying this matter would be greatly appreciated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "rothardo (via GitHub)" <gi...@apache.org>.
rothardo commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1845185183

   I have pushed changes after making changes as said, was that the right thing to do? I am asking this as I am new to the community


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1856404836

   I already stated, that I think we should only follow the name change on the surface. And it seems this PR is mostly in line with that. IMHO we gain little renaming packages or other things. We risk though internal breakage as we have sites that refer to modules, options, translations by name and these are hard to catch.
   
   Going through this PR @rothardo I notice:
   
   - What is the license of the image `instance.png`? The old was part of the donation from Oracle and thus relicensed to ALv2. A quick glance did not give me info about the license situation around the logo, the press page from Jenkins has a lot of yada-yada, but nothing substantial. I looked at the PNG and SVG both don't seem to have licenses attached. At least in my home country this makes the work non-redistributable.
   - In most files only UI strings were changed. This is different in, were also the keys are changed:
     -  `ide/hudson.ui/src/org/netbeans/modules/hudson/ui/wizard/InstanceDialog.java`: `UI_JENKINS_SERVER_REGISTERED` and `USG_JENKINS_SERVER_REGISTERED`
     - `php/hudson.php/src/org/netbeans/modules/hudson/php/resources/Bundle.properties` (+ use-sites): `LBL_JenkinsExportName`
     - `php/hudson.php/src/org/netbeans/modules/hudson/php/ui/options/Bundle.properties` (+ use-sites): `BL_JenkinsPHPOptionsName`
   
   All in this looks sane to me. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "rothardo (via GitHub)" <gi...@apache.org>.
rothardo commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1884256516

   
   
   > @rothardo congrats to your first contribution
   
   Thank you, @mbien @matthiasblaesing @junichi11 @ebarboni @lkishalmi 
   and the entire NetBeans team, for guiding me through my first contribution! I appreciate your time and support. Looking forward to more contributions and learning in this fantastic community.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "rothardo (via GitHub)" <gi...@apache.org>.
rothardo commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1868546493

   also @mbien I will squashing all the commits to single commit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1417895162


##########
ide/hudson/src/org/netbeans/modules/hudson/impl/HudsonJobBuildImpl.java:
##########
@@ -111,7 +111,7 @@ public Collection<? extends HudsonMavenModuleBuild> getMavenModules() {
         return modules;
     }
 
-    @Messages({"# {0} - job/module display name", "# {1} - build number", "HudsonJobBuildImpl.display_name={0} #{1,number,#}"})
+    @Messages({"# {0} - job/module display name", "# {1} - build number", "JenkinsJobBuildImpl.display_name={0} #{1,number,#}"})

Review Comment:
   We should not change this because the class name is used. 
   Maybe, there should be an error. (see: the return statement)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "rothardo (via GitHub)" <gi...@apache.org>.
rothardo commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1444062370


##########
ide/hudson/src/org/netbeans/modules/hudson/Bundle.properties:
##########
@@ -17,7 +17,7 @@
 
 OpenIDE-Module-Display-Category=Base IDE
 OpenIDE-Module-Long-Description=\
-    Helps browse and manage installations of the Hudson continuous integration server (http://hudson-ci.org/). \
+    Helps browse and manage installations of the Jenkins continuous integration server (http://hudson-ci.org/). \
     http://wiki.netbeans.org/HudsonInNetBeans has more information.
 OpenIDE-Module-Name=Hudson

Review Comment:
   @matthiasblaesing  and @mbien does that imply to all the modules including [php/hudson.php](https://github.com/apache/netbeans/tree/master/php/hudson.php) ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "rothardo (via GitHub)" <gi...@apache.org>.
rothardo commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1854534515

   Hello, @mbien Could you please confirm if this issue still requires changes? If not, could you  kindly guide me through the procedure for making this more merge ready?
   
   Thank you.
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1883649572

   thanks, I looked through the comments and diff and it looks like all were resolved. Going to merge once CI is green.
   
   @rothardo congrats to your first contribution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1444086292


##########
ide/hudson/src/org/netbeans/modules/hudson/Bundle.properties:
##########
@@ -17,7 +17,7 @@
 
 OpenIDE-Module-Display-Category=Base IDE
 OpenIDE-Module-Long-Description=\
-    Helps browse and manage installations of the Hudson continuous integration server (http://hudson-ci.org/). \
+    Helps browse and manage installations of the Jenkins continuous integration server (http://hudson-ci.org/). \

Review Comment:
   Should we change the URL to https://www.jenkins.io/ ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1444962570


##########
ide/hudson/src/org/netbeans/modules/hudson/Bundle.properties:
##########
@@ -17,7 +17,7 @@
 
 OpenIDE-Module-Display-Category=Base IDE
 OpenIDE-Module-Long-Description=\
-    Helps browse and manage installations of the Hudson continuous integration server (http://hudson-ci.org/). \
+    Helps browse and manage installations of the Jenkins continuous integration server (http://hudson-ci.org/). \
     http://wiki.netbeans.org/HudsonInNetBeans has more information.

Review Comment:
   for this we could later redirect or rewrite content.
   
   To have an overview
   https://web.archive.org/web/20190816094055/http://wiki.netbeans.org/HudsonInNetBeans 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "rothardo (via GitHub)" <gi...@apache.org>.
rothardo commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1444062370


##########
ide/hudson/src/org/netbeans/modules/hudson/Bundle.properties:
##########
@@ -17,7 +17,7 @@
 
 OpenIDE-Module-Display-Category=Base IDE
 OpenIDE-Module-Long-Description=\
-    Helps browse and manage installations of the Hudson continuous integration server (http://hudson-ci.org/). \
+    Helps browse and manage installations of the Jenkins continuous integration server (http://hudson-ci.org/). \
     http://wiki.netbeans.org/HudsonInNetBeans has more information.
 OpenIDE-Module-Name=Hudson

Review Comment:
   does that imply to all the modules including [php/hudson.php](https://github.com/apache/netbeans/tree/master/php/hudson.php) ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1843848482

   The artwork needs to be changed as well. Hudson and Jenkins have different mascot.
   
   See: https://get.jenkins.io/art/jenkins-logo/16x16/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1848729428

   @rothardo you don't have to push merge commits right away, its ok if the branch is a little bit out of date.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1848666984

   I assume you fixed the global git config already, you can check with `git config --list --global`
   
   here is how I would do it:
   
   lets put your commits on top of latest master (this changes the history in your branch, but we have to do this anyway):
   
   check out your branch locally (you likely already have that)
   run: 
   ```
   $ git pull --rebase --autostash git@github.com:apache/netbeans master
   From github.com:apache/netbeans
    * branch                master     -> FETCH_HEAD
   Current branch hudsontojenkins is up to date.
   ```
   this rebases your commits on latest master
   check with:
   ```
   $ git log --oneline
   bd3116056 (HEAD -> hudsontojenkins) Renamed Hudson to Jenkins
   cb4ff7ed2 Fixed the Issue of Renaming Hudson to Jenkins without changing any directory or method names
   b6a064d59 (origin/master, origin/HEAD, master) Use Ant for building NetBeans Gradle Tooling
   775f0f0ea Merge pull request #6765 from mbien/maven-dep-hint-profiles
   1b075fe0c Merge pull request #6748 from matthiasblaesing/jpa_provider_on_classpath
   ...
   ```
   so you see that your 2 commits are indeed on top of all other commits.
   
   now lets squash the 2 commits:
   ```
   $ git rebase --autostash -i HEAD~2
   ```
   
   this will open an editor with instructions. For this use case here, you have to change "pick" into "s" on all commits except the commit in the first line (so only the second line basically). This will squash the second commit into the first and then ask you to update the commit message, which you should do.
   
   lets check again:
   ```
   $ git log --oneline
   be2399296 (HEAD -> hudsontojenkins) Fixed the Issue of Renaming Hudson to Jenkins without changing any directory or method names
   b6a064d59 (origin/master, origin/HEAD, master) Use Ant for building NetBeans Gradle Tooling
   775f0f0ea Merge pull request #6765 from mbien/maven-dep-hint-profiles
   1b075fe0c Merge pull request #6748 from matthiasblaesing/jpa_provider_on_classpath
   ```
   worked!
   
   Now lets fix the commit header, since it would still have the wrong name:
   ```
   $ git log --oneline -n1 --pretty=format:'%h %an [%ae] %s'
   be2399296 rothardo [ashwintemkar@gmail.com] Fixed the Issue of Renaming Hudson to Jenkins without changing any directory or method names
   ```
   ```
   $ git commit --amend --author="Your Name <yo...@foo.bar>"
   ```
   check with `git log` and everything should be fine now
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "rothardo (via GitHub)" <gi...@apache.org>.
rothardo commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1869017742

   Hi @mbien and @matthiasblaesing ,
   
   I wanted to update you on the licensing clarification I received regarding the Jenkins artwork used in the Apache NetBeans contribution. [Mark Waite](https://community.jenkins.io/u/MarkEWaite), a member of the Jenkins Governance Board, provided insights into the licensing terms, which are detailed on the [Jenkins Artwork page](https://www.jenkins.io/artwork/).
   
   
   I've received clarity on the licensing terms for the Jenkins artwork used in the Apache NetBeans contribution. According to the [Creative Commons Attribution-ShareAlike 3.0 Unported License](https://creativecommons.org/licenses/by-sa/3.0/), the artwork,  i.e [instance.png](https://github.com/apache/netbeans/blob/master/ide/hudson.ui/src/org/netbeans/modules/hudson/ui/resources/instance.png) is redistributable with specific conditions.
   
   ### The licensing details are as follows:
   
   **License:** [Creative Commons Attribution-ShareAlike 3.0 Unported License](https://creativecommons.org/licenses/by-sa/3.0/)
   **Terms:** You are free to share and adapt the material for any purpose, even commercially, under the conditions of attribution and share-alike.
   
   Now I would like to seek your guidance in incorporating the recently obtained license information for the Jenkins artwork into the [ide/hudson.ui/licenseinfo.xml](https://github.com/apache/netbeans/blob/master/ide/hudson.ui/licenseinfo.xml) file. Can you specify the appropriate structure or format for including this licensing information in the XML file?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "rothardo (via GitHub)" <gi...@apache.org>.
rothardo commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1880158884

   @mbien and @matthiasblaesing I have force Pushed with the update in `OpenIDE-Module-Name` in all involved modules.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "rothardo (via GitHub)" <gi...@apache.org>.
rothardo commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1868533808

   Hi @matthiasblaesing ,
   
   I wanted to provide you with an update on the PR we've been discussing.
   
   I have addressed the concerns raised during the review process, and I've reverted the keys that were changed, and most modifications are limited to UI string updates, aligning with the consensus that we should primarily follow the name change on the surface to minimize internal breakage.
   
   I've initiated discussions on the Jenkins community forum regarding the licensing of the logo. The press page on Jenkins provides some information, but it's not conclusive. I believe obtaining clarity on this is crucial.
   
   If you have any additional insights or thoughts on these matters, please do share them with me.
   
   Thank you for your ongoing support.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "rothardo (via GitHub)" <gi...@apache.org>.
rothardo commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1868534812

   Hi @matthiasblaesing  ,
   
   I wanted to provide you with an update on the PR.
   
   I have addressed the concerns raised during the review process, and I've reverted the keys that were changed, and most modifications are limited to UI string updates, aligning with the consensus that we should primarily follow the name change on the surface to minimize internal breakage.
   
   I've initiated discussions on the Jenkins community forum regarding the licensing of the logo. The press page on Jenkins provides some information, but it's not conclusive. I believe obtaining clarity on this is crucial.
   
   If you have any additional insights or thoughts on these matters, please do share them with me.
   
   Thank you for your ongoing support.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1445146547


##########
ide/hudson/src/org/netbeans/modules/hudson/Bundle.properties:
##########
@@ -17,7 +17,7 @@
 
 OpenIDE-Module-Display-Category=Base IDE
 OpenIDE-Module-Long-Description=\
-    Helps browse and manage installations of the Hudson continuous integration server (http://hudson-ci.org/). \
+    Helps browse and manage installations of the Jenkins continuous integration server (http://hudson-ci.org/). \
     http://wiki.netbeans.org/HudsonInNetBeans has more information.

Review Comment:
   lets remove this URL, we should only redirect to archive.org as last resort. If someone writes new jenkins doc we can still add a URL again to the module description.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1881651203

   @rothardo yes, please do so. change `http://hudson-ci.org/` into `https://www.jenkins.io/` and remove the dead link `http://wiki.netbeans.org/HudsonInNetBeans`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "rothardo (via GitHub)" <gi...@apache.org>.
rothardo commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1882563581

   @mbien I have completed the necessary changes as adviced


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1845905811

   > I have pushed changes after making changes as told, was that the right thing to do? I am asking this as I am new to the community
   
   thats fine during review, but before merge it would be good if you would squash everything locally to one commit, make sure the commit message is how you like it and then force push into the PR. This PR would have to do that anyway, due to the commit author field, see https://github.com/apache/netbeans/pull/6797#pullrequestreview-1768358808


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Renamed Hudson to Jenkins in UI [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1872330825

   @rothardo thanks for staying with this. My proposal how to handle the logo would be:
   
   https://github.com/apache/netbeans/commit/92b2c2bac3c3fd6f5da56cebf9e01d48e14f8ad2
   
   That is in https://github.com/matthiasblaesing/netbeans (branch: pr-6797) feel free to squash into your changes, if it makes sense to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists