You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by "John Schneider (JIRA)" <ji...@apache.org> on 2013/12/05 02:03:36 UTC

[jira] [Comment Edited] (DELTASPIKE-450) Secured ViewConfig's are not working as documented

    [ https://issues.apache.org/jira/browse/DELTASPIKE-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839631#comment-13839631 ] 

John Schneider edited comment on DELTASPIKE-450 at 12/5/13 1:02 AM:
--------------------------------------------------------------------

Test project attached that reproduces the issue in my environment - Glassfish 4, Weld 2.0.4, Mojarra 2.2.5 Snapshot.  Here is the output from Glassfish when deploying the app:

INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: class: org.apache.deltaspike.core.impl.exception.control.extension.ExceptionControlExtension activated=true
INFO: class: org.apache.deltaspike.jsf.impl.scope.mapped.MappedJsf2ScopeExtension activated=true
INFO: class: org.apache.deltaspike.jsf.impl.config.view.ViewConfigExtension activated=true
INFO: class: org.apache.deltaspike.core.impl.config.ConfigurationExtension activated=true
INFO: class: org.apache.deltaspike.jsf.impl.scope.view.ViewScopedExtension activated=true
INFO: class: org.apache.deltaspike.security.impl.extension.SecurityExtension activated=true
INFO: class: org.apache.deltaspike.core.impl.message.MessageBundleExtension activated=true
INFO: class: org.apache.deltaspike.core.impl.exclude.extension.ExcludeExtension activated=true
INFO: class: org.apache.deltaspike.core.impl.exclude.CustomProjectStageBeanFilter activated=true
INFO: class: org.apache.deltaspike.core.impl.exclude.GlobalAlternative activated=true
INFO: class: org.apache.deltaspike.core.impl.jmx.MBeanExtension activated=true
INFO: Computed the following DeltaSpike ProjectStage: Production
WARNING: The following warnings have been detected: WARNING: Parameter 1 of type T from public void org.apache.deltaspike.core.util.context.ContextualInstanceInfo.setContextualInstance(T) is not resolvable to a concrete type.
WARNING: Parameter 1 of type javax.enterprise.context.spi.CreationalContext<T> from public void org.apache.deltaspike.core.util.context.ContextualInstanceInfo.setCreationalContext(javax.enterprise.context.spi.CreationalContext<T>) is not resolvable to a concrete type.

INFO: class: org.apache.deltaspike.servlet.impl.event.EventBridgeContextListener activated=true
INFO: class: org.apache.deltaspike.servlet.impl.event.EventBridgeSessionListener activated=true
INFO: Initializing Mojarra 2.2.5 (-SNAPSHOT 20131127-0846 https://svn.java.net/svn/mojarra~svn/branches/MOJARRA_2_2X_ROLLING@12684) for context '/test'
INFO: class: org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeFacesContextFactory activated=true
WARNING: WELD-001529 An InjectionTarget is created for a class org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeFacesContextFactory which does not have any appropriate constructor.
INFO: class: org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleFactoryWrapper activated=true
WARNING: WELD-001529 An InjectionTarget is created for a class org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleFactoryWrapper which does not have any appropriate constructor.
INFO: class: org.apache.deltaspike.jsf.impl.listener.phase.JsfRequestLifecyclePhaseListener activated=true
INFO: class: org.apache.deltaspike.jsf.impl.listener.phase.DeltaSpikePhaseListener activated=true
INFO: class: org.apache.deltaspike.jsf.impl.navigation.DeltaSpikeNavigationHandler activated=true
INFO: class: org.apache.deltaspike.jsf.impl.listener.action.DeltaSpikeActionListener activated=true
INFO: class: org.apache.deltaspike.jsf.impl.view.DeltaSpikeViewHandler activated=true
INFO: class: org.apache.deltaspike.jsf.impl.security.SecurityAwareViewHandler activated=true
INFO: class: org.apache.deltaspike.servlet.impl.event.EventBridgeFilter activated=true
INFO: Loading application [test] at [/test]
INFO: test was successfully deployed in 1,654 milliseconds.


was (Author: johnschneider):
Test project that reproduces the issue in my environment - Glassfish 4, Weld 2.0.4, Mojarra 2.2.5 Snapshot.  Here is the output from Glassfish when deploying the app:

INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: visiting unvisited references
INFO: class: org.apache.deltaspike.core.impl.exception.control.extension.ExceptionControlExtension activated=true
INFO: class: org.apache.deltaspike.jsf.impl.scope.mapped.MappedJsf2ScopeExtension activated=true
INFO: class: org.apache.deltaspike.jsf.impl.config.view.ViewConfigExtension activated=true
INFO: class: org.apache.deltaspike.core.impl.config.ConfigurationExtension activated=true
INFO: class: org.apache.deltaspike.jsf.impl.scope.view.ViewScopedExtension activated=true
INFO: class: org.apache.deltaspike.security.impl.extension.SecurityExtension activated=true
INFO: class: org.apache.deltaspike.core.impl.message.MessageBundleExtension activated=true
INFO: class: org.apache.deltaspike.core.impl.exclude.extension.ExcludeExtension activated=true
INFO: class: org.apache.deltaspike.core.impl.exclude.CustomProjectStageBeanFilter activated=true
INFO: class: org.apache.deltaspike.core.impl.exclude.GlobalAlternative activated=true
INFO: class: org.apache.deltaspike.core.impl.jmx.MBeanExtension activated=true
INFO: Computed the following DeltaSpike ProjectStage: Production
WARNING: The following warnings have been detected: WARNING: Parameter 1 of type T from public void org.apache.deltaspike.core.util.context.ContextualInstanceInfo.setContextualInstance(T) is not resolvable to a concrete type.
WARNING: Parameter 1 of type javax.enterprise.context.spi.CreationalContext<T> from public void org.apache.deltaspike.core.util.context.ContextualInstanceInfo.setCreationalContext(javax.enterprise.context.spi.CreationalContext<T>) is not resolvable to a concrete type.

INFO: class: org.apache.deltaspike.servlet.impl.event.EventBridgeContextListener activated=true
INFO: class: org.apache.deltaspike.servlet.impl.event.EventBridgeSessionListener activated=true
INFO: Initializing Mojarra 2.2.5 (-SNAPSHOT 20131127-0846 https://svn.java.net/svn/mojarra~svn/branches/MOJARRA_2_2X_ROLLING@12684) for context '/test'
INFO: class: org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeFacesContextFactory activated=true
WARNING: WELD-001529 An InjectionTarget is created for a class org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeFacesContextFactory which does not have any appropriate constructor.
INFO: class: org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleFactoryWrapper activated=true
WARNING: WELD-001529 An InjectionTarget is created for a class org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleFactoryWrapper which does not have any appropriate constructor.
INFO: class: org.apache.deltaspike.jsf.impl.listener.phase.JsfRequestLifecyclePhaseListener activated=true
INFO: class: org.apache.deltaspike.jsf.impl.listener.phase.DeltaSpikePhaseListener activated=true
INFO: class: org.apache.deltaspike.jsf.impl.navigation.DeltaSpikeNavigationHandler activated=true
INFO: class: org.apache.deltaspike.jsf.impl.listener.action.DeltaSpikeActionListener activated=true
INFO: class: org.apache.deltaspike.jsf.impl.view.DeltaSpikeViewHandler activated=true
INFO: class: org.apache.deltaspike.jsf.impl.security.SecurityAwareViewHandler activated=true
INFO: class: org.apache.deltaspike.servlet.impl.event.EventBridgeFilter activated=true
INFO: Loading application [test] at [/test]
INFO: test was successfully deployed in 1,654 milliseconds.

> Secured ViewConfig's are not working as documented
> --------------------------------------------------
>
>                 Key: DELTASPIKE-450
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-450
>             Project: DeltaSpike
>          Issue Type: Bug
>          Components: Core, Security-Module
>    Affects Versions: 0.5
>         Environment: Glassfish 4 / Weld 2.0.4
>            Reporter: John Schneider
>            Assignee: Gerhard Petracek
>         Attachments: test.zip
>
>
> I believe this is the documented method for securing pages, but the following view configuration does not invoke an AccessDecisionVoter.
> @View(navigation = NavigationMode.REDIRECT)
> public interface Pages extends ViewConfig {
>   class LogIn implements Pages {}
>   @Secured(value = ApplicationAccessDecisionVoter.class, errorView = LogIn.class)
>   class Manage implements Pages {}
> }
> I also tried with a @Sterotype @Secured annotation which I've confirmed to be working perfectly when placed on a CDI business method. 
> @Retention(RetentionPolicy.RUNTIME)
> @Target({ElementType.TYPE, ElementType.METHOD, ElementType.FIELD})
> @Documented
> @Stereotype
> @Secured(value = ApplicationAccessDecisionVoter.class, errorView = LogIn.class)
> public @interface LoggedIn {
> }
> @View(navigation = NavigationMode.REDIRECT)
> public interface Pages extends ViewConfig {
>   class LogIn implements Pages {}
>   @LoggedIn
>   class Manage implements Pages {}
> }



--
This message was sent by Atlassian JIRA
(v6.1#6144)