You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:25:40 UTC

[GitHub] [incubator-tubemq] viviel opened a new pull request #140: [TUBEMQ-228] Fixed: Exception used

viviel opened a new pull request #140:
URL: https://github.com/apache/incubator-tubemq/pull/140


   Fix exception use
   `Exception -> IllegalArgumentException`
   Example
   ```
   if (TStringUtils.isBlank(strTimeVal)) {
       throw new Exception(strValName + " value is null or blank of "
               + ruleType + " limit rule!");
   }
   
   change to 
   
   if (TStringUtils.isBlank(strTimeVal)) {
       throw new IllegalArgumentException(strValName + " value is null or blank of "
               + ruleType + " limit rule!");
   }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] dockerzhang commented on pull request #140: [TUBEMQ-228] Fixed: Exception used

Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #140:
URL: https://github.com/apache/incubator-tubemq/pull/140#issuecomment-640973859


   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] viviel closed pull request #140: [TUBEMQ-228] Fixed: Exception used

Posted by GitBox <gi...@apache.org>.
viviel closed pull request #140:
URL: https://github.com/apache/incubator-tubemq/pull/140


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] viviel commented on pull request #140: [TUBEMQ-228] Fixed: Exception used

Posted by GitBox <gi...@apache.org>.
viviel commented on pull request #140:
URL: https://github.com/apache/incubator-tubemq/pull/140#issuecomment-641000491


   Oh, I'm sorry, but this is specially shown to throw the inspected exception. I will close this pr


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org