[GitHub] [airflow] potiuk commented on a diff in pull request #28432: Fix discoverability of tests for ARM in Breeze

[GitBox <gi...@apache.org>]

potiuk commented on code in PR #28432:
URL: https://github.com/apache/airflow/pull/28432#discussion_r1051630531


##########
tests/system/providers/google/leveldb/example_leveldb.py:
##########
@@ -23,8 +23,16 @@
 import os
 from datetime import datetime
 
+import pytest
+
 from airflow import models
-from airflow.providers.google.leveldb.operators.leveldb import LevelDBOperator
+from airflow.exceptions import AirflowOptionalProviderFeatureException
+
+try:
+    from airflow.providers.google.leveldb.operators.leveldb import LevelDBOperator
+except AirflowOptionalProviderFeatureException:
+    pytest.skip("LevelDB not available", allow_module_level=True)

Review Comment:
   Yeah we can attempt to do it as next step. The difference is that the first one was needed for image building that's why aarch exclusion - the second is just extra specification for google provider (and those two might not be synchronized indeed). But if we can build it in the way you described, that would be better than excluding it. I will try it in a moment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org