[GitHub] [superset] graceguo-supercat edited a comment on pull request #18181: fix: Explore long URL problem

[GitBox <gi...@apache.org>]

graceguo-supercat edited a comment on pull request #18181:
URL: https://github.com/apache/superset/pull/18181#issuecomment-1056043302


   @villebro Thanks for the extra iterations. I have one question about implementation:
   
   > Adding permanent link endpoints for Dashboard and Explore that will persist the data in the metadata database and replace the current ones, while maintaining backwards compatibility with current short links
   After this change, when user clicks on the shorten url link from Dashboard and Explore view,  do you plan to use the old /r/12345 shorten url functions, or generate a new hashed key?
   
   I kind of prefer to use old shorten url `/r/12345` for the permanent shorten link, since this will be consistent with old behavior. While hashed key url, it will be created and only used by explore view navigation, I assume most of hashed explore view urls will be abandoned, and it mean to be re-usable in short term. 
   So I prefer to make these 2 use cases clearly different. What do you think?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org