You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by si...@apache.org on 2013/03/07 15:14:40 UTC

svn commit: r1453880 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/ParameterParser.java

Author: simonetripodi
Date: Thu Mar  7 14:14:40 2013
New Revision: 1453880

URL: http://svn.apache.org/r1453880
Log:
PMD: These nested if statements could be combined

Modified:
    commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/ParameterParser.java

Modified: commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/ParameterParser.java
URL: http://svn.apache.org/viewvc/commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/ParameterParser.java?rev=1453880&r1=1453879&r2=1453880&view=diff
==============================================================================
--- commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/ParameterParser.java (original)
+++ commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/ParameterParser.java Thu Mar  7 14:14:40 2013
@@ -100,13 +100,12 @@ public class ParameterParser {
             i2--;
         }
         // Strip away quotation marks if necessary
-        if (quoted) {
-            if (((i2 - i1) >= 2)
-                && (chars[i1] == '"')
-                && (chars[i2 - 1] == '"')) {
-                i1++;
-                i2--;
-            }
+        if (quoted
+            && ((i2 - i1) >= 2)
+            && (chars[i1] == '"')
+            && (chars[i2 - 1] == '"')) {
+            i1++;
+            i2--;
         }
         String result = null;
         if (i2 > i1) {