[GitHub] [spark] sitegui commented on a change in pull request #26029: [SPARK-29336][SQL] Fix the implementation of QuantileSummaries.merge (guarantee that the relativeError will be respected)

[GitBox <gi...@apache.org>]

sitegui commented on a change in pull request #26029: [SPARK-29336][SQL] Fix the implementation of QuantileSummaries.merge (guarantee that the relativeError will be respected)
URL: https://github.com/apache/spark/pull/26029#discussion_r331740235
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala
 ##########
 @@ -169,5 +170,22 @@ class QuantileSummariesSuite extends SparkFunSuite {
       checkQuantile(0.1, data, s)
       checkQuantile(0.001, data, s)
     }
+
+    // length of data21 is 4 * length of data22
+    val data21 = data.zipWithIndex.filter(_._2 % 5 != 0).map(_._1).toSeq
 
 Review comment:
   Hello @srowen , thanks a lot for the remarks. I've fixed the other two, but for this one, if I understood the usage correctly, I need to do something on the lines of:
   
   ```scala
   val (iterData21, iterData22) = data.zipWithIndex.partition(_._2 % 5 != 0)
   val data21 = iterData21.map(_._1).toSeq
   val data22 = iterData22.map(_._1).toSeq
   ```
   
   Or is there a cleaner way to do it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org