You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2014/07/21 20:29:57 UTC

Review Request 23749: Missing Apache headers

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
-------

Adding missing Apache licence headers on .cpp, .hpp and Makefiles, adding to mesos/support the script I use to make this patch.


Diffs
-----

  3rdparty/libprocess/3rdparty/Makefile.am 705d19c 
  3rdparty/libprocess/3rdparty/stout/Makefile.am b6464de 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 6fa5b74 
  3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp deb8df3 
  3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp 18b2474 
  3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp 3065278 
  3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 4269d3c 
  3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp d86b0ea 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8 
  3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 13296d8 
  3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp eb3abfc 
  3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3c4b732 
  3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d15 
  3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 685a9a1 
  3rdparty/libprocess/3rdparty/stout/tests/main.cpp 0f1e9cb 
  3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 79e7200 
  3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 425132e 
  3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 38d25bb 
  3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 7ae3b8f 
  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 4fe3f22 
  3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp ff9f10b 
  3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp ad79a16 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 7fa7346 
  3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp c723bd7 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 0651185 
  3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp cdedacd 
  3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 4041dc4 
  3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 
  3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 7519b12 
  3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp ad1d986 
  3rdparty/libprocess/Makefile.am 583f6ef 
  3rdparty/libprocess/examples/example.cpp 3fb4ef5 
  3rdparty/libprocess/include/Makefile.am 09f6e41 
  3rdparty/libprocess/include/process/async.hpp 9af3cc0 
  3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07 
  3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b 
  3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db 
  3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da282 
  3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d2 
  3rdparty/libprocess/include/process/clock.hpp eb157ca 
  3rdparty/libprocess/include/process/collect.hpp 3bee8a6 
  3rdparty/libprocess/include/process/defer.hpp dc2ec3b 
  3rdparty/libprocess/include/process/deferred.hpp 0552fb5 
  3rdparty/libprocess/include/process/delay.hpp 487f652 
  3rdparty/libprocess/include/process/dispatch.hpp 88570f7 
  3rdparty/libprocess/include/process/event.hpp 3c860f4 
  3rdparty/libprocess/include/process/executor.hpp e28790e 
  3rdparty/libprocess/include/process/filter.hpp aa0c91b 
  3rdparty/libprocess/include/process/future.hpp 5b0ed9b 
  3rdparty/libprocess/include/process/gc.hpp e83c636 
  3rdparty/libprocess/include/process/gmock.hpp 6330ea6 
  3rdparty/libprocess/include/process/gtest.hpp b77e2fc 
  3rdparty/libprocess/include/process/help.hpp 4333b5b 
  3rdparty/libprocess/include/process/http.hpp 6358e33 
  3rdparty/libprocess/include/process/id.hpp 8c256b9 
  3rdparty/libprocess/include/process/internal.hpp 9f478ec 
  3rdparty/libprocess/include/process/io.hpp c775290 
  3rdparty/libprocess/include/process/latch.hpp 9d010f0 
  3rdparty/libprocess/include/process/limiter.hpp 846ec09 
  3rdparty/libprocess/include/process/logging.hpp 1220223 
  3rdparty/libprocess/include/process/message.hpp c67c5e1 
  3rdparty/libprocess/include/process/metrics/counter.hpp 6800e7a 
  3rdparty/libprocess/include/process/metrics/gauge.hpp af06534 
  3rdparty/libprocess/include/process/metrics/metric.hpp 00ace49 
  3rdparty/libprocess/include/process/metrics/metrics.hpp 0a97f12 
  3rdparty/libprocess/include/process/metrics/timer.hpp 0b253aa 
  3rdparty/libprocess/include/process/mime.hpp 0abeac1 
  3rdparty/libprocess/include/process/mutex.hpp 3ff8955 
  3rdparty/libprocess/include/process/once.hpp e85b382 
  3rdparty/libprocess/include/process/owned.hpp ad6c734 
  3rdparty/libprocess/include/process/pid.hpp fbd512f 
  3rdparty/libprocess/include/process/process.hpp 3c31dfb 
  3rdparty/libprocess/include/process/profiler.hpp c886d7e 
  3rdparty/libprocess/include/process/protobuf.hpp a232107 
  3rdparty/libprocess/include/process/queue.hpp 0403e25 
  3rdparty/libprocess/include/process/reap.hpp 9de5336 
  3rdparty/libprocess/include/process/run.hpp 924d31a 
  3rdparty/libprocess/include/process/sequence.hpp 241afd2 
  3rdparty/libprocess/include/process/shared.hpp 572ea2d 
  3rdparty/libprocess/include/process/socket.hpp dbcb4f4 
  3rdparty/libprocess/include/process/statistics.hpp 929fb8d 
  3rdparty/libprocess/include/process/subprocess.hpp 7ff5a10 
  3rdparty/libprocess/include/process/system.hpp 48a02f0 
  3rdparty/libprocess/include/process/time.hpp 0803dc5 
  3rdparty/libprocess/include/process/timeout.hpp 40906cb 
  3rdparty/libprocess/include/process/timer.hpp e2f5563 
  3rdparty/libprocess/include/process/timeseries.hpp dbb2c7a 
  3rdparty/libprocess/include/process/tuples/details.hpp 80b0539 
  3rdparty/libprocess/include/process/tuples/tuples.hpp ac1198e 
  3rdparty/libprocess/src/config.hpp cbaf41d 
  3rdparty/libprocess/src/decoder.hpp c329882 
  3rdparty/libprocess/src/encoder.hpp 9c5aa81 
  3rdparty/libprocess/src/fatal.hpp 38646f3 
  3rdparty/libprocess/src/fatal.cpp b2934e0 
  3rdparty/libprocess/src/gate.hpp 69c906b 
  3rdparty/libprocess/src/http.cpp 4ef00d1 
  3rdparty/libprocess/src/httpd.cpp 4f4ab1b 
  3rdparty/libprocess/src/latch.cpp 89185ec 
  3rdparty/libprocess/src/metrics/metrics.cpp 38905d3 
  3rdparty/libprocess/src/net.hpp 1ba3dbb 
  3rdparty/libprocess/src/pid.cpp 20ff25c 
  3rdparty/libprocess/src/process.cpp 0c0fca7 
  3rdparty/libprocess/src/reap.cpp b350ee1 
  3rdparty/libprocess/src/subprocess.cpp 68bfd5d 
  3rdparty/libprocess/src/synchronized.hpp 577a5fc 
  3rdparty/libprocess/src/test-master.cpp f272919 
  3rdparty/libprocess/src/test-slave.cpp cf9b52c 
  3rdparty/libprocess/src/tests/decoder_tests.cpp 04ca3ff 
  3rdparty/libprocess/src/tests/encoder_tests.cpp 784a2c7 
  3rdparty/libprocess/src/tests/http_tests.cpp a1c3685 
  3rdparty/libprocess/src/tests/io_tests.cpp 05ea7bb 
  3rdparty/libprocess/src/tests/main.cpp 6c672b4 
  3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e4 
  3rdparty/libprocess/src/tests/mutex_tests.cpp 451b234 
  3rdparty/libprocess/src/tests/owned_tests.cpp 50025d9 
  3rdparty/libprocess/src/tests/process_tests.cpp ebce48c 
  3rdparty/libprocess/src/tests/queue_tests.cpp 79741d3 
  3rdparty/libprocess/src/tests/reap_tests.cpp a18d54c 
  3rdparty/libprocess/src/tests/sequence_tests.cpp 6b5d161 
  3rdparty/libprocess/src/tests/shared_tests.cpp 1df67b4 
  3rdparty/libprocess/src/tests/statistics_tests.cpp 0e4960a 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 98a4e44 
  3rdparty/libprocess/src/tests/time_tests.cpp be31418 
  3rdparty/libprocess/src/tests/timeseries_tests.cpp fd906b8 
  3rdparty/libprocess/src/timeseries.cpp 89af8ec 
  src/cli/mesos.cpp 171a707 
  src/common/http.cpp e81a7ad 
  src/common/thread.hpp 7e48724 
  src/files/files.cpp 3dacc66 
  src/hdfs/hdfs.hpp bbfedde 
  src/java/jni/org_apache_mesos_state_AbstractState.cpp 1accc8a 
  src/java/jni/org_apache_mesos_state_LevelDBState.cpp 30f6309 
  src/java/jni/org_apache_mesos_state_Variable.cpp 4d840ce 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp c40e685 
  src/jvm/java/io.hpp fcb1409 
  src/jvm/java/lang.hpp 6fc6566 
  src/jvm/java/net.hpp cabb3e5 
  src/jvm/jvm.hpp 2f2e1d1 
  src/jvm/jvm.cpp d33a655 
  src/jvm/org/apache/log4j.hpp 0913a6b 
  src/jvm/org/apache/log4j.cpp 105629c 
  src/jvm/org/apache/zookeeper.hpp 0797d47 
  src/jvm/org/apache/zookeeper.cpp 192b647 
  src/sasl/auxprop.cpp 6de1222 
  src/slave/state.cpp 87e9eb9 
  src/state/in_memory.hpp 2040618 
  src/state/in_memory.cpp ce04e47 
  src/state/leveldb.hpp 53447c6 
  src/state/leveldb.cpp 4303df3 
  src/state/log.hpp 6bd054f 
  src/state/log.cpp fd8b28a 
  src/state/zookeeper.hpp 1a8483d 
  src/state/zookeeper.cpp d355bd7 
  src/zookeeper/authentication.hpp 7b6b767 
  src/zookeeper/authentication.cpp ccd6bf7 
  src/zookeeper/contender.hpp 6529245 
  src/zookeeper/contender.cpp 55cb7a1 
  src/zookeeper/detector.hpp e41158e 
  src/zookeeper/detector.cpp 5305161 
  src/zookeeper/group.hpp 16f9b7b 
  src/zookeeper/group.cpp 58491c0 
  src/zookeeper/watcher.hpp 1e347ed 
  support/check-apache-headers.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/23749/diff/


Testing
-------


Thanks,

Isabel Jimenez


Re: Review Request 23749: Missing Apache headers for stout

Posted by Isabel Jimenez <co...@isabeljimenez.com>.

> On July 21, 2014, 6:41 p.m., Dominic Hamon wrote:
> > It is good practice to split this change across stout/libprocess/mesos boundaries.

Thanks for the tip, I split this in three, see : https://reviews.apache.org/r/23783/ and https://reviews.apache.org/r/23784/


- Isabel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/#review48269
-----------------------------------------------------------


On July 22, 2014, 12:33 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23749/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 12:33 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Adding missing Apache licence headers on .cpp, .hpp and Makefiles, adding to mesos/support the script I use to make this patch.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am b6464de 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 6fa5b74 
>   3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp deb8df3 
>   3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp 18b2474 
>   3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp 3065278 
>   3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 4269d3c 
>   3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp d86b0ea 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8 
>   3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 13296d8 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp eb3abfc 
>   3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3c4b732 
>   3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d15 
>   3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 685a9a1 
>   3rdparty/libprocess/3rdparty/stout/tests/main.cpp 0f1e9cb 
>   3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 79e7200 
>   3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 425132e 
>   3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 38d25bb 
>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 7ae3b8f 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 4fe3f22 
>   3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp ff9f10b 
>   3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp ad79a16 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 7fa7346 
>   3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp c723bd7 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 0651185 
>   3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp cdedacd 
>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 4041dc4 
>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 7519b12 
>   3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp ad1d986 
> 
> Diff: https://reviews.apache.org/r/23749/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Re: Review Request 23749: Missing Apache headers

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/#review48269
-----------------------------------------------------------


It is good practice to split this change across stout/libprocess/mesos boundaries.

- Dominic Hamon


On July 21, 2014, 11:29 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23749/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 11:29 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Adding missing Apache licence headers on .cpp, .hpp and Makefiles, adding to mesos/support the script I use to make this patch.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 705d19c 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am b6464de 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 6fa5b74 
>   3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp deb8df3 
>   3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp 18b2474 
>   3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp 3065278 
>   3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 4269d3c 
>   3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp d86b0ea 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8 
>   3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 13296d8 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp eb3abfc 
>   3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3c4b732 
>   3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d15 
>   3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 685a9a1 
>   3rdparty/libprocess/3rdparty/stout/tests/main.cpp 0f1e9cb 
>   3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 79e7200 
>   3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 425132e 
>   3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 38d25bb 
>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 7ae3b8f 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 4fe3f22 
>   3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp ff9f10b 
>   3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp ad79a16 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 7fa7346 
>   3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp c723bd7 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 0651185 
>   3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp cdedacd 
>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 4041dc4 
>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 7519b12 
>   3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp ad1d986 
>   3rdparty/libprocess/Makefile.am 583f6ef 
>   3rdparty/libprocess/examples/example.cpp 3fb4ef5 
>   3rdparty/libprocess/include/Makefile.am 09f6e41 
>   3rdparty/libprocess/include/process/async.hpp 9af3cc0 
>   3rdparty/libprocess/include/process/c++11/defer.hpp 7b4dd07 
>   3rdparty/libprocess/include/process/c++11/deferred.hpp 352205b 
>   3rdparty/libprocess/include/process/c++11/delay.hpp 5f686db 
>   3rdparty/libprocess/include/process/c++11/dispatch.hpp 76da282 
>   3rdparty/libprocess/include/process/c++11/executor.hpp 157a1d2 
>   3rdparty/libprocess/include/process/clock.hpp eb157ca 
>   3rdparty/libprocess/include/process/collect.hpp 3bee8a6 
>   3rdparty/libprocess/include/process/defer.hpp dc2ec3b 
>   3rdparty/libprocess/include/process/deferred.hpp 0552fb5 
>   3rdparty/libprocess/include/process/delay.hpp 487f652 
>   3rdparty/libprocess/include/process/dispatch.hpp 88570f7 
>   3rdparty/libprocess/include/process/event.hpp 3c860f4 
>   3rdparty/libprocess/include/process/executor.hpp e28790e 
>   3rdparty/libprocess/include/process/filter.hpp aa0c91b 
>   3rdparty/libprocess/include/process/future.hpp 5b0ed9b 
>   3rdparty/libprocess/include/process/gc.hpp e83c636 
>   3rdparty/libprocess/include/process/gmock.hpp 6330ea6 
>   3rdparty/libprocess/include/process/gtest.hpp b77e2fc 
>   3rdparty/libprocess/include/process/help.hpp 4333b5b 
>   3rdparty/libprocess/include/process/http.hpp 6358e33 
>   3rdparty/libprocess/include/process/id.hpp 8c256b9 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/include/process/io.hpp c775290 
>   3rdparty/libprocess/include/process/latch.hpp 9d010f0 
>   3rdparty/libprocess/include/process/limiter.hpp 846ec09 
>   3rdparty/libprocess/include/process/logging.hpp 1220223 
>   3rdparty/libprocess/include/process/message.hpp c67c5e1 
>   3rdparty/libprocess/include/process/metrics/counter.hpp 6800e7a 
>   3rdparty/libprocess/include/process/metrics/gauge.hpp af06534 
>   3rdparty/libprocess/include/process/metrics/metric.hpp 00ace49 
>   3rdparty/libprocess/include/process/metrics/metrics.hpp 0a97f12 
>   3rdparty/libprocess/include/process/metrics/timer.hpp 0b253aa 
>   3rdparty/libprocess/include/process/mime.hpp 0abeac1 
>   3rdparty/libprocess/include/process/mutex.hpp 3ff8955 
>   3rdparty/libprocess/include/process/once.hpp e85b382 
>   3rdparty/libprocess/include/process/owned.hpp ad6c734 
>   3rdparty/libprocess/include/process/pid.hpp fbd512f 
>   3rdparty/libprocess/include/process/process.hpp 3c31dfb 
>   3rdparty/libprocess/include/process/profiler.hpp c886d7e 
>   3rdparty/libprocess/include/process/protobuf.hpp a232107 
>   3rdparty/libprocess/include/process/queue.hpp 0403e25 
>   3rdparty/libprocess/include/process/reap.hpp 9de5336 
>   3rdparty/libprocess/include/process/run.hpp 924d31a 
>   3rdparty/libprocess/include/process/sequence.hpp 241afd2 
>   3rdparty/libprocess/include/process/shared.hpp 572ea2d 
>   3rdparty/libprocess/include/process/socket.hpp dbcb4f4 
>   3rdparty/libprocess/include/process/statistics.hpp 929fb8d 
>   3rdparty/libprocess/include/process/subprocess.hpp 7ff5a10 
>   3rdparty/libprocess/include/process/system.hpp 48a02f0 
>   3rdparty/libprocess/include/process/time.hpp 0803dc5 
>   3rdparty/libprocess/include/process/timeout.hpp 40906cb 
>   3rdparty/libprocess/include/process/timer.hpp e2f5563 
>   3rdparty/libprocess/include/process/timeseries.hpp dbb2c7a 
>   3rdparty/libprocess/include/process/tuples/details.hpp 80b0539 
>   3rdparty/libprocess/include/process/tuples/tuples.hpp ac1198e 
>   3rdparty/libprocess/src/config.hpp cbaf41d 
>   3rdparty/libprocess/src/decoder.hpp c329882 
>   3rdparty/libprocess/src/encoder.hpp 9c5aa81 
>   3rdparty/libprocess/src/fatal.hpp 38646f3 
>   3rdparty/libprocess/src/fatal.cpp b2934e0 
>   3rdparty/libprocess/src/gate.hpp 69c906b 
>   3rdparty/libprocess/src/http.cpp 4ef00d1 
>   3rdparty/libprocess/src/httpd.cpp 4f4ab1b 
>   3rdparty/libprocess/src/latch.cpp 89185ec 
>   3rdparty/libprocess/src/metrics/metrics.cpp 38905d3 
>   3rdparty/libprocess/src/net.hpp 1ba3dbb 
>   3rdparty/libprocess/src/pid.cpp 20ff25c 
>   3rdparty/libprocess/src/process.cpp 0c0fca7 
>   3rdparty/libprocess/src/reap.cpp b350ee1 
>   3rdparty/libprocess/src/subprocess.cpp 68bfd5d 
>   3rdparty/libprocess/src/synchronized.hpp 577a5fc 
>   3rdparty/libprocess/src/test-master.cpp f272919 
>   3rdparty/libprocess/src/test-slave.cpp cf9b52c 
>   3rdparty/libprocess/src/tests/decoder_tests.cpp 04ca3ff 
>   3rdparty/libprocess/src/tests/encoder_tests.cpp 784a2c7 
>   3rdparty/libprocess/src/tests/http_tests.cpp a1c3685 
>   3rdparty/libprocess/src/tests/io_tests.cpp 05ea7bb 
>   3rdparty/libprocess/src/tests/main.cpp 6c672b4 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e4 
>   3rdparty/libprocess/src/tests/mutex_tests.cpp 451b234 
>   3rdparty/libprocess/src/tests/owned_tests.cpp 50025d9 
>   3rdparty/libprocess/src/tests/process_tests.cpp ebce48c 
>   3rdparty/libprocess/src/tests/queue_tests.cpp 79741d3 
>   3rdparty/libprocess/src/tests/reap_tests.cpp a18d54c 
>   3rdparty/libprocess/src/tests/sequence_tests.cpp 6b5d161 
>   3rdparty/libprocess/src/tests/shared_tests.cpp 1df67b4 
>   3rdparty/libprocess/src/tests/statistics_tests.cpp 0e4960a 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 98a4e44 
>   3rdparty/libprocess/src/tests/time_tests.cpp be31418 
>   3rdparty/libprocess/src/tests/timeseries_tests.cpp fd906b8 
>   3rdparty/libprocess/src/timeseries.cpp 89af8ec 
>   src/cli/mesos.cpp 171a707 
>   src/common/http.cpp e81a7ad 
>   src/common/thread.hpp 7e48724 
>   src/files/files.cpp 3dacc66 
>   src/hdfs/hdfs.hpp bbfedde 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 1accc8a 
>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp 30f6309 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 4d840ce 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp c40e685 
>   src/jvm/java/io.hpp fcb1409 
>   src/jvm/java/lang.hpp 6fc6566 
>   src/jvm/java/net.hpp cabb3e5 
>   src/jvm/jvm.hpp 2f2e1d1 
>   src/jvm/jvm.cpp d33a655 
>   src/jvm/org/apache/log4j.hpp 0913a6b 
>   src/jvm/org/apache/log4j.cpp 105629c 
>   src/jvm/org/apache/zookeeper.hpp 0797d47 
>   src/jvm/org/apache/zookeeper.cpp 192b647 
>   src/sasl/auxprop.cpp 6de1222 
>   src/slave/state.cpp 87e9eb9 
>   src/state/in_memory.hpp 2040618 
>   src/state/in_memory.cpp ce04e47 
>   src/state/leveldb.hpp 53447c6 
>   src/state/leveldb.cpp 4303df3 
>   src/state/log.hpp 6bd054f 
>   src/state/log.cpp fd8b28a 
>   src/state/zookeeper.hpp 1a8483d 
>   src/state/zookeeper.cpp d355bd7 
>   src/zookeeper/authentication.hpp 7b6b767 
>   src/zookeeper/authentication.cpp ccd6bf7 
>   src/zookeeper/contender.hpp 6529245 
>   src/zookeeper/contender.cpp 55cb7a1 
>   src/zookeeper/detector.hpp e41158e 
>   src/zookeeper/detector.cpp 5305161 
>   src/zookeeper/group.hpp 16f9b7b 
>   src/zookeeper/group.cpp 58491c0 
>   src/zookeeper/watcher.hpp 1e347ed 
>   support/check-apache-headers.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23749/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Re: Review Request 23749: Missing Apache headers for mesos

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/#review91001
-----------------------------------------------------------


Patch looks great!

Reviews applied: [23749]

All tests passed.

- Mesos ReviewBot


On July 8, 2015, 7:17 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23749/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 7:17 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding missing Apache licence headers on .cpp, .hpp and Makefiles
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos.cpp 0c315f7 
>   src/files/files.cpp 3a62ee7 
>   src/hdfs/hdfs.hpp cba386a 
>   src/slave/state.cpp fab47a7 
>   src/state/in_memory.hpp 2040618 
>   src/state/in_memory.cpp ce04e47 
>   src/state/leveldb.hpp 53447c6 
>   src/state/leveldb.cpp 14a1807 
>   src/state/log.hpp a0ca4f8 
>   src/state/log.cpp 326f3a7 
>   src/state/zookeeper.hpp 1a8483d 
>   src/state/zookeeper.cpp 9151d55 
>   src/tests/active_user_test_helper.cpp c32d467 
>   src/zookeeper/authentication.hpp 7b6b767 
>   src/zookeeper/authentication.cpp ccd6bf7 
>   src/zookeeper/contender.hpp 6529245 
>   src/zookeeper/contender.cpp 3255ef0 
>   src/zookeeper/detector.hpp e41158e 
>   src/zookeeper/detector.cpp 5305161 
>   src/zookeeper/group.hpp 9246130 
>   src/zookeeper/group.cpp 01066e3 
>   src/zookeeper/watcher.hpp 1e347ed 
> 
> Diff: https://reviews.apache.org/r/23749/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Re: Review Request 23749: Missing Apache headers for mesos

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/
-----------------------------------------------------------

(Updated July 8, 2015, 7:17 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
-------

Adding missing Apache licence headers on .cpp, .hpp and Makefiles


Diffs
-----

  src/cli/mesos.cpp 0c315f7 
  src/files/files.cpp 3a62ee7 
  src/hdfs/hdfs.hpp cba386a 
  src/slave/state.cpp fab47a7 
  src/state/in_memory.hpp 2040618 
  src/state/in_memory.cpp ce04e47 
  src/state/leveldb.hpp 53447c6 
  src/state/leveldb.cpp 14a1807 
  src/state/log.hpp a0ca4f8 
  src/state/log.cpp 326f3a7 
  src/state/zookeeper.hpp 1a8483d 
  src/state/zookeeper.cpp 9151d55 
  src/tests/active_user_test_helper.cpp c32d467 
  src/zookeeper/authentication.hpp 7b6b767 
  src/zookeeper/authentication.cpp ccd6bf7 
  src/zookeeper/contender.hpp 6529245 
  src/zookeeper/contender.cpp 3255ef0 
  src/zookeeper/detector.hpp e41158e 
  src/zookeeper/detector.cpp 5305161 
  src/zookeeper/group.hpp 9246130 
  src/zookeeper/group.cpp 01066e3 
  src/zookeeper/watcher.hpp 1e347ed 

Diff: https://reviews.apache.org/r/23749/diff/


Testing
-------


Thanks,

Isabel Jimenez


Re: Review Request 23749: Missing Apache headers for mesos

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/#review90964
-----------------------------------------------------------


Bad patch!

Reviews applied: [23784]

Failed command: ./support/apply-review.sh -n -r 23784

Error:
 2015-07-08 19:14:12 URL:https://reviews.apache.org/r/23784/diff/raw/ [30874/30874] -> "23784.patch" [1]
Successfully applied: Missing Apache headers for stout

Adding missing Apache licence headers on .cpp, .hpp and Makefiles


Review: https://reviews.apache.org/r/23784
Checking 28 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
Total errors found: 0
ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
mesos:
  support/check-apache-header.sh
stout:
  3rdparty/libprocess/3rdparty/stout/Makefile.am
  3rdparty/libprocess/3rdparty/stout/configure.ac
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am
  3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/main.cpp
  3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp
Failed to commit patch

- Mesos ReviewBot


On July 8, 2015, 6:57 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23749/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 6:57 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding missing Apache licence headers on .cpp, .hpp and Makefiles
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos.cpp 0c315f7 
>   src/files/files.cpp 3a62ee7 
>   src/hdfs/hdfs.hpp cba386a 
>   src/slave/state.cpp fab47a7 
>   src/state/in_memory.hpp 2040618 
>   src/state/in_memory.cpp ce04e47 
>   src/state/leveldb.hpp 53447c6 
>   src/state/leveldb.cpp 14a1807 
>   src/state/log.hpp a0ca4f8 
>   src/state/log.cpp 326f3a7 
>   src/state/zookeeper.hpp 1a8483d 
>   src/state/zookeeper.cpp 9151d55 
>   src/tests/active_user_test_helper.cpp c32d467 
>   src/zookeeper/authentication.hpp 7b6b767 
>   src/zookeeper/authentication.cpp ccd6bf7 
>   src/zookeeper/contender.hpp 6529245 
>   src/zookeeper/contender.cpp 3255ef0 
>   src/zookeeper/detector.hpp e41158e 
>   src/zookeeper/detector.cpp 5305161 
>   src/zookeeper/group.hpp 9246130 
>   src/zookeeper/group.cpp 01066e3 
>   src/zookeeper/watcher.hpp 1e347ed 
> 
> Diff: https://reviews.apache.org/r/23749/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Re: Review Request 23749: Missing Apache headers for mesos

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/
-----------------------------------------------------------

(Updated July 8, 2015, 6:57 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
-------

Adding missing Apache licence headers on .cpp, .hpp and Makefiles


Diffs
-----

  src/cli/mesos.cpp 0c315f7 
  src/files/files.cpp 3a62ee7 
  src/hdfs/hdfs.hpp cba386a 
  src/slave/state.cpp fab47a7 
  src/state/in_memory.hpp 2040618 
  src/state/in_memory.cpp ce04e47 
  src/state/leveldb.hpp 53447c6 
  src/state/leveldb.cpp 14a1807 
  src/state/log.hpp a0ca4f8 
  src/state/log.cpp 326f3a7 
  src/state/zookeeper.hpp 1a8483d 
  src/state/zookeeper.cpp 9151d55 
  src/tests/active_user_test_helper.cpp c32d467 
  src/zookeeper/authentication.hpp 7b6b767 
  src/zookeeper/authentication.cpp ccd6bf7 
  src/zookeeper/contender.hpp 6529245 
  src/zookeeper/contender.cpp 3255ef0 
  src/zookeeper/detector.hpp e41158e 
  src/zookeeper/detector.cpp 5305161 
  src/zookeeper/group.hpp 9246130 
  src/zookeeper/group.cpp 01066e3 
  src/zookeeper/watcher.hpp 1e347ed 

Diff: https://reviews.apache.org/r/23749/diff/


Testing
-------


Thanks,

Isabel Jimenez


Re: Review Request 23749: Missing Apache headers for mesos

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/#review90628
-----------------------------------------------------------


Patch looks great!

Reviews applied: [23749]

All tests passed.

- Mesos ReviewBot


On July 6, 2015, 10:33 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23749/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 10:33 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding missing Apache licence headers on .cpp, .hpp and Makefiles
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos.cpp 0c315f7 
>   src/files/files.cpp 3a62ee7 
>   src/hdfs/hdfs.hpp cba386a 
>   src/slave/state.cpp fab47a7 
>   src/state/in_memory.hpp 2040618 
>   src/state/in_memory.cpp ce04e47 
>   src/state/leveldb.hpp 53447c6 
>   src/state/leveldb.cpp 14a1807 
>   src/state/log.hpp a0ca4f8 
>   src/state/log.cpp 326f3a7 
>   src/state/zookeeper.hpp 1a8483d 
>   src/state/zookeeper.cpp 9151d55 
>   src/tests/active_user_test_helper.cpp c32d467 
>   src/zookeeper/authentication.hpp 7b6b767 
>   src/zookeeper/authentication.cpp ccd6bf7 
>   src/zookeeper/contender.hpp 6529245 
>   src/zookeeper/contender.cpp 3255ef0 
>   src/zookeeper/detector.hpp e41158e 
>   src/zookeeper/detector.cpp 5305161 
>   src/zookeeper/group.hpp 9246130 
>   src/zookeeper/group.cpp 01066e3 
>   src/zookeeper/watcher.hpp 1e347ed 
> 
> Diff: https://reviews.apache.org/r/23749/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Re: Review Request 23749: Missing Apache headers for mesos

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/
-----------------------------------------------------------

(Updated July 6, 2015, 10:33 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
-------

Adding missing Apache licence headers on .cpp, .hpp and Makefiles


Diffs (updated)
-----

  src/cli/mesos.cpp 0c315f7 
  src/files/files.cpp 3a62ee7 
  src/hdfs/hdfs.hpp cba386a 
  src/slave/state.cpp fab47a7 
  src/state/in_memory.hpp 2040618 
  src/state/in_memory.cpp ce04e47 
  src/state/leveldb.hpp 53447c6 
  src/state/leveldb.cpp 14a1807 
  src/state/log.hpp a0ca4f8 
  src/state/log.cpp 326f3a7 
  src/state/zookeeper.hpp 1a8483d 
  src/state/zookeeper.cpp 9151d55 
  src/tests/active_user_test_helper.cpp c32d467 
  src/zookeeper/authentication.hpp 7b6b767 
  src/zookeeper/authentication.cpp ccd6bf7 
  src/zookeeper/contender.hpp 6529245 
  src/zookeeper/contender.cpp 3255ef0 
  src/zookeeper/detector.hpp e41158e 
  src/zookeeper/detector.cpp 5305161 
  src/zookeeper/group.hpp 9246130 
  src/zookeeper/group.cpp 01066e3 
  src/zookeeper/watcher.hpp 1e347ed 

Diff: https://reviews.apache.org/r/23749/diff/


Testing
-------


Thanks,

Isabel Jimenez


Re: Review Request 23749: Missing Apache headers for mesos

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/
-----------------------------------------------------------

(Updated July 6, 2015, 10:25 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
-------

Adding missing Apache licence headers on .cpp, .hpp and Makefiles


Diffs (updated)
-----

  src/cli/mesos.cpp 0c315f7 
  src/files/files.cpp 3a62ee7 
  src/hdfs/hdfs.hpp cba386a 
  src/slave/state.cpp fab47a7 
  src/state/in_memory.hpp 2040618 
  src/state/in_memory.cpp ce04e47 
  src/state/leveldb.hpp 53447c6 
  src/state/leveldb.cpp 14a1807 
  src/state/log.hpp a0ca4f8 
  src/state/log.cpp 326f3a7 
  src/state/zookeeper.hpp 1a8483d 
  src/state/zookeeper.cpp 9151d55 
  src/tests/active_user_test_helper.cpp c32d467 
  src/zookeeper/authentication.hpp 7b6b767 
  src/zookeeper/authentication.cpp ccd6bf7 
  src/zookeeper/contender.hpp 6529245 
  src/zookeeper/contender.cpp 3255ef0 
  src/zookeeper/detector.hpp e41158e 
  src/zookeeper/detector.cpp 5305161 
  src/zookeeper/group.hpp 9246130 
  src/zookeeper/group.cpp 01066e3 
  src/zookeeper/watcher.hpp 1e347ed 

Diff: https://reviews.apache.org/r/23749/diff/


Testing
-------


Thanks,

Isabel Jimenez


Re: Review Request 23749: Missing Apache headers for mesos

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/
-----------------------------------------------------------

(Updated July 22, 2014, 10:34 p.m.)


Review request for mesos and Benjamin Hindman.


Summary (updated)
-----------------

Missing Apache headers for mesos


Repository: mesos-git


Description (updated)
-------

Adding missing Apache licence headers on .cpp, .hpp and Makefiles


Diffs (updated)
-----

  src/cli/mesos.cpp 171a707 
  src/common/http.cpp e81a7ad 
  src/common/thread.hpp 7e48724 
  src/files/files.cpp 3dacc66 
  src/hdfs/hdfs.hpp bbfedde 
  src/java/jni/org_apache_mesos_state_AbstractState.cpp 1accc8a 
  src/java/jni/org_apache_mesos_state_LevelDBState.cpp 30f6309 
  src/java/jni/org_apache_mesos_state_Variable.cpp 4d840ce 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp c40e685 
  src/jvm/java/io.hpp fcb1409 
  src/jvm/java/lang.hpp 6fc6566 
  src/jvm/java/net.hpp cabb3e5 
  src/jvm/jvm.hpp 2f2e1d1 
  src/jvm/jvm.cpp d33a655 
  src/jvm/org/apache/log4j.hpp 0913a6b 
  src/jvm/org/apache/log4j.cpp 105629c 
  src/jvm/org/apache/zookeeper.hpp 0797d47 
  src/jvm/org/apache/zookeeper.cpp 192b647 
  src/sasl/auxprop.cpp 6de1222 
  src/slave/state.cpp 87e9eb9 
  src/state/in_memory.hpp 2040618 
  src/state/in_memory.cpp ce04e47 
  src/state/leveldb.hpp 53447c6 
  src/state/leveldb.cpp 4303df3 
  src/state/log.hpp 6bd054f 
  src/state/log.cpp fd8b28a 
  src/state/zookeeper.hpp 1a8483d 
  src/state/zookeeper.cpp d355bd7 
  src/zookeeper/authentication.hpp 7b6b767 
  src/zookeeper/authentication.cpp ccd6bf7 
  src/zookeeper/contender.hpp 6529245 
  src/zookeeper/contender.cpp 55cb7a1 
  src/zookeeper/detector.hpp e41158e 
  src/zookeeper/detector.cpp 5305161 
  src/zookeeper/group.hpp 16f9b7b 
  src/zookeeper/group.cpp 58491c0 
  src/zookeeper/watcher.hpp 1e347ed 

Diff: https://reviews.apache.org/r/23749/diff/


Testing
-------


Thanks,

Isabel Jimenez


Re: Review Request 23749: Missing Apache headers for stout

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/
-----------------------------------------------------------

(Updated July 22, 2014, 12:33 a.m.)


Review request for mesos and Benjamin Hindman.


Summary (updated)
-----------------

Missing Apache headers for stout


Repository: mesos-git


Description
-------

Adding missing Apache licence headers on .cpp, .hpp and Makefiles, adding to mesos/support the script I use to make this patch.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am b6464de 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 6fa5b74 
  3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp deb8df3 
  3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp 18b2474 
  3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp 3065278 
  3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 4269d3c 
  3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp d86b0ea 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8 
  3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 13296d8 
  3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp eb3abfc 
  3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3c4b732 
  3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d15 
  3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 685a9a1 
  3rdparty/libprocess/3rdparty/stout/tests/main.cpp 0f1e9cb 
  3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 79e7200 
  3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 425132e 
  3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 38d25bb 
  3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 7ae3b8f 
  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 4fe3f22 
  3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp ff9f10b 
  3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp ad79a16 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 7fa7346 
  3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp c723bd7 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 0651185 
  3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp cdedacd 
  3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 4041dc4 
  3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 
  3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 7519b12 
  3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp ad1d986 

Diff: https://reviews.apache.org/r/23749/diff/


Testing
-------


Thanks,

Isabel Jimenez