You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2022/06/28 09:41:10 UTC
[GitHub] [knox] MrtnBalazs opened a new pull request, #601: KNOX-123 - Test commit
MrtnBalazs opened a new pull request, #601:
URL: https://github.com/apache/knox/pull/601
This is a test, do not merge!!
## What changes were proposed in this pull request?
Added a comment with test purpuses
## How was this patch tested?
TODO Not tested yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] zeroflag commented on a diff in pull request #601: KNOX-123 - Test commit
Posted by GitBox <gi...@apache.org>.
zeroflag commented on code in PR #601:
URL: https://github.com/apache/knox/pull/601#discussion_r908275157
##########
gateway-util-common/src/test/java/org/apache/knox/gateway/audit/AuditLayoutTest.java:
##########
@@ -115,6 +115,7 @@ public void testFullyFilledAuditEvent() {
RESOURCE_TYPE, RESOURCE_NAME, OUTCOME, MESSAGE, System.lineSeparator() );
String auditOutput = layout.toSerializable( event );
assertThat( auditOutput, is( expectedOutput ) );
+ //hello world
Review Comment:
Test: Please add a space after the /
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #601: KNOX-123 - Test commit
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on PR #601:
URL: https://github.com/apache/knox/pull/601#issuecomment-1168652832
@moresandeep Inviting you to review this very important change! It's critical! Please make it first today!! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] MrtnBalazs commented on a diff in pull request #601: KNOX-123 - Test commit
Posted by GitBox <gi...@apache.org>.
MrtnBalazs commented on code in PR #601:
URL: https://github.com/apache/knox/pull/601#discussion_r908279687
##########
gateway-util-common/src/test/java/org/apache/knox/gateway/audit/AuditLayoutTest.java:
##########
@@ -115,6 +115,7 @@ public void testFullyFilledAuditEvent() {
RESOURCE_TYPE, RESOURCE_NAME, OUTCOME, MESSAGE, System.lineSeparator() );
String auditOutput = layout.toSerializable( event );
assertThat( auditOutput, is( expectedOutput ) );
+ //hello world
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 closed pull request #601: KNOX-123 - Test commit
Posted by GitBox <gi...@apache.org>.
smolnar82 closed pull request #601: KNOX-123 - Test commit
URL: https://github.com/apache/knox/pull/601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #601: KNOX-123 - Test commit
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on PR #601:
URL: https://github.com/apache/knox/pull/601#issuecomment-1173832383
This was a test PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] moresandeep commented on pull request #601: KNOX-123 - Test commit
Posted by GitBox <gi...@apache.org>.
moresandeep commented on PR #601:
URL: https://github.com/apache/knox/pull/601#issuecomment-1168732872
Looks good :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org