You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/10 23:45:27 UTC
[GitHub] [spark] c21 opened a new pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
c21 opened a new pull request #31802:
URL: https://github.com/apache/spark/pull/31802
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
As a followup from code review in https://github.com/apache/spark/pull/31736#discussion_r588134104 , for `JoinCodegenSupport.genBuildSideVars`, we only need to generate build side variables with default values for LEFT OUTER and RIGHT OUTER join, but not for other join types (i.e. LEFT SEMI and LEFT ANTI). Create this PR to clean up the code.
In addition, change multiple unit tests to cover both whole stage code-gen enabled and disabled. Harden the unit tests to exercise all code paths.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Avoid unnecessary code generation.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing unit tests.
* BHJ and SHJ inner join is covered in `InnerJoinSuite.scala`
* BHJ and SHJ left outer and right outer join are covered in `OuterJoinSuite.scala`
* BHJ and SHJ left semi, left anti and existence join are covered in `ExistenceJoinSuite.scala`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-797006018
Thank you @cloud-fan and @dongjoon-hyun for review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31802:
URL: https://github.com/apache/spark/pull/31802#discussion_r592068440
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/ExistenceJoinSuite.scala
##########
@@ -103,7 +103,7 @@ class ExistenceJoinSuite extends SparkPlanTest with SharedSparkSession {
ProjectExec(output, FilterExec(condition, join))
}
- test(s"$testName using ShuffledHashJoin") {
+ testWithWholeStageCodegenOnAndOff(s"$testName using ShuffledHashJoin") { _ =>
Review comment:
This test enforcement looks orthogonal to this PR (`Avoiding unncessary code generation`). Can we do this as a test PR independently? We can merge it separately to the other branches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-796698199
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135965/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31802:
URL: https://github.com/apache/spark/pull/31802#discussion_r592066686
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
##########
@@ -46,7 +46,7 @@ case class BroadcastHashJoinExec(
left: SparkPlan,
right: SparkPlan,
isNullAwareAntiJoin: Boolean = false)
- extends HashJoin with CodegenSupport {
+ extends HashJoin {
Review comment:
If you don't mind, could you make a separate PR? You can use `[MINOR]` tag instead of creating a new JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-796380794
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40534/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31802:
URL: https://github.com/apache/spark/pull/31802#discussion_r592102966
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/ExistenceJoinSuite.scala
##########
@@ -103,7 +103,7 @@ class ExistenceJoinSuite extends SparkPlanTest with SharedSparkSession {
ProjectExec(output, FilterExec(condition, join))
}
- test(s"$testName using ShuffledHashJoin") {
+ testWithWholeStageCodegenOnAndOff(s"$testName using ShuffledHashJoin") { _ =>
Review comment:
@dongjoon-hyun - sure, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31802:
URL: https://github.com/apache/spark/pull/31802#discussion_r591962398
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
##########
@@ -46,7 +46,7 @@ case class BroadcastHashJoinExec(
left: SparkPlan,
right: SparkPlan,
isNullAwareAntiJoin: Boolean = false)
- extends HashJoin with CodegenSupport {
+ extends HashJoin {
Review comment:
This is just a minor fix packed in this PR. `HashJoin` already extends `JoinCodegenSupport`. So we don't need `CodegenSupport` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-796532744
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40549/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-799189324
Thank you @maropu for review as well!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31802:
URL: https://github.com/apache/spark/pull/31802#discussion_r592070442
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
##########
@@ -46,7 +46,7 @@ case class BroadcastHashJoinExec(
left: SparkPlan,
right: SparkPlan,
isNullAwareAntiJoin: Boolean = false)
- extends HashJoin with CodegenSupport {
+ extends HashJoin {
Review comment:
@dongjoon-hyun - sure, will do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-796349313
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-796735909
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-796525447
**[Test build #135965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135965/testReport)** for PR 31802 at commit [`a0cb676`](https://github.com/apache/spark/commit/a0cb67694bf398e827f31e3df842501b71bc0207).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31802:
URL: https://github.com/apache/spark/pull/31802#discussion_r592073176
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/ExistenceJoinSuite.scala
##########
@@ -103,7 +103,7 @@ class ExistenceJoinSuite extends SparkPlanTest with SharedSparkSession {
ProjectExec(output, FilterExec(condition, join))
}
- test(s"$testName using ShuffledHashJoin") {
+ testWithWholeStageCodegenOnAndOff(s"$testName using ShuffledHashJoin") { _ =>
Review comment:
SPARK-34702 is for Apache Spark 3.2.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-796532744
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40549/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-796525447
**[Test build #135965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135965/testReport)** for PR 31802 at commit [`a0cb676`](https://github.com/apache/spark/commit/a0cb67694bf398e827f31e3df842501b71bc0207).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31802:
URL: https://github.com/apache/spark/pull/31802#discussion_r592072821
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/ExistenceJoinSuite.scala
##########
@@ -103,7 +103,7 @@ class ExistenceJoinSuite extends SparkPlanTest with SharedSparkSession {
ProjectExec(output, FilterExec(condition, join))
}
- test(s"$testName using ShuffledHashJoin") {
+ testWithWholeStageCodegenOnAndOff(s"$testName using ShuffledHashJoin") { _ =>
Review comment:
Yes, I want to merge the test improvement into branch-3.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-796349313
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135950/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-797157080
late lgtm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-796456221
The code cleanup LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31802:
URL: https://github.com/apache/spark/pull/31802#discussion_r592070353
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/ExistenceJoinSuite.scala
##########
@@ -103,7 +103,7 @@ class ExistenceJoinSuite extends SparkPlanTest with SharedSparkSession {
ProjectExec(output, FilterExec(condition, join))
}
- test(s"$testName using ShuffledHashJoin") {
+ testWithWholeStageCodegenOnAndOff(s"$testName using ShuffledHashJoin") { _ =>
Review comment:
@dongjoon-hyun - if the purpose of separating PRs is to merge change to other branches as well, I can submit another PR for all test-related change, i.e. the change in `InnerJoinSuite.scala`, `OuterJoinSuite.scala` and `ExistenceJoinSuite.scala`.
Do we want to do that? These test changes are valid to be merged into `3.1` branch as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31802:
URL: https://github.com/apache/spark/pull/31802#discussion_r592102650
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/InnerJoinSuite.scala
##########
@@ -207,7 +207,7 @@ class InnerJoinSuite extends SparkPlanTest with SharedSparkSession {
}
}
- test(s"$testName using BroadcastNestedLoopJoin build right") {
+ testWithWholeStageCodegenOnAndOff(s"$testName using BroadcastNestedLoopJoin build right") { _ =>
Review comment:
same reason as change above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-796676073
**[Test build #135965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135965/testReport)** for PR 31802 at commit [`a0cb676`](https://github.com/apache/spark/commit/a0cb67694bf398e827f31e3df842501b71bc0207).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-796698199
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135965/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31802:
URL: https://github.com/apache/spark/pull/31802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31802:
URL: https://github.com/apache/spark/pull/31802#discussion_r592102545
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/InnerJoinSuite.scala
##########
@@ -198,7 +198,7 @@ class InnerJoinSuite extends SparkPlanTest with SharedSparkSession {
}
}
- test(s"$testName using BroadcastNestedLoopJoin build left") {
+ testWithWholeStageCodegenOnAndOff(s"$testName using BroadcastNestedLoopJoin build left") { _ =>
Review comment:
`BroadcastNestedLoopJoin` codegen is merged in `3.2` (current master), so keep test change here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31802: [SPARK-34702][SQL] Avoid unnecessary code generation in JoinCodegenSupport.genBuildSideVars
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31802:
URL: https://github.com/apache/spark/pull/31802#issuecomment-796296728
@cloud-fan and @maropu could you help take a look when you have time, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org