You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/02/09 08:48:41 UTC
[GitHub] [parquet-mr] martin-g opened a new pull request #866: Update Maven plugin versions
martin-g opened a new pull request #866:
URL: https://github.com/apache/parquet-mr/pull/866
Use scala-maven-plugin instead of the old maven-scala-plugin.
Update Scala version to 2.12.12
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on a change in pull request #866: PARQUET-1976: Update Scala and Maven plugin versions
Posted by GitBox <gi...@apache.org>.
shangxinli commented on a change in pull request #866:
URL: https://github.com/apache/parquet-mr/pull/866#discussion_r595271958
##########
File path: parquet-scala/pom.xml
##########
@@ -46,13 +46,13 @@
<url>https://scala-tools.org/repo-releases</url>
</pluginRepository>
</pluginRepositories>
-
+
Review comment:
Probably IDE does that but let's avoid unnecessary change here. If other pending PRs touch the same line, it would conflict.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] martin-g commented on a change in pull request #866: PARQUET-1976: Update Scala and Maven plugin versions
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #866:
URL: https://github.com/apache/parquet-mr/pull/866#discussion_r616432665
##########
File path: parquet-scala/pom.xml
##########
@@ -75,8 +75,9 @@
<build>
<plugins>
<plugin>
- <groupId>org.scala-tools</groupId>
- <artifactId>maven-scala-plugin</artifactId>
+ <groupId>net.alchim31.maven</groupId>
+ <artifactId>scala-maven-plugin</artifactId>
+ <version>${scala-maven-plugin.version}</version>
Review comment:
Done!
But at the moment some Maven plugins' versions in parquet-mr/pom.xml are newer than the ones in https://search.maven.org/artifact/org.apache/apache/23/pom, so I didn't apply your suggestion because this will actually downgrade them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] martin-g commented on a change in pull request #866: PARQUET-1976: Update Scala and Maven plugin versions
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #866:
URL: https://github.com/apache/parquet-mr/pull/866#discussion_r616392578
##########
File path: parquet-scala/pom.xml
##########
@@ -75,8 +75,9 @@
<build>
<plugins>
<plugin>
- <groupId>org.scala-tools</groupId>
- <artifactId>maven-scala-plugin</artifactId>
+ <groupId>net.alchim31.maven</groupId>
+ <artifactId>scala-maven-plugin</artifactId>
+ <version>${scala-maven-plugin.version}</version>
Review comment:
There is no pluginManagement for this scala-maven-plugin in the parquet-mr/pom.xml.
Also there is nothing about scala-maven-plugin at https://search.maven.org/artifact/org.apache/apache/23/pom so what you suggest won't work.
I will:
1) update the version of org.apache:apache from 16 to 23
2) add pluginManagement for scala-maven-plugin in parquet-mr/pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] martin-g commented on a change in pull request #866: PARQUET-1976: Update Scala and Maven plugin versions
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #866:
URL: https://github.com/apache/parquet-mr/pull/866#discussion_r616392578
##########
File path: parquet-scala/pom.xml
##########
@@ -75,8 +75,9 @@
<build>
<plugins>
<plugin>
- <groupId>org.scala-tools</groupId>
- <artifactId>maven-scala-plugin</artifactId>
+ <groupId>net.alchim31.maven</groupId>
+ <artifactId>scala-maven-plugin</artifactId>
+ <version>${scala-maven-plugin.version}</version>
Review comment:
There is no dependencyManagement for this plugin in the parquet-mr/pom.xml.
Also there is nothing about scala-maven-plugin at https://search.maven.org/artifact/org.apache/apache/23/pom so what you suggest won't work.
I will:
1) update the version of org.apache:apache from 16 to 23
2) add dependencyManagement in parquet-mr/pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] akauppi commented on pull request #866: PARQUET-1976: Update Scala and Maven plugin versions
Posted by GitBox <gi...@apache.org>.
akauppi commented on pull request #866:
URL: https://github.com/apache/parquet-mr/pull/866#issuecomment-1012229534
Looking at Parquet, with Scala 2.13 in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] martin-g commented on pull request #866: PARQUET-1976: Update Scala and Maven plugin versions
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #866:
URL: https://github.com/apache/parquet-mr/pull/866#issuecomment-814857164
> I think it is better, in the end, to inherit versions from the Parent Apache POM. WDYT?
Let me know if this is what Parquet team prefers and I will update the PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] martin-g commented on a change in pull request #866: PARQUET-1976: Update Scala and Maven plugin versions
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #866:
URL: https://github.com/apache/parquet-mr/pull/866#discussion_r616450690
##########
File path: parquet-scala/pom.xml
##########
@@ -75,8 +75,9 @@
<build>
<plugins>
<plugin>
- <groupId>org.scala-tools</groupId>
- <artifactId>maven-scala-plugin</artifactId>
+ <groupId>net.alchim31.maven</groupId>
+ <artifactId>scala-maven-plugin</artifactId>
+ <version>${scala-maven-plugin.version}</version>
Review comment:
The local build failed because of https://github.com/apache/parquet-mr/blob/5d8fe214f16829fe258400d0c68ddaacc979b03a/pom.xml#L241 and https://github.com/apache/parquet-mr/blob/5d8fe214f16829fe258400d0c68ddaacc979b03a/parquet-cli/pom.xml#L83.
How is this supposed to work ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] Fokko commented on a change in pull request #866: PARQUET-1976: Update Scala and Maven plugin versions
Posted by GitBox <gi...@apache.org>.
Fokko commented on a change in pull request #866:
URL: https://github.com/apache/parquet-mr/pull/866#discussion_r615972571
##########
File path: parquet-scala/pom.xml
##########
@@ -75,8 +75,9 @@
<build>
<plugins>
<plugin>
- <groupId>org.scala-tools</groupId>
- <artifactId>maven-scala-plugin</artifactId>
+ <groupId>net.alchim31.maven</groupId>
+ <artifactId>scala-maven-plugin</artifactId>
+ <version>${scala-maven-plugin.version}</version>
Review comment:
If you bump the parent pom version: https://github.com/apache/parquet-mr/blob/master/pom.xml#L7. Then this line shouldn't be required, because we then inherit the version from the parent pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] martin-g commented on a change in pull request #866: PARQUET-1976: Update Scala and Maven plugin versions
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #866:
URL: https://github.com/apache/parquet-mr/pull/866#discussion_r595961952
##########
File path: parquet-scala/pom.xml
##########
@@ -46,13 +46,13 @@
<url>https://scala-tools.org/repo-releases</url>
</pluginRepository>
</pluginRepositories>
-
+
Review comment:
@shangxinli I've re-introduced the empty spaces!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] martin-g commented on a change in pull request #866: PARQUET-1976: Update Scala and Maven plugin versions
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #866:
URL: https://github.com/apache/parquet-mr/pull/866#discussion_r616452324
##########
File path: parquet-scala/pom.xml
##########
@@ -75,8 +75,9 @@
<build>
<plugins>
<plugin>
- <groupId>org.scala-tools</groupId>
- <artifactId>maven-scala-plugin</artifactId>
+ <groupId>net.alchim31.maven</groupId>
+ <artifactId>scala-maven-plugin</artifactId>
+ <version>${scala-maven-plugin.version}</version>
Review comment:
CI failed too: https://github.com/apache/parquet-mr/runs/2388424766?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] martin-g commented on a change in pull request #866: PARQUET-1976: Update Scala and Maven plugin versions
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #866:
URL: https://github.com/apache/parquet-mr/pull/866#discussion_r616392578
##########
File path: parquet-scala/pom.xml
##########
@@ -75,8 +75,9 @@
<build>
<plugins>
<plugin>
- <groupId>org.scala-tools</groupId>
- <artifactId>maven-scala-plugin</artifactId>
+ <groupId>net.alchim31.maven</groupId>
+ <artifactId>scala-maven-plugin</artifactId>
+ <version>${scala-maven-plugin.version}</version>
Review comment:
There is no pluginManagement for this plugin in the parquet-mr/pom.xml.
Also there is nothing about scala-maven-plugin at https://search.maven.org/artifact/org.apache/apache/23/pom so what you suggest won't work.
I will:
1) update the version of org.apache:apache from 16 to 23
2) add pluginManagement in parquet-mr/pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org